[jira] [Comment Edited] (OFBIZ-11976) svg files not removed on clean

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186294#comment-17186294 ] Jacques Le Roux edited comment on OFBIZ-11976 at 8/28/20, 6:54 AM: ---

[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186312#comment-17186312 ] Jacques Le Roux commented on OFBIZ-11973: - Hi Alex, I'm not sure to understand,

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Ankush Upadhyay (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186311#comment-17186311 ] Ankush Upadhyay commented on OFBIZ-11928: - [~surajk], Sure, I will do that asap

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2020-08-27 Thread GitBox
sonarcloud[bot] commented on pull request #41: URL: https://github.com/apache/ofbiz-plugins/pull/41#issuecomment-682360345 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=41&resolved=false&types=BUG) [](https://sonarc

[GitHub] [ofbiz-plugins] lodhiravi opened a new pull request #41: Fixed: Add To Cart and related UI issue for the products with variant explosion and feature explosion (OFBIZ-11970)

2020-08-27 Thread GitBox
lodhiravi opened a new pull request #41: URL: https://github.com/apache/ofbiz-plugins/pull/41 Done following- 1. Corrected markup to fix the issue where add to cart is not working for the feature explosion products. 2. Added a separate screen for rendering Product UOM dropdown and

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186310#comment-17186310 ] Suraj Khurana commented on OFBIZ-11928: --- Hello [~ankush.upadhyay], These are all

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186309#comment-17186309 ] Suraj Khurana commented on OFBIZ-11928: --- Thanks [~ankush.upadhyay] for the patch.

[jira] [Updated] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11970: --- Attachment: addToCartProductWithVariantExplosionError.png > Add to cart is not working for products

[jira] [Comment Edited] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186306#comment-17186306 ] Ravi Lodhi edited comment on OFBIZ-11970 at 8/28/20, 6:33 AM:

[jira] [Updated] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11970: --- Attachment: (was: addToCartProductWithVariantExplosionError.png) > Add to cart is not working fo

[jira] [Updated] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi updated OFBIZ-11970: --- Attachment: addToCartProductWithVariantExplosionError.png > Add to cart is not working for products

[jira] [Commented] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186306#comment-17186306 ] Ravi Lodhi commented on OFBIZ-11970: While working on this ticket I found one more i

[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Ankush Upadhyay (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186304#comment-17186304 ] Ankush Upadhyay commented on OFBIZ-11928: - [~surajk], [~rohit.koushal], Thanks

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-08-27 Thread GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-682351106 Hi Suraj, You need to merge trunk HEAD, conflicts here and locally: C:\projectsASF\Git\ofbiz-framework>git apply 230.patch error: patch failed: frame

[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186294#comment-17186294 ] Jacques Le Roux commented on OFBIZ-11976: - We got an exaplantion from [~grv] at

[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Ankush Upadhyay (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay updated OFBIZ-11928: Attachment: OFBIZ-11928.patch > Explode items not handling tax and adjustments properly >

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186281#comment-17186281 ] Jacques Le Roux commented on OFBIZ-11947: - Hi Suraj, I cursorily reviewed, soun

[jira] [Commented] (OFBIZ-11984) MessagingException in sendShipmentScheduledNotification service

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186280#comment-17186280 ] Jacques Le Roux commented on OFBIZ-11984: - Hi Mridul, Ha yes forgot those, than

[jira] [Updated] (OFBIZ-11984) MessagingException in sendShipmentScheduledNotification service

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11984: Fix Version/s: (was: Upcoming Branch) > MessagingException in sendShipmentScheduledNot

[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186279#comment-17186279 ] Jacques Le Roux commented on OFBIZ-11985: - Thanks Girish, I was not aware of th

[jira] [Updated] (OFBIZ-11978) "cart" should be "card"

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11978: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > "cart" s

[jira] [Assigned] (OFBIZ-11928) Explode items not handling tax and adjustments properly

2020-08-27 Thread Ankush Upadhyay (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankush Upadhyay reassigned OFBIZ-11928: --- Assignee: Ankush Upadhyay (was: Pradeep Choudhary) > Explode items not handling ta

[jira] [Commented] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186275#comment-17186275 ] Suraj Khurana commented on OFBIZ-11947: --- Attached next patch consisting further en

[jira] [Updated] (OFBIZ-11947) Checkstyle: Add Javadoc for classes designed for extension

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11947: -- Attachment: OFBIZ-11947-2.patch > Checkstyle: Add Javadoc for classes designed for extension >

[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread Girish Vasmatkar (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186234#comment-17186234 ] Girish Vasmatkar commented on OFBIZ-11985: -- Hi Jacques I was not sure about ba

[jira] [Commented] (OFBIZ-11984) MessagingException in sendShipmentScheduledNotification service

2020-08-27 Thread Mridul Pathak (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186049#comment-17186049 ] Mridul Pathak commented on OFBIZ-11984: --- [~jleroux] This issue also existed in mig

[jira] [Updated] (OFBIZ-11984) MessagingException in sendShipmentScheduledNotification service

2020-08-27 Thread Mridul Pathak (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-11984: -- Fix Version/s: Upcoming Branch > MessagingException in sendShipmentScheduledNotification servi

[jira] [Commented] (OFBIZ-11984) MessagingException in sendShipmentScheduledNotification service

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186044#comment-17186044 ] ASF subversion and git services commented on OFBIZ-11984: - Commi

[jira] [Commented] (OFBIZ-11958) Freemarker macro for JsLanguageFilesMapping

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186007#comment-17186007 ] ASF subversion and git services commented on OFBIZ-11958: - Commi

[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185998#comment-17185998 ] Jacques Le Roux commented on OFBIZ-11985: - Thanks Girish, Should we not conside

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185992#comment-17185992 ] ASF subversion and git services commented on OFBIZ-11926: - Commi

[jira] [Commented] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185966#comment-17185966 ] ASF subversion and git services commented on OFBIZ-11985: - Commi

[jira] [Assigned] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread Girish Vasmatkar (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Girish Vasmatkar reassigned OFBIZ-11985: Assignee: Girish Vasmatkar > Add a new NumberConverter to convert Integer to BigI

[jira] [Created] (OFBIZ-11985) Add a new NumberConverter to convert Integer to BigInteger

2020-08-27 Thread Girish Vasmatkar (Jira)
Girish Vasmatkar created OFBIZ-11985: Summary: Add a new NumberConverter to convert Integer to BigInteger Key: OFBIZ-11985 URL: https://issues.apache.org/jira/browse/OFBIZ-11985 Project: OFBiz

[jira] [Comment Edited] (OFBIZ-11424) createPartyContent not working

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185937#comment-17185937 ] Jacques Le Roux edited comment on OFBIZ-11424 at 8/27/20, 4:11 PM: ---

[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185940#comment-17185940 ] Jacques Le Roux commented on OFBIZ-9759: +1 for closing (after test), TIA > Fisc

[jira] [Commented] (OFBIZ-11424) createPartyContent not working

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185937#comment-17185937 ] Jacques Le Roux commented on OFBIZ-11424: - +1 for closing, TIA > createPartyCon

[jira] [Commented] (OFBIZ-9759) Fiscal Gl type is reflecting twice in drop-down of Cost Centers.

2020-08-27 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185928#comment-17185928 ] Akash Jain commented on OFBIZ-9759: --- Reported issue has been fixed, I think we are good

[jira] [Commented] (OFBIZ-11424) createPartyContent not working

2020-08-27 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185920#comment-17185920 ] Akash Jain commented on OFBIZ-11424: I verified reported issue with various scenario

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-08-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-678647972 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https:

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-08-27 Thread GitBox
sonarcloud[bot] commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-681962270 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=230&resolved=false&types=BUG) [](https://sonarc

[jira] [Closed] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-27 Thread Akash Jain (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain closed OFBIZ-10532. -- Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed > Default value flags not

[jira] [Commented] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185834#comment-17185834 ] ASF subversion and git services commented on OFBIZ-10532: - Commi

[jira] [Commented] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185831#comment-17185831 ] ASF subversion and git services commented on OFBIZ-10532: - Commi

[jira] [Commented] (OFBIZ-10532) Default value flags not working for configurable and variant products at the time of order entry

2020-08-27 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185828#comment-17185828 ] ASF subversion and git services commented on OFBIZ-10532: - Commi

[jira] [Assigned] (OFBIZ-11970) Add to cart is not working for products with selectable features

2020-08-27 Thread Ravi Lodhi (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravi Lodhi reassigned OFBIZ-11970: -- Assignee: Ravi Lodhi > Add to cart is not working for products with selectable features > ---

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185777#comment-17185777 ] Suraj Khurana commented on OFBIZ-11926: --- Hello [~jleroux], I got your point. Coul

[jira] [Updated] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-08-27 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11926: -- Attachment: JsLanguageFilesMapping.patch > Checkstyle: Variable name must match pattern >

[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-27 Thread Alex Bodnaru (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185741#comment-17185741 ] Alex Bodnaru commented on OFBIZ-11973: -- this page is not bootstrap enabled at all,

[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-27 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185714#comment-17185714 ] Jacques Le Roux commented on OFBIZ-11973: - Hi Alex, Sure the div.row patch soun

[jira] [Commented] (OFBIZ-11973) enclose productsummary list in div.row to better use the screen

2020-08-27 Thread Alex Bodnaru (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17185695#comment-17185695 ] Alex Bodnaru commented on OFBIZ-11973: -- ok, thanks [~jleroux] . i'll carry on from