[jira] [Comment Edited] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467124#comment-17467124 ] Jacques Le Roux edited comment on OFBIZ-12456 at 12/31/21, 7:12 AM:

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467124#comment-17467124 ] Jacques Le Roux commented on OFBIZ-12456: - Also the builds results are available here:

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17467123#comment-17467123 ] Jacques Le Roux commented on OFBIZ-12456: - As can be seen at https://ci2.apache.org/#/builders

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2021-12-30 Thread GitBox
PierreSmits commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003126709 Indeed, Ioan. Any property value used during the startup of OFBiz can't be set as a SystemProperty record. I guess that applies to most in the config

[GitHub] [ofbiz-framework] ieugen commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2021-12-30 Thread GitBox
ieugen commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003121702 @PierreSmits : True, and maybe we should consider moving those there. I don't think we will have a lot of config options use via ENV. For those that need this

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2021-12-30 Thread GitBox
PierreSmits commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003054946 I like this improvement. But it seems to me that there might be more properties that could be applicable (not those related to run-time configuration, which can be

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2021-12-30 Thread Ioan Eugen Stan (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466855#comment-17466855 ] Ioan Eugen Stan commented on OFBIZ-9498: Thanks.   I saw there is the PR here that can improve

[GitHub] [ofbiz-framework] ieugen commented on pull request #355: Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498)

2021-12-30 Thread GitBox
ieugen commented on pull request #355: URL: https://github.com/apache/ofbiz-framework/pull/355#issuecomment-1003014965 @gilPts : Here is my feedback: The PR looks good overall. * I would add documentation for this feature in the asciidoc files + link to issue ?! * I would

[jira] [Commented] (OFBIZ-9498) Improve DevOps using environment variable configuration

2021-12-30 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17466789#comment-17466789 ] Gil Portenseigne commented on OFBIZ-9498: - Hello [~ieugen] , Thanks for your review, I work with

[jira] [Updated] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12456: Attachment: patch.patch > Migrate Ofbiz bb 0.8 config to 3.2 >

[jira] [Updated] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-30 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12456: Attachment: (was: patch.patch) > Migrate Ofbiz bb 0.8 config to 3.2 >