[GitHub] [ofbiz-framework] danwatford commented on pull request #401: OFBIZ 12174: Improved: Convert InventoryServices.xml mini lang to groovy

2022-12-13 Thread GitBox
danwatford commented on PR #401: URL: https://github.com/apache/ofbiz-framework/pull/401#issuecomment-1350584194 Hi @mbrohl , It certainly wasn't my intention to cause any upset and I am sorry if my actions came across that way. There is a lot of value locked up in the various

[GitHub] [ofbiz-framework] mbrohl commented on pull request #401: OFBIZ 12174: Improved: Convert InventoryServices.xml mini lang to groovy

2022-12-13 Thread GitBox
mbrohl commented on PR #401: URL: https://github.com/apache/ofbiz-framework/pull/401#issuecomment-1349642073 @danwatford it would at least be nice to wait for a response before you grab contributions and put them in your own PR's and commit right away. I do not understand why it's easier t

[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy

2022-12-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646745#comment-17646745 ] ASF subversion and git services commented on OFBIZ-12174: - Commi

[GitHub] [ofbiz-framework] danwatford merged pull request #570: Improved: Ported createUpdateFacilityGeoPoint service to groovy (OFBIZ-12174)

2022-12-13 Thread GitBox
danwatford merged PR #570: URL: https://github.com/apache/ofbiz-framework/pull/570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [ofbiz-framework] danwatford commented on pull request #570: Improved: Ported createUpdateFacilityGeoPoint service to groovy (OFBIZ-12174)

2022-12-13 Thread GitBox
danwatford commented on PR #570: URL: https://github.com/apache/ofbiz-framework/pull/570#issuecomment-1349180530 Tested by updating the location of a facility: https://localhost:8443/facility/control/EditFacilityGeoPoint?facilityId=WebStoreWarehouse -- This is an automated message from th

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #570: Improved: Ported createUpdateFacilityGeoPoint service to groovy (OFBIZ-12174)

2022-12-13 Thread GitBox
sonarcloud[bot] commented on PR #570: URL: https://github.com/apache/ofbiz-framework/pull/570#issuecomment-1349068999 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #570: Improved: Ported createUpdateFacilityGeoPoint service to groovy (OFBIZ-12174)

2022-12-13 Thread GitBox
danwatford opened a new pull request, #570: URL: https://github.com/apache/ofbiz-framework/pull/570 Thanks: Sebastian Berg for implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Closed] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2022-12-13 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12723. -- Fix Version/s: Upcoming Branch Resolution: Implemented > Remove fields oldQuantityOnHan

[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2022-12-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646701#comment-17646701 ] ASF subversion and git services commented on OFBIZ-12723: - Commi

[GitHub] [ofbiz-framework] danwatford merged pull request #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

2022-12-13 Thread GitBox
danwatford merged PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

2022-12-13 Thread GitBox
sonarcloud[bot] commented on PR #569: URL: https://github.com/apache/ofbiz-framework/pull/569#issuecomment-1348764654 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #569: Improved: Removed unused oldQOH and oldATP fields from InventoryItem (OFBIZ-12723)

2022-12-13 Thread GitBox
danwatford opened a new pull request, #569: URL: https://github.com/apache/ofbiz-framework/pull/569 Fields were used to migrate QOH and ATP inventory values to InventoryItemDetails entities following data model changes prior to June 2006 are are no longer needed. Similarly, services which p

[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2022-12-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646650#comment-17646650 ] ASF subversion and git services commented on OFBIZ-12723: - Commi

[jira] [Commented] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2022-12-13 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17646623#comment-17646623 ] Jacques Le Roux commented on OFBIZ-12723: - +1 > Remove fields oldQuantityOnHand

[jira] [Assigned] (OFBIZ-12723) Remove fields oldQuantityOnHand and oldAvailableToPromise from InventoryItem entity

2022-12-13 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford reassigned OFBIZ-12723: -- Assignee: Daniel Watford > Remove fields oldQuantityOnHand and oldAvailableToPromise