[jira] [Commented] (OFBIZ-12033) Separate login service for API calls

2023-02-06 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685125#comment-17685125 ] Michael Brohl commented on OFBIZ-12033: --- Thanks [~rohit.koushal] for your observations and the

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #584: Ofbiz 10134 general refactoring product category

2023-02-06 Thread via GitHub
sonarcloud[bot] commented on PR #584: URL: https://github.com/apache/ofbiz-framework/pull/584#issuecomment-1420343620 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #584: Ofbiz 10134 general refactoring product category

2023-02-06 Thread via GitHub
cshan-ecomify opened a new pull request, #584: URL: https://github.com/apache/ofbiz-framework/pull/584 Improved: Refactored multiple java classes (OFBIZ-10134) Thanks: Dennis Balkir -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy

2023-02-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685112#comment-17685112 ] ASF subversion and git services commented on OFBIZ-12174: - Commit

[GitHub] [ofbiz-framework] danwatford merged pull request #579: Improved: Convert Inventory Services permission checks to groovy (OFBIZ-12174)

2023-02-06 Thread via GitHub
danwatford merged PR #579: URL: https://github.com/apache/ofbiz-framework/pull/579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (OFBIZ-12033) Separate login service for API calls

2023-02-06 Thread Rohit Koushal (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685079#comment-17685079 ] Rohit Koushal edited comment on OFBIZ-12033 at 2/7/23 7:01 AM: --- Hey

[jira] [Commented] (OFBIZ-12033) Separate login service for API calls

2023-02-06 Thread Rohit Koushal (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685079#comment-17685079 ] Rohit Koushal commented on OFBIZ-12033: --- Hey [~mbrohl] and [~gvasmatkar]  In my analysis, I found

[jira] [Updated] (OFBIZ-12033) Separate login service for API calls

2023-02-06 Thread Rohit Koushal (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-12033: -- Attachment: OFBIZ-12033.patch > Separate login service for API calls >

[jira] [Commented] (OFBIZ-12754) Accumulated depreciation switches from negative to positive value following closure of corresponding time period

2023-02-06 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684949#comment-17684949 ] Daniel Watford commented on OFBIZ-12754: Issue is caused by GlAccountHistory records for contra

[jira] [Created] (OFBIZ-12754) Accumulated depreciation switches from negative to positive value following closure of corresponding time period

2023-02-06 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12754: -- Summary: Accumulated depreciation switches from negative to positive value following closure of corresponding time period Key: OFBIZ-12754 URL:

[GitHub] [ofbiz-framework] danwatford commented on pull request #583: Improvement: Simplify code used to prepare the balance sheet (OFBIZ-12753)

2023-02-06 Thread via GitHub
danwatford commented on PR #583: URL: https://github.com/apache/ofbiz-framework/pull/583#issuecomment-1419714938 Note: There are other issues with balance sheet, but this PR was focussed on replicating existing balance sheet behaviour while simplifying the associated code. -- This is an

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #583: Improvement: Simplify code used to prepare the balance sheet (OFBIZ-12753)

2023-02-06 Thread via GitHub
sonarcloud[bot] commented on PR #583: URL: https://github.com/apache/ofbiz-framework/pull/583#issuecomment-1419714809 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] danwatford commented on pull request #583: Improvement: Simplify code used to prepare the balance sheet (OFBIZ-12753)

2023-02-06 Thread via GitHub
danwatford commented on PR #583: URL: https://github.com/apache/ofbiz-framework/pull/583#issuecomment-1419714156 Tested using demo data: - Created custom time periods for Jan, Feb, Mar, Apr 2009 - Created a balance sheet with ThruDates: - 2009-02-01 - 2009-03-01 -

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #583: Improvement: Simplify code used to prepare the balance sheet (OFBIZ-12753)

2023-02-06 Thread via GitHub
danwatford opened a new pull request, #583: URL: https://github.com/apache/ofbiz-framework/pull/583 Refactored duplicate code into functions with the intention of improving readability of balance sheet related code. -- This is an automated message from the Apache Git Service. To respond

[jira] [Created] (OFBIZ-12753) Reduce duplication in BalanceSheet.groovy

2023-02-06 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12753: -- Summary: Reduce duplication in BalanceSheet.groovy Key: OFBIZ-12753 URL: https://issues.apache.org/jira/browse/OFBIZ-12753 Project: OFBiz Issue Type:

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #76: Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434)

2023-02-06 Thread via GitHub
sonarcloud[bot] commented on PR #76: URL: https://github.com/apache/ofbiz-plugins/pull/76#issuecomment-1419195345 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #76: Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434)

2023-02-06 Thread via GitHub
sonarcloud[bot] commented on PR #76: URL: https://github.com/apache/ofbiz-plugins/pull/76#issuecomment-1419181136 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [ofbiz-plugins] cshan-ecomify opened a new pull request, #76: Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434)

2023-02-06 Thread via GitHub
cshan-ecomify opened a new pull request, #76: URL: https://github.com/apache/ofbiz-plugins/pull/76 Fixed: Makes Forum Articles respond to pagination controls (OFBIZ-11434) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (OFBIZ-10134) [Refactoring] Package org.apache.ofbiz.product.category

2023-02-06 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reassigned OFBIZ-10134: - Assignee: Michael Brohl > [Refactoring] Package org.apache.ofbiz.product.category >

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #373: Fixed: Link Party feature stop the EECA rules globally(OFBIZ-12424)

2023-02-06 Thread via GitHub
sonarcloud[bot] commented on PR #373: URL: https://github.com/apache/ofbiz-framework/pull/373#issuecomment-1418784289 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] rohitkou closed pull request #373: Fixed: Link Party feature stop the EECA rules globally(OFBIZ-12424)

2023-02-06 Thread via GitHub
rohitkou closed pull request #373: Fixed: Link Party feature stop the EECA rules globally(OFBIZ-12424) URL: https://github.com/apache/ofbiz-framework/pull/373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above