[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-04-18 Thread Gil Portenseigne (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713934#comment-17713934 ] Gil Portenseigne commented on OFBIZ-12801: -- For this case I agree that the fix

[jira] [Created] (OFBIZ-12805) Remove unused jquery.jcrop, jQuery.Rotate and jquery.color javascript modules

2023-04-18 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12805: -- Summary: Remove unused jquery.jcrop, jQuery.Rotate and jquery.color javascript modules Key: OFBIZ-12805 URL: https://issues.apache.org/jira/browse/OFBIZ-12805 Pro

[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713728#comment-17713728 ] Daniel Watford commented on OFBIZ-12801: Another approach, but less favourable i

[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713725#comment-17713725 ] Daniel Watford commented on OFBIZ-12801: In the case of sendEmailDated, I believ

[jira] [Commented] (OFBIZ-12801) Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713721#comment-17713721 ] Daniel Watford commented on OFBIZ-12801: Regarding GroovyBaseScript#success, we

[jira] [Closed] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford closed OFBIZ-12804. -- Resolution: Implemented > Replace jsgantt sources in common-theme with npm module in project p

[jira] [Commented] (OFBIZ-11310) JSON renderer for screen/menu/form

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713645#comment-17713645 ] Daniel Watford commented on OFBIZ-11310: Hi [~holivier] , OFBIZ-12789 added the

[jira] [Commented] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713638#comment-17713638 ] ASF subversion and git services commented on OFBIZ-12804: - Commi

[GitHub] [ofbiz-plugins] danwatford merged pull request #80: Improved: Reduced codenarc issues for Project plugin (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford merged PR #80: URL: https://github.com/apache/ofbiz-plugins/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [ofbiz-plugins] danwatford opened a new pull request, #80: Improved: Reduced codenarc issues for Project plugin (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford opened a new pull request, #80: URL: https://github.com/apache/ofbiz-plugins/pull/80 Applied codenarc recommendations to groovy code used to produce data for rendering in a gantt chart. Also applied Groovy idioms to the code, hopefully improving readability. -- This is an auto

[jira] [Commented] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713634#comment-17713634 ] Daniel Watford commented on OFBIZ-12804: I think the new JsGantt library is a vi

[jira] [Updated] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-12804: --- Attachment: image-2023-04-18-16-40-55-215.png > Replace jsgantt sources in common-theme with

[jira] [Updated] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-12804: --- Attachment: image-2023-04-18-16-39-30-913.png > Replace jsgantt sources in common-theme with

[jira] [Updated] (OFBIZ-12804) Replace jsgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Watford updated OFBIZ-12804: --- Summary: Replace jsgantt sources in common-theme with npm module in project plugin (was: Re

[jira] [Commented] (OFBIZ-12789) Explore further use of npm modules to reduce bugs reported by sonarcloud

2023-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713588#comment-17713588 ] ASF subversion and git services commented on OFBIZ-12789: - Commi

[GitHub] [ofbiz-plugins] danwatford merged pull request #79: Improved: Reduce codenarc issues in example plugin (OFBIZ-12789)

2023-04-18 Thread via GitHub
danwatford merged PR #79: URL: https://github.com/apache/ofbiz-plugins/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [ofbiz-framework] danwatford closed pull request #517: Codenarc integration

2023-04-18 Thread via GitHub
danwatford closed pull request #517: Codenarc integration URL: https://github.com/apache/ofbiz-framework/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [ofbiz-framework] danwatford commented on pull request #517: Codenarc integration

2023-04-18 Thread via GitHub
danwatford commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1513021758 Closing as a rebased version of this PR's branch was handled through #618 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (OFBIZ-12804) Replace jgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713573#comment-17713573 ] ASF subversion and git services commented on OFBIZ-12804: - Commi

[jira] [Commented] (OFBIZ-12804) Replace jgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713574#comment-17713574 ] ASF subversion and git services commented on OFBIZ-12804: - Commi

[GitHub] [ofbiz-framework] danwatford merged pull request #624: Removed: JsGantt sources removed from ofbiz-framework (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford merged PR #624: URL: https://github.com/apache/ofbiz-framework/pull/624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [ofbiz-plugins] danwatford merged pull request #78: Added: Project plugin retrieve jsgantt module via npm (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford merged PR #78: URL: https://github.com/apache/ofbiz-plugins/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #624: Removed: JsGantt sources removed from ofbiz-framework (OFBIZ-12804)

2023-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #624: URL: https://github.com/apache/ofbiz-framework/pull/624#issuecomment-1513005757 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #78: Added: Project plugin retrieve jsgantt module via npm (OFBIZ-12804)

2023-04-18 Thread via GitHub
sonarcloud[bot] commented on PR #78: URL: https://github.com/apache/ofbiz-plugins/pull/78#issuecomment-1512999619 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Qu

[GitHub] [ofbiz-framework] danwatford opened a new pull request, #624: Removed: JsGantt sources removed from ofbiz-framework (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford opened a new pull request, #624: URL: https://github.com/apache/ofbiz-framework/pull/624 Sources for the javascript module, jsgantt, have been removed from ofbiz' sources. The module was out of date and was a cause of various issues reported by sonarcloud. JsGantt was only

[GitHub] [ofbiz-plugins] danwatford opened a new pull request, #78: Added: Project plugin retrieve jsgantt module via npm (OFBIZ-12804)

2023-04-18 Thread via GitHub
danwatford opened a new pull request, #78: URL: https://github.com/apache/ofbiz-plugins/pull/78 An outdated version of jsgantt was previously included in ofbiz-framework sources as part of common-theme. These sources have been removed from common-theme and the project plugin will now retrie

[jira] [Commented] (OFBIZ-12804) Replace jgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713559#comment-17713559 ] Jacques Le Roux commented on OFBIZ-12804: - +1 > Replace jgantt sources in commo

[jira] [Commented] (OFBIZ-12804) Replace jgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713540#comment-17713540 ] Daniel Watford commented on OFBIZ-12804: This ticket includes an assumption that

[jira] [Created] (OFBIZ-12804) Replace jgantt sources in common-theme with npm module in project plugin

2023-04-18 Thread Daniel Watford (Jira)
Daniel Watford created OFBIZ-12804: -- Summary: Replace jgantt sources in common-theme with npm module in project plugin Key: OFBIZ-12804 URL: https://issues.apache.org/jira/browse/OFBIZ-12804 Project: