[jira] [Commented] (OFBIZ-10091) Unnecessary throws clauses in renderer classes?

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822695#comment-16822695 ] Mathieu Lirzin commented on OFBIZ-10091: I don't think you overlook anything. I

[jira] [Created] (OFBIZ-10938) Unnecessary declared exceptions should be removed

2019-04-21 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10938: -- Summary: Unnecessary declared exceptions should be removed Key: OFBIZ-10938 URL: https://issues.apache.org/jira/browse/OFBIZ-10938 Project: OFBiz Issue T

[jira] [Updated] (OFBIZ-10938) Unnecessary declared exceptions should be removed

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10938: --- Attachment: OFBIZ-10938_RequestHandlerTests.patch > Unnecessary declared exceptions should b

[jira] [Commented] (OFBIZ-10938) Unnecessary declared exceptions should be removed

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822699#comment-16822699 ] Mathieu Lirzin commented on OFBIZ-10938: [^OFBIZ-10938_RequestHandlerTests.patc

[jira] [Updated] (OFBIZ-10938) Unnecessary declared exceptions should be removed

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10938: --- Attachment: OFBIZ-10938_ContainerException.patch > Unnecessary declared exceptions should be

[jira] [Commented] (OFBIZ-10938) Unnecessary declared exceptions should be removed

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822700#comment-16822700 ] Mathieu Lirzin commented on OFBIZ-10938: [^OFBIZ-10938_ContainerException.patch

[jira] [Created] (OFBIZ-10939) @Override annotations should be used when possible

2019-04-21 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10939: -- Summary: @Override annotations should be used when possible Key: OFBIZ-10939 URL: https://issues.apache.org/jira/browse/OFBIZ-10939 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10939) @Override annotations should be used when possible

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10939: --- Attachment: OFBIZ-10939_Use-the-Override-annotation.patch > @Override annotations should be

[jira] [Commented] (OFBIZ-10939) @Override annotations should be used when possible

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822711#comment-16822711 ] Mathieu Lirzin commented on OFBIZ-10939: I will wait a couple a days for comment

[jira] [Assigned] (OFBIZ-10939) @Override annotations should be used when possible

2019-04-21 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10939: -- Assignee: Mathieu Lirzin > @Override annotations should be used when possible > -

[jira] [Created] (OFBIZ-10941) Use ‘contains’ and ‘containsInAnyOrder’ matchers when possible

2019-04-22 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10941: -- Summary: Use ‘contains’ and ‘containsInAnyOrder’ matchers when possible Key: OFBIZ-10941 URL: https://issues.apache.org/jira/browse/OFBIZ-10941 Project: OFBiz

[jira] [Updated] (OFBIZ-10941) Use ‘contains’ and ‘containsInAnyOrder’ matchers when possible

2019-04-22 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10941: --- Attachment: OFBIZ-10941_0001-Use-containsInAnyOrder-matcher-when-possibl.patch

[jira] [Commented] (OFBIZ-10935) Do not use deprecated method in ‘DBCPConnectionFactory’

2019-04-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827690#comment-16827690 ] Mathieu Lirzin commented on OFBIZ-10935: Hello Jacques, Sure I will follow that

[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-04-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827727#comment-16827727 ] Mathieu Lirzin commented on OFBIZ-10933: Hello Jacques, I see this warnings whe

[jira] [Comment Edited] (OFBIZ-10959) Enable entity timestamp fields

2019-04-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827756#comment-16827756 ] Mathieu Lirzin edited comment on OFBIZ-10959 at 4/27/19 9:37 PM: -

[jira] [Commented] (OFBIZ-10959) Enable entity timestamp fields

2019-04-27 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827756#comment-16827756 ] Mathieu Lirzin commented on OFBIZ-10959: Hello Pawan, The "include-internal" na

[jira] [Created] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11003: -- Summary: Do not use ‘java.util’ backported classes Key: OFBIZ-11003 URL: https://issues.apache.org/jira/browse/OFBIZ-11003 Project: OFBiz Issue Type: Imp

[jira] [Assigned] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-11003: -- Assignee: Mathieu Lirzin > Do not use ‘java.util’ backported classes > --

[jira] [Updated] (OFBIZ-11003) Do not use ‘java.util’ backported classes

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11003: --- Attachment: OFBIZ-11003_Do-not-use-java.util-backported-classes.patch > Do not use ‘java.uti

[jira] [Commented] (OFBIZ-10933) Insertion order of ‘LinkedHashMap’ is not preserved by ‘MapContext’

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830983#comment-16830983 ] Mathieu Lirzin commented on OFBIZ-10933: The warning should not appear anymore a

[jira] [Updated] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10187: --- Attachment: OFBIZ-10187_Rewrite-CustomPermissivePolicy-matchesEithe.patch > OWASP sanitizer

[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830996#comment-16830996 ] Mathieu Lirzin commented on OFBIZ-10187: Hello there, I have added [^OFBIZ-101

[jira] [Commented] (OFBIZ-10518) Inventory (Supply) Allocation Planning

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831007#comment-16831007 ] Mathieu Lirzin commented on OFBIZ-10518: Hello here, In revision 1858487, I hav

[jira] [Created] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11004: -- Summary: Add missing ‘synchronized’ modifier Key: OFBIZ-11004 URL: https://issues.apache.org/jira/browse/OFBIZ-11004 Project: OFBiz Issue Type: Improveme

[jira] [Updated] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11004: --- Attachment: OFBIZ-11004_Add-missing-synchronized-modifier.patch > Add missing ‘synchronized’

[jira] [Commented] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831021#comment-16831021 ] Mathieu Lirzin commented on OFBIZ-11004: This is not a bug fix since I didn't ob

[jira] [Comment Edited] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831021#comment-16831021 ] Mathieu Lirzin edited comment on OFBIZ-11004 at 5/1/19 2:30 PM: --

[jira] [Commented] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831030#comment-16831030 ] Mathieu Lirzin commented on OFBIZ-11004: Committed in revision 1858490 on trunk.

[jira] [Resolved] (OFBIZ-11004) Add missing ‘synchronized’ modifier

2019-05-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin resolved OFBIZ-11004. Resolution: Fixed Fix Version/s: Release Branch 16.11 Release Bra

[jira] [Commented] (OFBIZ-10187) OWASP sanitizer breaks proper rendering of HTML code

2019-05-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835762#comment-16835762 ] Mathieu Lirzin commented on OFBIZ-10187: I have applied [^OFBIZ-10187_Rewrite-

[jira] [Created] (OFBIZ-11014) StringUtil cleanup

2019-05-08 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11014: -- Summary: StringUtil cleanup Key: OFBIZ-11014 URL: https://issues.apache.org/jira/browse/OFBIZ-11014 Project: OFBiz Issue Type: Improvement Comp

[jira] [Created] (OFBIZ-11015) Remove useless ‘StringUtil#makeSetWritable’

2019-05-08 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11015: -- Summary: Remove useless ‘StringUtil#makeSetWritable’ Key: OFBIZ-11015 URL: https://issues.apache.org/jira/browse/OFBIZ-11015 Project: OFBiz Issue Type: I

[jira] [Updated] (OFBIZ-11015) Remove useless ‘StringUtil#makeSetWritable’

2019-05-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11015: --- Attachment: OFBIZ-11015_Remove-useless-UtilMisc-makeSetWritable.patch > Remove useless ‘Stri

[jira] [Updated] (OFBIZ-11015) Remove useless ‘UtilMisc#makeSetWritable’

2019-05-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11015: --- Summary: Remove useless ‘UtilMisc#makeSetWritable’ (was: Remove useless ‘StringUtil#makeSet

[jira] [Created] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11019: -- Summary: Removing ‘hasPermission(String, HttpSession)’ from ‘Security’ Key: OFBIZ-11019 URL: https://issues.apache.org/jira/browse/OFBIZ-11019 Project: OFBiz

[jira] [Updated] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Description: The ‘hasPermission(String, HttpSession)’ method declaration from the ‘Security’

[jira] [Updated] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Attachment: OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch > Removing ‘hasPer

[jira] [Updated] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Attachment: OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch > Removing ‘hasPer

[jira] [Updated] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Attachment: (was: OFBIZ-11019_Relax-the-contract-of-the-Security-interfac.patch) > Remo

[jira] [Commented] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837367#comment-16837367 ] Mathieu Lirzin commented on OFBIZ-11019: I have included [^OFBIZ-11019_Relax-t

[jira] [Comment Edited] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837367#comment-16837367 ] Mathieu Lirzin edited comment on OFBIZ-11019 at 5/10/19 3:20 PM: -

[jira] [Updated] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-05-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10757: --- Attachment: OFBIZ-10757_Fix-javadoc-build-for-OpenJDK-11.patch > Upgrade OFBiz to use Java J

[jira] [Commented] (OFBIZ-10757) Upgrade OFBiz to use Java JDK Version 11

2019-05-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837927#comment-16837927 ] Mathieu Lirzin commented on OFBIZ-10757: Committed [^OFBIZ-10757_Fix-javadoc-bu

[jira] [Commented] (OFBIZ-11019) Removing ‘hasPermission(String, HttpSession)’ from ‘Security’

2019-05-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837929#comment-16837929 ] Mathieu Lirzin commented on OFBIZ-11019: After a deeper look at the {{security}}

[jira] [Updated] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface

2019-05-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Summary: Cleaning the bloated ‘Security’ interface (was: Removing ‘hasPermission(String, Ht

[jira] [Updated] (OFBIZ-11019) Cleaning the bloated ‘Security’ interface

2019-05-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11019: --- Description: The ‘hasPermission(String, HttpSession)’ method declaration from the ‘Security’

[jira] [Comment Edited] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-05-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838369#comment-16838369 ] Mathieu Lirzin edited comment on OFBIZ-10934 at 5/13/19 8:31 AM: -

[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-05-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838369#comment-16838369 ] Mathieu Lirzin commented on OFBIZ-10934: Hello, the [^OFBIZ10934-MORE.patch] co

[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-05-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838659#comment-16838659 ] Mathieu Lirzin commented on OFBIZ-10934: Thanks [~aditya.sharma] I didn't know a

[jira] [Created] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11032: -- Summary: ServiceDispatcher implementation details should be private Key: OFBIZ-11032 URL: https://issues.apache.org/jira/browse/OFBIZ-11032 Project: OFBiz

[jira] [Updated] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11032: --- Attachment: OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch > ServiceDispatche

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840128#comment-16840128 ] Mathieu Lirzin commented on OFBIZ-11032: I will wait a couple of days for commen

[jira] [Commented] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-15 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840203#comment-16840203 ] Mathieu Lirzin commented on OFBIZ-11032: I agree :) > ServiceDispatcher impleme

[jira] [Commented] (OFBIZ-11040) Manage EECAs on delegator.removeBy

2019-05-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843191#comment-16843191 ] Mathieu Lirzin commented on OFBIZ-11040: Hello at a first look, The {{ecaCache}}

[jira] [Comment Edited] (OFBIZ-11040) Manage EECAs on delegator.removeBy

2019-05-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843191#comment-16843191 ] Mathieu Lirzin edited comment on OFBIZ-11040 at 5/18/19 3:59 PM: -

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-05-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Attachment: OFBIZ-11014_0001-Remove-useless-StringUtil-join-overload.patch OF

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-05-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Attachment: OFBIZ-11014_0014-Turn-StringUtilTests-into-a-unit-test.patch > StringUtil cleanu

[jira] [Commented] (OFBIZ-11014) StringUtil cleanup

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848117#comment-16848117 ] Mathieu Lirzin commented on OFBIZ-11014: Patch 1 to 14 has been commited on trun

[jira] [Comment Edited] (OFBIZ-11014) StringUtil cleanup

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848117#comment-16848117 ] Mathieu Lirzin edited comment on OFBIZ-11014 at 5/25/19 9:46 AM: -

[jira] [Updated] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11032: --- Attachment: OFBIZ-11032_ServiceDispatcher-is-not-meant-to-be-extend.patch > ServiceDispatche

[jira] [Created] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11067: -- Summary: Migrate integration tests to unit tests when possible Key: OFBIZ-11067 URL: https://issues.apache.org/jira/browse/OFBIZ-11067 Project: OFBiz Iss

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Sprint: OFBiz Community Day (May 2019) > StringUtil cleanup > -- > >

[jira] [Commented] (OFBIZ-11014) StringUtil cleanup

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848126#comment-16848126 ] Mathieu Lirzin commented on OFBIZ-11014: Hello [~swapnilmmane], done, thanks fo

[jira] [Updated] (OFBIZ-11032) ServiceDispatcher implementation details should be private

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11032: --- Sprint: OFBiz Community Day (May 2019) > ServiceDispatcher implementation details should be

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Sprint: OFBiz Community Day (May 2019) > Migrate integration tests to unit tests when possib

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848213#comment-16848213 ] Mathieu Lirzin commented on OFBIZ-11067: Committed patches 1 to 7 on trunk in re

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848214#comment-16848214 ] Mathieu Lirzin commented on OFBIZ-11067: {{UtilPropertiesTests}} is surprisingly

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848217#comment-16848217 ] Mathieu Lirzin commented on OFBIZ-11067: When trying to convert {{FlexibleMapAcc

[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848233#comment-16848233 ] Mathieu Lirzin commented on OFBIZ-8858: --- I would recommend rewriting the following

[jira] [Commented] (OFBIZ-8853) Unit test case for service - CheckReturnComplete

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-8853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848238#comment-16848238 ] Mathieu Lirzin commented on OFBIZ-8853: --- Like what I said in OFBIZ-8858, I would re

[jira] [Commented] (OFBIZ-8858) Unit test case for service - CreateReturnAndItemOrAdjustment

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848246#comment-16848246 ] Mathieu Lirzin commented on OFBIZ-8858: --- Hello [~suraj.khurana],I didn't notice any

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: (was: OFBIZ-11067_0016-Turn-FlexibleStringExpanderTests-into-a-uni.patch) >

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: (was: OFBIZ-11067_0018-Turn-TestJSONConverters-into-a-unit-test-cl.patch) >

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: (was: OFBIZ-11067_0017-Turn-TestBooleanConverters-into-a-unit-test.patch) >

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Attachment: OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch

[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848293#comment-16848293 ] Mathieu Lirzin commented on OFBIZ-11067: Committed patches 8 to 17 on trunk in r

[jira] [Updated] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2019-05-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11067: --- Fix Version/s: Upcoming Branch > Migrate integration tests to unit tests when possible > ---

[jira] [Created] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11070: -- Summary: Refactor EntityDataLoadContainer Key: OFBIZ-11070 URL: https://issues.apache.org/jira/browse/OFBIZ-11070 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Attachment: OFBIZ-11070_0001-Rewrite-EntityDataLoadContainer-isPropertySet.patch

[jira] [Updated] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-05-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11070: --- Sprint: OFBiz Community Day (May 2019) > Refactor EntityDataLoadContainer >

[jira] [Updated] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10817: --- Attachment: OFBIZ-10817_Use-method-references-instead-of-lambda-ins.patch > Configure stackT

[jira] [Commented] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859228#comment-16859228 ] Mathieu Lirzin commented on OFBIZ-10817: Lambda expressions are not meant to be

[jira] [Comment Edited] (OFBIZ-10817) Configure stackTrace displaying on ftl rendering

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859228#comment-16859228 ] Mathieu Lirzin edited comment on OFBIZ-10817 at 6/8/19 2:14 PM: --

[jira] [Commented] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859231#comment-16859231 ] Mathieu Lirzin commented on OFBIZ-11070: After bisecting I identified that the r

[jira] [Closed] (OFBIZ-11070) Refactor EntityDataLoadContainer

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin closed OFBIZ-11070. -- I don't want to investigate more on why [^OFBIZ-11070_0003-Inline-EntityDataLoadContainer-getLoa

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Attachment: OFBIZ-11014_Inline-StringUtil-toMap.patch > StringUtil cleanup > ---

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Attachment: (was: OFBIZ-11014_Inline-StringUtil-toMap.patch) > StringUtil cleanup >

[jira] [Updated] (OFBIZ-11014) StringUtil cleanup

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11014: --- Attachment: OFBIZ-11014_0015-Inline-StringUtil-toMap.patch > StringUtil cleanup > --

[jira] [Commented] (OFBIZ-11014) StringUtil cleanup

2019-06-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859323#comment-16859323 ] Mathieu Lirzin commented on OFBIZ-11014: ‘StringUtil#toMap’ is only used in the

[jira] [Created] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

2019-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11098: -- Summary: methods not accessing ‘this’ should be ‘static’ Key: OFBIZ-11098 URL: https://issues.apache.org/jira/browse/OFBIZ-11098 Project: OFBiz Issue Typ

[jira] [Updated] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11098: --- Attachment: OFBIZ-11098_plugins.patch > methods not accessing ‘this’ should be ‘static’ > --

[jira] [Updated] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11098: --- Attachment: OFBIZ-11098_framework.patch > methods not accessing ‘this’ should be ‘static’ >

[jira] [Commented] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859972#comment-16859972 ] Mathieu Lirzin commented on OFBIZ-11098: Committed [^OFBIZ-11098_framework.patc

[jira] [Updated] (OFBIZ-11098) methods not accessing ‘this’ should be ‘static’

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11098: --- Attachment: OFBIZ-11098_framework-safe-public.patch > methods not accessing ‘this’ should be

[jira] [Created] (OFBIZ-11099) Refactor ‘ContainerLoader’

2019-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11099: -- Summary: Refactor ‘ContainerLoader’ Key: OFBIZ-11099 URL: https://issues.apache.org/jira/browse/OFBIZ-11099 Project: OFBiz Issue Type: Improvement

[jira] [Updated] (OFBIZ-11099) Refactor ‘ContainerLoader’

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11099: --- Attachment: OFBIZ-11099_0001-Use-the-Deque-interface-in-ContainerLoader.patch

[jira] [Created] (OFBIZ-11100) Remove support for "ofbiz-containers.xml"

2019-06-10 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-11100: -- Summary: Remove support for "ofbiz-containers.xml" Key: OFBIZ-11100 URL: https://issues.apache.org/jira/browse/OFBIZ-11100 Project: OFBiz Issue Type: Imp

[jira] [Updated] (OFBIZ-11100) Remove support for "ofbiz-containers.xml"

2019-06-10 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-11100: --- Attachment: OFBIZ-11100_Remove-support-for-ofbiz-containers.xml.patch > Remove support for "

<    2   3   4   5   6   7   8   9   10   11   >