subject:"\[GitHub\] \[ofbiz\-framework\] JacquesLeRoux commented on pull request #209\: OFBIZ\-11446 Improved\: Convert ContentPermissionServices.xml mini lang to groovy"

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-02 Thread GitBox

JacquesLeRoux commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-667652461 Hi Wiebke, Just a cursory review for now, please respect the max filelenght (150), TIA This i

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-03 Thread GitBox

JacquesLeRoux commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668131743 Hi Wiebke, Yes: in https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, HTH