[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #423: Improved: List and Grid (OFBIZ-11345)

2022-01-16 Thread GitBox
JacquesLeRoux commented on pull request #423: URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1013872744 Hi Pierre, I'll push from here because GH merges it easily. I'll then make some modification after pulling locally -- This is an automated message from the

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #423: Improved: List and Grid (OFBIZ-11345)

2022-01-08 Thread GitBox
JacquesLeRoux commented on pull request #423: URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007206586 Actually I was unable of locally patching all and was a bit tired. Now I see things better and I have only one question: why removing

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #423: Improved: List and Grid (OFBIZ-11345)

2022-01-06 Thread GitBox
JacquesLeRoux commented on pull request #423: URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007206586 Actually I was unable of locally patching all and was a bit tired. Now I see things better and I have only one question: why removing

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #423: Improved: List and Grid (OFBIZ-11345)

2022-01-06 Thread GitBox
JacquesLeRoux commented on pull request #423: URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006506836 Then could you please split this part in another PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #423: Improved: List and Grid (OFBIZ-11345)

2022-01-06 Thread GitBox
JacquesLeRoux commented on pull request #423: URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006482708 Hi Pierre, Could you please explain why did you introduced unrelated changes eg in FindSubscription, ListFindSubscription? I guess it's the clean-up you speak