JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1000276537
Hi @adityasharma7,
Is that not already done when adding a new package? For instance adding
`"trumbowyg": "^2.25.1"` we get
```
> Task :npmInstall
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161
>We do also sanitize serversided again, right?
Java but not js, why?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998971560
@bjugl ,
I'm no longer able to review the js CodeQL analysis (because of npm use).
There were no real issues. I saw for instance that they used things like \.
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998736206
@PierreSmits
The problem Pierre is that there is not really an " appropriate code file"
--
This is an automated message from the Apache Git Service.
To resp
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998704199
Thanks Benjamin,
Following [this
advice](https://www.freecodecamp.org/news/json-comment-example-how-to-comment-in-json-files/),
maybe as a data? To be checked
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998130748
I did not review yet. I suggest we consider to use gradle-npm to load the
lib.
--
This is an automated message from the Apache Git Service.
To respond to the messa
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998118055
Hi Benjamin,
I'll review the CodeQL scanning results. There are often false or benign
alerts...
--
This is an automated message from the Apache Git Service.
JacquesLeRoux commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998119942
It's all 3rd lib issues so hard to fix w/o losing contact with their
upgrades. I'll still check...
--
This is an automated message from the Apache Git Service.
To
