[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-12 Thread GitBox
danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758538114 Hi @ieugen , It was my first commit so I was very keen to ensure I followed ofbiz conventions. However there are examples in the git log of merge commits being

[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-11 Thread GitBox
danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758190643 Merged in commit c9ee8421639a9d9b623d012531d76eddce1dcb48 This is an automated message from the Apache

[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-11 Thread GitBox
danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757871611 Hi @ieugen , I tried running the integration steps again today, this time carefully double checking and recording my steps and am happy to report that integration

[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-09 Thread GitBox
danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757397683 Hi @ieugen, I'm getting some integration test failures with the caching change. Please could you double check by running: `./gradlew "ofbiz --test"`

[GitHub] [ofbiz-framework] danwatford commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-09 Thread GitBox
danwatford commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-757397683 Hi @ieugen, I'm getting some integration test failures with the caching change. Please could you double check by running: `./gradlew "ofbiz --test"`