[GitHub] [ofbiz-framework] priyasharma1 edited a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 edited a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602910 > I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] priyasharma1 edited a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 edited a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638601279 Thanks, Jacques Actually, in these files, I found the message to be like Debug.logError(e, "Failure in " + module) Thus I did not omit the "module" i