Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-10-16 Thread via GitHub
gtchaboussie closed pull request #745: OFBIZ-12989 URL: https://github.com/apache/ofbiz-framework/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-06-09 Thread via GitHub
JacquesLeRoux commented on PR #745: URL: https://github.com/apache/ofbiz-framework/pull/745#issuecomment-215641 Hi @gtchaboussie, So you can squash? I thought we could only squash when merge. At least as a committer I see no squash option alone, only "Squash and merge" -- This

Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-06-07 Thread via GitHub
sonarcloud[bot] commented on PR #745: URL: https://github.com/apache/ofbiz-framework/pull/745#issuecomment-2154382807 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://so

Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-04-05 Thread via GitHub
gtchaboussie commented on PR #745: URL: https://github.com/apache/ofbiz-framework/pull/745#issuecomment-2039318934 thanks for the heads up. I'll focus on https://issues.apache.org/jira/browse/OFBIZ-12991 for now. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-04-05 Thread via GitHub
JacquesLeRoux commented on PR #745: URL: https://github.com/apache/ofbiz-framework/pull/745#issuecomment-2039246589 Hi @gtchaboussie, I'm working on https://issues.apache.org/jira/browse/OFBIZ-12985, for now https://issues.apache.org/jira/browse/OFBIZ-12995 as a 1st step, so there are

Re: [PR] OFBIZ-12989 [ofbiz-framework]

2024-04-05 Thread via GitHub
JacquesLeRoux commented on PR #745: URL: https://github.com/apache/ofbiz-framework/pull/745#issuecomment-2039170868 Hi @gtchaboussie , Yes that works too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a