[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2021-12-20 Thread Michael Brohl (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17462759#comment-17462759 ] Michael Brohl commented on OFBIZ-10047: --- Investigating why we have a Request Object inside a

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2018-03-24 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412611#comment-16412611 ] Jacques Le Roux commented on OFBIZ-10047: - I did not review but at least there is no issue

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2018-03-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411177#comment-16411177 ] Jacques Le Roux commented on OFBIZ-10047: - This feature will be under review after OFBIZ-10304. I

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-23 Thread James Yong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302479#comment-16302479 ] James Yong commented on OFBIZ-10047: Thanks Michael for linking the revision info to the issue. >

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-23 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302472#comment-16302472 ] Michael Brohl commented on OFBIZ-10047: --- The changes are in trunk r1819133. > Tomcat SSO >

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-20 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298038#comment-16298038 ] Jacques Le Roux commented on OFBIZ-10047: - Thanks James, OK, I stand corrected. I followed

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-19 Thread James Yong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297020#comment-16297020 ] James Yong commented on OFBIZ-10047: Hi Jacques, This block of code is needed, or else the user is

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-19 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296572#comment-16296572 ] Jacques Le Roux commented on OFBIZ-10047: - About Michael's concern about how this works in a

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-19 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296569#comment-16296569 ] Jacques Le Roux commented on OFBIZ-10047: - About

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-19 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296545#comment-16296545 ] Jacques Le Roux commented on OFBIZ-10047: - I reviewed the code a last time and read the Tomcat

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295183#comment-16295183 ] Jacques Le Roux commented on OFBIZ-10047: - bq. A year? The last time we did a release soon after

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295131#comment-16295131 ] Michael Brohl commented on OFBIZ-10047: --- bq. I think that we should rather use true by default and

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295045#comment-16295045 ] Jacques Le Roux commented on OFBIZ-10047: - Thanks James, bq. I have revised the original

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-17 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294114#comment-16294114 ] Jacques Le Roux commented on OFBIZ-10047: - Hi Michael, Did not see your comment before posting

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-17 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294083#comment-16294083 ] Jacques Le Roux commented on OFBIZ-10047: - Thanks James, Just a question why did you comment?

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-17 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294055#comment-16294055 ] Michael Brohl commented on OFBIZ-10047: --- Hi James, Jacques, thanks you for your efforts on this!

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293904#comment-16293904 ] Jacques Le Roux commented on OFBIZ-10047: - Thanks James, This works now and I see you have fixed

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-16 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293767#comment-16293767 ] Jacques Le Roux commented on OFBIZ-10047: - It's not lonly when you use

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-16 Thread James Yong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293761#comment-16293761 ] James Yong commented on OFBIZ-10047: If

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293385#comment-16293385 ] Jacques Le Roux commented on OFBIZ-10047: - Actually it works as long as you don't try to use a

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16293005#comment-16293005 ] Jacques Le Roux commented on OFBIZ-10047: - I surmise it could be related with {code} 2017-12-15

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292993#comment-16292993 ] Jacques Le Roux commented on OFBIZ-10047: - The problem I thought was in OFBIZ-10057 is easily

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292763#comment-16292763 ] Jacques Le Roux commented on OFBIZ-10047: - Also this page should then be removed

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292656#comment-16292656 ] Jacques Le Roux commented on OFBIZ-10047: - Hi James, I'd really like to have this feature in the

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292295#comment-16292295 ] Jacques Le Roux commented on OFBIZ-10047: - Hi James, Please check OFBIZ-10057, thanks > Tomcat

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-11 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16286359#comment-16286359 ] Jacques Le Roux commented on OFBIZ-10047: - Thanks James, It works now. I'll review ASAP, this

[jira] [Commented] (OFBIZ-10047) Tomcat SSO

2017-12-11 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285723#comment-16285723 ] Jacques Le Roux commented on OFBIZ-10047: - Hi James, I just applied the patch on trunk HEAD, set