Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-15 Thread via GitHub
JacquesLeRoux commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2056827627 @PierreSmits, The reason I agreed with Michael in substance is because now OFBiz is really mature. So if you change a label id you also change the possible translation

Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-14 Thread via GitHub
PierreSmits commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2054054946 Hi @JacquesLeRoux With your label corrections you neglected the aspect that in several other screens (and templates) CommonRole and CommonParty as labels already have

Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-14 Thread via GitHub
JacquesLeRoux merged PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-14 Thread via GitHub
sonarcloud[bot] commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2053939842 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-13 Thread via GitHub
sonarcloud[bot] commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2053634581 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Improved: Agreement Roles - VIEW permissions (OFBIZ-12518) [ofbiz-framework]

2024-04-13 Thread via GitHub
JacquesLeRoux commented on PR #471: URL: https://github.com/apache/ofbiz-framework/pull/471#issuecomment-2053634310 Hi, I agree with Michael, but we can do otherwise, reopening -- This is an automated message from the Apache Git Service. To respond to the message, please log on to