sonarcloud[bot] commented on pull request #380:
URL: https://github.com/apache/ofbiz-framework/pull/380#issuecomment-984836545
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452613#comment-17452613
]
Scott Gray commented on OFBIZ-12391:
A few points here from my perspective:
- createdDate and
Pierre Smits created OFBIZ-12429:
Summary: VIEW permissions - invoice overview term triggers
Key: OFBIZ-12429
URL: https://issues.apache.org/jira/browse/OFBIZ-12429
Project: OFBiz
Issue
PierreSmits opened a new pull request #380:
URL: https://github.com/apache/ofbiz-framework/pull/380
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12412:
-
Affects Version/s: Trunk
> Support for generating consolidate invoice for a
[
https://issues.apache.org/jira/browse/OFBIZ-12411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12411:
-
Affects Version/s: Trunk
> Generated requirments should also have a PDF support
[
https://issues.apache.org/jira/browse/OFBIZ-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12412:
-
Component/s: accounting
> Support for generating consolidate invoice for a
[
https://issues.apache.org/jira/browse/OFBIZ-12411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12411:
-
Component/s: order
> Generated requirments should also have a PDF support
>
[
https://issues.apache.org/jira/browse/OFBIZ-12410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12410:
-
Component/s: product/facility
> Receive product by supplier
>
[
https://issues.apache.org/jira/browse/OFBIZ-12410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava reassigned OFBIZ-12410:
Assignee: Aishwary Shrivastava
> Receive product by supplier
>
Nameet Jain created OFBIZ-12430:
---
Summary: Add Invoice notes
Key: OFBIZ-12430
URL: https://issues.apache.org/jira/browse/OFBIZ-12430
Project: OFBiz
Issue Type: Improvement
Pierre Smits created OFBIZ-12431:
Summary: VIEW permissions - invoice notes
Key: OFBIZ-12431
URL: https://issues.apache.org/jira/browse/OFBIZ-12431
Project: OFBiz
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/OFBIZ-12431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-12431:
-
Description:
Though there is an entity InvoiceNote, this cannot be accessed by user with
VIEW
[
https://issues.apache.org/jira/browse/OFBIZ-12409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12409:
-
Affects Version/s: Trunk
> Support to manage order terms for purchase order
>
[
https://issues.apache.org/jira/browse/OFBIZ-12410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12410:
-
Affects Version/s: Trunk
> Receive product by supplier
>
[
https://issues.apache.org/jira/browse/OFBIZ-12409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12409:
-
Component/s: order
> Support to manage order terms for purchase order
>
[
https://issues.apache.org/jira/browse/OFBIZ-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava reassigned OFBIZ-12412:
Assignee: Aishwary Shrivastava
> Support for generating consolidate
[
https://issues.apache.org/jira/browse/OFBIZ-12407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12407:
-
Affects Version/s: Trunk
> Downloadable costing PDF
>
[
https://issues.apache.org/jira/browse/OFBIZ-12407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12407:
-
Component/s: product/catalog
(was: manufacturing)
>
[
https://issues.apache.org/jira/browse/OFBIZ-12408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava updated OFBIZ-12408:
-
Component/s: product/facility
(was: order)
> Add manifest
[
https://issues.apache.org/jira/browse/OFBIZ-12412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aishwary Shrivastava reassigned OFBIZ-12412:
Assignee: (was: Aishwary Shrivastava)
> Support for generating
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452797#comment-17452797
]
Pierre Smits commented on OFBIZ-12391:
--
Hi Scott,
Thanks for sharing your insights and
PierreSmits opened a new pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378
Though there is an entity InvoiceContactMech, this cannot be accessed by
user with VIEW permissions when accessing an invoice.
See:
for entity data:
sonarcloud[bot] commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984424564
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
Pierre Smits created OFBIZ-12428:
Summary: VIEW permissions - invoice contact mechs
Key: OFBIZ-12428
URL: https://issues.apache.org/jira/browse/OFBIZ-12428
Project: OFBiz
Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452341#comment-17452341
]
Pierre Smits commented on OFBIZ-12391:
--
Gutentag Michael,
Indeed, I am aware of this has a impact
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452349#comment-17452349
]
Pierre Smits commented on OFBIZ-12391:
--
Additionally, [~mbrohl], enhancing modelentity.java with
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452349#comment-17452349
]
Pierre Smits edited comment on OFBIZ-12391 at 12/2/21, 11:35 AM:
-
sonarcloud[bot] commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984554810
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452357#comment-17452357
]
Pierre Smits commented on OFBIZ-12391:
--
[~mbrohl],
Your initial argument(s) did't hold merit, and
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452298#comment-17452298
]
Pierre Smits commented on OFBIZ-12391:
--
Bonjour Jacques,
My apologies for not reacting in more
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452334#comment-17452334
]
Michael Brohl commented on OFBIZ-12391:
---
Please have in mind that audit functions are problematic
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452341#comment-17452341
]
Pierre Smits edited comment on OFBIZ-12391 at 12/2/21, 11:21 AM:
-
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452357#comment-17452357
]
Pierre Smits edited comment on OFBIZ-12391 at 12/2/21, 11:49 AM:
-
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452347#comment-17452347
]
Michael Brohl commented on OFBIZ-12391:
---
It is simply a bad (wrong) approach to hard-code this
bjugl opened a new pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379
Fixed: Induction from DB does not represent relations properly.
(OFBIZ-12178)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JacquesLeRoux merged pull request #376:
URL: https://github.com/apache/ofbiz-framework/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12425.
Fix Version/s: Upcoming Branch
Resolution: Fixed
Thanks to Jacques for his assistance to
JacquesLeRoux commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984592456
Hi Pierre,
Did you check locally? It seems we have a test issue.
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/OFBIZ-12425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452387#comment-17452387
]
ASF subversion and git services commented on OFBIZ-12425:
-
Commit
PierreSmits edited a comment on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984595557
Hi @bjugl,
I tried to merge the commits in this PR into a test branch (based on
current trunk), and it didn't go through. Multiple rejection files were
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984595557
Hi @bjugl,
I tried to merge the commits in this PR to a test branch (based on current
trunk), and it didn't go through. Multiple rejection files were created.
PierreSmits commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984624010
HI Jacques,
Yes I did. Are you referring to the 'Java CI with Gradle/build
(pull_request) failing check mentioned above?
It seems there is something
PierreSmits commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984634899
Hi @JacquesLeRoux,
You have anymore insights?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sonarcloud[bot] commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984649383
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] removed a comment on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984424564
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
PierreSmits commented on pull request #378:
URL: https://github.com/apache/ofbiz-framework/pull/378#issuecomment-984652112
Hi Jacques,
It appears everything is ok now. Was the missing label the culprit?
--
This is an automated message from the Apache Git Service.
To respond to the
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984658188
HI @bjugl,
Please consider (for next time around) to keep the ticket id on the first
line. Otherwise the PR won't be referenced in the ticket.
--
This is an
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452423#comment-17452423
]
Michael Brohl commented on OFBIZ-12391:
---
To make my position more clear: I see that this is a
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984664103
> I tried to merge the commits in this PR into a test branch (based on
current trunk), and it didn't go through. Multiple rejection files were created.
This PR is
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984668229
> Please consider (for next time around) to keep the ticket id on the first
line. Otherwise the PR won't be referenced in the ticket.
Fixed.
--
This is an
bjugl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984672315
Thank you, Michael.
On 02.12.21 15:17, Michael Brohl ***@***.***> wrote:
> Please consider (for next time around) to keep the ticket id on the
> first
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984674645
> > I tried to merge the commits in this PR into a test branch (based on
current trunk), and it didn't go through. Multiple rejection files were created.
>
>
mbrohl commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984677525
It's clearly stated, please have a look at the information below the title.
Both target an source branches are named with reference to the 18.12 branch:
"bjugl wants to
[
https://issues.apache.org/jira/browse/OFBIZ-12391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17452436#comment-17452436
]
Pierre Smits commented on OFBIZ-12391:
--
No worries, [~mbrohl]. Take your time.
For sure, there are
mbrohl edited a comment on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984677525
It's clearly stated, please have a look at the information below the title.
Both target an source branches are named with reference to the 18.12 branch:
"bjugl
PierreSmits commented on pull request #379:
URL: https://github.com/apache/ofbiz-framework/pull/379#issuecomment-984686682
Thanks, Michael.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
57 matches
Mail list logo
