[jira] [Closed] (OFBIZ-12473) CheckStyleMain Task is Failing in 18.12.04

2021-12-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12473. --- Fix Version/s: 18.12.05 Resolution: Fixed > CheckStyleMain Task is Failing in

[jira] [Closed] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-22 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-12450. Fix Version/s: Upcoming Branch Resolution: Fixed Thanks to Jacques for his assistance to

[jira] [Updated] (OFBIZ-12473) CheckStyleMain Task is Failing in 18.12.04

2021-12-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12473: Summary: CheckStyleMain Task is Failing in 18.12.04 (was: CLONE - CheckStyleMain Task is

[jira] [Comment Edited] (OFBIZ-12471) Gradle Wrapper is not downloaded with 18.12.03

2021-12-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463603#comment-17463603 ] Jacques Le Roux edited comment on OFBIZ-12471 at 12/22/21, 4:33 PM:

[jira] [Commented] (OFBIZ-12471) Gradle Wrapper is not downloaded with 18.12.03

2021-12-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463958#comment-17463958 ] Jacques Le Roux commented on OFBIZ-12471: - Hi David, Please try this patch:

[jira] [Updated] (OFBIZ-12471) Gradle Wrapper is not downloaded with 18.12.03

2021-12-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12471: Attachment: OFBIZ-12471.patch > Gradle Wrapper is not downloaded with 18.12.03 >

[jira] [Commented] (OFBIZ-12450) Price Rules: Price rules configurations are not syncing with eCommerce storefront

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463885#comment-17463885 ] ASF subversion and git services commented on OFBIZ-12450: - Commit

[jira] [Commented] (OFBIZ-12473) CheckStyleMain Task is Failing in 18.12.04

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463944#comment-17463944 ] ASF subversion and git services commented on OFBIZ-12473: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #424: Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450)

2021-12-22 Thread GitBox
JacquesLeRoux merged pull request #424: URL: https://github.com/apache/ofbiz-framework/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
adityasharma7 commented on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-148402 > @bjugl , > > I'm no longer able to review the js CodeQL analysis (because of npm use). There were no real issues. I saw for instance that they used things

[GitHub] [ofbiz-framework] bjugl commented on a change in pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
bjugl commented on a change in pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773682160 ## File path: applications/content/widget/CommonScreens.xml ## @@ -33,6 +33,7 @@ under the License.

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463675#comment-17463675 ] ASF subversion and git services commented on OFBIZ-12456: - Commit

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463765#comment-17463765 ] ASF subversion and git services commented on OFBIZ-12456: - Commit

[GitHub] [ofbiz-framework] bjugl edited a comment on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
bjugl edited a comment on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999354788 > I'm no longer able to review the js CodeQL analysis (because of npm use). There were no real issues. I saw for instance that they used things like `\.` in regexp

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
JacquesLeRoux edited a comment on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-998971560 @bjugl , I'm no longer able to review the js CodeQL analysis (because of npm use). There were no real issues. I saw for instance that they used things

[GitHub] [ofbiz-framework] bjugl edited a comment on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
bjugl edited a comment on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999354788 > I'm no longer able to review the js CodeQL analysis (because of npm use). There were no real issues. I saw for instance that they used things like `\.` in regexp

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463682#comment-17463682 ] ASF subversion and git services commented on OFBIZ-12456: - Commit

[jira] [Commented] (OFBIZ-12456) Migrate Ofbiz bb 0.8 config to 3.2

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17463743#comment-17463743 ] ASF subversion and git services commented on OFBIZ-12456: - Commit

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
JacquesLeRoux commented on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161 >We do also sanitize serversided again, right? Java but not js, why? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
JacquesLeRoux edited a comment on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161 >We do also sanitize serversided again, right? Java but not js, why? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
JacquesLeRoux edited a comment on pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-999423161 >We do also sanitize serversided again, right? Yes inputs are sanitised -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [ofbiz-framework] adityasharma7 commented on a change in pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
adityasharma7 commented on a change in pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773791624 ## File path: themes/common-theme/webapp/common/css/trumbowygCustom.css ## @@ -0,0 +1,642 @@ +/** Review comment: I think we should

[GitHub] [ofbiz-framework] adityasharma7 commented on a change in pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

2021-12-22 Thread GitBox
adityasharma7 commented on a change in pull request #425: URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773793559 ## File path: applications/content/widget/CommonScreens.xml ## @@ -33,6 +33,7 @@ under the License.