JacquesLeRoux commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007206586
Actually I was unable of locally patching all and was a bit tired. Now I see
things better and I have only one question: why removing
PierreSmits commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007187623
You talk about the labels added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470377#comment-17470377
]
Pierre Smits commented on OFBIZ-10093:
--
As this (Trumbowyg) is now included in the code base, the
[
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma closed OFBIZ-10093.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~bjugl] for your
[
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya Sharma reassigned OFBIZ-10093:
-
Assignee: Aditya Sharma (was: Benjamin Jugl)
> Replace ELRTE plugin with Trumbowyg
>
[
https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470368#comment-17470368
]
ASF subversion and git services commented on OFBIZ-10093:
-
Commit
adityasharma7 commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1007179064
Thanks @bjugl for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adityasharma7 merged pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adityasharma7 edited a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1001592780
> Hi @adityasharma7,
>
> Is that not already done when adding a new package? For instance adding
`"trumbowyg": "^2.25.1"` we get
>
> ```
> >
PierreSmits commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1007171525
Hi Jacques,
It is true that the underlying entity used to display the line items has
more elements than is being displayed with the change. This is controlled
JacquesLeRoux commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1006748343
Pierre,
Why are some elements not present in the view only?
Fin Account Name
From Date
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470025#comment-17470025
]
Pierre Smits commented on OFBIZ-9352:
-
Thanks to Jacques for his assistance to get this into the
[
https://issues.apache.org/jira/browse/OFBIZ-9352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470018#comment-17470018
]
ASF subversion and git services commented on OFBIZ-9352:
Commit
JacquesLeRoux merged pull request #413:
URL: https://github.com/apache/ofbiz-framework/pull/413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12457.
Resolution: Implemented
Thanks to Jacques for his assistance to get this into the codebase.
>
[
https://issues.apache.org/jira/browse/OFBIZ-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470010#comment-17470010
]
ASF subversion and git services commented on OFBIZ-12457:
-
Commit
JacquesLeRoux merged pull request #414:
URL: https://github.com/apache/ofbiz-framework/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12458.
Resolution: Implemented
Thanks to Jacques for his assistance to get this into the codebase.
>
[
https://issues.apache.org/jira/browse/OFBIZ-12462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-12462.
Resolution: Implemented
Thanks to Jacques for his assistance to get this into the codebase
>
[
https://issues.apache.org/jira/browse/OFBIZ-12458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1746#comment-1746
]
ASF subversion and git services commented on OFBIZ-12458:
-
Commit
JacquesLeRoux merged pull request #415:
URL: https://github.com/apache/ofbiz-framework/pull/415
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469979#comment-17469979
]
ASF subversion and git services commented on OFBIZ-12462:
-
Commit
JacquesLeRoux merged pull request #418:
URL: https://github.com/apache/ofbiz-framework/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469977#comment-17469977
]
Jacques Le Roux commented on OFBIZ-12479:
-
Hi Jacopo,
Here is the new draft version:
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469977#comment-17469977
]
Jacques Le Roux edited comment on OFBIZ-12479 at 1/6/22, 3:42 PM:
--
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469977#comment-17469977
]
Jacques Le Roux edited comment on OFBIZ-12479 at 1/6/22, 3:42 PM:
--
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12479:
Fix Version/s: 17.12.09
(was: 17.12.08)
Affects
[
https://issues.apache.org/jira/browse/OFBIZ-12474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469910#comment-17469910
]
ASF subversion and git services commented on OFBIZ-12474:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469907#comment-17469907
]
ASF subversion and git services commented on OFBIZ-12479:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469908#comment-17469908
]
ASF subversion and git services commented on OFBIZ-12449:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469906#comment-17469906
]
ASF subversion and git services commented on OFBIZ-12464:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469909#comment-17469909
]
ASF subversion and git services commented on OFBIZ-12470:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469911#comment-17469911
]
ASF subversion and git services commented on OFBIZ-12475:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469905#comment-17469905
]
ASF subversion and git services commented on OFBIZ-12479:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-12479:
Summary: Announce 17.12.09 EOL (was: Announce 17.12.08 EOL)
> Announce 17.12.09 EOL
>
[
https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469865#comment-17469865
]
Pierre Smits commented on OFBIZ-11345:
--
Thanks to Jacques for his assistance to get this into the
PierreSmits edited a comment on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006495069
Hi Jacques,
Thanks for the review.
The short answer on all three questions is 'Yes'.
--
This is an automated message from the Apache Git Service.
JacquesLeRoux commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006506836
Then could you please split this part in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
PierreSmits commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006495069
Hi Jacques,
Thanks for the review.
The short answer on both questions is 'Yes'.
--
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469817#comment-17469817
]
Jacques Le Roux edited comment on OFBIZ-12479 at 1/6/22, 11:14 AM:
---
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469817#comment-17469817
]
Jacques Le Roux edited comment on OFBIZ-12479 at 1/6/22, 11:13 AM:
---
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-11783.
Resolution: Implemented
Thanks to Jacques to get this into the codebase
> Have a Menu in
JacquesLeRoux edited a comment on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006482708
Hi Pierre,
Could you please explain why you introduced unrelated changes eg in
FindSubscription, ListFindSubscription? I guess it's the clean-up you
[
https://issues.apache.org/jira/browse/OFBIZ-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits closed OFBIZ-11777.
Resolution: Implemented
Thanks to Jacques for getting this into the repository.
> Have a Menu in
JacquesLeRoux commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1006482708
Hi Pierre,
Could you please explain why did you introduced unrelated changes eg in
FindSubscription, ListFindSubscription? I guess it's the clean-up you
[
https://issues.apache.org/jira/browse/OFBIZ-11345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469849#comment-17469849
]
ASF subversion and git services commented on OFBIZ-11345:
-
Commit
JacquesLeRoux merged pull request #426:
URL: https://github.com/apache/ofbiz-framework/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-11783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469848#comment-17469848
]
ASF subversion and git services commented on OFBIZ-11783:
-
Commit
JacquesLeRoux merged pull request #428:
URL: https://github.com/apache/ofbiz-framework/pull/428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469847#comment-17469847
]
ASF subversion and git services commented on OFBIZ-11777:
-
Commit
JacquesLeRoux merged pull request #429:
URL: https://github.com/apache/ofbiz-framework/pull/429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469830#comment-17469830
]
Pierre Smits commented on OFBIZ-10363:
--
Thanks to Jacques for his assistance to get this into the
[
https://issues.apache.org/jira/browse/OFBIZ-10363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469822#comment-17469822
]
ASF subversion and git services commented on OFBIZ-10363:
-
Commit
JacquesLeRoux merged pull request #430:
URL: https://github.com/apache/ofbiz-framework/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469817#comment-17469817
]
Jacques Le Roux edited comment on OFBIZ-12479 at 1/6/22, 10:15 AM:
---
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469817#comment-17469817
]
Jacques Le Roux commented on OFBIZ-12479:
-
Hi Jacopo,
Yes I thought about that. I like you idea
sonarcloud[bot] removed a comment on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1000334043
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
sonarcloud[bot] commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1006436120
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
[
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469792#comment-17469792
]
Jacopo Cappellato commented on OFBIZ-12479:
---
[~jleroux] I think that the draft should be
59 matches
Mail list logo