[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #161: Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304)

2020-06-09 Thread GitBox
adityasharma7 commented on pull request #161: URL: https://github.com/apache/ofbiz-framework/pull/161#issuecomment-641341580 Hi Jacques, I think the issues reported by SonarCloud are unrelated. It's strange that it reported issues for JS files and I have made changes to only Gradle

[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #27: OFBIZ-11756 vue js renderer

2020-06-09 Thread GitBox
JacquesLeRoux commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-641327354 Hi Olivier, It seems uneasy but please check the issues reported by "SonarCloud Quality Gate ", TIA

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #194: [Improved]: Overload groovy utility method to handle error logging with only throwable object as parameter. (OFBIZ-11762)

2020-06-09 Thread GitBox
JacquesLeRoux merged pull request #194: URL: https://github.com/apache/ofbiz-framework/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
JacquesLeRoux commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638354697 Thanks Priya, It's OK with me but for EditSurveyQuestions.groovy OpenOrderItemsReport.groovy ComputeProductSellThroughData.groovy

[GitHub] [ofbiz-framework] mbrohl commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
mbrohl commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638374937 I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638161272 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
sonarcloud[bot] commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638164702 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #188: Improved: flatgrey - simplified uris (OFBIZ-11795)

2020-06-04 Thread GitBox
PierreSmits opened a new pull request #188: URL: https://github.com/apache/ofbiz-framework/pull/188 adjusted the main menu ftl to work with simplified uris This is an automated message from the Apache Git Service. To respond

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #188: Improved: flatgrey - simplified uris (OFBIZ-11795)

2020-06-04 Thread GitBox
sonarcloud[bot] commented on pull request #188: URL: https://github.com/apache/ofbiz-framework/pull/188#issuecomment-639095730 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=188=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #190: Improved: tomahawk - simplified uris (OFBIZ-11798)

2020-06-05 Thread GitBox
sonarcloud[bot] commented on pull request #190: URL: https://github.com/apache/ofbiz-framework/pull/190#issuecomment-639320649 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=190=false=BUG)

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #117: Improved: Update Data Sets

2020-06-05 Thread GitBox
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the demo set.

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #189: Improved: rainbow - simplified uris (OFBIZ-11797)

2020-06-05 Thread GitBox
PierreSmits opened a new pull request #189: URL: https://github.com/apache/ofbiz-framework/pull/189 implement changes to the rainbow theme to provide simplified uris in the main menu. This is an automated message from

[GitHub] [ofbiz-framework] surajkhurana merged pull request #171: Improved: Enforce noninstantiability to FinAccountHelper Class.

2020-06-05 Thread GitBox
surajkhurana merged pull request #171: URL: https://github.com/apache/ofbiz-framework/pull/171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] surajkhurana merged pull request #22: Improved: Enforce noninstantiability to FinAccountHelper Class.

2020-06-05 Thread GitBox
surajkhurana merged pull request #22: URL: https://github.com/apache/ofbiz-plugins/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #190: Improved: tomahawk - simplified uris (OFBIZ-11798)

2020-06-05 Thread GitBox
PierreSmits opened a new pull request #190: URL: https://github.com/apache/ofbiz-framework/pull/190 implement changes to the rainbow theme to provide simplified uris in the main menu. This is an automated message from the

[GitHub] [ofbiz-plugins] PierreSmits opened a new pull request #25: Improved: project - simplified uris (OFBIZ-11792)

2020-06-04 Thread GitBox
PierreSmits opened a new pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25 reworked web.xml, widgets and other xml files to have simplified project uris. This is an automated message from the Apache

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #25: Improved: project - simplified uris (OFBIZ-11792)

2020-06-04 Thread GitBox
sonarcloud[bot] commented on pull request #25: URL: https://github.com/apache/ofbiz-plugins/pull/25#issuecomment-638846788 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=25=false=BUG)

[GitHub] [ofbiz-framework] verma-pawan opened a new pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatc

2020-06-05 Thread GitBox
verma-pawan opened a new pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191 Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for EntityBatchIterator to EntityQuery via

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for Entity

2020-06-05 Thread GitBox
sonarcloud[bot] commented on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639398377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support fo

2020-06-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639398377 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #191: Implemented: EntityBatchIterator which pages through large resultsets (500 at a time by default) and added support for Entity

2020-06-05 Thread GitBox
sonarcloud[bot] commented on pull request #191: URL: https://github.com/apache/ofbiz-framework/pull/191#issuecomment-639402499 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=191=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #65: OFBIZ-11587 docbook to asciidoc

2020-06-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-630146642 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #65: OFBIZ-11587 docbook to asciidoc

2020-06-05 Thread GitBox
sonarcloud[bot] commented on pull request #65: URL: https://github.com/apache/ofbiz-framework/pull/65#issuecomment-639464042 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=65=false=BUG)

[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #117: Improved: Update Data Sets

2020-06-05 Thread GitBox
PierreSmits edited a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-639308014 How is this check fail possible? 2 days ago everything was fine, and now it is stating that it failed. The only thing changed is added a few records in the

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #202: Improved: Changed decimals, rounding, zero static variables names as per best practices in accounting component.

2020-06-11 Thread GitBox
sonarcloud[bot] commented on pull request #202: URL: https://github.com/apache/ofbiz-framework/pull/202#issuecomment-642430812 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=202=false=BUG)

[GitHub] [ofbiz-framework] surajkhurana opened a new pull request #201: Improved: Changed decimals, rounding, zero static variables names

2020-06-11 Thread GitBox
surajkhurana opened a new pull request #201: URL: https://github.com/apache/ofbiz-framework/pull/201 Improved: Changed decimals, rounding, zero static variables names as per best practices in third party payment component. (OFBIZ-11804) Also make them private data members of the

[GitHub] [ofbiz-framework] surajkhurana opened a new pull request #202: Improved: Changed decimals, rounding, zero static variables names as per best practices in accounting component.

2020-06-11 Thread GitBox
surajkhurana opened a new pull request #202: URL: https://github.com/apache/ofbiz-framework/pull/202 Improved: Changed decimals, rounding, zero static variables names as per best practices in accounting component. (OFBIZ-11804) Also make them private data members of the class.

[GitHub] [ofbiz-framework] surajkhurana merged pull request #200: Improved: Changed decimals, rounding, zero static variables names as per best practices in manufacturing component.

2020-06-12 Thread GitBox
surajkhurana merged pull request #200: URL: https://github.com/apache/ofbiz-framework/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] adityasharma7 merged pull request #161: Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304)

2020-06-12 Thread GitBox
adityasharma7 merged pull request #161: URL: https://github.com/apache/ofbiz-framework/pull/161 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] surajkhurana merged pull request #195: Improved: Changed decimals, rounding, zero static variables names as per best practices.

2020-06-13 Thread GitBox
surajkhurana merged pull request #195: URL: https://github.com/apache/ofbiz-framework/pull/195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] surajkhurana merged pull request #196: Improved: Changed decimals, rounding, zero static variables names as per best practices in order component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #196: URL: https://github.com/apache/ofbiz-framework/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] surajkhurana merged pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] removed a comment on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=28=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] commented on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595978 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=28=false=BUG)

[GitHub] [ofbiz-framework] surajkhurana merged pull request #201: Improved: Changed decimals, rounding, zero static variables names

2020-06-13 Thread GitBox
surajkhurana merged pull request #201: URL: https://github.com/apache/ofbiz-framework/pull/201 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] surajkhurana merged pull request #202: Improved: Changed decimals, rounding, zero static variables names as per best practices in accounting component.

2020-06-13 Thread GitBox
surajkhurana merged pull request #202: URL: https://github.com/apache/ofbiz-framework/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
sonarcloud[bot] commented on pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28#issuecomment-643595664 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=28=false=BUG)

[GitHub] [ofbiz-plugins] surajkhurana opened a new pull request #28: Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component.

2020-06-13 Thread GitBox
surajkhurana opened a new pull request #28: URL: https://github.com/apache/ofbiz-plugins/pull/28 Improved: Changed dependency of decimals, rounding static variables as per best practices in ebay component. (OFBIZ-11804)

[GitHub] [ofbiz-framework] priyasharma1 closed pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 closed pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] priyasharma1 commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638601279 Thanks Jacques, Actually in these files, I found the message to be Debug.logError(e, "Failure in " + module) Thus I did not omit the "module" in the error

[GitHub] [ofbiz-framework] priyasharma1 commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602910 > I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #144: Improved: removed AR and AP Webapps from Accounting

2020-06-04 Thread GitBox
sonarcloud[bot] removed a comment on pull request #144: URL: https://github.com/apache/ofbiz-framework/pull/144#issuecomment-629833429 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=144=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #144: Improved: removed AR and AP Webapps from Accounting

2020-06-04 Thread GitBox
sonarcloud[bot] commented on pull request #144: URL: https://github.com/apache/ofbiz-framework/pull/144#issuecomment-638630499 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=144=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 edited a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-04 Thread GitBox
priyasharma1 edited a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602910 > I am not able to check right now but are we sure that this change does not introduce unwanted changes? Does it respect the log configurations with log4j?

[GitHub] [ofbiz-framework] priyasharma1 edited a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 edited a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638601279 Thanks, Jacques Actually, in these files, I found the message to be like Debug.logError(e, "Failure in " + module) Thus I did not omit the "module"

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
sonarcloud[bot] commented on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638602270 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #185: WIP: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #185: URL: https://github.com/apache/ofbiz-framework/pull/185#issuecomment-638164702 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=185=false=BUG)

[GitHub] [ofbiz-framework] surajkhurana merged pull request #177: Improved: Enforce noninstantiability to ServiceGroupReader Class.

2020-06-04 Thread GitBox
surajkhurana merged pull request #177: URL: https://github.com/apache/ofbiz-framework/pull/177 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] surajkhurana merged pull request #167: Improved: Enforce noninstantiability to BillingAccountWorker Class.

2020-06-04 Thread GitBox
surajkhurana merged pull request #167: URL: https://github.com/apache/ofbiz-framework/pull/167 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] priyasharma1 opened a new pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 opened a new pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24 (OFBIZ-11762) Explanation: - As per the discussion, updated all Debug.log* to log* - Removed unused Debug import from the files - Removed module variables as they are no

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
sonarcloud[bot] commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637986063 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=24=false=BUG)

[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
JacquesLeRoux commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-637996192 Hi Priya, Instead of logError(e, "") why not simply using logError(e) ? This is

[GitHub] [ofbiz-plugins] priyasharma1 commented on pull request #24: [Improved]: Use GroovyBaseScript's logging utility methods instead of using Debug (OFBIZ-11762)

2020-06-03 Thread GitBox
priyasharma1 commented on pull request #24: URL: https://github.com/apache/ofbiz-plugins/pull/24#issuecomment-638001095 > Hi Priya, > > Instead of > logError(e, "") > why not simply using > logError(e) > ? In that case, we will have to overload logError once again,

[GitHub] [ofbiz-framework] lodhiravi opened a new pull request #219: Fixed: Error in Quick Receive Purchase Order process (OFBIZ-11911)

2020-07-25 Thread GitBox
lodhiravi opened a new pull request #219: URL: https://github.com/apache/ofbiz-framework/pull/219 Done following- 1) Fixed typo in the createShipmentForFacilityAndShipGroup groovy method. PRUCH_SHIP_CREATED -> PURCH_SHIP_CREATED shipgroupSeqId -> shipGroupSeqId

[GitHub] [ofbiz-framework] verma-pawan merged pull request #219: Fixed: Error in Quick Receive Purchase Order process (OFBIZ-11911)

2020-07-25 Thread GitBox
verma-pawan merged pull request #219: URL: https://github.com/apache/ofbiz-framework/pull/219 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #219: Fixed: Error in Quick Receive Purchase Order process (OFBIZ-11911)

2020-07-25 Thread GitBox
sonarcloud[bot] commented on pull request #219: URL: https://github.com/apache/ofbiz-framework/pull/219#issuecomment-663817235 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=219=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #218: Fixed: Error while receiving the purchase order (OFBIZ-11909)

2020-07-24 Thread GitBox
sonarcloud[bot] commented on pull request #218: URL: https://github.com/apache/ofbiz-framework/pull/218#issuecomment-663808209 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=218=false=BUG)

[GitHub] [ofbiz-framework] verma-pawan merged pull request #218: Fixed: Error while receiving the purchase order (OFBIZ-11909)

2020-07-25 Thread GitBox
verma-pawan merged pull request #218: URL: https://github.com/apache/ofbiz-framework/pull/218 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] lodhiravi opened a new pull request #218: Fixed: Error while receiving the purchase order (OFBIZ-11909)

2020-07-24 Thread GitBox
lodhiravi opened a new pull request #218: URL: https://github.com/apache/ofbiz-framework/pull/218 Done following- 1. Converted GString to String while setting the success message in receiveInventoryProduct service to avoid the ClassCastException. 2. Also corrected loop condition

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #32: Release17.12

2020-07-15 Thread GitBox
sonarcloud[bot] removed a comment on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-656092289 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12

2020-07-15 Thread GitBox
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-659065038 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[GitHub] [ofbiz-plugins] JacquesLeRoux commented on pull request #32: Release17.12

2020-07-16 Thread GitBox
JacquesLeRoux commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-659198940 Hi Alex, Not sure why you are still pushing here. You know this will never be merged because we only merge PRs in trunk (our master if you prefer), and then

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
sonarcloud[bot] commented on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-660189770 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-658620356 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 commented on a change in pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)

2020-07-16 Thread GitBox
priyasharma1 commented on a change in pull request #158: URL: https://github.com/apache/ofbiz-framework/pull/158#discussion_r455750319 ## File path: applications/accounting/groovyScripts/payment/PaymentServices.groovy ## @@ -134,3 +136,77 @@ def updatePaymentContent() { }

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)

2020-07-16 Thread GitBox
sonarcloud[bot] commented on pull request #158: URL: https://github.com/apache/ofbiz-framework/pull/158#issuecomment-659381921 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)

2020-07-16 Thread GitBox
sonarcloud[bot] removed a comment on pull request #158: URL: https://github.com/apache/ofbiz-framework/pull/158#issuecomment-658150509 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG)

[GitHub] [ofbiz-framework] girishvasmatkar merged pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
girishvasmatkar merged pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
sonarcloud[bot] commented on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-660415573 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
sonarcloud[bot] removed a comment on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-660189770 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=214=false=BUG)

[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977565 Hi @JacquesLeRoux , conflict has been fixed now. This is an automated message from the Apache Git

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663113465 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry, "This branch has conflicts that must be resolved" as reports GH

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry "This branch has conflicts that must be resolved" as reports GH This

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-26 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663956951 Hi Daniel, Sorry "This branch has conflicts that must be resolved" as report GH This is an

[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665192736 All fixed @JacquesLeRoux This is an automated message from the Apache Git Service. To respond to the

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665155521 Hi Daniel, Sorry again, "This branch has conflicts that must be resolved" as reports GH. I guess it will be easier to fix for you. TIA :)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #216: Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11895)

2020-07-20 Thread GitBox
sonarcloud[bot] commented on pull request #216: URL: https://github.com/apache/ofbiz-framework/pull/216#issuecomment-660856405 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=216=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #215: Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894)

2020-07-20 Thread GitBox
sonarcloud[bot] commented on pull request #215: URL: https://github.com/apache/ofbiz-framework/pull/215#issuecomment-660869035 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=215=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #216: Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11

2020-07-20 Thread GitBox
sonarcloud[bot] removed a comment on pull request #216: URL: https://github.com/apache/ofbiz-framework/pull/216#issuecomment-660856405 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=216=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #216: Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11895)

2020-07-20 Thread GitBox
sonarcloud[bot] commented on pull request #216: URL: https://github.com/apache/ofbiz-framework/pull/216#issuecomment-660881303 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=216=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #215: Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894)

2020-07-20 Thread GitBox
sonarcloud[bot] removed a comment on pull request #215: URL: https://github.com/apache/ofbiz-framework/pull/215#issuecomment-660635724 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=215=false=BUG)

[GitHub] [ofbiz-framework] verma-pawan merged pull request #216: Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11895)

2020-07-20 Thread GitBox
verma-pawan merged pull request #216: URL: https://github.com/apache/ofbiz-framework/pull/216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #216: Improved: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls (OFBIZ-11895)

2020-07-20 Thread GitBox
priyasharma1 opened a new pull request #216: URL: https://github.com/apache/ofbiz-framework/pull/216 (OFBIZ-11895) - Updated the service definition to convert it into entity-auto - Added permission check service as used in the Java implementation - Removed the java

[GitHub] [ofbiz-framework] danwatford opened a new pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-23 Thread GitBox
danwatford opened a new pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217 Refactoring of WidgetWorker so that it generates URI and JSoup Element objects to represent created URLs, hidden forms and anchor tags. This replaces the previous approach where

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-23 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663113465 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666498799 Thanks Daniel, The patch applies, I'll review ASAP... This is an automated message from the

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-07-30 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-666340394 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-07-30 Thread GitBox
girishvasmatkar opened a new pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35 Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz. Explanation : This initial implementation allows existing or new OFBiz services (export=true

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #32: Release17.12

2020-07-05 Thread GitBox
sonarcloud[bot] commented on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-653898600 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #32: Release17.12

2020-07-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #32: URL: https://github.com/apache/ofbiz-plugins/pull/32#issuecomment-651662919 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=32=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-14 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-674046554 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669891871 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] girishvasmatkar merged pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-14 Thread GitBox
girishvasmatkar merged pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-14 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-674058021 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-14 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-674046554 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-framework] ieugen commented on pull request #250: OFBIZ-12118 Fixes issue with starting ofbiz via jar

2021-01-11 Thread GitBox
ieugen commented on pull request #250: URL: https://github.com/apache/ofbiz-framework/pull/250#issuecomment-758067795 Thanks @danwatford . How can we merge this PR in trunk? This is an automated message from the

<    6   7   8   9   10   11   12   13   14   15   >