JacquesLeRoux merged pull request #431:
URL: https://github.com/apache/ofbiz-framework/pull/431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
sonarcloud[bot] commented on pull request #432:
URL: https://github.com/apache/ofbiz-framework/pull/432#issuecomment-1007320716
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
adityasharma7 commented on pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#issuecomment-1007179064
Thanks @bjugl for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
PierreSmits commented on pull request #410:
URL: https://github.com/apache/ofbiz-framework/pull/410#issuecomment-1007171525
Hi Jacques,
It is true that the underlying entity used to display the line items has
more elements than is being displayed with the change. This is controlled b
sonarcloud[bot] commented on pull request #431:
URL: https://github.com/apache/ofbiz-framework/pull/431#issuecomment-1007227191
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
sonarcloud[bot] commented on pull request #434:
URL: https://github.com/apache/ofbiz-framework/pull/434#issuecomment-1007938669
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #432:
URL: https://github.com/apache/ofbiz-framework/pull/432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007187623
You talk about the labels added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
JacquesLeRoux commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1007206586
Actually I was unable of locally patching all and was a bit tired. Now I see
things better and I have only one question: why removing
PierreSmits closed pull request #179:
URL: https://github.com/apache/ofbiz-framework/pull/179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
sonarcloud[bot] commented on pull request #433:
URL: https://github.com/apache/ofbiz-framework/pull/433#issuecomment-1007917953
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #434:
URL: https://github.com/apache/ofbiz-framework/pull/434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #435:
URL: https://github.com/apache/ofbiz-framework/pull/435
Screen EditProductStoreGroupAndAssoc does not connect with grid forms.
Modified: StoreScreens.xml
moved from form references to grid references
removed screen duplicate
additio
sonarcloud[bot] commented on pull request #435:
URL: https://github.com/apache/ofbiz-framework/pull/435#issuecomment-1008262001
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #435:
URL: https://github.com/apache/ofbiz-framework/pull/435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #433:
URL: https://github.com/apache/ofbiz-framework/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #436:
URL: https://github.com/apache/ofbiz-framework/pull/436
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #436:
URL: https://github.com/apache/ofbiz-framework/pull/436#issuecomment-1008608810
Kudos, SonarCloud Quality Gate passed! 
Modified: CommonScreens.xml
moved Payment Group action menu and label to a better location. Additional
cleanup.
--
This is an
sonarcloud[bot] commented on pull request #438:
URL: https://github.com/apache/ofbiz-framework/pull/438#issuecomment-1008866906
Kudos, SonarCloud Quality Gate passed!  reserv
sonarcloud[bot] commented on pull request #441:
URL: https://github.com/apache/ofbiz-framework/pull/441#issuecomment-1009787216
Kudos, SonarCloud Quality Gate passed!  r
sonarcloud[bot] commented on pull request #442:
URL: https://github.com/apache/ofbiz-framework/pull/442#issuecomment-1011003948
Kudos, SonarCloud Quality Gate passed!  reserved
sonarcloud[bot] commented on pull request #444:
URL: https://github.com/apache/ofbiz-framework/pull/444#issuecomment-1011884803
Kudos, SonarCloud Quality Gate passed!  reserved f
sonarcloud[bot] commented on pull request #445:
URL: https://github.com/apache/ofbiz-framework/pull/445#issuecomment-1011948806
Kudos, SonarCloud Quality Gate passed!  rese
sonarcloud[bot] commented on pull request #446:
URL: https://github.com/apache/ofbiz-framework/pull/446#issuecomment-1011992943
Kudos, SonarCloud Quality Gate passed!  re
sonarcloud[bot] commented on pull request #448:
URL: https://github.com/apache/ofbiz-framework/pull/448#issuecomment-1012175495
Kudos, SonarCloud Quality Gate passed!  Failing after
2m — build is due to a hiccup in the action.
--
This is an automated message from th
JacquesLeRoux merged pull request #449:
URL: https://github.com/apache/ofbiz-framework/pull/449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #451:
URL: https://github.com/apache/ofbiz-framework/pull/451
Currently, as can be seen in
https://localhost:8443/ordermgr/control/ViewQuote?quoteId=CQ0001, action
triggers (for users with CREATE/UPDATE permissions are located within screens
instead o
sonarcloud[bot] commented on pull request #451:
URL: https://github.com/apache/ofbiz-framework/pull/451#issuecomment-1013673075
Kudos, SonarCloud Quality Gate passed!  in Manufacturing, the title of the shown
object is below the menu items for that
sonarcloud[bot] commented on pull request #452:
URL: https://github.com/apache/ofbiz-framework/pull/452#issuecomment-1013683653
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #452:
URL: https://github.com/apache/ofbiz-framework/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux commented on pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423#issuecomment-1013872744
Hi Pierre,
I'll push from here because GH merges it easily. I'll then make some
modification after pulling locally
--
This is an automated message from the
JacquesLeRoux merged pull request #423:
URL: https://github.com/apache/ofbiz-framework/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #436:
URL: https://github.com/apache/ofbiz-framework/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
sonarcloud[bot] removed a comment on pull request #437:
URL: https://github.com/apache/ofbiz-framework/pull/437#issuecomment-1008782355
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
sonarcloud[bot] commented on pull request #437:
URL: https://github.com/apache/ofbiz-framework/pull/437#issuecomment-1013919180
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #437:
URL: https://github.com/apache/ofbiz-framework/pull/437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #453:
URL: https://github.com/apache/ofbiz-framework/pull/453
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #453:
URL: https://github.com/apache/ofbiz-framework/pull/453#issuecomment-1014283615
Kudos, SonarCloud Quality Gate passed! 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
sonarcloud[bot] commented on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1014629089
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux commented on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1014740778
Hi Benjamin,
Did you notice the WebAppCacheTest.java issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
sonarcloud[bot] commented on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1015144862
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
sonarcloud[bot] removed a comment on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1014629089
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadg
PierreSmits opened a new pull request #455:
URL: https://github.com/apache/ofbiz-framework/pull/455
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #455:
URL: https://github.com/apache/ofbiz-framework/pull/455#issuecomment-1015179642
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #438:
URL: https://github.com/apache/ofbiz-framework/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #439:
URL: https://github.com/apache/ofbiz-framework/pull/439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #456:
URL: https://github.com/apache/ofbiz-framework/pull/456
In general, a TabBar menu is intended to give
users access to overviews related to the .
And a SubTabBar menu is intended to give
users access to actions to be performed on the ,
l
sonarcloud[bot] commented on pull request #456:
URL: https://github.com/apache/ofbiz-framework/pull/456#issuecomment-1015370227
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
bjugl edited a comment on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1015406974
> Did you notice the WebAppCacheTest.java issue?
I did. I changed the tests accordingly.
--
This is an automated message from the Apache Git Service.
To
bjugl commented on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1015406974
> Did you notice the WebAppCacheTest.java issue?
I did. I changed the tests accordingly.
--
This is an automated message from the Apache Git Service.
To respond to
PierreSmits opened a new pull request #457:
URL: https://github.com/apache/ofbiz-framework/pull/457
Currently, a user with only 'VIEW' permissions, as
demonstrated in trunk demo with userId = auditor,
accessing the Payment Group Payments screen, sees
editable fields and/or triggers
sonarcloud[bot] commented on pull request #457:
URL: https://github.com/apache/ofbiz-framework/pull/457#issuecomment-1015477314
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
JacquesLeRoux merged pull request #456:
URL: https://github.com/apache/ofbiz-framework/pull/456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux commented on pull request #454:
URL: https://github.com/apache/ofbiz-framework/pull/454#issuecomment-1015488762
Yes saw that, thanks Benjamin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
PierreSmits opened a new pull request #458:
URL: https://github.com/apache/ofbiz-framework/pull/458
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #458:
URL: https://github.com/apache/ofbiz-framework/pull/458#issuecomment-1016396077
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
PierreSmits opened a new pull request #459:
URL: https://github.com/apache/ofbiz-framework/pull/459
According to the definition in widget-form.xsd the
use of a combination of a form with type="list" is
deprecated in favour of a grid.
Refactor various list forms into grids.
Re
sonarcloud[bot] commented on pull request #459:
URL: https://github.com/apache/ofbiz-framework/pull/459#issuecomment-1016428641
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
PierreSmits opened a new pull request #460:
URL: https://github.com/apache/ofbiz-framework/pull/460
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #460:
URL: https://github.com/apache/ofbiz-framework/pull/460#issuecomment-1016460679
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed
PierreSmits opened a new pull request #461:
URL: https://github.com/apache/ofbiz-framework/pull/461
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #461:
URL: https://github.com/apache/ofbiz-framework/pull/461#issuecomment-1017193784
Kudos, SonarCloud Quality Gate passed! 