[GitHub] incubator-rya issue #288: RYA-485 Fixed issues with maven-shade-plugin.

2018-04-13 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/288 asfbot build ---

[GitHub] incubator-rya issue #288: RYA-485 Fixed issues with maven-shade-plugin.

2018-04-12 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/288 asfbot build ---

[GitHub] incubator-rya pull request #288: RYA-485 Fixed issues with maven-shade-plugi...

2018-04-12 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/288 RYA-485 Fixed issues with maven-shade-plugin. ## Description - Fixed issues with shade jars being built. - Removed the mr profile for the rya.mapreduce shade jar. Didn't make

[GitHub] incubator-rya issue #282: RYA-443 Fixed Rya Streams Query Manager RPM versio...

2018-03-16 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/282 Interesting that you included the architecture type as part of the package name. Can you confirm the following command also works? ``` sudo yum install -y rya.streams.query-manager

[GitHub] incubator-rya pull request #281: POM version fix

2018-03-12 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/281 POM version fix ## Description pom versioning bugfix ### Tests N/A People To Reivew @pujav65 @meiercaleb @DLotts You can merge

[GitHub] incubator-rya issue #274: Added giraph profile to resolve an incompatible li...

2018-02-16 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/274 Good idea. I just pinged their dev list. ---

[GitHub] incubator-rya pull request #274: Added giraph profile to resolve an incompat...

2018-02-14 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/274 Added giraph profile to resolve an incompatible license issue. ## Description Added a profile to make rya.giraph an optional module in the maven build. ### Tests N

[GitHub] incubator-rya issue #270: Update readme.md

2018-02-02 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/270 asfbot build ---

[GitHub] incubator-rya pull request #252: RYA-410 Add geo profile dependency manageme...

2018-01-04 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/252#discussion_r159702629 --- Diff: pom.xml --- @@ -144,7 +141,83 @@ under the License. true

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159475679 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/StatefulMongoDBRdfConfiguration.java --- @@ -0,0 +1,102 @@ +/** + * Licensed

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159477148 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java --- @@ -92,184 +93,162 @@ public MongoDBRdfConfiguration

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159477077 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/MongoDBRdfConfiguration.java --- @@ -92,184 +93,162 @@ public MongoDBRdfConfiguration

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159484331 --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/entity/update/mongo/MongoEntityIndexer.java --- @@ -39,44 +35,16

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159484266 --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/entity/update/mongo/MongoEntityIndexer.java --- @@ -39,44 +35,16

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159478708 --- Diff: sail/src/main/java/org/apache/rya/rdftriplestore/RdfCloudTripleStore.java --- @@ -2,12 +2,6 @@ import static

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159479656 --- Diff: extras/rya.geoindexing/geo.mongo/src/test/java/org/apache/rya/indexing/geotemporal/GeoTemporalProviderTest.java --- @@ -36,7 +36,7

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159477674 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/AbstractMongoDBRdfConfigurationBuilder.java --- @@ -120,7 +120,7 @@ public B

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159466471 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/StatefulMongoDBRdfConfiguration.java --- @@ -0,0 +1,102 @@ +/** + * Licensed

[GitHub] incubator-rya pull request #256: RYA-414

2018-01-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/256#discussion_r159466978 --- Diff: dao/mongodb.rya/src/main/java/org/apache/rya/mongodb/EmbeddedMongoFactory.java --- @@ -79,19 +79,27 @@ private int

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-02 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148546455 --- Diff: extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148272083 --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/pcj/matching/AccumuloIndexSetProvider.java --- @@ -155,9 +152,9 @@ public int size

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148271883 --- Diff: extras/periodic.notification/service/src/main/java/org/apache/rya/periodic/notification/application

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148271410 --- Diff: extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/integration/KafkaExportIT.java --- @@ -92,8 +89,8

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148271436 --- Diff: extras/rya.benchmark/src/main/config/common.options --- @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-11-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/248#discussion_r148271382 --- Diff: extras/rya.pcj.fluo/pcj.fluo.integration/src/test/java/org/apache/rya/indexing/pcj/fluo/integration/KafkaExportIT.java --- @@ -249,10

[GitHub] incubator-rya pull request #248: RYA-356 Added a Twill App for running the p...

2017-10-26 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/248 RYA-356 Added a Twill App for running the periodic service ## Description >What Changed? [Brief Description of what changed] ### Tests >Co

[GitHub] incubator-rya pull request #244: RYA-358 Added checkstyle policy to build an...

2017-10-13 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/244 RYA-358 Added checkstyle policy to build and fixed problems. - Disabled snapshot repos since there are no snapshot dependencies. ## Description A number of classes use

[GitHub] incubator-rya pull request #243: RYA-401 Added findbugs policy to build, fix...

2017-10-12 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/243 RYA-401 Added findbugs policy to build, fixed all default charset bugs. ## Description - Added a findbugs policy for default encoding bugs - fixed all default encoding bugs

[GitHub] incubator-rya pull request #242: RYA-402 Create Kafka reusable test code pro...

2017-10-11 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/242#discussion_r144007026 --- Diff: test/kafka/pom.xml --- @@ -0,0 +1,82 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLS

[GitHub] incubator-rya issue #241: RYA-333 Added "-P coverage" to generate code cover...

2017-10-10 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/241 asfbot build ---

[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...

2017-10-10 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/241#discussion_r143771929 --- Diff: pom.xml --- @@ -151,6 +151,54 @@ under the License. false

[GitHub] incubator-rya pull request #241: RYA-333 Added "-P coverage" to generate cod...

2017-10-10 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/241 RYA-333 Added "-P coverage" to generate code coverage reports. ## Description Added -P coverage for generating a code-coverage report removed unnecessary versio

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-10 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143750533 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java --- @@ -0,0 +1,130 @@ +/* + * Licensed

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-10 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143742559 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/OWLTime.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-10 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143742007 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/OWLTime.java --- @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

[GitHub] incubator-rya issue #239: Rya 398

2017-10-10 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 Oh, and this built for me fine. ---

[GitHub] incubator-rya issue #233: RYA-387 Restored Mongo IT's that were not being ex...

2017-10-06 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/233 merged in a2ebefe ---

[GitHub] incubator-rya pull request #233: RYA-387 Restored Mongo IT's that were not b...

2017-10-06 Thread jdasch
Github user jdasch closed the pull request at: https://github.com/apache/incubator-rya/pull/233 ---

[GitHub] incubator-rya issue #239: Rya 398

2017-10-06 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 Caleb, RYA-353 handles the Test to IT refactor. ---

[GitHub] incubator-rya issue #239: Rya 398

2017-10-06 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/239 RYA-397 was the rename of mockmongo stuff, RYA-398 was fixing the `MongoEntityIndexTest` ---

[GitHub] incubator-rya issue #238: RYA-397 Renamed MockMongoSingleton/Factory to Embe...

2017-10-06 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/238 Oh, and this builds for me. yay. ---

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-05 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143051442 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-05 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143049674 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-05 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143047847 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-05 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143046845 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/functions/DateTimeWithinPeriod.java --- @@ -0,0 +1,121 @@ +/* + * Licensed

[GitHub] incubator-rya pull request #237: RYA-392-Datetime-Within

2017-10-05 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/237#discussion_r143046217 --- Diff: common/rya.api/pom.xml --- @@ -95,5 +95,20 @@ under the License. test

[GitHub] incubator-rya issue #238: RYA-397 Renamed MockMongoSingleton/Factory to Embe...

2017-10-05 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/238 Yay! I think you missed a couple classes though. `MongoITBase` and `MongoIndexerDeleteIT` have references. ---

[GitHub] incubator-rya pull request #233: RYA-387 Restored Mongo IT's that were not b...

2017-10-03 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/233 RYA-387 Restored Mongo IT's that were not being exercised. ## Description Moved `MongoGeoIndexerFilterIT` and `MongoIndexerDeleteIT` to the `rya.geo.mongo` project from

[GitHub] incubator-rya pull request #227: RYA-372 Excluded org.json:json for incompat...

2017-09-18 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/227#discussion_r139505373 --- Diff: extras/rya.giraph/pom.xml --- @@ -35,6 +35,13 @@ under the License. org.apache.giraph giraph-core

[GitHub] incubator-rya issue #229: RYA-373 Make Benchmarks optional by profile

2017-09-18 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/229 asfbot build ---

[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...

2017-09-18 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---

[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...

2017-09-18 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---

[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...

2017-09-18 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---

[GitHub] incubator-rya issue #227: RYA-372 Excluded org.json:json for incompatible li...

2017-09-18 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/227 asfbot build ---

[GitHub] incubator-rya pull request #226: RYA-342 RYA-321 Added documentation on the ...

2017-09-13 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/226 RYA-342 RYA-321 Added documentation on the shell and PCJ Updater ## Description Added documentation on the shell and PCJ Updater ### Tests N/A ### Links

[GitHub] incubator-rya issue #225: RYA-370 Improvements from review of 3.2.11-RC2

2017-09-13 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/225 asfbot build ---

[GitHub] incubator-rya pull request #225: RYA-370 Improvements from review of 3.2.11-...

2017-09-13 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/225 RYA-370 Improvements from review of 3.2.11-RC2 ## Description - Fixed a regression on the geoindexing profile in extras/pom.xml - Added a 'rya.' prefix to the new geo

[GitHub] incubator-rya issue #224: RYA-361 Remove JCalendar library from merge/copy/e...

2017-09-08 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/224 asfbot build ---

[GitHub] incubator-rya pull request #224: RYA-361 Remove JCalendar library from merge...

2017-09-08 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/224#discussion_r137833944 --- Diff: extras/rya.export/export.client/src/main/java/org/apache/rya/export/client/conf/MergeConfigurationCLI.java --- @@ -149,7 +145,12 @@ public

[GitHub] incubator-rya pull request #223: RYA-362 Improved UX for case where create-p...

2017-09-07 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/223 RYA-362 Improved UX for case where create-pcj is called without args. ## Description Improved UX for case where create-pcj is called without args. Also updated the order

[GitHub] incubator-rya pull request #222: [WIP] RYA-360 Fixed licensing issues.

2017-09-06 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/222 [WIP] RYA-360 Fixed licensing issues. ## Description Corrected Copyright on the NOTICE file. Fixed a license header. Renamed some occurrences of Rya to Apache Rya

[GitHub] incubator-rya issue #221: RYA-355 Refactored the periodic notification servi...

2017-09-05 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/221 asfbot build ---

[GitHub] incubator-rya pull request #221: RYA-355 Refactored the periodic notificatio...

2017-09-04 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/221 RYA-355 Refactored the periodic notification service structure. ## Description New artifactIds align better with code packaging, semantics. Light pom cleaning. Eliminates

[GitHub] incubator-rya pull request #220: Rya 319

2017-09-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136645046 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/client/CreatePeriodicPCJ.java --- @@ -0,0 +1,39 @@ +/** + * Licensed to the Apache

[GitHub] incubator-rya pull request #220: Rya 319

2017-09-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136571851 --- Diff: extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloListIncrementalQueries.java --- @@ -0,0 +1,97

[GitHub] incubator-rya pull request #220: Rya 319

2017-09-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136571283 --- Diff: extras/indexing/src/main/java/org/apache/rya/api/client/accumulo/AccumuloDeletePeriodicPCJ.java --- @@ -0,0 +1,131

[GitHub] incubator-rya pull request #220: Rya 319

2017-09-01 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136567933 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/client/CreatePCJ.java --- @@ -44,7 +44,7 @@ * Application

[GitHub] incubator-rya pull request #220: Rya 319

2017-08-31 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/220#discussion_r136359005 --- Diff: extras/rya.periodic.service/periodic.service.api/pom.xml --- @@ -0,0 +1,51 @@ +http://maven.apache.org/POM/4.0.0; xmlns:xsi="

[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...

2017-08-29 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/182#discussion_r135881634 --- Diff: pom.xml --- @@ -137,6 +137,7 @@ under the License. 1.0-1 3.0.4 0.10.0.1 +4.9 --- End

[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...

2017-08-29 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/182#discussion_r135877423 --- Diff: extras/rya.geoindexing/geo.common/src/main/java/org/apache/rya/indexing/GeoIndexerType.java --- @@ -31,31 +28,49

[GitHub] incubator-rya pull request #182: RYA-324, RYA-272 Geo refactoring and exampl...

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/182#discussion_r135169942 --- Diff: extras/rya.geoindexing/pom.xml --- @@ -62,6 +79,11 @@ org.apache.rya rya.prospector

[GitHub] incubator-rya issue #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/216 Moved my concerns with this PR to RYA-353 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/216#discussion_r135040081 --- Diff: dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAOIT.java --- @@ -99,16 +102,16 @@ public void testDelete() throws

[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/216#discussion_r135036771 --- Diff: dao/mongodb.rya/src/test/java/org/apache/rya/mongodb/MongoDBRyaDAOIT.java --- @@ -41,34 +40,38 @@ import org.junit.Before; import

[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/216#discussion_r135038577 --- Diff: extras/indexing/src/test/java/org/apache/rya/indexing/entity/query/EntityQueryNodeTest.java --- @@ -152,7 +153,7 @@ public void

[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/216#discussion_r135039213 --- Diff: extras/indexing/src/test/java/org/apache/rya/indexing/mongo/MongoFreeTextIndexerTest.java --- @@ -43,27 +44,36 @@ import

[GitHub] incubator-rya pull request #216: Rya-289 Mongo Singleton tests

2017-08-24 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/216#discussion_r135038884 --- Diff: extras/indexing/src/test/java/org/apache/rya/indexing/entity/query/EntityQueryNodeTest.java --- @@ -53,7 +54,7 @@ /** * Unit

[GitHub] incubator-rya issue #212: RYA-332 rename integration tests

2017-08-23 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/212 Ditto. Looks good. Just need to fix this test: org.apache.rya.camel.cbsail.CbSailIT.testCbSail --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] incubator-rya pull request #214: [WIP] RYA-350 Added EmbeddedKafkaSingleton ...

2017-08-22 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/214 [WIP] RYA-350 Added EmbeddedKafkaSingleton and stabilized an IT. ## Description >What Changed? [Brief Description of what changed] ### Tests >Co

[GitHub] incubator-rya pull request #205: RYA-343 Fixed rya.api connection issue for ...

2017-08-16 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/205#discussion_r133458983 --- Diff: common/rya.api/src/main/java/org/apache/rya/api/instance/RyaDetailsToConfiguration.java --- @@ -53,14 +53,16 @@ public static void

[GitHub] incubator-rya issue #208: fix-mongo-tests

2017-08-15 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #208: fix-mongo-tests

2017-08-15 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #208: fix-mongo-tests

2017-08-15 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #208: fix-mongo-tests

2017-08-15 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/208 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #207: RYA-340 Added dependency filtering to rya.pcj.fluo...

2017-08-15 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/207 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya pull request #208: fix-mongo-tests

2017-08-15 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/208 fix-mongo-tests ## Description MongoGeoTemporalIndexIT and MongoGeoIndexerFilterIT had 5 tests failing between them. Updated to extend MongoITBase. Added unique mongoDBs

[GitHub] incubator-rya pull request #207: RYA-340 Added dependency filtering to rya.p...

2017-08-15 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/207 RYA-340 Added dependency filtering to rya.pcj.fluo.app for deployments. ## Description - Added dependency filtering to rya.pcj.fluo.app for deployments. - Also improved scoping

[GitHub] incubator-rya pull request #205: RYA-343 Fixed rya.api connection issue for ...

2017-08-14 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/205 RYA-343 Fixed rya.api connection issue for PCJ-enabled rya table. ## Description Added a couple configs that weren't getting set and caused a regression. Purpose of this PR

[GitHub] incubator-rya issue #202: [WIP] Rya 331

2017-08-09 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #202: [WIP] Rya 331

2017-08-09 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya issue #202: [WIP] Rya 331

2017-08-09 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/202 asfbot builld --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya pull request #202: [WIP] Rya 331

2017-08-09 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/202 [WIP] Rya 331 ## Description >What Changed? Don't bother reviewing this right now. This PR is just a mechanism for exercising the build servers. ### Tests >Co

[GitHub] incubator-rya pull request #195: Temp it fix

2017-08-03 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/195 Temp it fix ## Description - Updated maven-failsafe-plugin to run IT's in separate forks until RYA-331 is finished. - Removed a duplicate dependency in the rya.pcj.fluo.test.base

[GitHub] incubator-rya pull request #193: Refactored the rya.periodic.notification.se...

2017-08-03 Thread jdasch
Github user jdasch closed the pull request at: https://github.com/apache/incubator-rya/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.

2017-08-03 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 Punting until RYA-283 gets merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.

2017-08-03 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 Mostly my OCD. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya pull request #194: RYA-325 Renamed rya.console to rya.shell.

2017-08-03 Thread jdasch
Github user jdasch commented on a diff in the pull request: https://github.com/apache/incubator-rya/pull/194#discussion_r131241480 --- Diff: extras/pom.xml --- @@ -34,7 +34,7 @@ under the License. rya.prospector rya.manual rya.periodic.service

[GitHub] incubator-rya issue #193: Refactored the rya.periodic.notification.service.

2017-08-03 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/193 asfbot build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-rya pull request #193: Refactored the rya.periodic.notification.se...

2017-08-03 Thread jdasch
GitHub user jdasch opened a pull request: https://github.com/apache/incubator-rya/pull/193 Refactored the rya.periodic.notification.service. ## Description >What Changed? - Light pom cleaning (removed overrides, renaming, wordsmithing) - Set maven-failsave-plu

[GitHub] incubator-rya issue #182: RYA-324, RYA-272 Geo refactoring and examples

2017-08-03 Thread jdasch
Github user jdasch commented on the issue: https://github.com/apache/incubator-rya/pull/182 Nit on artifact names. Please make them consistent with other artifacts: ``` [INFO] Reactor Build Order: [INFO] [INFO] Apache Rya Project [INFO] Apache Rya Common

  1   2   >