[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-08-01 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-517557000 I thinks you can study groovy script first and try to use the script to calculate the routing result. ---

[GitHub] [incubator-shardingsphere] jingshanglu opened a new pull request #2799: add mysql grammar support for srs and trigger

2019-08-01 Thread GitBox
jingshanglu opened a new pull request #2799: add mysql grammar support for srs and trigger URL: https://github.com/apache/incubator-shardingsphere/pull/2799 Changes proposed in this pull request: - add mysql grammar support for srs and trigger - revision keyword.g4 -

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
terrymanu commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517524576 Got it. Thank you very much for the pull request, and sorry about for polluted for other projects. -

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
terrymanu merged pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-shardingsphere] lalicw commented on issue #2722: Make SQL parse module as an open public API

2019-08-01 Thread GitBox
lalicw commented on issue #2722: Make SQL parse module as an open public API URL: https://github.com/apache/incubator-shardingsphere/issues/2722#issuecomment-517519503 This is really an usable and impressive optimization that can help end users a lot,thank you for your efforts ---

[GitHub] [incubator-shardingsphere] hboutemy commented on a change in pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
hboutemy commented on a change in pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#discussion_r309902225 ## File path: .mvn/jvm.config ## @@ -0,0 +1 @@ +-Xmx1024m -XX:MaxPermSize=256m Revi

[GitHub] [incubator-shardingsphere] hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node home directory... and yes, this

[GitHub] [incubator-shardingsphere] hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
hboutemy edited a comment on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node home directory... and yes, this

[GitHub] [incubator-shardingsphere] hboutemy commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
hboutemy commented on issue #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798#issuecomment-517459580 notice: what is polluted first is `.mavenrc` file that is added to Jenkins node filesystem... and yes, this script poll

[GitHub] [incubator-shardingsphere] rfscholte opened a new pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ...

2019-08-01 Thread GitBox
rfscholte opened a new pull request #2798: [INFRA-18812] Switch to .mvn/jvm.config ... URL: https://github.com/apache/incubator-shardingsphere/pull/2798 ... so MAVEN_OPTS won't get polluted. Recently while running integration tests of Apache Maven we noticed our builds becoming more

[GitHub] [incubator-shardingsphere] coveralls commented on issue #2797: #2777, change select_distinct test case from H2 to MySQL

2019-08-01 Thread GitBox
coveralls commented on issue #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797#issuecomment-517244564 ## Pull Request Test Coverage Report for [Build 9045](https://coveralls.io/builds/24924570) * **0**

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2797: #2777, change select_distinct test case from H2 to MySQL

2019-08-01 Thread GitBox
terrymanu merged pull request #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #2797: #2777, change select_distinct test case from H2 to MySQL

2019-08-01 Thread GitBox
tuohai666 opened a new pull request #2797: #2777, change select_distinct test case from H2 to MySQL URL: https://github.com/apache/incubator-shardingsphere/pull/2797 #2777 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2746: add Java Microbenchmark Harness to our project

2019-08-01 Thread GitBox
terrymanu commented on issue #2746: add Java Microbenchmark Harness to our project URL: https://github.com/apache/incubator-shardingsphere/issues/2746#issuecomment-517222024 @CalvinKirs Just as @nancyzrh said, this PR only add a maven dependency for jmh, but does not add any test cases ye

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2791: Broadcast Tables Round Robin (Load Balance)

2019-08-01 Thread GitBox
terrymanu commented on issue #2791: Broadcast Tables Round Robin (Load Balance) URL: https://github.com/apache/incubator-shardingsphere/issues/2791#issuecomment-517221184 Hi, the title should be a question, or a statement to describe your proposal. What's is your proposal for this issue?

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2795: How to integrate apollo configuration

2019-08-01 Thread GitBox
terrymanu closed issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2795: How to integrate apollo configuration

2019-08-01 Thread GitBox
terrymanu commented on issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795#issuecomment-517220042 duplicate with #2530 This is an automated message from the A

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2796: select.....for update应该路由到master节点

2019-08-01 Thread GitBox
terrymanu commented on issue #2796: select.for update应该路由到master节点 URL: https://github.com/apache/incubator-shardingsphere/issues/2796#issuecomment-517219668 **For English only**, other languages will not accept. This is

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2796: select.....for update应该路由到master节点

2019-08-01 Thread GitBox
terrymanu closed issue #2796: select.for update应该路由到master节点 URL: https://github.com/apache/incubator-shardingsphere/issues/2796 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] VitZhou opened a new issue #2796: select.....for update应该路由到master节点

2019-08-01 Thread GitBox
VitZhou opened a new issue #2796: select.for update应该路由到master节点 URL: https://github.com/apache/incubator-shardingsphere/issues/2796 ## Feature Request select.for update应该路由到master节点,在一般的业务场景下,使用for update是为了锁行,然后进行数据的修改.比如: @Transactional public void updateById(String i

[GitHub] [incubator-shardingsphere] jeffmxzhao opened a new issue #2795: How to integrate apollo configuration

2019-08-01 Thread GitBox
jeffmxzhao opened a new issue #2795: How to integrate apollo configuration URL: https://github.com/apache/incubator-shardingsphere/issues/2795 I am using ctrip apollo in my project, Is there any API can be use to integate apollo configuration? --