[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#discussion_r322064912 ## File path:

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#discussion_r322063673 ## File path:

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#discussion_r322063110 ## File path:

[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #242: Function modify

2019-09-08 Thread GitBox
haetao opened a new pull request #242: Function modify URL: https://github.com/apache/incubator-shardingsphere-doc/pull/242 Change Constructor "TableRuleConfiguration();" to "TableRuleConfiguration("t_order","ds${0..1}.t_order${0..1}");" and remove member function "setLogicTable()"

[GitHub] [incubator-shardingsphere-doc] haetao opened a new pull request #241: Function modify

2019-09-08 Thread GitBox
haetao opened a new pull request #241: Function modify URL: https://github.com/apache/incubator-shardingsphere-doc/pull/241 Change Constructor "TableRuleConfiguration();" to "TableRuleConfiguration("t_order","ds${0..1}.t_order${0..1}");" and remove member function "setLogicTable()"

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#discussion_r322061612 ## File path:

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2992: Data does not decrypt

2019-09-08 Thread GitBox
betterjava commented on issue #2992: Data does not decrypt URL: https://github.com/apache/incubator-shardingsphere/issues/2992#issuecomment-529296235 @shuohao my pull has been merged ,you can close the issue.:blush: This is

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529296075 > > it seems like some test failed in sharding-ui-distribution,how can I let the checks run again? > > I'll contact the ui

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on a change in pull request #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#discussion_r322061243 ## File path:

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2972: when using sharding master-slave-rules, the encryptRule is not worked for result, but is wored for param

2019-09-08 Thread GitBox
tristaZero closed issue #2972: when using sharding master-slave-rules,the encryptRule is not worked for result,but is wored for param URL: https://github.com/apache/incubator-shardingsphere/issues/2972 This is an automated

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2983: fix bug 2972 EncryptRule can not work somtimes when use getResultSet()

2019-09-08 Thread GitBox
tristaZero commented on issue #2983: fix bug 2972 EncryptRule can not work somtimes when use getResultSet() URL: https://github.com/apache/incubator-shardingsphere/pull/2983#issuecomment-529290392 Thanks :) This is an

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #2983: fix bug 2972 EncryptRule can not work somtimes when use getResultSet()

2019-09-08 Thread GitBox
tristaZero merged pull request #2983: fix bug 2972 EncryptRule can not work somtimes when use getResultSet() URL: https://github.com/apache/incubator-shardingsphere/pull/2983 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529287733 > it seems like some test failed in sharding-ui-distribution,how can I let the checks run again? I'll contact the ui

[GitHub] [incubator-shardingsphere] betterjava commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529286861 it seems like some test failed in sharding-ui-distribution,how can I let the checks run again?

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-08 Thread GitBox
tristaZero closed issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #3000: fix #2923 add replayMethodsInvocation for EncryptPreparedStatement

2019-09-08 Thread GitBox
tristaZero merged pull request #3000: fix #2923 add replayMethodsInvocation for EncryptPreparedStatement URL: https://github.com/apache/incubator-shardingsphere/pull/3000 This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] betterjava removed a comment on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava removed a comment on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529282819 it is done, thanks for your reminder. This is an automated

[GitHub] [incubator-shardingsphere] betterjava commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529282819 it is done, thanks for your reminder. This is an automated message

[GitHub] [incubator-shardingsphere] betterjava commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529279665 ok,I will check. This is an automated message from the Apache Git

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529278953 I found your editor setting is different with us, please check it at first

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-08 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-529278083 Sounds good. I'd like to see your pr to judge whether there's performance issue.

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3002: support hint in sharding-proxy

2019-09-08 Thread GitBox
cherrylzhao commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529277760 good job! I'd like to review this PR today. This is an automated

[GitHub] [incubator-shardingsphere] tuohai666 opened a new pull request #3004: remove gpg plugin

2019-09-08 Thread GitBox
tuohai666 opened a new pull request #3004: remove gpg plugin URL: https://github.com/apache/incubator-shardingsphere/pull/3004 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] skyoxZ opened a new issue #3003: Detail implementation of AES Data Masking is not documented.

2019-09-08 Thread GitBox
skyoxZ opened a new issue #3003: Detail implementation of AES Data Masking is not documented. URL: https://github.com/apache/incubator-shardingsphere/issues/3003 After some research I find the AES masking algorithm (MySQL): `UPDATE _table_ SET _cipherColumn_ =

[GitHub] [incubator-shardingsphere] betterjava commented on issue #2993: fix bug 2092 check update shard key

2019-09-08 Thread GitBox
betterjava commented on issue #2993: fix bug 2092 check update shard key URL: https://github.com/apache/incubator-shardingsphere/pull/2993#issuecomment-529251090 Thanks for your review. This is an automated message from the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2994: 3.1.0 two datasources may memory leak

2019-09-08 Thread GitBox
terrymanu commented on issue #2994: 3.1.0 two datasources may memory leak URL: https://github.com/apache/incubator-shardingsphere/issues/2994#issuecomment-529240614 Can you explain the reason to close this issue? This is an

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2926: mysql page limit Long parameter type error

2019-09-08 Thread GitBox
terrymanu closed issue #2926: mysql page limit Long parameter type error URL: https://github.com/apache/incubator-shardingsphere/issues/2926 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2996: Feature#2926 replace int with long for limit parameter.

2019-09-08 Thread GitBox
terrymanu commented on issue #2996: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2996#issuecomment-529240239 Wonderful pull request This is an

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2996: Feature#2926 replace int with long for limit parameter.

2019-09-08 Thread GitBox
terrymanu merged pull request #2996: Feature#2926 replace int with long for limit parameter. URL: https://github.com/apache/incubator-shardingsphere/pull/2996 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2993: fix bug 2092 check update shard key

2019-09-08 Thread GitBox
terrymanu commented on issue #2993: fix bug 2092 check update shard key URL: https://github.com/apache/incubator-shardingsphere/pull/2993#issuecomment-529231626 Bravo, thank you for contribution. This is an automated message

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2092: Update sharding key is allowed but not work

2019-09-08 Thread GitBox
terrymanu closed issue #2092: Update sharding key is allowed but not work URL: https://github.com/apache/incubator-shardingsphere/issues/2092 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2993: fix bug 2092 check update shard key

2019-09-08 Thread GitBox
terrymanu merged pull request #2993: fix bug 2092 check update shard key URL: https://github.com/apache/incubator-shardingsphere/pull/2993 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2990: Merge OpenShardingUI features

2019-09-08 Thread GitBox
terrymanu commented on issue #2990: Merge OpenShardingUI features URL: https://github.com/apache/incubator-shardingsphere/pull/2990#issuecomment-529230778 Wow, it is a big and important pull request. This is an automated

[GitHub] [incubator-shardingsphere] terrymanu closed issue #2986: Merge OpenShardingUI features

2019-09-08 Thread GitBox
terrymanu closed issue #2986: Merge OpenShardingUI features URL: https://github.com/apache/incubator-shardingsphere/issues/2986 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #2990: Merge OpenShardingUI features

2019-09-08 Thread GitBox
terrymanu merged pull request #2990: Merge OpenShardingUI features URL: https://github.com/apache/incubator-shardingsphere/pull/2990 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3001: 分页查询返回的是Long类型。但是代码做了Integer类型强制转化。

2019-09-08 Thread GitBox
terrymanu commented on issue #3001: 分页查询返回的是Long类型。但是代码做了Integer类型强制转化。 URL: https://github.com/apache/incubator-shardingsphere/issues/3001#issuecomment-529230210 **For English only**, other languages will not accept. This

[GitHub] [incubator-shardingsphere] terrymanu closed issue #3001: 分页查询返回的是Long类型。但是代码做了Integer类型强制转化。

2019-09-08 Thread GitBox
terrymanu closed issue #3001: 分页查询返回的是Long类型。但是代码做了Integer类型强制转化。 URL: https://github.com/apache/incubator-shardingsphere/issues/3001 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-shardingsphere] betterjava edited a comment on issue #2979: support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava edited a comment on issue #2979: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/issues/2979#issuecomment-529170037 Aggree. I am working on it. This is an automated

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3002: Support hint in sharding-proxy

2019-09-08 Thread GitBox
coveralls commented on issue #3002: Support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-529204423 ## Pull Request Test Coverage Report for [Build 313](https://coveralls.io/builds/25592452) * **79** of **90** **(87.78%)**

[GitHub] [incubator-shardingsphere] betterjava opened a new pull request #3002: Support hint in sharding-proxy

2019-09-08 Thread GitBox
betterjava opened a new pull request #3002: Support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002 Fixes #2979. Changes proposed in this pull request: - support hint in sharding-proxy,client can write sql like bellow: -

[GitHub] [incubator-shardingsphere] yjjqrqqq commented on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables

2019-09-08 Thread GitBox
yjjqrqqq commented on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables URL: https://github.com/apache/incubator-shardingsphere/issues/1930#issuecomment-529199907 finally,, i reloved like this . copy TableMetaDataInitializer.java to my

[GitHub] [incubator-shardingsphere] yjjqrqqq removed a comment on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables

2019-09-08 Thread GitBox
yjjqrqqq removed a comment on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables URL: https://github.com/apache/incubator-shardingsphere/issues/1930#issuecomment-529199506 Finally, I reloved like this. I copy TableMetaDataInitializer.java to my

[GitHub] [incubator-shardingsphere] yjjqrqqq commented on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables

2019-09-08 Thread GitBox
yjjqrqqq commented on issue #1930: Initiating datasource too slow when defaultDataSource has big amount of tables URL: https://github.com/apache/incubator-shardingsphere/issues/1930#issuecomment-529199506 Finally, I reloved like this. I copy TableMetaDataInitializer.java to my own

[GitHub] [incubator-shardingsphere] tristaZero closed pull request #2999: Replay for ShardingPreparedStatement when execute.

2019-09-08 Thread GitBox
tristaZero closed pull request #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tristaZero merged pull request #2999: Replay for ShardingPreparedStatement when execute.

2019-09-08 Thread GitBox
tristaZero merged pull request #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2999: Replay for ShardingPreparedStatement when execute.

2019-09-08 Thread GitBox
tristaZero commented on issue #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999#issuecomment-529181179 @sunbufu Not only the bugfix but also the test was added, thanks.

[GitHub] [incubator-shardingsphere] tristaZero closed issue #2981: It doesn't work when set properties for ShardingPreparedStatement.

2019-09-08 Thread GitBox
tristaZero closed issue #2981: It doesn't work when set properties for ShardingPreparedStatement. URL: https://github.com/apache/incubator-shardingsphere/issues/2981 This is an automated message from the Apache Git Service.

[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #2999: Replay for ShardingPreparedStatement when execute.

2019-09-08 Thread GitBox
sunbufu opened a new pull request #2999: Replay for ShardingPreparedStatement when execute. URL: https://github.com/apache/incubator-shardingsphere/pull/2999 Fixes https://github.com/apache/incubator-shardingsphere/issues/2981. Changes proposed in this pull request: 1. add

[GitHub] [incubator-shardingsphere] tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-08 Thread GitBox
tristaZero edited a comment on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-529180180 @xiyelife Hi, Busy though you are, yet you raize [this

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #3000: fix #2923 add replayMethodsInvocation for EncryptPreparedStatement

2019-09-08 Thread GitBox
tristaZero commented on issue #3000: fix #2923 add replayMethodsInvocation for EncryptPreparedStatement URL: https://github.com/apache/incubator-shardingsphere/pull/3000#issuecomment-529180551 Hi, i think, `executeQuery() ` and `executeBatch()` are needed to be fixed as well. Can you

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error

2019-09-08 Thread GitBox
tristaZero commented on issue #2923: when using EncryptPreparedStatement to savebatch occours error URL: https://github.com/apache/incubator-shardingsphere/issues/2923#issuecomment-529180180 @xiyelife Hi, Busy though you are, yet you raize [this

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning

2019-09-08 Thread GitBox
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-529176287 I think we should check dataNode's dataSourceName and tableName to judge dataNode is legal or not. For dataSourceName, we