[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning

2019-09-11 Thread GitBox
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-530253790 Hello, I am almost finished it, but I am blocked by `sharding-jdbc-spring-namespace`'s unit test. We know SS will load M

[GitHub] [incubator-shardingsphere] sunbufu edited a comment on issue #2601: Verify the shardingRule at the beginning

2019-09-11 Thread GitBox
sunbufu edited a comment on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-530253790 Hello, I am almost finished, but I am blocked by `sharding-jdbc-spring-namespace`'s unit test. We know SS will l

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #2601: Verify the shardingRule at the beginning

2019-09-11 Thread GitBox
tuohai666 commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-530271720 If your codes are right, you'd better modify test cases instead of modify existing codes. ---

[GitHub] [incubator-shardingsphere] Myshiner opened a new issue #3019: maven build errors

2019-09-11 Thread GitBox
Myshiner opened a new issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019 ## Question Got errors to build the project using maven followed the steps. git clone https://github.com/apache/incubator-shardingsphere.git mvn clean install -P

[GitHub] [incubator-shardingsphere] wgy8283335 opened a new pull request #3020: Add Config Center

2019-09-11 Thread GitBox
wgy8283335 opened a new pull request #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020 Fixes #2912. Changes proposed in this pull request: -add module sharding-orchestration-config-center -add module sharding-orchestration-config-center-a

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3020: Add Config Center

2019-09-11 Thread GitBox
coveralls commented on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-530290587 ## Pull Request Test Coverage Report for [Build 323](https://coveralls.io/builds/25648815) * **0** of **132** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
Keanhua commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530297023 i think you need to install the node.js environment This is an automated message

[GitHub] [incubator-shardingsphere] sunbufu opened a new pull request #3021: Feature#2601 Check RoutingResult.

2019-09-11 Thread GitBox
sunbufu opened a new pull request #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021 Fixes https://github.com/apache/incubator-shardingsphere/issues/2601. Changes proposed in this pull request: 1. add checker in ParsingSQLRout

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #2601: Verify the shardingRule at the beginning

2019-09-11 Thread GitBox
sunbufu commented on issue #2601: Verify the shardingRule at the beginning URL: https://github.com/apache/incubator-shardingsphere/issues/2601#issuecomment-530356117 I send a PR, can U take a look? We can dicuss at here. 😁 Th

[GitHub] [incubator-shardingsphere] wangh09 opened a new issue #3022: Error when using Clob type schema definitions

2019-09-11 Thread GitBox
wangh09 opened a new issue #3022: Error when using Clob type schema definitions URL: https://github.com/apache/incubator-shardingsphere/issues/3022 ## Bug Report **For English only**, other languages will not accept. Before report a bug, make sure you have: - Searched op

[GitHub] [incubator-shardingsphere] Pramy opened a new pull request #3023: fix bug 2193

2019-09-11 Thread GitBox
Pramy opened a new pull request #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023 Fixes #2193 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
coveralls commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530365060 ## Pull Request Test Coverage Report for [Build 326](https://coveralls.io/builds/25652451) * **12** of **13** **(92.31%)** changed or added re

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2949: 4.0.0-RC2 does not support Oracle 12C connection configuration #2911

2019-09-11 Thread GitBox
terrymanu commented on issue #2949: 4.0.0-RC2 does not support Oracle 12C connection configuration #2911 URL: https://github.com/apache/incubator-shardingsphere/pull/2949#issuecomment-530389400 @timchan1011 Does this pr complete? --

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3020: Add Config Center

2019-09-11 Thread GitBox
terrymanu commented on a change in pull request #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#discussion_r323253517 ## File path: sharding-orchestration/sharding-orchestration-config-center/sharding-orchestration-config-server-api/pom.xm

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3020: Add Config Center

2019-09-11 Thread GitBox
terrymanu commented on a change in pull request #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#discussion_r323253100 ## File path: sharding-orchestration/sharding-orchestration-config-center/pom.xml ## @@ -0,0 +1,38 @@ + + + +htt

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3020: Add Config Center

2019-09-11 Thread GitBox
terrymanu commented on a change in pull request #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#discussion_r323253457 ## File path: sharding-orchestration/sharding-orchestration-config-center/pom.xml ## @@ -0,0 +1,38 @@ + + + +htt

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3020: Add Config Center

2019-09-11 Thread GitBox
terrymanu commented on issue #3020: Add Config Center URL: https://github.com/apache/incubator-shardingsphere/pull/3020#issuecomment-530390792 Any idea to increase testing coverage? This is an automated message from the Apach

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2995: version 3.1.0 may route wrong and cause memory leak when tomcat start ( A sql route wrong to 1002 table )

2019-09-11 Thread GitBox
terrymanu commented on issue #2995: version 3.1.0 may route wrong and cause memory leak when tomcat start ( A sql route wrong to 1002 table ) URL: https://github.com/apache/incubator-shardingsphere/issues/2995#issuecomment-530393559 Is it in version 4.0.0-RC2 or 3.1.0? --

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache

2019-09-11 Thread GitBox
terrymanu commented on issue #2997: cpu load 100% when using sqlstatement cache URL: https://github.com/apache/incubator-shardingsphere/issues/2997#issuecomment-530393892 Can it reproduce on 4.0.0-RC2? This is an automated me

[GitHub] [incubator-shardingsphere] xriqyu opened a new issue #3024: proxy-4.0.0-RC2 process blob data error

2019-09-11 Thread GitBox
xriqyu opened a new issue #3024: proxy-4.0.0-RC2 process blob data error URL: https://github.com/apache/incubator-shardingsphere/issues/3024 writedata: byte[] oriArray = new byte[]{ 1,0,99,111,109,46,108,115,46,114,112,99,46,115,101,114,118,101,114,46,82,112,99,82,101,

[GitHub] [incubator-shardingsphere] tuohai666 closed issue #3022: Error when using Clob type schema definitions

2019-09-11 Thread GitBox
tuohai666 closed issue #3022: Error when using Clob type schema definitions URL: https://github.com/apache/incubator-shardingsphere/issues/3022 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3022: Error when using Clob type schema definitions

2019-09-11 Thread GitBox
tuohai666 commented on issue #3022: Error when using Clob type schema definitions URL: https://github.com/apache/incubator-shardingsphere/issues/3022#issuecomment-530415647 Duplicate with #2956. This is an automated message

[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3024: proxy-4.0.0-RC2 process blob data error

2019-09-11 Thread GitBox
terrymanu commented on issue #3024: proxy-4.0.0-RC2 process blob data error URL: https://github.com/apache/incubator-shardingsphere/issues/3024#issuecomment-530477947 Is it same issue with #3017? This is an automated message

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-11 Thread GitBox
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530565710 Reflect is only in AbstractSpringJUnitTest.java for unit test to reload MetaData after create table. ---

[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-11 Thread GitBox
sunbufu commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530570624 We can discuss which sql should be check. In my view, we can divide the check into two parts, dataSource check and table check. In th

[GitHub] [incubator-shardingsphere] taojintianxia commented on issue #2962: when the tables in the DB is too much, the sharding init so slow

2019-09-11 Thread GitBox
taojintianxia commented on issue #2962: when the tables in the DB is too much, the sharding init so slow URL: https://github.com/apache/incubator-shardingsphere/issues/2962#issuecomment-530606260 hi there, do you still work on this issue ? -

[GitHub] [incubator-shardingsphere] Keanhua commented on issue #3017: By Use EncryptDataSource the query with blob column occurs error

2019-09-11 Thread GitBox
Keanhua commented on issue #3017: By Use EncryptDataSource the query with blob column occurs error URL: https://github.com/apache/incubator-shardingsphere/issues/3017#issuecomment-530627058 this is my ddl sql ,with text column it occurs error ![image](https://user-images.githubusercont

[GitHub] [incubator-shardingsphere] haetao commented on issue #2966: The document is not up to date

2019-09-11 Thread GitBox
haetao commented on issue #2966: The document is not up to date URL: https://github.com/apache/incubator-shardingsphere/issues/2966#issuecomment-530628348 I have already pulled request this question, please pay attention to the latest example of the official website. h

[GitHub] [incubator-shardingsphere] xriqyu commented on issue #3024: proxy-4.0.0-RC2 process blob data error

2019-09-11 Thread GitBox
xriqyu commented on issue #3024: proxy-4.0.0-RC2 process blob data error URL: https://github.com/apache/incubator-shardingsphere/issues/3024#issuecomment-530629800 different . not has exception,only process data error . use mysql ok, use proxy error. code: byte[] oriArray = ne

[GitHub] [incubator-shardingsphere] cherrylzhao commented on issue #3002: support hint in sharding-proxy

2019-09-11 Thread GitBox
cherrylzhao commented on issue #3002: support hint in sharding-proxy URL: https://github.com/apache/incubator-shardingsphere/pull/3002#issuecomment-530634958 @betterjava how are things going on, do you need any help? This

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530637541 Hi @Myshiner , can you run 'npm install -X' and show me the full debug logs ?

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530638766 @Keanhua ,no need to install the Node environment manually. We use the frontend-maven-plugin, and it can downloads/installs Node and NPM locall

[GitHub] [incubator-shardingsphere] tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult.

2019-09-11 Thread GitBox
tuohai666 commented on issue #3021: Feature#2601 Check RoutingResult. URL: https://github.com/apache/incubator-shardingsphere/pull/3021#issuecomment-530642861 It's right to check all the DMLs. You can take a performance test for comparision. ---

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
Myshiner commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530650732 @beckhampu thx, please refer to the 'npm install -X' logs, yup it seems permission problem, but i run with root. ![image](https://user-images

[GitHub] [incubator-shardingsphere] Myshiner commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
Myshiner commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530656278 @beckhampu it's ok now, i just adjusted the directory permissions. ![image](https://user-images.githubusercontent.com/48242833/64753443-d68cd1

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530659952 @Myshiner , sorry , it's my fault ! Run 'mvn clean install -Dmaven.test.skip=true -Prelease -X ' , not 'npm install -X'. -

[GitHub] [incubator-shardingsphere] Pramy commented on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
Pramy commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530675923 @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? What do you think of creating an abstract strategy? ---

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
coveralls edited a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530365060 ## Pull Request Test Coverage Report for [Build 327](https://coveralls.io/builds/25669512) * **0** of **6** **(0.0%)** changed or added

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3023: fix bug 2193

2019-09-11 Thread GitBox
KomachiSion commented on a change in pull request #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#discussion_r323566234 ## File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/inline/InlineSh

[GitHub] [incubator-shardingsphere] KomachiSion commented on a change in pull request #3023: fix bug 2193

2019-09-11 Thread GitBox
KomachiSion commented on a change in pull request #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#discussion_r323566424 ## File path: sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/route/inline/InlineSh

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
KomachiSion commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract strategy?

[GitHub] [incubator-shardingsphere] beijing-penguin opened a new pull request #3025: Fixed generic compilation errors

2019-09-11 Thread GitBox
beijing-penguin opened a new pull request #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025 In the jdk8,Fixed generic compilation errors Fixes #ISSUSE_ID. Changes proposed in this pull request: - - - ---

[GitHub] [incubator-shardingsphere] ningyu1 opened a new issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-09-11 Thread GitBox
ningyu1 opened a new issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873 ## How to get the results of the database fragmentation algorithm in the table fragmentation algor

[GitHub] [incubator-shardingsphere] Pramy commented on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
Pramy commented on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating an abstra

[GitHub] [incubator-shardingsphere] Pramy removed a comment on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
Pramy removed a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530681723 @KomachiSion > > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > > What do you think of creating a

[GitHub] [incubator-shardingsphere] KomachiSion commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm

2019-09-11 Thread GitBox
KomachiSion commented on issue #2873: How to get the results of the database sharding algorithm in the table sharding algorithm URL: https://github.com/apache/incubator-shardingsphere/issues/2873#issuecomment-530682504 Sorry @ningyu1, is the problem your table algorithm don't know what d

[GitHub] [incubator-shardingsphere] KomachiSion edited a comment on issue #3023: fix bug 2193

2019-09-11 Thread GitBox
KomachiSion edited a comment on issue #3023: fix bug 2193 URL: https://github.com/apache/incubator-shardingsphere/pull/3023#issuecomment-530678798 > @KomachiSion Is it necessary to check the `availableTargetName` of other strategies? > What do you think of creating an abstract strategy?

[GitHub] [incubator-shardingsphere] coveralls commented on issue #3025: Fixed generic compilation errors

2019-09-11 Thread GitBox
coveralls commented on issue #3025: Fixed generic compilation errors URL: https://github.com/apache/incubator-shardingsphere/pull/3025#issuecomment-530684147 ## Pull Request Test Coverage Report for [Build 328](https://coveralls.io/builds/25669845) * **1** of **1** **(100.0%)** c

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2878: Fail to execute create dynamic table sql

2019-09-11 Thread GitBox
tristaZero commented on issue #2878: Fail to execute create dynamic table sql URL: https://github.com/apache/incubator-shardingsphere/issues/2878#issuecomment-530689858 @yangjwInRiver Have you ever tried the 4.0.0.RC2 This i

[GitHub] [incubator-shardingsphere] Ah39 commented on issue #2995: version 3.1.0 may route wrong and cause memory leak when tomcat start ( A sql route wrong to 1002 table )

2019-09-11 Thread GitBox
Ah39 commented on issue #2995: version 3.1.0 may route wrong and cause memory leak when tomcat start ( A sql route wrong to 1002 table ) URL: https://github.com/apache/incubator-shardingsphere/issues/2995#issuecomment-530690126 my version 3.1.0 dont test 4.0.4-RC2 ---

[GitHub] [incubator-shardingsphere] tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version

2019-09-11 Thread GitBox
tristaZero commented on issue #2819: How to turn off keyGenerator feature in 4.0.0-RC1 version URL: https://github.com/apache/incubator-shardingsphere/issues/2819#issuecomment-530691280 Sorry, i have no idea about your scenerio and problem, can you upload your example to gitHub, and tell

[GitHub] [incubator-shardingsphere] beckhampu commented on issue #3019: maven build errors

2019-09-11 Thread GitBox
beckhampu commented on issue #3019: maven build errors URL: https://github.com/apache/incubator-shardingsphere/issues/3019#issuecomment-530692404 Hi @Myshiner , is there any progress ? This is an automated message from the Ap