[GitHub] ajanthan commented on issue #989: spring cloud bug

2018-04-24 Thread GitBox
ajanthan commented on issue #989: spring cloud bug URL: https://github.com/apache/incubator-skywalking/issues/989#issuecomment-384169523 I am trying to reproduce the issue here. My understanding is that the spring application should have @aspect annotation with proxyTargetClass = true. I

[GitHub] wu-sheng closed issue #1115: Build Failure

2018-04-24 Thread GitBox
wu-sheng closed issue #1115: Build Failure URL: https://github.com/apache/incubator-skywalking/issues/1115 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the

[GitHub] ajanthan opened a new issue #1115: Build Failure

2018-04-24 Thread GitBox
ajanthan opened a new issue #1115: Build Failure URL: https://github.com/apache/incubator-skywalking/issues/1115 Please answer these questions before submitting your issue. - Why do you submit this issue? - [* ] Question or discussion - [ ] Bug - [ ] Requirement - [ ]

[GitHub] wu-sheng closed issue #938: PostgreSql Plugin Icon missing

2018-04-24 Thread GitBox
wu-sheng closed issue #938: PostgreSql Plugin Icon missing URL: https://github.com/apache/incubator-skywalking/issues/938 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] candyleer opened a new issue #1114: NPE in serialize EnhanceRequireObjectCache

2018-04-24 Thread GitBox
candyleer opened a new issue #1114: NPE in serialize EnhanceRequireObjectCache URL: https://github.com/apache/incubator-skywalking/issues/1114 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug -

[GitHub] wu-sheng closed pull request #160: change postgresql icon

2018-04-24 Thread GitBox
wu-sheng closed pull request #160: change postgresql icon URL: https://github.com/apache/incubator-skywalking-ui/pull/160 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng closed issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

2018-04-24 Thread GitBox
wu-sheng closed issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028 This is an automated message from the Apache Git Service.

[GitHub] wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor

2018-04-24 Thread GitBox
wu-sheng commented on issue #1028: 5.0-alpha , Can't find XMemcachedConstructorWithHostPortArgInterceptor URL: https://github.com/apache/incubator-skywalking/issues/1028#issuecomment-384152070 Fixed and merged. This is an

[GitHub] ascrutae opened a new pull request #160: change postgresql icon

2018-04-24 Thread GitBox
ascrutae opened a new pull request #160: change postgresql icon URL: https://github.com/apache/incubator-skywalking-ui/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] wu-sheng closed pull request #1113: Fix wrong interceptors names in XMemcached plugin

2018-04-24 Thread GitBox
wu-sheng closed pull request #1113: Fix wrong interceptors names in XMemcached plugin URL: https://github.com/apache/incubator-skywalking/pull/1113 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] wu-sheng commented on issue #1113: Fix wrong interceptors names in XMemcached plugin

2018-04-24 Thread GitBox
wu-sheng commented on issue #1113: Fix wrong interceptors names in XMemcached plugin URL: https://github.com/apache/incubator-skywalking/pull/1113#issuecomment-384150777 Merging and thanks for your contributions. This is an

[GitHub] coveralls commented on issue #1113: Fix wrong interceptors names in XMemcached plugin

2018-04-24 Thread GitBox
coveralls commented on issue #1113: Fix wrong interceptors names in XMemcached plugin URL: https://github.com/apache/incubator-skywalking/pull/1113#issuecomment-384148117 [![Coverage Status](https://coveralls.io/builds/16683105/badge)](https://coveralls.io/builds/16683105)

[GitHub] coveralls commented on issue #1113: Fix wrong interceptors names in XMemcached plugin

2018-04-24 Thread GitBox
coveralls commented on issue #1113: Fix wrong interceptors names in XMemcached plugin URL: https://github.com/apache/incubator-skywalking/pull/1113#issuecomment-384148117 [![Coverage Status](https://coveralls.io/builds/16683085/badge)](https://coveralls.io/builds/16683085)

[GitHub] coveralls commented on issue #1112: Fix rat check in ui local fonts file

2018-04-24 Thread GitBox
coveralls commented on issue #1112: Fix rat check in ui local fonts file URL: https://github.com/apache/incubator-skywalking/pull/1112#issuecomment-384147682 [![Coverage Status](https://coveralls.io/builds/16683055/badge)](https://coveralls.io/builds/16683055) Coverage remained

[GitHub] wu-sheng closed pull request #159: upload PostgreSQL icon

2018-04-24 Thread GitBox
wu-sheng closed pull request #159: upload PostgreSQL icon URL: https://github.com/apache/incubator-skywalking-ui/pull/159 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] wu-sheng commented on issue #1112: Fix rat check in ui local fonts file

2018-04-24 Thread GitBox
wu-sheng commented on issue #1112: Fix rat check in ui local fonts file URL: https://github.com/apache/incubator-skywalking/pull/1112#issuecomment-384144407 Does this https://github.com/apache/incubator-skywalking-ui/pull/158 trigger CI fail if we sync the submodule?

[GitHub] ascrutae opened a new pull request #159: upload PostgreSQL icon

2018-04-24 Thread GitBox
ascrutae opened a new pull request #159: upload PostgreSQL icon URL: https://github.com/apache/incubator-skywalking-ui/pull/159 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] candyleer opened a new pull request #1112: Fix rat exclud

2018-04-24 Thread GitBox
candyleer opened a new pull request #1112: Fix rat exclud URL: https://github.com/apache/incubator-skywalking/pull/1112 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve

[GitHub] wu-sheng commented on issue #901: Sort segment in more sensible way

2018-04-24 Thread GitBox
wu-sheng commented on issue #901: Sort segment in more sensible way URL: https://github.com/apache/incubator-skywalking/issues/901#issuecomment-384129567 I will move this into RC, considering this is not a functional issue, just for experience.

[GitHub] wu-sheng commented on issue #977: Add calls and online time to replace tps in graphQL protocol

2018-04-24 Thread GitBox
wu-sheng commented on issue #977: Add calls and online time to replace tps in graphQL protocol URL: https://github.com/apache/incubator-skywalking/issues/977#issuecomment-384129377 **Remove** this enhancement requirement. All metrics are now based on cpm(calls per min) instead of tps.

[GitHub] wu-sheng closed issue #940: [skywalking-ui]Request Error 500

2018-04-24 Thread GitBox
wu-sheng closed issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] wu-sheng commented on issue #940: [skywalking-ui]Request Error 500

2018-04-24 Thread GitBox
wu-sheng commented on issue #940: [skywalking-ui]Request Error 500 URL: https://github.com/apache/incubator-skywalking/issues/940#issuecomment-384129040 > @wu-sheng Hi, morning, yesterday I've solved this problem Closing this.

[GitHub] wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception

2018-04-24 Thread GitBox
wu-sheng commented on issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044#issuecomment-384128026 Closing this because this issue has no updates in 15 days.

[GitHub] wu-sheng closed issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception

2018-04-24 Thread GitBox
wu-sheng closed issue #1044: 5.0.0-alpha grpc server CallServerInterceptor some times has null exception URL: https://github.com/apache/incubator-skywalking/issues/1044 This is an automated message from the Apache Git

[GitHub] wu-sheng closed pull request #1111: Allow use SkyWalking plugin to override service in Agent core.

2018-04-24 Thread GitBox
wu-sheng closed pull request #: Allow use SkyWalking plugin to override service in Agent core. URL: https://github.com/apache/incubator-skywalking/pull/ This is an automated message from the Apache Git Service. To

[GitHub] ascrutae commented on issue #1111: Allow use SkyWalking plugin to override service in Agent core.

2018-04-24 Thread GitBox
ascrutae commented on issue #: Allow use SkyWalking plugin to override service in Agent core. URL: https://github.com/apache/incubator-skywalking/pull/#issuecomment-384009436 This feature has been tested. This is an

[GitHub] coveralls commented on issue #1111: Allow use SkyWalking plugin to override service in Agent core.

2018-04-24 Thread GitBox
coveralls commented on issue #: Allow use SkyWalking plugin to override service in Agent core. URL: https://github.com/apache/incubator-skywalking/pull/#issuecomment-383837758 [![Coverage

[GitHub] nikitap492 closed pull request #1099: Reduced amount of the guava cache services code

2018-04-24 Thread GitBox
nikitap492 closed pull request #1099: Reduced amount of the guava cache services code URL: https://github.com/apache/incubator-skywalking/pull/1099 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] nikitap492 commented on a change in pull request #1099: Reduced amount of the guava cache services code

2018-04-24 Thread GitBox
nikitap492 commented on a change in pull request #1099: Reduced amount of the guava cache services code URL: https://github.com/apache/incubator-skywalking/pull/1099#discussion_r183630582 ## File path:

[GitHub] wu-sheng commented on issue #1111: Allow use SkyWalking plugin to override service in Agent core.

2018-04-24 Thread GitBox
wu-sheng commented on issue #: Allow use SkyWalking plugin to override service in Agent core. URL: https://github.com/apache/incubator-skywalking/pull/#issuecomment-383825094 FYI @peng-yongsheng @hanahmily @ascrutae this feature will help us to extend the core from any plugin.

[GitHub] hanahmily commented on issue #1060: the menu icons cannot be displayed without internet

2018-04-24 Thread GitBox
hanahmily commented on issue #1060: the menu icons cannot be displayed without internet URL: https://github.com/apache/incubator-skywalking/issues/1060#issuecomment-383821675 fixed in https://github.com/apache/incubator-skywalking-ui/pull/158

[GitHub] hanahmily closed issue #1060: the menu icons cannot be displayed without internet

2018-04-24 Thread GitBox
hanahmily closed issue #1060: the menu icons cannot be displayed without internet URL: https://github.com/apache/incubator-skywalking/issues/1060 This is an automated message from the Apache Git Service. To respond to the

[GitHub] candyleer opened a new pull request #158: change font to local #1060

2018-04-24 Thread GitBox
candyleer opened a new pull request #158: change font to local #1060 URL: https://github.com/apache/incubator-skywalking-ui/pull/158 change font to local #1060 ![image](https://user-images.githubusercontent.com/11530760/39169531-c7ad0b2e-47ca-11e8-8960-52ce30658274.png)