[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110947 > Ok, maybe should put traceId in MDC to support Async Yes. I just don't use MDC often. But you can do that.

[GitHub] candyleer commented on issue #1241: TraceId is invalid in Logback AsyncAppender

candyleer commented on issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110766 Ok, maybe should put traceId in MDC to support Async This

[GitHub] candyleer commented on issue #1241: TraceId is invalid in Logback AsyncAppender

candyleer commented on issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110766 Ok, maybe should put traceId in `MDC` to support Async Thi

[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110244 `AsyncAppender ` is definitely a total different story. Thi

[GitHub] wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender

wu-sheng commented on issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241#issuecomment-390110357 And I will tag this as `enhancement`, because I didn't support that. before. ---

[GitHub] candyleer opened a new issue #1241: TraceId is invalid in Logback AsyncAppender

candyleer opened a new issue #1241: TraceId is invalid in Logback AsyncAppender URL: https://github.com/apache/incubator-skywalking/issues/1241 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug -

[GitHub] coveralls commented on issue #1220: support shardingjdbc database storage feature

coveralls commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-389104242 [](https://coveralls.io/builds/17047124) Coverag

[GitHub] wu-sheng opened a new pull request #1240: Add application filter for service and two conditions for trace query.

wu-sheng opened a new pull request #1240: Add application filter for service and two conditions for trace query. URL: https://github.com/apache/incubator-skywalking/pull/1240 There are the top two important features in beta2 related. 1. Service query related 1. Trace query related --

[GitHub] wu-sheng commented on issue #1220: support shardingjdbc database storage feature

wu-sheng commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-390079342 @chidaodezhongsheng You are still missing @peng-yongsheng 's review. -

[GitHub] candyleer commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

candyleer commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239#issuecomment-390068104 I haven't compile on windows... This is an

[GitHub] candyleer commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

candyleer commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239#issuecomment-390068104 I haven't compile in windows... This is an

[GitHub] wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

wu-sheng commented on issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239#issuecomment-390062318 This is a Windows issue. I think you can set your register. @liuhaoyang @candyleer Have any of you done this

[GitHub] leilianjie opened a new issue #1239: file name too long on windows7 when i checkout 5.0.0-beta

leilianjie opened a new issue #1239: file name too long on windows7 when i checkout 5.0.0-beta URL: https://github.com/apache/incubator-skywalking/issues/1239 unable to create file apm-collector/apm-collector-analysis/analysis-metric/metric-provider/src/main/java/org/apache/skywalking/apm/

[GitHub] candyleer commented on issue #1238: NPE when use hystrix in spring

candyleer commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389854128 Wow,I should learn how the grpc do This is an automated message from t

[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring

wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389852363 Then @ascrutae , please consider to refactor this plugin, as we just did for gRPC in beta. I think the old interceptor points have same

[GitHub] candyleer commented on issue #1238: NPE when use hystrix in spring

candyleer commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389851723 I have no idea how to fix cause they are not in the same thread. This

[GitHub] wu-sheng commented on issue #1237: Does the alarm have documentation?

wu-sheng commented on issue #1237: Does the alarm have documentation? URL: https://github.com/apache/incubator-skywalking/issues/1237#issuecomment-389850487 Please look your `application.yml` in your collector config directory. The following settings are alarm related. And I think it is ea

[GitHub] wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-389849943 Look like same as #1238

[GitHub] wu-sheng commented on issue #1238: NPE when use hystrix in spring

wu-sheng commented on issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238#issuecomment-389849692 @candyleer Do you need me to ping Xin for help? Or you want to try by yourself? ---

[GitHub] candyleer opened a new issue #1238: NPE when use hystrix in spring

candyleer opened a new issue #1238: NPE when use hystrix in spring URL: https://github.com/apache/incubator-skywalking/issues/1238 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Require

[GitHub] tangmingming opened a new issue #1237: Does the alarm have documentation?

tangmingming opened a new issue #1237: Does the alarm have documentation? URL: https://github.com/apache/incubator-skywalking/issues/1237 Please answer these questions before submitting your issue. - Why do you submit this issue? - [1 ] Question or discussion - [ ] Bug - [ ]

[GitHub] coveralls commented on issue #1220: support shardingjdbc database storage feature

coveralls commented on issue #1220: support shardingjdbc database storage feature URL: https://github.com/apache/incubator-skywalking/pull/1220#issuecomment-389104242 [](https://coveralls.io/builds/17027832) Coverag

[GitHub] wfs0902 commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

wfs0902 commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-389784373 hystrix calls rxjava.jar did the hystrix in my project and the hystrix in skywalking cause s

[GitHub] wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

wu-sheng commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-389765889 What is rxjava? I am not familiar with that. --

[GitHub] wfs0902 commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

wfs0902 commented on issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236#issuecomment-389765736 No error was started, and rxjava-1.2.0 was called for error. ---

[GitHub] wfs0902 opened a new issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages

wfs0902 opened a new issue #1236: bug:5.0.0-beta:The project contains hystrix1.5.12 and rxjava-1.2.0 packages URL: https://github.com/apache/incubator-skywalking/issues/1236 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question