[GitHub] WithLin commented on issue #2000: Support rabbitmq plugin

WithLin commented on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444781327 I adjusted the test case again, and then ran all versions of rabbitmq in my local environment, all compatible. Please run the test case again.

[incubator-skywalking] branch master updated (f39c040 -> 3f2fb8d)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from f39c040 Merge pull request #2005 from JaredTan95/clean add efad116 add system env for trace

[incubator-skywalking] 01/01: Merge pull request #1981 from a198720/len

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 3f2fb8dbf94e239f17d68dc68ec76fbad8c35980 Merge: f39c040 1b66346 Author: Jared Tan AuthorDate: Thu Dec 6

[GitHub] JaredTan95 closed pull request #1981: add system env for trace ignore plugin

JaredTan95 closed pull request #1981: add system env for trace ignore plugin URL: https://github.com/apache/incubator-skywalking/pull/1981 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] ASCE1885 commented on issue #1997: Print traceId to log4j2 failed

ASCE1885 commented on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444776347 > I prefer you could contribute this as optional plugin. Do you have interests to do that? I will create a pull requests later,

[incubator-skywalking] branch master updated (f2b1588 -> f39c040)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from f2b1588 [OAL refactor step 1]Refactor dispatcher manager (#2006) add 1b1a9bf Remove unused

[GitHub] JaredTan95 closed pull request #2005: Remove unused Debug Switches

JaredTan95 closed pull request #2005: Remove unused Debug Switches URL: https://github.com/apache/incubator-skywalking/pull/2005 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-skywalking] 01/01: Merge pull request #2005 from JaredTan95/clean

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit f39c0407069507bf52cad1788123647cb8a83574 Merge: f2b1588 1587b05 Author: Jared Tan AuthorDate: Thu Dec 6

[incubator-skywalking] branch refactor-dispatcher-manager deleted (was 6766fd6)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch refactor-dispatcher-manager in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 6766fd6 Add comments. The revisions that were on this branch are still

[GitHub] wu-sheng closed pull request #2006: [OAL refactor step 1]Refactor dispatcher manager

wu-sheng closed pull request #2006: [OAL refactor step 1]Refactor dispatcher manager URL: https://github.com/apache/incubator-skywalking/pull/2006 This is an automated message from the Apache Git Service. To respond to the

[incubator-skywalking] branch master updated: [OAL refactor step 1]Refactor dispatcher manager (#2006)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new f2b1588 [OAL refactor step

[GitHub] wu-sheng commented on issue #1981: add system env for trace ignore plugin

wu-sheng commented on issue #1981: add system env for trace ignore plugin URL: https://github.com/apache/incubator-skywalking/pull/1981#issuecomment-444761387 @a198720 Do you want to continue this contribution? @JaredTan95 How about starting to new PR to fix this?

[GitHub] wu-sheng opened a new pull request #2006: [OAL refactor step 1]Refactor dispatcher manager

wu-sheng opened a new pull request #2006: [OAL refactor step 1]Refactor dispatcher manager URL: https://github.com/apache/incubator-skywalking/pull/2006 This is the first step of OAL related refactor. The major point of this refactor is moving the oal-tool back to the main repo, and make

[GitHub] wu-sheng commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT

wu-sheng commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT URL: https://github.com/apache/incubator-skywalking/issues/1991#issuecomment-444758190 If the namespace, there is a bug fixed in beta milestone, the delete mechanism doesn't work right.

[GitHub] wu-sheng closed issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT

wu-sheng closed issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT URL: https://github.com/apache/incubator-skywalking/issues/1991 This is an automated message from the Apache Git Service. To

[GitHub] a198720 commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT

a198720 commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT URL: https://github.com/apache/incubator-skywalking/issues/1991#issuecomment-444753613 @wu-sheng @peng-yongsheng Can you give some ideas to consider what is the trigger?

[GitHub] a198720 commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT

a198720 commented on issue #1991: oap can't review data after about 8 hours in 6.0.0-beta-SNAPSHOT URL: https://github.com/apache/incubator-skywalking/issues/1991#issuecomment-444753386 this time, I deploy oap with a different configuration. first I use h2 as the storage. after 8 hours

[GitHub] wu-sheng commented on issue #1997: Print traceId to log4j2 failed

wu-sheng commented on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444749814 @candyleer what do you think? This is an automated message from the

[GitHub] wu-sheng commented on issue #1997: Print traceId to log4j2 failed

wu-sheng commented on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444749739 I prefer you could contribute this as optional plugin. Do you have interests to do that?

[GitHub] ASCE1885 edited a comment on issue #1997: Print traceId to log4j2 failed

ASCE1885 edited a comment on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444747585 @wu-sheng I enhanced `org.apache.logging.log4j.ThreadContext` and intercept method `getImmutableContext` and `getContext`,before

[GitHub] ASCE1885 edited a comment on issue #1997: Print traceId to log4j2 failed

ASCE1885 edited a comment on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444747585 @wu-sheng I enhanced `org.apache.logging.log4j.ThreadContext` and intercept method `getImmutableContext` and `getContext`,before

[GitHub] ASCE1885 commented on issue #1997: Print traceId to log4j2 failed

ASCE1885 commented on issue #1997: Print traceId to log4j2 failed URL: https://github.com/apache/incubator-skywalking/issues/1997#issuecomment-444747585 @wu-sheng I enhanced `org.apache.logging.log4j.ThreadContext` and intercept method `getImmutableContext` and `getContext`,before this

[incubator-skywalking] branch refactor-dispatcher-manager updated: Add comments.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch refactor-dispatcher-manager in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/refactor-dispatcher-manager by this

[incubator-skywalking] branch refactor-dispatcher-manager created (now 1ed574e)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch refactor-dispatcher-manager in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 1ed574e Remove the hard codes about DispatcherManager. This branch includes

[incubator-skywalking] 01/01: Remove the hard codes about DispatcherManager.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch refactor-dispatcher-manager in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 1ed574e5a949f01db40d65ab9aa8669d18fb28cd Author: Wu Sheng AuthorDate: Thu Dec 6

[GitHub] JaredTan95 opened a new pull request #2005: Remove unused Debug Switches

JaredTan95 opened a new pull request #2005: Remove unused Debug Switches URL: https://github.com/apache/incubator-skywalking/pull/2005 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ]

[incubator-skywalking-oal-tool] branch master updated: Update README.md

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-oal-tool.git The following commit(s) were added to refs/heads/master by this push: new eb7932b Update

[GitHub] wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md

wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#discussion_r239141046 ## File path: docs/en/setup/backend/backend-upgrade.md ## @@ -0,0 +1,26 @@ +# Backend upgrade +First and

[GitHub] wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md

wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#discussion_r239138910 ## File path: docs/en/setup/backend/backend-upgrade.md ## @@ -0,0 +1,26 @@ +# Backend upgrade +First and

[GitHub] wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md

wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#discussion_r239137202 ## File path: docs/en/setup/backend/backend-upgrade.md ## @@ -0,0 +1,26 @@ +# Backend upgrade +First and

[GitHub] wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md

wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#discussion_r239139288 ## File path: docs/en/setup/backend/backend-upgrade.md ## @@ -0,0 +1,26 @@ +# Backend upgrade +First and

[GitHub] wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md

wu-sheng commented on a change in pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004#discussion_r239138446 ## File path: docs/en/setup/backend/backend-upgrade.md ## @@ -0,0 +1,26 @@ +# Backend upgrade +First and

[incubator-skywalking] 01/01: Create backend-upgrade.md

This is an automated email from the ASF dual-hosted git repository. pengys pushed a commit to branch peng-yongsheng-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit d487fb52f02074f4dc8f7f4b85faa11de4bd3370 Author: 彭勇升 pengys AuthorDate: Thu Dec 6

[incubator-skywalking] branch peng-yongsheng-patch-2 created (now d487fb5)

This is an automated email from the ASF dual-hosted git repository. pengys pushed a change to branch peng-yongsheng-patch-2 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at d487fb5 Create backend-upgrade.md This branch includes the following new commits:

[GitHub] peng-yongsheng opened a new pull request #2004: Create backend-upgrade.md

peng-yongsheng opened a new pull request #2004: Create backend-upgrade.md URL: https://github.com/apache/incubator-skywalking/pull/2004 A document for how to upgrade the SkyWalking to new edition. This is an automated

[incubator-skywalking] branch peng-yongsheng-patch-1 deleted (was e53077d)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch peng-yongsheng-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was e53077d Update README.md This change permanently discards the following revisions:

[GitHub] wu-sheng commented on issue #2000: Support rabbitmq plugin

wu-sheng commented on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444518978 @WithLin Please make the compatible better. At least, 5.4.x and 5.5.x should be supported. Thanks.

[GitHub] SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin

SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-444512681 Here is the [test

[GitHub] SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin

SkyWalkingRobot commented on issue #2000: Support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-84313 Here is the [test

[GitHub] wu-sheng commented on issue #2000: Fix support rabbitmq plugin

wu-sheng commented on issue #2000: Fix support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-81464 Thank @ascrutae to address the bug in this PR. This is an automated message

[incubator-skywalking] branch 5.x updated: FileUtils Transaction problem (#1996)

This is an automated email from the ASF dual-hosted git repository. pengys pushed a commit to branch 5.x in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/5.x by this push: new 69a765d FileUtils Transaction problem

[GitHub] peng-yongsheng closed pull request #1996: FileUtils Transaction problem

peng-yongsheng closed pull request #1996: FileUtils Transaction problem URL: https://github.com/apache/incubator-skywalking/pull/1996 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-skywalking] branch alarm-fix deleted (was 0281e43)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 0281e43 Merge branch 'alarm-fix' of https://github.com/apache/incubator-skywalking into

[incubator-skywalking] branch master updated: Fix the alarm being started too many times. (#2003)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 5f5be77 Fix the alarm being

[GitHub] wu-sheng closed pull request #2003: Fix the alarm being started too many times.

wu-sheng closed pull request #2003: Fix the alarm being started too many times. URL: https://github.com/apache/incubator-skywalking/pull/2003 This is an automated message from the Apache Git Service. To respond to the

[GitHub] wu-sheng commented on issue #2003: Fix the alarm being started too many times.

wu-sheng commented on issue #2003: Fix the alarm being started too many times. URL: https://github.com/apache/incubator-skywalking/pull/2003#issuecomment-74785 FYI @peng-yongsheng This is an automated message from the

[GitHub] qibaichao commented on issue #2003: Fix the alarm being started too many times.

qibaichao commented on issue #2003: Fix the alarm being started too many times. URL: https://github.com/apache/incubator-skywalking/pull/2003#issuecomment-74497 this bug is fixed This is an automated message from the

[incubator-skywalking] branch alarm-fix updated (e15e216 -> 0281e43)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from e15e216 Merge branch 'master' into alarm-fix add 4af8c17 Fix wrong status changed add

[GitHub] SkyWalkingRobot commented on issue #2000: Fix support rabbitmq plugin

SkyWalkingRobot commented on issue #2000: Fix support rabbitmq plugin URL: https://github.com/apache/incubator-skywalking/pull/2000#issuecomment-11093 Here is the [test

[incubator-skywalking] branch alarm-fix updated (cb93146 -> e15e216)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from cb93146 Remove unnecessary interface. add d75a147 Update How-to-build.md (#2002) add

[incubator-skywalking] branch alarm-fix updated (4ba15c2 -> cb93146)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 4ba15c2 Fix the alarm being started too many times. add cb93146 Remove unnecessary

[GitHub] wu-sheng opened a new pull request #2003: Fix the alarm being started too many times.

wu-sheng opened a new pull request #2003: Fix the alarm being started too many times. URL: https://github.com/apache/incubator-skywalking/pull/2003 From the community feedback, they addressed this bug. **NotifyHandler** should be inited and started inside `AlarmModuleProvider`.

[incubator-skywalking] 01/01: Fix the alarm being started too many times.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 4ba15c2cb4c1606b4eb15038fcf49824135699f8 Author: Wu Sheng AuthorDate: Wed Dec 5 16:29:29 2018 +0800

[incubator-skywalking] branch alarm-fix created (now 4ba15c2)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch alarm-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 4ba15c2 Fix the alarm being started too many times. This branch includes the following new

[GitHub] SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin

SkyWalkingRobot commented on issue #1985: Fix the NPE about elasticsearch plugin URL: https://github.com/apache/incubator-skywalking/pull/1985#issuecomment-444395700 Here is the [test