[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446866368 @ASCE1885 Before people begin to review, please fix your CI first. --

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446861368 Approve(not merge) this PR when you think it is ready. --

[GitHub] wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
wu-sheng commented on issue #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040#issuecomment-446861250 @candyleer Please review this PR. This is an

[GitHub] ASCE1885 opened a new pull request #2040: enabled log4j2 to print traceId both in sync and async mode

2018-12-12 Thread GitBox
ASCE1885 opened a new pull request #2040: enabled log4j2 to print traceId both in sync and async mode URL: https://github.com/apache/incubator-skywalking/pull/2040 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] N

[GitHub] wu-sheng commented on issue #1791: NullPointException

2018-12-12 Thread GitBox
wu-sheng commented on issue #1791: NullPointException URL: https://github.com/apache/incubator-skywalking/issues/1791#issuecomment-446852356 No update in a whole month. This is an automated message from the Apache Git Service

[GitHub] wu-sheng closed issue #1791: NullPointException

2018-12-12 Thread GitBox
wu-sheng closed issue #1791: NullPointException URL: https://github.com/apache/incubator-skywalking/issues/1791 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] wu-sheng commented on issue #1708: Design for web performance's data structure.

2018-12-12 Thread GitBox
wu-sheng commented on issue #1708: Design for web performance's data structure. URL: https://github.com/apache/incubator-skywalking/issues/1708#issuecomment-446839175 Any update for this? @kkroy-zs If still don't have an update in next two weeks, I will remove the milestone. -

[GitHub] wu-sheng commented on issue #1706: Netty Client跨线程 ContextManager.continued出现空指针

2018-12-12 Thread GitBox
wu-sheng commented on issue #1706: Netty Client跨线程 ContextManager.continued出现空指针 URL: https://github.com/apache/incubator-skywalking/issues/1706#issuecomment-446838237 You should easy to find this reason by your self. `capture/continued` require running when active span exists, which in yo

[GitHub] RyouZhang commented on issue #1706: Netty Client跨线程 ContextManager.continued出现空指针

2018-12-12 Thread GitBox
RyouZhang commented on issue #1706: Netty Client跨线程 ContextManager.continued出现空指针 URL: https://github.com/apache/incubator-skywalking/issues/1706#issuecomment-446837381 > English only accepted here. so please replay this question

[GitHub] wu-sheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families.

2018-12-12 Thread GitBox
wu-sheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families. URL: https://github.com/apache/incubator-skywalking/issues/2039#issuecomment-446836945 Good plan to do this. Try to implement a prototype version in GA version,

[GitHub] peng-yongsheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families.

2018-12-12 Thread GitBox
peng-yongsheng commented on issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families. URL: https://github.com/apache/incubator-skywalking/issues/2039#issuecomment-446832690 I will try to implement the authentication of the Elasticsearch. ---

[GitHub] peng-yongsheng opened a new issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families.

2018-12-12 Thread GitBox
peng-yongsheng opened a new issue #2039: [OAP Server][Storage] A new Elasticsearch client supports 2.x, 5.x and 6.x version families. URL: https://github.com/apache/incubator-skywalking/issues/2039 Please answer these questions before submitting your issue. - Why do you submit this i

[GitHub] xiaoni157 commented on issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
xiaoni157 commented on issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038#issuecomment-446829228 ok, i see. thank you. This is an automated message from

[GitHub] peng-yongsheng commented on issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
peng-yongsheng commented on issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038#issuecomment-446825622 @xiaoni157 From you logs, I see a missing authentication exception. Our elasticsearch client not support authentica

[GitHub] peng-yongsheng commented on issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
peng-yongsheng commented on issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038#issuecomment-446824775 @wu-sheng 5.x is transport client, default is 9300 port, not 9200, 6.x is rest client, default is 9200. --

[GitHub] xiaoni157 commented on issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
xiaoni157 commented on issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038#issuecomment-446821316 Oh, i found this error in the skywalking-collector-server.log ![error](https://user-images.githubusercontent.com/

[GitHub] wu-sheng commented on issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446809714 > thank you. i will try. you gets up earlier today, and have a nice day. Actually, I am at Seattle, so, just regular work time. Have a good day, too.

[GitHub] coki230 commented on issue #2037: 少包

2018-12-12 Thread GitBox
coki230 commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446809375 thank you. i will try. you gets up earlier today, and have a nice day. This is an automated message f

[GitHub] wu-sheng commented on issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446803610 See `Setup your IntelliJ IDEA` section, you will find the introductions. And at the same time, `./mvnw compile` or `./mvnw package` requires nothing to do.

[GitHub] wu-sheng commented on issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446803343 This image have been checked by PPMC, committer and Apache team before we do the release. So it can't miss any package from my understanding. These package w

[GitHub] wu-sheng edited a comment on issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng edited a comment on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446803343 This image have been checked by PPMC, committer and Apache team before we do the release. So it can't miss any package from my understanding. These pa

[GitHub] coki230 commented on issue #2037: 少包

2018-12-12 Thread GitBox
coki230 commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446802779 I follow document https://github.com/apache/incubator-skywalking/blob/master/docs/en/guides/How-to-build.md. and download the source form http://mirrors.hust.

[GitHub] wu-sheng commented on issue #208: open skywalking website 404

2018-12-12 Thread GitBox
wu-sheng commented on issue #208: open skywalking website 404 URL: https://github.com/apache/incubator-skywalking-ui/issues/208#issuecomment-446801060 @TinyAllen When you have time, help on fix this? This is an automated mess

[GitHub] AloneJiang opened a new issue #208: open skywalking website 404

2018-12-12 Thread GitBox
AloneJiang opened a new issue #208: open skywalking website 404 URL: https://github.com/apache/incubator-skywalking-ui/issues/208 version:5.0.0-GA,Pictured: ![qq 20181213083804](https://user-images.githubusercontent.com/2296441/49907744-80014200-feb2-11e8-887c-9307e221dd7e.png)

[incubator-skywalking-website] 02/03: Merge branch 'asf-site' of https://github.com/apache/incubator-skywalking-website into asf-site

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git commit 9b2c2fcc89da9badfe690778a2f00c26af229fd8 Merge: 7312b2b 21dc2c7 Author: Wu Sheng AuthorDate: W

[incubator-skywalking-website] 01/03: Post the blog of SkyWalking v6

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git commit 7312b2b389a142f1dd3281f5181edfe16fc7545e Author: Wu Sheng AuthorDate: Wed Dec 12 16:27:16 2018

[incubator-skywalking-website] 03/03: website update with new blog.

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git commit 5e19fbc4733ebfc21ecc9b07a7c553c0b2e68ebd Author: Wu Sheng AuthorDate: Wed Dec 12 16:32:50 2018

[incubator-skywalking-website] branch asf-site updated (21dc2c7 -> 5e19fbc)

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. from 21dc2c7 Updata: update README (#5) new 7312b2b Post the blog of SkyWalking v6 n

[incubator-skywalking-website] branch asf-site updated: Updata: update README (#5)

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 21dc2c7 Updata: upd

[GitHub] wu-sheng closed pull request #5: Updata: update README

2018-12-12 Thread GitBox
wu-sheng closed pull request #5: Updata: update README URL: https://github.com/apache/incubator-skywalking-website/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] wu-sheng commented on a change in pull request #5: Updata: update README

2018-12-12 Thread GitBox
wu-sheng commented on a change in pull request #5: Updata: update README URL: https://github.com/apache/incubator-skywalking-website/pull/5#discussion_r241234628 ## File path: README.md ## @@ -15,8 +15,9 @@ Note, branch `asf-site` don't accept pull request, all `asf-site`

[GitHub] JaredTan95 commented on a change in pull request #5: Updata: update README

2018-12-12 Thread GitBox
JaredTan95 commented on a change in pull request #5: Updata: update README URL: https://github.com/apache/incubator-skywalking-website/pull/5#discussion_r241227804 ## File path: README.md ## @@ -15,8 +15,9 @@ Note, branch `asf-site` don't accept pull request, all `asf-sit

[GitHub] JaredTan95 closed pull request #4: Update: add clean script

2018-12-12 Thread GitBox
JaredTan95 closed pull request #4: Update: add clean script URL: https://github.com/apache/incubator-skywalking-website/pull/4 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[incubator-skywalking-website] branch asf-site updated: Update: add clean script (#4)

2018-12-12 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3faf31a Update: add

[GitHub] TinyAllen opened a new pull request #5: Updata: update README

2018-12-12 Thread GitBox
TinyAllen opened a new pull request #5: Updata: update README URL: https://github.com/apache/incubator-skywalking-website/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] TinyAllen opened a new pull request #4: Update: add clean script

2018-12-12 Thread GitBox
TinyAllen opened a new pull request #4: Update: add clean script URL: https://github.com/apache/incubator-skywalking-website/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] wu-sheng commented on issue #1031: Links missing from website

2018-12-12 Thread GitBox
wu-sheng commented on issue #1031: Links missing from website URL: https://github.com/apache/incubator-skywalking/issues/1031#issuecomment-446750379 Through the PR #1139 ( link to https://github.com/apache/incubator-skywalking-website/pull/3 ). Now the website has that too. See http://sky

[GitHub] wu-sheng closed issue #1031: Links missing from website

2018-12-12 Thread GitBox
wu-sheng closed issue #1031: Links missing from website URL: https://github.com/apache/incubator-skywalking/issues/1031 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] wu-sheng commented on issue #1139: Look for contributors to rebuild our website

2018-12-12 Thread GitBox
wu-sheng commented on issue #1139: Look for contributors to rebuild our website URL: https://github.com/apache/incubator-skywalking/issues/1139#issuecomment-44674 Super cool. This has been done by PR https://github.com/apache/incubator-skywalking-website/pull/3 . Appreciate @TinyAllen

[GitHub] wu-sheng closed issue #1139: Look for contributors to rebuild our website

2018-12-12 Thread GitBox
wu-sheng closed issue #1139: Look for contributors to rebuild our website URL: https://github.com/apache/incubator-skywalking/issues/1139 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] wu-sheng commented on issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
wu-sheng commented on issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038#issuecomment-446741630 Version 5.x asked for ElasticSearch TCP ports, default in 9200. Follow document please. --

[GitHub] wu-sheng closed issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
wu-sheng closed issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] wu-sheng commented on issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng commented on issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037#issuecomment-446741377 English only. And follow document https://github.com/apache/incubator-skywalking/blob/master/docs/en/guides/How-to-build.md

[GitHub] wu-sheng closed issue #2037: 少包

2018-12-12 Thread GitBox
wu-sheng closed issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above t

[incubator-skywalking] branch 6-beta-release created (now dfe2b08)

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch 6-beta-release in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at dfe2b08 [OAP Server][Cluster Plugin] Provide consul cluster plugin (#2036) No new revisions

[incubator-skywalking] branch master updated: [OAP Server][Cluster Plugin] Provide consul cluster plugin (#2036)

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new dfe2b08 [OAP Server][Cluster Plu

[GitHub] wu-sheng closed pull request #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin

2018-12-12 Thread GitBox
wu-sheng closed pull request #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin URL: https://github.com/apache/incubator-skywalking/pull/2036 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] coveralls edited a comment on issue #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin

2018-12-12 Thread GitBox
coveralls edited a comment on issue #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin URL: https://github.com/apache/incubator-skywalking/pull/2036#issuecomment-446509144 [![Coverage Status](https://coveralls.io/builds/20595929/badge)](https://coveralls.io/builds/20595

[GitHub] xiaoni157 opened a new issue #2038: Connection es failed NoNodeAvailableException

2018-12-12 Thread GitBox
xiaoni157 opened a new issue #2038: Connection es failed NoNodeAvailableException URL: https://github.com/apache/incubator-skywalking/issues/2038 - Why do you submit this issue? - [ ✅] Question or discussion ___ ### Question - What do you want to know? Why is the connection a

[GitHub] coki230 opened a new issue #2037: 少包

2018-12-12 Thread GitBox
coki230 opened a new issue #2037: 少包 URL: https://github.com/apache/incubator-skywalking/issues/2037 ### Bug - Which version of SkyWalking, OS and JRE? 最新版本SkyWalking - Which company or project? oap-server - What happen? 少包,lack the packege of "org.apache.skywalking.oap

[GitHub] coveralls commented on issue #2035: Support canal plugin

2018-12-12 Thread GitBox
coveralls commented on issue #2035: Support canal plugin URL: https://github.com/apache/incubator-skywalking/pull/2035#issuecomment-446514058 [![Coverage Status](https://coveralls.io/builds/20589007/badge)](https://coveralls.io/builds/20589007) Coverage increased (+0.03%) to 14.

[GitHub] coveralls commented on issue #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin

2018-12-12 Thread GitBox
coveralls commented on issue #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin URL: https://github.com/apache/incubator-skywalking/pull/2036#issuecomment-446509144 [![Coverage Status](https://coveralls.io/builds/20588806/badge)](https://coveralls.io/builds/20588806)

[GitHub] wu-sheng commented on a change in pull request #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin

2018-12-12 Thread GitBox
wu-sheng commented on a change in pull request #2036: [OAP Server][Cluster Plugin] Provide consul cluster plugin URL: https://github.com/apache/incubator-skywalking/pull/2036#discussion_r240916891 ## File path: oap-server/pom.xml ## @@ -153,6 +154,11 @@ g

[GitHub] wu-sheng commented on issue #1865: Agent5.0GA not support SpringCloud2.x?

2018-12-12 Thread GitBox
wu-sheng commented on issue #1865: Agent5.0GA not support SpringCloud2.x? URL: https://github.com/apache/incubator-skywalking/issues/1865#issuecomment-446498958 New Spring MVC 5 should be supported in beta release. This is an

[GitHub] wu-sheng closed issue #1865: Agent5.0GA not support SpringCloud2.x?

2018-12-12 Thread GitBox
wu-sheng closed issue #1865: Agent5.0GA not support SpringCloud2.x? URL: https://github.com/apache/incubator-skywalking/issues/1865 This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-skywalking] branch master updated: Support webflux and spring mvc 5 plugin (#1993)

2018-12-12 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2a566bb Support webflux and spri

[GitHub] wu-sheng closed pull request #1993: Support webflux and spring mvc 5 plugin

2018-12-12 Thread GitBox
wu-sheng closed pull request #1993: Support webflux and spring mvc 5 plugin URL: https://github.com/apache/incubator-skywalking/pull/1993 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] coveralls edited a comment on issue #1993: Support webflux and spring mvc 5 plugin

2018-12-12 Thread GitBox
coveralls edited a comment on issue #1993: Support webflux and spring mvc 5 plugin URL: https://github.com/apache/incubator-skywalking/pull/1993#issuecomment-443575488 [![Coverage Status](https://coveralls.io/builds/20588319/badge)](https://coveralls.io/builds/20588319) Coverag