[GitHub] foxracle commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451860938 Thanks for your quick reply! Could you tell me the details about how to collect the OS hostname, because r

[GitHub] wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451861534 No. That name would not show in service map. Service map is based on service code, not hostname. In real prod

[GitHub] foxracle commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451863784 when service instance nodes is one vm like aliyun's ecs, what does the 'hostname' mean. we install sw into o

[GitHub] wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451864516 OS hostname has just one meanings. What do you expect? I am confusing. I feel you are creating your own conc

[GitHub] foxracle commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451866922 As a user, we just want to know which service instance nodes the service is now running. but we now can only

[GitHub] wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451867613 It is OS hostname. You could find tons of documents about how to set OS hostname in Google or Baidu. ---

[GitHub] foxracle commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451868675 the question is that we have a unique hostname for every machine, but on service map page all machine show as

[GitHub] wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451869257 That depends on JVM. We use JVM API to get that. So you could easily test it by a simple demo java app. ---

[GitHub] foxracle edited a comment on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle edited a comment on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451868675 the question is that we have set a unique hostname for every machine, but on service map page all mach

[GitHub] foxracle commented on issue #2127: how to set a unique name for each service instance nodes?

2019-01-07 Thread GitBox
foxracle commented on issue #2127: how to set a unique name for each service instance nodes? URL: https://github.com/apache/incubator-skywalking/issues/2127#issuecomment-451869950 thank you, we will check it This is an autom

[GitHub] TinyAllen opened a new pull request #217: Update:fix #2114 datas are too much

2019-01-07 Thread GitBox
TinyAllen opened a new pull request #217: Update:fix #2114 datas are too much URL: https://github.com/apache/incubator-skywalking-ui/pull/217 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] wu-sheng commented on issue #217: Update:fix #2114 datas are too much

2019-01-07 Thread GitBox
wu-sheng commented on issue #217: Update:fix #2114 datas are too much URL: https://github.com/apache/incubator-skywalking-ui/pull/217#issuecomment-451949737 Fix https://github.com/apache/incubator-skywalking/issues/2114 This

[incubator-skywalking-ui] branch master updated: Update:fix #2114 datas are too much (#217)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-ui.git The following commit(s) were added to refs/heads/master by this push: new 2372ccb Update:fix #2114 data

[GitHub] wu-sheng closed pull request #217: Update:fix #2114 datas are too much

2019-01-07 Thread GitBox
wu-sheng closed pull request #217: Update:fix #2114 datas are too much URL: https://github.com/apache/incubator-skywalking-ui/pull/217 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] wu-sheng commented on issue #217: Update:fix #2114 datas are too much

2019-01-07 Thread GitBox
wu-sheng commented on issue #217: Update:fix #2114 datas are too much URL: https://github.com/apache/incubator-skywalking-ui/pull/217#issuecomment-451949943 Please sync the submodule to the main repo. This is an automated mes

[incubator-skywalking] branch prometheus created (now 2107b3a)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 2107b3a Finish the basic codes of telemetry. This branch includes the following new commits:

[incubator-skywalking] 01/01: Finish the basic codes of telemetry.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 2107b3a3f42e3dfcad5a247bfbadadf2af2eac09 Author: Wu Sheng AuthorDate: Mon Jan 7 22:34:54 2019 +0800

[incubator-skywalking] branch prometheus updated: Add many telemetry in oap.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/prometheus by this push: new 79f4a7c Add many telemet

[GitHub] coveralls edited a comment on issue #2025: [WIP]Database metrics provided.

2019-01-07 Thread GitBox
coveralls edited a comment on issue #2025: [WIP]Database metrics provided. URL: https://github.com/apache/incubator-skywalking/pull/2025#issuecomment-445507702 [![Coverage Status](https://coveralls.io/builds/20941584/badge)](https://coveralls.io/builds/20941584) Coverage decreas

[GitHub] TinyAllen opened a new pull request #2128: Update: update ui trace-tree

2019-01-07 Thread GitBox
TinyAllen opened a new pull request #2128: Update: update ui trace-tree URL: https://github.com/apache/incubator-skywalking/pull/2128 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Im

[incubator-skywalking] branch prometheus updated: Fix a test case.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/prometheus by this push: new 1155c17 Fix a test case.

[GitHub] gantts opened a new issue #2129: Each method needs to add @Trace tracing. How to configure uniform interception in aop?

2019-01-07 Thread GitBox
gantts opened a new issue #2129: Each method needs to add @Trace tracing. How to configure uniform interception in aop? URL: https://github.com/apache/incubator-skywalking/issues/2129 Too many methods and @Trace annotations are too cumbersome. Hope to unify the interception configuration

[GitHub] wu-sheng commented on issue #2129: Each method needs to add @Trace tracing. How to configure uniform interception in aop?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2129: Each method needs to add @Trace tracing. How to configure uniform interception in aop? URL: https://github.com/apache/incubator-skywalking/issues/2129#issuecomment-452150666 We are welcome to accept this as an optional plugin. We don't have that for now.

[GitHub] honganan opened a new pull request #2130: add user info of Youzan.com

2019-01-07 Thread GitBox
honganan opened a new pull request #2130: add user info of Youzan.com URL: https://github.com/apache/incubator-skywalking/pull/2130 add user info of Youzan.com This is an automated message from the Apache Git Service. To respo

[incubator-skywalking] branch master updated: Update: update ui trace-tree (#2128)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new cb905f0 Update: update ui trace-

[GitHub] coveralls commented on issue #2128: Update: update ui trace-tree

2019-01-07 Thread GitBox
coveralls commented on issue #2128: Update: update ui trace-tree URL: https://github.com/apache/incubator-skywalking/pull/2128#issuecomment-452153356 [![Coverage Status](https://coveralls.io/builds/20951997/badge)](https://coveralls.io/builds/20951997) Coverage remained the same

[GitHub] wu-sheng closed pull request #2128: Update: update ui trace-tree

2019-01-07 Thread GitBox
wu-sheng closed pull request #2128: Update: update ui trace-tree URL: https://github.com/apache/incubator-skywalking/pull/2128 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] wu-sheng commented on issue #2130: add user info of Youzan.com

2019-01-07 Thread GitBox
wu-sheng commented on issue #2130: add user info of Youzan.com URL: https://github.com/apache/incubator-skywalking/pull/2130#issuecomment-452153434 Ref #443 This is an automated message from the Apache Git Service. To respon

[GitHub] coveralls commented on issue #2130: add user info of Youzan.com

2019-01-07 Thread GitBox
coveralls commented on issue #2130: add user info of Youzan.com URL: https://github.com/apache/incubator-skywalking/pull/2130#issuecomment-452158603 [![Coverage Status](https://coveralls.io/builds/20952319/badge)](https://coveralls.io/builds/20952319) Coverage decreased (-0.002%

[GitHub] wu-sheng closed pull request #2130: add user info of Youzan.com

2019-01-07 Thread GitBox
wu-sheng closed pull request #2130: add user info of Youzan.com URL: https://github.com/apache/incubator-skywalking/pull/2130 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[incubator-skywalking] branch master updated: add user info of Youzan.com (#2130)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new f61a927 add user info of Youzan.

[incubator-skywalking] branch prometheus updated: Finish all telemetry metric.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/prometheus by this push: new ae63e10 Finish all telem

[incubator-skywalking] branch prometheus updated: Fix format.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/prometheus by this push: new fd76182 Fix format. fd76

[GitHub] wu-sheng commented on issue #2124: Just register entry and exit span op names.

2019-01-07 Thread GitBox
wu-sheng commented on issue #2124: Just register entry and exit span op names. URL: https://github.com/apache/incubator-skywalking/pull/2124#issuecomment-452166356 @peng-yongsheng I am closing this. Don't register local span could cause ref endpoint broken. I need to think more about this.

[GitHub] wu-sheng closed pull request #2124: Just register entry and exit span op names.

2019-01-07 Thread GitBox
wu-sheng closed pull request #2124: Just register entry and exit span op names. URL: https://github.com/apache/incubator-skywalking/pull/2124 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] woshijay7788 opened a new issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null

2019-01-07 Thread GitBox
woshijay7788 opened a new issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null URL: https://github.com/apache/incubator-skywalking/issues/2131 2019-01-08 11:50:19,398 - org.apache.skywalking.apm.collecto

[GitHub] wu-sheng closed issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null

2019-01-07 Thread GitBox
wu-sheng closed issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null URL: https://github.com/apache/incubator-skywalking/issues/2131 This

[GitHub] wu-sheng commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null

2019-01-07 Thread GitBox
wu-sheng commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null URL: https://github.com/apache/incubator-skywalking/issues/2131#issuecomment-452168411 Look like you delete the inventory data i

[GitHub] woshijay7788 commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null

2019-01-07 Thread GitBox
woshijay7788 commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null URL: https://github.com/apache/incubator-skywalking/issues/2131#issuecomment-452169158 I have more than 40 application, rebo

[GitHub] wu-sheng commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null

2019-01-07 Thread GitBox
wu-sheng commented on issue #2131: org.apache.skywalking.apm.collector.analysis.segment.parser.provider.parser.SegmentParse:java.lang.NullPointerException: null URL: https://github.com/apache/incubator-skywalking/issues/2131#issuecomment-452170198 The reason is you deleting the data. Righ

[GitHub] wu-sheng commented on issue #2073: Set a telemetry module for backend, and provide Prometheus as default implementation

2019-01-07 Thread GitBox
wu-sheng commented on issue #2073: Set a telemetry module for backend, and provide Prometheus as default implementation URL: https://github.com/apache/incubator-skywalking/issues/2073#issuecomment-452192975 This is the telemetry set I got ``` # HELP persistence_timer_bulk_prepare

[incubator-skywalking] branch prometheus updated: Make telemetry works.

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/prometheus by this push: new c84db10 Make telemetry w

[GitHub] ywf4026 opened a new issue #2132: Does Motan plugin support cross-thread call?

2019-01-07 Thread GitBox
ywf4026 opened a new issue #2132: Does Motan plugin support cross-thread call? URL: https://github.com/apache/incubator-skywalking/issues/2132 I created a thread B from the main thread A, the thread B executed a motan rpc call, then I found the motan rpc call had a different traceid.

[GitHub] wu-sheng opened a new pull request #2133: Implement Prometheus to oap backend telemetry

2019-01-07 Thread GitBox
wu-sheng opened a new pull request #2133: Implement Prometheus to oap backend telemetry URL: https://github.com/apache/incubator-skywalking/pull/2133 This pull request follows #2073 to set Prometheus as first oap telemetry module implementation. ---

[incubator-skywalking] branch prometheus updated (c84db10 -> a396df8)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from c84db10 Make telemetry works. add a396df8 Support JVM metrics. No new revisions were added

[GitHub] wu-sheng commented on issue #2132: Does Motan plugin support cross-thread call?

2019-01-07 Thread GitBox
wu-sheng commented on issue #2132: Does Motan plugin support cross-thread call? URL: https://github.com/apache/incubator-skywalking/issues/2132#issuecomment-452195686 Read https://github.com/apache/incubator-skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit

[GitHub] wu-sheng closed issue #2132: Does Motan plugin support cross-thread call?

2019-01-07 Thread GitBox
wu-sheng closed issue #2132: Does Motan plugin support cross-thread call? URL: https://github.com/apache/incubator-skywalking/issues/2132 This is an automated message from the Apache Git Service. To respond to the message, p

[incubator-skywalking] branch prometheus updated (a396df8 -> 85c16f8)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from a396df8 Support JVM metrics. add 85c16f8 Add doc for telemetry. No new revisions were adde

[incubator-skywalking] branch prometheus updated (85c16f8 -> 51f97f3)

2019-01-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch prometheus in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. from 85c16f8 Add doc for telemetry. add 51f97f3 Fix typo. No new revisions were added by this u

[GitHub] coveralls commented on issue #2133: Implement Prometheus to oap backend telemetry

2019-01-07 Thread GitBox
coveralls commented on issue #2133: Implement Prometheus to oap backend telemetry URL: https://github.com/apache/incubator-skywalking/pull/2133#issuecomment-452200445 [![Coverage Status](https://coveralls.io/builds/20954483/badge)](https://coveralls.io/builds/20954483) Coverage

[GitHub] coveralls edited a comment on issue #2133: Implement Prometheus to oap backend telemetry

2019-01-07 Thread GitBox
coveralls edited a comment on issue #2133: Implement Prometheus to oap backend telemetry URL: https://github.com/apache/incubator-skywalking/pull/2133#issuecomment-452200445 [![Coverage Status](https://coveralls.io/builds/20954676/badge)](https://coveralls.io/builds/20954676) C