[GitHub] coveralls commented on issue #2165: fixed the index name to format name in logs

2019-01-15 Thread GitBox
coveralls commented on issue #2165: fixed the index name to format name in logs URL: https://github.com/apache/incubator-skywalking/pull/2165#issuecomment-454683989 [![Coverage Status](https://coveralls.io/builds/21099865/badge)](https://coveralls.io/builds/21099865) Coverage d

[GitHub] wu-sheng commented on a change in pull request #2165: fixed the index name to format name in logs

2019-01-15 Thread GitBox
wu-sheng commented on a change in pull request #2165: fixed the index name to format name in logs URL: https://github.com/apache/incubator-skywalking/pull/2165#discussion_r248167554 ## File path: oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/ser

[GitHub] a198720 opened a new pull request #2165: fixed the index name to format name in logs

2019-01-15 Thread GitBox
a198720 opened a new pull request #2165: fixed the index name to format name in logs URL: https://github.com/apache/incubator-skywalking/pull/2165 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provi

[GitHub] wu-sheng commented on issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql

2019-01-15 Thread GitBox
wu-sheng commented on issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql URL: https://github.com/apache/incubator-skywalking/issues/2164#issuecomment-454643196 Which version of skywalking? I think you don't follow our documents. --

[GitHub] wu-sheng closed issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql

2019-01-15 Thread GitBox
wu-sheng closed issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql URL: https://github.com/apache/incubator-skywalking/issues/2164 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] xiaour opened a new issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql

2019-01-15 Thread GitBox
xiaour opened a new issue #2164: Request Error 500: http://127.0.0.1:8080/api/graphql URL: https://github.com/apache/incubator-skywalking/issues/2164 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ Request Error 500: http://127.0.0.1

[GitHub] zhaoyuguang commented on issue #2152: [WIP]Support lettuce plugin

2019-01-15 Thread GitBox
zhaoyuguang commented on issue #2152: [WIP]Support lettuce plugin URL: https://github.com/apache/incubator-skywalking/pull/2152#issuecomment-454639369 All right! This is an automated message from the Apache Git Service. To re

[GitHub] wu-sheng commented on issue #2152: [WIP]Support lettuce plugin

2019-01-15 Thread GitBox
wu-sheng commented on issue #2152: [WIP]Support lettuce plugin URL: https://github.com/apache/incubator-skywalking/pull/2152#issuecomment-454638808 Sure. Take your time. The codes are going to be frozen at the end of this week for GA. So let's put this feature into 6.1 ---

[GitHub] zhaoyuguang commented on issue #2152: Support lettuce plugin

2019-01-15 Thread GitBox
zhaoyuguang commented on issue #2152: Support lettuce plugin URL: https://github.com/apache/incubator-skywalking/pull/2152#issuecomment-454632010 Thanks for your guidance, lettuce versions 5.0.0~5.1.3 maven compiler by java8, I will put it in the optional plugin, so I will open [WIP] again

[GitHub] coveralls edited a comment on issue #2146: add serviceInstanceId in Segment storage.

2019-01-15 Thread GitBox
coveralls edited a comment on issue #2146: add serviceInstanceId in Segment storage. URL: https://github.com/apache/incubator-skywalking/pull/2146#issuecomment-453543563 [![Coverage Status](https://coveralls.io/builds/21097088/badge)](https://coveralls.io/builds/21097088) Cover

[GitHub] wu-sheng commented on issue #2149: Why is my link broken into two?

2019-01-15 Thread GitBox
wu-sheng commented on issue #2149: Why is my link broken into two? URL: https://github.com/apache/incubator-skywalking/issues/2149#issuecomment-454405749 We have just fixed a serious bug, https://github.com/apache/incubator-skywalking/pull/2162 , which could lose trace and break topology.

[GitHub] liyongfa0311 commented on issue #2149: Why is my link broken into two?

2019-01-15 Thread GitBox
liyongfa0311 commented on issue #2149: Why is my link broken into two? URL: https://github.com/apache/incubator-skywalking/issues/2149#issuecomment-454394966 I'm sure I'm using the v6 agent all the time; I tried the 6.0.0-Apache version again today.Project-e calling project-mysql is normal

[GitHub] wu-sheng closed issue #2163: ServiceAndEndpointRegisterClient execute fail.

2019-01-15 Thread GitBox
wu-sheng closed issue #2163: ServiceAndEndpointRegisterClient execute fail. URL: https://github.com/apache/incubator-skywalking/issues/2163 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] wu-sheng commented on issue #2163: ServiceAndEndpointRegisterClient execute fail.

2019-01-15 Thread GitBox
wu-sheng commented on issue #2163: ServiceAndEndpointRegisterClient execute fail. URL: https://github.com/apache/incubator-skywalking/issues/2163#issuecomment-454379786 Do you set to grpc port? And are you using the backend with same version? It is a very easy error, the codes don't matc

[incubator-skywalking] Diff for: [GitHub] wu-sheng merged pull request #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
diff --git a/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/parser/standardization/ReferenceIdExchanger.java b/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/sk

[incubator-skywalking] branch master updated: Un-exchanged endpoint name in ref can't find the id (#2162)

2019-01-15 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new a3e03f6 Un-exchanged endpoint na

[GitHub] wu-sheng merged pull request #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
wu-sheng merged pull request #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, notifications@skywalking.apache.org -

[GitHub] langyan1022 commented on issue #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
langyan1022 commented on issue #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454377687 > @langyan1022 I changed your code comments and pull request title. I am making the code comments describing the w

[GitHub] coveralls edited a comment on issue #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
coveralls edited a comment on issue #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454357914 [![Coverage Status](https://coveralls.io/builds/21081077/badge)](https://coveralls.io/builds/21081077)

[GitHub] wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454370018 FYI @peng-yongsheng This is an automated message fr

[GitHub] wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454368846 The root cause of this issue is, the endpoint name in ref, if it is from local span, then it wouldn't be set as id al

[GitHub] wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id

2019-01-15 Thread GitBox
wu-sheng commented on issue #2162: Un-exchanged endpoint name in ref can't find the id URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454368393 @langyan1022 I changed your code comments and pull request title. I am making the code comments describing the what c

[GitHub] sanxun0325 opened a new issue #2163: ServiceAndEndpointRegisterClient execute fail.

2019-01-15 Thread GitBox
sanxun0325 opened a new issue #2163: ServiceAndEndpointRegisterClient execute fail. URL: https://github.com/apache/incubator-skywalking/issues/2163 The following problems were encountered when starting the agent: INFO 2019-01-15 19:46:16:175 AgentClassLoader : C:\apache-skywal

[GitHub] coveralls edited a comment on issue #2162: Update ReferenceIdExchanger.java

2019-01-15 Thread GitBox
coveralls edited a comment on issue #2162: Update ReferenceIdExchanger.java URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454357914 [![Coverage Status](https://coveralls.io/builds/21080157/badge)](https://coveralls.io/builds/21080157) Coverage decrea

[GitHub] coveralls edited a comment on issue #2162: Update ReferenceIdExchanger.java

2019-01-15 Thread GitBox
coveralls edited a comment on issue #2162: Update ReferenceIdExchanger.java URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454357914 [![Coverage Status](https://coveralls.io/builds/21080102/badge)](https://coveralls.io/builds/21080102) Coverage decrea

[GitHub] coveralls commented on issue #2162: Update ReferenceIdExchanger.java

2019-01-15 Thread GitBox
coveralls commented on issue #2162: Update ReferenceIdExchanger.java URL: https://github.com/apache/incubator-skywalking/pull/2162#issuecomment-454357914 [![Coverage Status](https://coveralls.io/builds/21079894/badge)](https://coveralls.io/builds/21079894) Coverage decreased (-0

[GitHub] langyan1022 closed issue #2134: Hystrix Or agent core bug

2019-01-15 Thread GitBox
langyan1022 closed issue #2134: Hystrix Or agent core bug URL: https://github.com/apache/incubator-skywalking/issues/2134 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] langyan1022 opened a new pull request #2162: Update ReferenceIdExchanger.java

2019-01-15 Thread GitBox
langyan1022 opened a new pull request #2162: Update ReferenceIdExchanger.java URL: https://github.com/apache/incubator-skywalking/pull/2162 Please answer these questions before submitting pull request - Why submit this pull request? - [X] Bug fix - [ ] New feature provided -

[GitHub] jjlu521016 edited a comment on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2019-01-15 Thread GitBox
jjlu521016 edited a comment on issue #2104: Support spring-rabbit plugin for 1.x and 2.x URL: https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-454330420 @wu-sheng not yet , if i had good idea,i will give PR

[GitHub] jjlu521016 commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x

2019-01-15 Thread GitBox
jjlu521016 commented on issue #2104: Support spring-rabbit plugin for 1.x and 2.x URL: https://github.com/apache/incubator-skywalking/pull/2104#issuecomment-454330420 @wu-sheng not any update , if i had good idea,i will give PR