[GitHub] [incubator-skywalking] wu-sheng closed issue #2317: what's the difference of ServiceHandler and ReportServiceHandler?

2019-03-04 Thread GitBox
wu-sheng closed issue #2317: what's the difference of ServiceHandler and ReportServiceHandler? URL: https://github.com/apache/incubator-skywalking/issues/2317 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2317: what's the difference of ServiceHandler and ReportServiceHandler?

2019-03-04 Thread GitBox
wu-sheng commented on issue #2317: what's the difference of ServiceHandler and ReportServiceHandler? URL: https://github.com/apache/incubator-skywalking/issues/2317#issuecomment-469554487 There are for different versions of protocol. We have upgraded the protocol, because of concept chang

[GitHub] [incubator-skywalking] sidawei opened a new issue #2317: what's the difference of TraceSegmentServiceHandler and TraceSegmentReportServiceHandler, JVMMetricsServiceHandler and JVMMetricReport

2019-03-04 Thread GitBox
sidawei opened a new issue #2317: what's the difference of TraceSegmentServiceHandler and TraceSegmentReportServiceHandler, JVMMetricsServiceHandler and JVMMetricReportServiceHandler? URL: https://github.com/apache/incubator-skywalking/issues/2317 - Why do you submit this issue? - [

[GitHub] [incubator-skywalking] ywf4026 opened a new issue #2316: agent 6.0.0GA is not compatible with tomcat 7.0.42

2019-03-04 Thread GitBox
ywf4026 opened a new issue #2316: agent 6.0.0GA is not compatible with tomcat 7.0.42 URL: https://github.com/apache/incubator-skywalking/issues/2316 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ √] Question or discussion - [ ] B

[GitHub] [incubator-skywalking] ascrutae commented on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
ascrutae commented on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469509544 This case is more common in some business environment, I will try to fix it in this version. ---

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
wu-sheng commented on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469508107 I think that is the exact case. You call between controllers. This is an

[GitHub] [incubator-skywalking] mbao commented on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
mbao commented on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469506596 > Why call the method twice? > > cc @ascrutae We need to avoid this issue, but I just don't know why this happens. Not one meth

[GitHub] [incubator-skywalking] vanlin edited a comment on issue #2308: [agent]java.lang.NullPointerException: null with apm-spring-annotation-plugin-6.0.0-GA.jar

2019-03-04 Thread GitBox
vanlin edited a comment on issue #2308: [agent]java.lang.NullPointerException: null with apm-spring-annotation-plugin-6.0.0-GA.jar URL: https://github.com/apache/incubator-skywalking/issues/2308#issuecomment-469282947 hi @candyleer, please look at this : https://github.com/vanlin/service

[GitHub] [incubator-skywalking] vanlin commented on issue #2308: [agent]java.lang.NullPointerException: null with apm-spring-annotation-plugin-6.0.0-GA.jar

2019-03-04 Thread GitBox
vanlin commented on issue #2308: [agent]java.lang.NullPointerException: null with apm-spring-annotation-plugin-6.0.0-GA.jar URL: https://github.com/apache/incubator-skywalking/issues/2308#issuecomment-469282947 hi @candyleer, look this please: https://github.com/vanlin/servicecombtest -

[GitHub] [incubator-skywalking] JaredTan95 merged pull request #2315: remove cn docs.

2019-03-04 Thread GitBox
JaredTan95 merged pull request #2315: remove cn docs. URL: https://github.com/apache/incubator-skywalking/pull/2315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-skywalking] branch master updated: remove cn docs. (#2315)

2019-03-04 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new c50c804 remove cn docs. (#2315)

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2315: remove cn docs.

2019-03-04 Thread GitBox
wu-sheng commented on issue #2315: remove cn docs. URL: https://github.com/apache/incubator-skywalking/pull/2315#issuecomment-469261700 Finally and sadly, we move in this way. Too many misguides because the Chinese document link. @JaredTan95 Could send the finalization mail to dev m

[GitHub] [incubator-skywalking] JaredTan95 opened a new pull request #2315: remove cn docs.

2019-03-04 Thread GitBox
JaredTan95 opened a new pull request #2315: remove cn docs. URL: https://github.com/apache/incubator-skywalking/pull/2315 In the document page, there are too many **TODO** in those files, especially in Chinese docs. This really misguides the new incomers. So, considering there is

[GitHub] [incubator-skywalking] zhaoyuguang commented on a change in pull request #2300: [WIP]Customize Enhance code of plugin

2019-03-04 Thread GitBox
zhaoyuguang commented on a change in pull request #2300: [WIP]Customize Enhance code of plugin URL: https://github.com/apache/incubator-skywalking/pull/2300#discussion_r262046134 ## File path: docs/en/setup/service-agent/java-agent/Supported-list.md ## @@ -62,6 +62,8 @@

[GitHub] [incubator-skywalking] zhaoyuguang commented on a change in pull request #2300: [WIP]Customize Enhance code of plugin

2019-03-04 Thread GitBox
zhaoyuguang commented on a change in pull request #2300: [WIP]Customize Enhance code of plugin URL: https://github.com/apache/incubator-skywalking/pull/2300#discussion_r262046108 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -89,6 +89,7 @@ Now, we h

[GitHub] [incubator-skywalking] wu-sheng edited a comment on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
wu-sheng edited a comment on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469241419 @ascrutae Look like, runtime context should be stack based for each key? I am not sure yet. -

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
wu-sheng commented on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469241419 @ascrutae Look like, runntime context should be stack based for each key? I am not sure yet. ---

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2314: spring config trace info error

2019-03-04 Thread GitBox
wu-sheng commented on issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314#issuecomment-469241250 Why call the method twice? cc @ascrutae We need to avoid this issue, but I just don't know why this happens.

[GitHub] [incubator-skywalking] mbao opened a new issue #2314: spring config trace info error

2019-03-04 Thread GitBox
mbao opened a new issue #2314: spring config trace info error URL: https://github.com/apache/incubator-skywalking/issues/2314 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion ___ ### Question -

[GitHub] [incubator-skywalking] zhangkewei commented on issue #1768: [DISCUSS] Heading to graduation

2019-03-04 Thread GitBox
zhangkewei commented on issue #1768: [DISCUSS] Heading to graduation URL: https://github.com/apache/incubator-skywalking/issues/1768#issuecomment-469162687 +1 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-skywalking] dejdong commented on issue #2312: 服务启动报错,我哪里配置错了么?

2019-03-04 Thread GitBox
dejdong commented on issue #2312: 服务启动报错,我哪里配置错了么? URL: https://github.com/apache/incubator-skywalking/issues/2312#issuecomment-469160154 thank you! This is an automated message from the Apache Git Service. To respond to the