[GitHub] [incubator-skywalking] wu-sheng commented on issue #2322: How to make receiver settings more reasonable

2019-03-08 Thread GitBox
wu-sheng commented on issue #2322: How to make receiver settings more reasonable URL: https://github.com/apache/incubator-skywalking/issues/2322#issuecomment-471150847 I am +1 for env variable. But we still need default way, and typical scenarios, right? --

[GitHub] [incubator-skywalking] liuhaoyang commented on issue #2322: How to make receiver settings more reasonable

2019-03-08 Thread GitBox
liuhaoyang commented on issue #2322: How to make receiver settings more reasonable URL: https://github.com/apache/incubator-skywalking/issues/2322#issuecomment-471150370 I prefer to use environment variables as receiver switches, providing a XXX_RECEIVER_ENABLE environment variable switch

[GitHub] [incubator-skywalking] wu-sheng closed issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher

2019-03-08 Thread GitBox
wu-sheng closed issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher URL: https://github.com/apache/incubator-skywalking/issues/2337 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher

2019-03-08 Thread GitBox
wu-sheng commented on issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher URL: https://github.com/apache/incubator-skywalking/issues/2337#issuecomment-471143342 You use the wrong way package agent jar. Please follow SkyWalking's plugin module settings. --

[GitHub] [incubator-skywalking] sunshinebaby00 opened a new issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher

2019-03-08 Thread GitBox
sunshinebaby00 opened a new issue #2337: ClassNotFoundException net.bytebuddy.matcher.ElementMatcher URL: https://github.com/apache/incubator-skywalking/issues/2337 Please answer these questions before submitting your issue. - Why do you submit this issue? - Question or discussio

[incubator-skywalking-website] branch asf-site updated (65a940f -> 730d08e)

2019-03-08 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git. discard 65a940f Update asf-site new 730d08e Update asf-site This update added new revisions

[GitHub] [incubator-skywalking-website] wu-sheng merged pull request #40: Fix typo.

2019-03-08 Thread GitBox
wu-sheng merged pull request #40: Fix typo. URL: https://github.com/apache/incubator-skywalking-website/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[incubator-skywalking-website] branch master updated: Fix typo. (#40)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new d705578 Fix typo. (#40)

[GitHub] [incubator-skywalking-website] agile6v opened a new pull request #40: Fix typo.

2019-03-08 Thread GitBox
agile6v opened a new pull request #40: Fix typo. URL: https://github.com/apache/incubator-skywalking-website/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-skywalking] coveralls commented on issue #2336: If the node has no interaction, then it disappear in topology.

2019-03-08 Thread GitBox
coveralls commented on issue #2336: If the node has no interaction, then it disappear in topology. URL: https://github.com/apache/incubator-skywalking/pull/2336#issuecomment-470985449 [![Coverage Status](https://coveralls.io/builds/22069650/badge)](https://coveralls.io/builds/22069650

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2336: If the node has no interaction, then it disappear in topology.

2019-03-08 Thread GitBox
wu-sheng opened a new pull request #2336: If the node has no interaction, then it disappear in topology. URL: https://github.com/apache/incubator-skywalking/pull/2336 In the hybrid scenario, some nodes will show in the topology with complex reasons. Let's keep this as simple as possible fo

[incubator-skywalking] 01/01: If the node has no interaction, then it disappear in topology.

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch topology in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit c9a101bad7d97901d4880e49373421ceeddc5eeb Author: Wu Sheng AuthorDate: Fri Mar 8 23:35:35 2019 +0800

[incubator-skywalking] branch topology created (now c9a101b)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch topology in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at c9a101b If the node has no interaction, then it disappear in topology. This branch includes the fo

[GitHub] [incubator-skywalking] JaredTan95 edited a comment on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
JaredTan95 edited a comment on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470937002 @kezhenxu94 Hi, Glad to hear that you have interests in helping the community to build doc or

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470937401 > of course I wil :) I've subscribe to the ML and just receive the celebration of 100th contributor :)

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470936987 @wu-sheng of course I wil :) I've subscribe to the ML and just receive the celebration of 100th contr

[GitHub] [incubator-skywalking] JaredTan95 edited a comment on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
JaredTan95 edited a comment on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470937002 @kezhenxu94 @brucewu-fly Hi, Glad to hear that you have interests in helping the community to

[GitHub] [incubator-skywalking] JaredTan95 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
JaredTan95 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470937002 @kezhenxu94 Hi, Glad to hear that you have interests in helping the community to build doc or site. L

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470933874 Sure. Feel free to discuss here or on d...@skywalking.apache.org ml. I noticed you are an Apache commit

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470933130 > we need to consider to provide documents for each release. @wu-sheng provident opinion, I'll

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470930446 @kezhenxu94 Make sense to me. You have the `admin` role in that repo, go for it. Also, please consider,

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470929648 @wu-sheng yes that's my thought, many open-sourced projects have a separate repo to hold their docume

[GitHub] [incubator-skywalking] coveralls commented on issue #2335: Separation the remote gRPC server from the receiver gRPC server.

2019-03-08 Thread GitBox
coveralls commented on issue #2335: Separation the remote gRPC server from the receiver gRPC server. URL: https://github.com/apache/incubator-skywalking/pull/2335#issuecomment-470929346 [![Coverage Status](https://coveralls.io/builds/22066831/badge)](https://coveralls.io/builds/220668

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2309: When creating elastic search index, the index that can delete histori…

2019-03-08 Thread GitBox
wu-sheng commented on issue #2309: When creating elastic search index, the index that can delete histori… URL: https://github.com/apache/incubator-skywalking/pull/2309#issuecomment-470926952 > queryTrace by trace id is really needs the UI to be modified or we can try to search from the re

[GitHub] [incubator-skywalking] peng-yongsheng commented on issue #2335: Separation the remote gRPC server from the receiver gRPC server.

2019-03-08 Thread GitBox
peng-yongsheng commented on issue #2335: Separation the remote gRPC server from the receiver gRPC server. URL: https://github.com/apache/incubator-skywalking/pull/2335#issuecomment-470926741 > Codes make sense to me. Just one suggestion, share should be sharing. Share in your meaning is v

[GitHub] [incubator-skywalking] peng-yongsheng commented on issue #2309: When creating elastic search index, the index that can delete histori…

2019-03-08 Thread GitBox
peng-yongsheng commented on issue #2309: When creating elastic search index, the index that can delete histori… URL: https://github.com/apache/incubator-skywalking/pull/2309#issuecomment-470926118 @yeerpeng @wu-sheng 1. From the previous pressure measurement, the record insertion and d

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470924523 If you want to publish it as GitHub Pages page, let me known. -

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470924371 @kezhenxu94 Invite you to https://github.com/SkyAPM/document-cn-translation-of-skywalking

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2322: How to make receiver settings more reasonable

2019-03-08 Thread GitBox
wu-sheng commented on issue #2322: How to make receiver settings more reasonable URL: https://github.com/apache/incubator-skywalking/issues/2322#issuecomment-470923616 I am thinking of something else than the principle. I think we can't say `turn on` agent only is the right call, be

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470920981 @wu-sheng I'd like to work on this, and study SkyWalking further by this chance, but again, the trans

[GitHub] [incubator-skywalking] peng-yongsheng commented on issue #2322: How to make receiver settings more reasonable

2019-03-08 Thread GitBox
peng-yongsheng commented on issue #2322: How to make receiver settings more reasonable URL: https://github.com/apache/incubator-skywalking/issues/2322#issuecomment-470916596 ### Current configuration Turn on * receiver-register * receiver-trace * receiver-jvm * service-

[GitHub] [incubator-skywalking] wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
wu-sheng commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470915589 @kezhenxu94 Yes, we used to have part document, which misguide users to read. They think, SkyWalking do

[GitHub] [incubator-skywalking] peng-yongsheng commented on issue #2327: Separation the remote gRPC server from the receiver gRPC server.

2019-03-08 Thread GitBox
peng-yongsheng commented on issue #2327: Separation the remote gRPC server from the receiver gRPC server. URL: https://github.com/apache/incubator-skywalking/issues/2327#issuecomment-470914851 Optional, just for advanced user. --

[GitHub] [incubator-skywalking] peng-yongsheng opened a new pull request #2335: Separation the remote gRPC server from the receiver gRPC server.

2019-03-08 Thread GitBox
peng-yongsheng opened a new pull request #2335: Separation the remote gRPC server from the receiver gRPC server. URL: https://github.com/apache/incubator-skywalking/pull/2335 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese

2019-03-08 Thread GitBox
kezhenxu94 commented on issue #1360: Look volunteers to translate(sync) English documents to Chinese URL: https://github.com/apache/incubator-skywalking/issues/1360#issuecomment-470909509 The task is a good start for those who are new to SkyWalking and are interested in translating (like

[GitHub] [incubator-skywalking] coveralls commented on issue #2300: [WIP]Customize Enhance code of plugin

2019-03-08 Thread GitBox
coveralls commented on issue #2300: [WIP]Customize Enhance code of plugin URL: https://github.com/apache/incubator-skywalking/pull/2300#issuecomment-470908746 [![Coverage Status](https://coveralls.io/builds/22065789/badge)](https://coveralls.io/builds/22065789) Coverage increase

[incubator-skywalking] branch bug-fix deleted (was 4c7082c)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch bug-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was 4c7082c Envoy heartbeat update bug The revisions that were on this branch are still contained in ot

[incubator-skywalking] branch master updated: Envoy heartbeat update bug (#2334)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 93347b2 Envoy heartbeat update b

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2334: Envoy heartbeat update bug

2019-03-08 Thread GitBox
wu-sheng merged pull request #2334: Envoy heartbeat update bug URL: https://github.com/apache/incubator-skywalking/pull/2334 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-skywalking] coveralls commented on issue #2334: Envoy heartbeat update bug

2019-03-08 Thread GitBox
coveralls commented on issue #2334: Envoy heartbeat update bug URL: https://github.com/apache/incubator-skywalking/pull/2334#issuecomment-470865971 [![Coverage Status](https://coveralls.io/builds/22063555/badge)](https://coveralls.io/builds/22063555) Coverage decreased (-0.002%)

[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2334: Envoy heartbeat update bug

2019-03-08 Thread GitBox
wu-sheng opened a new pull request #2334: Envoy heartbeat update bug URL: https://github.com/apache/incubator-skywalking/pull/2334 Heartbeat doesn't update. This is an automated message from the Apache Git Service. To respond

[incubator-skywalking] 01/01: Envoy heartbeat update bug

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch bug-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git commit 4c7082c0850992a99626aaace01e0c5d3c5f36f6 Author: Wu Sheng AuthorDate: Fri Mar 8 16:48:53 2019 +0800

[incubator-skywalking] branch bug-fix created (now 4c7082c)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch bug-fix in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. at 4c7082c Envoy heartbeat update bug This branch includes the following new commits: new 4c7082

[incubator-skywalking] branch master updated: Bug fix. (#2333)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new c2a7e8e Bug fix. (#2333) c2a7e8e

[incubator-skywalking] branch wrong-field deleted (was ff4eccc)

2019-03-08 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wrong-field in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git. was ff4eccc Merge branch 'master' into wrong-field The revisions that were on this branch are still

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2333: Wrong default field in all service instance related scope

2019-03-08 Thread GitBox
wu-sheng merged pull request #2333: Wrong default field in all service instance related scope URL: https://github.com/apache/incubator-skywalking/pull/2333 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2333: Wrong default field in all service instance related scope

2019-03-08 Thread GitBox
coveralls edited a comment on issue #2333: Wrong default field in all service instance related scope URL: https://github.com/apache/incubator-skywalking/pull/2333#issuecomment-470836351 [![Coverage Status](https://coveralls.io/builds/22062426/badge)](https://coveralls.io/builds/220624