[GitHub] [incubator-skywalking] coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
coveralls edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474659408 [![Coverage Status](https://coveralls.io/builds/22786095/badge)](https://coveralls.io/builds/22786095) Coverage decreased (-0.00

[GitHub] [incubator-skywalking] coki230 commented on issue #2443: i want monitor c and c++, what can i do?

2019-04-13 Thread GitBox
coki230 commented on issue #2443: i want monitor c and c++, what can i do? URL: https://github.com/apache/incubator-skywalking/issues/2443#issuecomment-482805383 thank you very much. do you have any book which learn APM or skywalking to recommend --

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2443: i want monitor c and c++, what can i do?

2019-04-13 Thread GitBox
wu-sheng commented on issue #2443: i want monitor c and c++, what can i do? URL: https://github.com/apache/incubator-skywalking/issues/2443#issuecomment-482806256 @coki230 Assuming you could read Chinese(from your profile), I used to write part of this book, https://item.jd.com/12498217.ht

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2443: i want monitor c and c++, what can i do?

2019-04-13 Thread GitBox
wu-sheng commented on issue #2443: i want monitor c and c++, what can i do? URL: https://github.com/apache/incubator-skywalking/issues/2443#issuecomment-482806362 @dio The community is calling you :P This is an automated mess

[GitHub] [incubator-skywalking] SkyWalkingRobot commented on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
SkyWalkingRobot commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482820412 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/4/bfergerson/testReport-master-201

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482825099 3.3+, do you want 3.1 and 3.2 supported? This is an automated message from the Apa

[GitHub] [incubator-skywalking] wu-sheng edited a comment on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
wu-sheng edited a comment on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482825099 3.3+ works, do you want 3.1 and 3.2 supported? This is an automated message

[GitHub] [incubator-skywalking] BFergerson commented on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482831750 @wu-sheng, I should be able to get it to support 3.2+. This is when Vert.x introduced the `ClusteredMessage` which is what I use to tell if a mes

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
wu-sheng commented on issue #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482897177 3.x in name should be fine. Can you confirm two thing? 1. This plugin wouldn't make 3.0 and 3.1 codes break 2. Supported list document includ

[incubator-skywalking] branch master updated: Fix create multiple EntrySpan (#2482)

2019-04-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2f8e19f Fix create multiple Entr

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2482: Fix webflux-plugin create multiple EntrySpan

2019-04-13 Thread GitBox
wu-sheng merged pull request #2482: Fix webflux-plugin create multiple EntrySpan URL: https://github.com/apache/incubator-skywalking/pull/2482 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-skywalking] wu-sheng commented on a change in pull request #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
wu-sheng commented on a change in pull request #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#discussion_r275136447 ## File path: docs/en/setup/service-agent/java-agent/Supported-list.md ## @@ -63,6 +63,8 @@ * [Canal: Alibaba m

[GitHub] [incubator-skywalking] wu-sheng commented on a change in pull request #2386: Vert.x Core 3.x Plugin

2019-04-13 Thread GitBox
wu-sheng commented on a change in pull request #2386: Vert.x Core 3.x Plugin URL: https://github.com/apache/incubator-skywalking/pull/2386#discussion_r275136454 ## File path: apm-sniffer/apm-sdk-plugin/vertx-plugins/vertx-core-3.x-plugin/src/main/java/org/apache/skywalking/apm/plug

[GitHub] [incubator-skywalking] kezhenxu94 opened a new pull request #2483: Fix typo and grammar error

2019-04-13 Thread GitBox
kezhenxu94 opened a new pull request #2483: Fix typo and grammar error URL: https://github.com/apache/incubator-skywalking/pull/2483 FYI, recently I'm undertaking the translation work so I might open some PR's that's trivial (fixing typos or grammar errors) when I find issues in the Englis

[GitHub] [incubator-skywalking] kezhenxu94 closed issue #2338: [Bug] Login button is still disabled after failure

2019-04-13 Thread GitBox
kezhenxu94 closed issue #2338: [Bug] Login button is still disabled after failure URL: https://github.com/apache/incubator-skywalking/issues/2338 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-skywalking] kezhenxu94 commented on issue #2338: [Bug] Login button is still disabled after failure

2019-04-13 Thread GitBox
kezhenxu94 commented on issue #2338: [Bug] Login button is still disabled after failure URL: https://github.com/apache/incubator-skywalking/issues/2338#issuecomment-482911446 I think this is a rarely-appeared bug and since the RocketBot UI is going to replace the current UI, I'll close th

[GitHub] [incubator-skywalking] wu-sheng commented on issue #2483: Fix typo and grammar error

2019-04-13 Thread GitBox
wu-sheng commented on issue #2483: Fix typo and grammar error URL: https://github.com/apache/incubator-skywalking/pull/2483#issuecomment-482912729 Appreciate you do this. I wrote too many documents, need recheck. This is an a

[GitHub] [incubator-skywalking] coveralls commented on issue #2483: Fix typo and grammar error

2019-04-13 Thread GitBox
coveralls commented on issue #2483: Fix typo and grammar error URL: https://github.com/apache/incubator-skywalking/pull/2483#issuecomment-482913351 [![Coverage Status](https://coveralls.io/builds/22794799/badge)](https://coveralls.io/builds/22794799) Coverage decreased (-0.002%)

[incubator-skywalking] branch master updated: Fix typo and grammar error (#2483)

2019-04-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git The following commit(s) were added to refs/heads/master by this push: new c27f36a Fix typo and grammar err

[GitHub] [incubator-skywalking] wu-sheng merged pull request #2483: Fix typo and grammar error

2019-04-13 Thread GitBox
wu-sheng merged pull request #2483: Fix typo and grammar error URL: https://github.com/apache/incubator-skywalking/pull/2483 This is an automated message from the Apache Git Service. To respond to the message, please log on t