[GitHub] [skywalking] wu-sheng commented on issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
wu-sheng commented on issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634#issuecomment-490767835 I hope I could have some time to write that, it is a long story, need several days to organize the whole document actually. --

[GitHub] [skywalking] wu-sheng commented on issue #2638: 运行一段时间后上报数据失败

2019-05-08 Thread GitBox
wu-sheng commented on issue #2638: 运行一段时间后上报数据失败 URL: https://github.com/apache/skywalking/issues/2638#issuecomment-490760593 > DEBUG 2019-05-09 09:17:48:103 DubboServerHandler-10.42.188.146:20883-thread-62 TraceSegmentServiceClient : One trace segment has been abandoned, cause by buffer i

[GitHub] [skywalking] wu-sheng closed issue #2638: 运行一段时间后上报数据失败

2019-05-08 Thread GitBox
wu-sheng closed issue #2638: 运行一段时间后上报数据失败 URL: https://github.com/apache/skywalking/issues/2638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [skywalking] duanzonglong opened a new issue #2638: 运行一段时间后上报数据失败

2019-05-08 Thread GitBox
duanzonglong opened a new issue #2638: 运行一段时间后上报数据失败 URL: https://github.com/apache/skywalking/issues/2638 ___ ### Bug 6.1.0 docker tomcat:7.0.77-jre8 - c-wms.com - What happen? 运行一段时间后 所有的节点都无法上报信息 必须重启agent所在服务 一下错误是我查找其中一个节点的消息 DEBUG 2019-05-09 09:17:48:1

[GitHub] [skywalking] huangwei2013 commented on issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
huangwei2013 commented on issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634#issuecomment-490755164 Yeah, it's kind of a extension. SW may offer some guides of plugin, about how to make better use of the data --

[GitHub] [skywalking] liudantop opened a new issue #2637: pring MVC/Tomcat plugin can not output tracing data if current request is forward request.

2019-05-08 Thread GitBox
liudantop opened a new issue #2637: pring MVC/Tomcat plugin can not output tracing data if current request is forward request. URL: https://github.com/apache/skywalking/issues/2637 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Qu

[GitHub] [skywalking] zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin

2019-05-08 Thread GitBox
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490741815 > OK. I has ping @ascrutae to deal with your other PRs. OK This is an au

[GitHub] [skywalking] wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin

2019-05-08 Thread GitBox
wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490741472 OK. I has ping @ascrutae to deal with your other PRs. This is an automated message

[GitHub] [skywalking] zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin

2019-05-08 Thread GitBox
zhaoyuguang commented on issue #2517: [WIP]Spring cloud gateways plugin URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490741126 > We need to add witness class for this plugin, right? Yes, I am still trying to be compatible with the low version -

[GitHub] [skywalking] wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin

2019-05-08 Thread GitBox
wu-sheng commented on issue #2517: [WIP]Spring cloud gateways plugin URL: https://github.com/apache/skywalking/pull/2517#issuecomment-490740877 We need to add witness class for this plugin, right? This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files?

2019-05-08 Thread GitBox
wu-sheng commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files? URL: https://github.com/apache/skywalking/issues/2633#issuecomment-490721607 Read the agent setup document. This is an au

[GitHub] [skywalking] polaris952 commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files?

2019-05-08 Thread GitBox
polaris952 commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files? URL: https://github.com/apache/skywalking/issues/2633#issuecomment-490719123 > We don't have this. Contribution is welcome. thank you for your reply, is it possible to simply di

[GitHub] [skywalking] IanCao edited a comment on issue #2605: Support span#error in toolkit

2019-05-08 Thread GitBox
IanCao edited a comment on issue #2605: Support span#error in toolkit URL: https://github.com/apache/skywalking/pull/2605#issuecomment-490718676 > Application toolkit document should update, and add an [integration test case](https://github.com/SkyAPMTest/agent-auto-integration-testcases) f

[GitHub] [skywalking] IanCao commented on issue #2605: Support span#error in toolkit

2019-05-08 Thread GitBox
IanCao commented on issue #2605: Support span#error in toolkit URL: https://github.com/apache/skywalking/pull/2605#issuecomment-490718676 > Application toolkit document should update, and add an [integration test case](https://github.com/SkyAPMTest/agent-auto-integration-testcases) for this

[GitHub] [skywalking] wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor

2019-05-08 Thread GitBox
wu-sheng commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/skywalking/pull/1325#issuecomment-490710676 Please submit this to new issue if you could provide demo codes to reproduce the issue. ---

[GitHub] [skywalking] liudantop edited a comment on issue #1325: Fix #1280: Modify tomcat interceptor

2019-05-08 Thread GitBox
liudantop edited a comment on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/skywalking/pull/1325#issuecomment-490704818 I have a issue, in scenario two: 1. have a API "/test_forward" 2.API "/test_forward" mapping method will forward to the URL "/error

[GitHub] [skywalking] liudantop edited a comment on issue #1325: Fix #1280: Modify tomcat interceptor

2019-05-08 Thread GitBox
liudantop edited a comment on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/skywalking/pull/1325#issuecomment-490704818 I have a issue, in scenario two: 1. have a API "/test_forward" 2.API "/test_forward" mapping method will forward to the URL "/error

[GitHub] [skywalking] liudantop commented on issue #1325: Fix #1280: Modify tomcat interceptor

2019-05-08 Thread GitBox
liudantop commented on issue #1325: Fix #1280: Modify tomcat interceptor URL: https://github.com/apache/skywalking/pull/1325#issuecomment-490704818 I have a issue, in scenario two: 1. have a API "/test_forward" 2.API "/test_forward" mapping method will forward to the URL "/error_proto"

[GitHub] [skywalking] wu-sheng commented on issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
wu-sheng commented on issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634#issuecomment-490453970 If you want this, query the data based on graphql, and save the data. Then you could build the compare. OSS project should build the c

[GitHub] [skywalking] wu-sheng closed issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
wu-sheng closed issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [skywalking] wu-sheng closed issue #2636: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
wu-sheng closed issue #2636: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2636 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [skywalking] wu-sheng commented on issue #2636: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
wu-sheng commented on issue #2636: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2636#issuecomment-490452019 Php agent is not SkyWalking official repo. Ask at php agent repo please.

[GitHub] [skywalking] indraneelbaronia opened a new issue #2636: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
indraneelbaronia opened a new issue #2636: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2636 I am new to skywalking and am trying to install the **Skywalking php agent**. i am following the given document in the **SkyAPM-php-sdk**. However aft

[GitHub] [skywalking] wu-sheng commented on issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
wu-sheng commented on issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634#issuecomment-490441626 I am not sure this is a good scope for the project. We are building tool, rather than the management system. -

[GitHub] [skywalking] wu-sheng commented on issue #2635: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
wu-sheng commented on issue #2635: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2635#issuecomment-490441202 Please move the question to php agent repo. It is the official Apache repo. -

[GitHub] [skywalking] wu-sheng closed issue #2635: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
wu-sheng closed issue #2635: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2635 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [skywalking] indraneelbaronia opened a new issue #2635: [Agent] Doubts about Skywalking-php agent

2019-05-08 Thread GitBox
indraneelbaronia opened a new issue #2635: [Agent] Doubts about Skywalking-php agent URL: https://github.com/apache/skywalking/issues/2635 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ]

[GitHub] [skywalking] huangwei2013 opened a new issue #2634: [Improvement ] Topology compare

2019-05-08 Thread GitBox
huangwei2013 opened a new issue #2634: [Improvement ] Topology compare URL: https://github.com/apache/skywalking/issues/2634 # Brief Make a snapshot when System everything is fine - topology - metrics(p50\p90\..,as well as latency) Select one sna

[GitHub] [skywalking] wu-sheng commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files?

2019-05-08 Thread GitBox
wu-sheng commented on issue #2633: [help wanted] is there a way to make agent delete the OLD log files? URL: https://github.com/apache/skywalking/issues/2633#issuecomment-490420619 We don't have this. Contribution is welcome.

[GitHub] [skywalking] polaris952 opened a new issue #2633: [help wanted] is there a way to control the agent log historic files count?

2019-05-08 Thread GitBox
polaris952 opened a new issue #2633: [help wanted] is there a way to control the agent log historic files count? URL: https://github.com/apache/skywalking/issues/2633 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ YES] Question or d

[GitHub] [skywalking] coveralls edited a comment on issue #1934: Provide plugin for ShardingSphere

2019-05-08 Thread GitBox
coveralls edited a comment on issue #1934: Provide plugin for ShardingSphere URL: https://github.com/apache/skywalking/pull/1934#issuecomment-439763210 [![Coverage Status](https://coveralls.io/builds/23253743/badge)](https://coveralls.io/builds/23253743) Coverage increased (+0.04

[GitHub] [skywalking] coveralls commented on issue #2632: sync ui.

2019-05-08 Thread GitBox
coveralls commented on issue #2632: sync ui. URL: https://github.com/apache/skywalking/pull/2632#issuecomment-490380805 [![Coverage Status](https://coveralls.io/builds/23253465/badge)](https://coveralls.io/builds/23253465) Coverage remained the same at 16.395% when pulling **829

[GitHub] [skywalking] JaredTan95 commented on issue #2632: sync ui.

2019-05-08 Thread GitBox
JaredTan95 commented on issue #2632: sync ui. URL: https://github.com/apache/skywalking/pull/2632#issuecomment-490375032 > Wait for the two pr landed in UI? I think my change is not important. yeah, that's what I'm wanna to say. ---

[skywalking] branch master updated: add test cases for Base64 (#2630)

2019-05-08 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 37c9252 add test cases for Base64 (#2630)

[GitHub] [skywalking] JaredTan95 merged pull request #2630: Add test cases for Base64

2019-05-08 Thread GitBox
JaredTan95 merged pull request #2630: Add test cases for Base64 URL: https://github.com/apache/skywalking/pull/2630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #2632: sync ui.

2019-05-08 Thread GitBox
wu-sheng commented on issue #2632: sync ui. URL: https://github.com/apache/skywalking/pull/2632#issuecomment-490374469 Wait for the two pr landed in UI? I think my change is not important. This is an automated message from the

[GitHub] [skywalking] JaredTan95 opened a new pull request #2632: sync ui.

2019-05-08 Thread GitBox
JaredTan95 opened a new pull request #2632: sync ui. URL: https://github.com/apache/skywalking/pull/2632 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance --

[skywalking] branch ui created (now 8293044)

2019-05-08 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch ui in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 8293044 sync ui. This branch includes the following new commits: new 8293044 sync ui. The 1 revisions list

[skywalking] 01/01: sync ui.

2019-05-08 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch ui in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 82930441b0fd9a0488fa42796fa647ed8eee3d5e Author: Jared.Tan AuthorDate: Wed May 8 15:01:53 2019 +0800 sync ui. ---