[GitHub] [skywalking] woshuowozhihuiduiniyiyinyiyi commented on issue #2521: skywalking will stop collect unexpectedly when hundreds os service

woshuowozhihuiduiniyiyinyiyi commented on issue #2521: skywalking will stop collect unexpectedly when hundreds os service URL: https://github.com/apache/skywalking/issues/2521#issuecomment-517153896 thanks for your help.I change my elasticsearch config,and it work normal now. ![image](

[GitHub] [skywalking] woshuowozhihuiduiniyiyinyiyi removed a comment on issue #2521: skywalking will stop collect unexpectedly when hundreds os service

woshuowozhihuiduiniyiyinyiyi removed a comment on issue #2521: skywalking will stop collect unexpectedly when hundreds os service URL: https://github.com/apache/skywalking/issues/2521#issuecomment-517153896 thanks for your help.I change my elasticsearch config,and it work normal now. !

[GitHub] [skywalking] woshuowozhihuiduiniyiyinyiyi commented on issue #2521: skywalking will stop collect unexpectedly when hundreds os service

woshuowozhihuiduiniyiyinyiyi commented on issue #2521: skywalking will stop collect unexpectedly when hundreds os service URL: https://github.com/apache/skywalking/issues/2521#issuecomment-517154304 Thanks for your help. I change my elasticsearch config ,and it work normal now. ![imag

[GitHub] [skywalking] wu-sheng commented on issue #3199: [WIP] Make auto instrumentation works when Module definition existing

wu-sheng commented on issue #3199: [WIP] Make auto instrumentation works when Module definition existing URL: https://github.com/apache/skywalking/pull/3199#issuecomment-517154763 /run e2e This is an automated message from th

[GitHub] [skywalking] wu-sheng commented on issue #3170: Support upgrade backend w/o rebooting agents

wu-sheng commented on issue #3170: Support upgrade backend w/o rebooting agents URL: https://github.com/apache/skywalking/pull/3170#issuecomment-517181859 One question, why the case is so quickly, AFAIK, the agent cooldown should be 10 mins in default. I saw the `table: alarm_record

[GitHub] [skywalking] qxo opened a new pull request #3200: fixed for okhttp 4.0.x AsyncCall

qxo opened a new pull request #3200: fixed for okhttp 4.0.x AsyncCall URL: https://github.com/apache/skywalking/pull/3200 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve perfor

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3200: fixed for okhttp 4.0.x AsyncCall

wu-sheng commented on a change in pull request #3200: fixed for okhttp 4.0.x AsyncCall URL: https://github.com/apache/skywalking/pull/3200#discussion_r309690194 ## File path: apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/defin

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3173: Java agent support undertow routing handler

SkyWalkingRobot commented on issue #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#issuecomment-517299863 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/8/aiyanbo/testReport-ma

[GitHub] [skywalking] wu-sheng commented on issue #3173: Java agent support undertow routing handler

wu-sheng commented on issue #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#issuecomment-517301133 Test passed. @ascrutae Please verify the existing test for undertow. @aiyanbo Your new test case name should be changed. Currently

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3173: Java agent support undertow routing handler

SkyWalkingRobot commented on issue #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#issuecomment-517309323 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/8/aiyanbo/testReport-ma

[GitHub] [skywalking] qxo commented on a change in pull request #3200: fixed for okhttp 4.0.x AsyncCall

qxo commented on a change in pull request #3200: fixed for okhttp 4.0.x AsyncCall URL: https://github.com/apache/skywalking/pull/3200#discussion_r309735397 ## File path: apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/define/Asy

[GitHub] [skywalking] wu-sheng commented on issue #3200: fixed for okhttp 4.0.x AsyncCall

wu-sheng commented on issue #3200: fixed for okhttp 4.0.x AsyncCall URL: https://github.com/apache/skywalking/pull/3200#issuecomment-517319280 If you are talking about OKHttp 4, then you need this PR CI works, and add the test cases to https://github.com/SkyAPMTest/agent-auto-integration-t

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3173: Java agent support undertow routing handler

wu-sheng commented on a change in pull request #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#discussion_r309740445 ## File path: apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/src/main/java/org/apache/skywalk

[GitHub] [skywalking] qxo commented on issue #3175: improve ContextCarrier: reduce unnecessary object creation -- reduce gc

qxo commented on issue #3175: improve ContextCarrier: reduce unnecessary object creation -- reduce gc URL: https://github.com/apache/skywalking/pull/3175#issuecomment-517324122 This PR is only offer two new ways for good gc and performance And should be 100% compatible with old code

[GitHub] [skywalking] wu-sheng commented on issue #3175: improve ContextCarrier: reduce unnecessary object creation -- reduce gc

wu-sheng commented on issue #3175: improve ContextCarrier: reduce unnecessary object creation -- reduce gc URL: https://github.com/apache/skywalking/pull/3175#issuecomment-517328356 > This PR is only offer two new ways That is the key reason we can't accept. We usually don't open new

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3170: Support upgrade backend w/o rebooting agents

wu-sheng commented on a change in pull request #3170: Support upgrade backend w/o rebooting agents URL: https://github.com/apache/skywalking/pull/3170#discussion_r309751220 ## File path: test/e2e/e2e-agent-reboot/pom.xml ## @@ -84,6 +84,7 @@

[GitHub] [skywalking] qxo opened a new pull request #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once

qxo opened a new pull request #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once URL: https://github.com/apache/skywalking/pull/3201 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] B

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once

wu-sheng commented on a change in pull request #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once URL: https://github.com/apache/skywalking/pull/3201#discussion_r309754421 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apa

[GitHub] [skywalking-website] BFergerson opened a new pull request #50: Simple spelling fix

BFergerson opened a new pull request #50: Simple spelling fix URL: https://github.com/apache/skywalking-website/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [skywalking-website] wu-sheng merged pull request #50: Simple spelling fix

wu-sheng merged pull request #50: Simple spelling fix URL: https://github.com/apache/skywalking-website/pull/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[skywalking-website] branch master updated: Simple spelling fix (#50)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 967c304 Simple spelling fix (#50)

[skywalking-website] branch asf-site updated (2f12239 -> d8e07cf)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 2f12239 Update asf-site new d8e07cf Update asf-site This update added new revisions after undo

[GitHub] [skywalking] wu-sheng merged pull request #3170: Support upgrade backend w/o rebooting agents

wu-sheng merged pull request #3170: Support upgrade backend w/o rebooting agents URL: https://github.com/apache/skywalking/pull/3170 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking] branch master updated: Support upgrade backend w/o rebooting agents (#3170)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 49f50a2 Support upgrade backend w/o reboot

[GitHub] [skywalking] wu-sheng closed issue #3072: Support upgrade backend w/o rebooting agents

wu-sheng closed issue #3072: Support upgrade backend w/o rebooting agents URL: https://github.com/apache/skywalking/issues/3072 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [skywalking] wu-sheng commented on issue #3171: [WIP]Add jdk http plugin

wu-sheng commented on issue #3171: [WIP]Add jdk http plugin URL: https://github.com/apache/skywalking/pull/3171#issuecomment-517517049 /run e2e This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3173: Java agent support undertow routing handler

kezhenxu94 commented on a change in pull request #3173: Java agent support undertow routing handler URL: https://github.com/apache/skywalking/pull/3173#discussion_r309955815 ## File path: apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/src/main/java/org/apache/skywa

[GitHub] [skywalking] SevenBlue2018 opened a new issue #3202: skywalking ttl

SevenBlue2018 opened a new issue #3202: skywalking ttl URL: https://github.com/apache/skywalking/issues/3202 I want to know which one will take effect when default ttl and elasticsearch ttl are present？ ` core: default: # Mixed: Receive agent data, Level 1 aggregate, L

[GitHub] [skywalking] wu-sheng commented on issue #3202: skywalking ttl

wu-sheng commented on issue #3202: skywalking ttl URL: https://github.com/apache/skywalking/issues/3202#issuecomment-517528697 The document has said that. If ElasticSearch is set as storage, then core TTL will be ignored. Thi

[GitHub] [skywalking] wu-sheng closed issue #3202: skywalking ttl

wu-sheng closed issue #3202: skywalking ttl URL: https://github.com/apache/skywalking/issues/3202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [skywalking] wu-sheng commented on issue #3170: Support upgrade backend w/o rebooting agents

wu-sheng commented on issue #3170: Support upgrade backend w/o rebooting agents URL: https://github.com/apache/skywalking/pull/3170#issuecomment-517529513 @heyanlong @liuhaoyang @ascrutae Please notice this. The reboot command has been supported in OAP and Java agent. Please consider suppor

[GitHub] [skywalking] zhaoyuguang commented on issue #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once

zhaoyuguang commented on issue #3201: improve AsyncSpan API: make #asyncFinish and #prepareForAsync can not invoke more than once URL: https://github.com/apache/skywalking/pull/3201#issuecomment-517541333 By learning your design, it seems that asyncStop and isInAsyncMode are very differ

[GitHub] [skywalking] kezhenxu94 opened a new pull request #3203: Fix wrong time unit

kezhenxu94 opened a new pull request #3203: Fix wrong time unit URL: https://github.com/apache/skywalking/pull/3203 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] [skywalking] wu-sheng merged pull request #3203: Fix wrong time unit

wu-sheng merged pull request #3203: Fix wrong time unit URL: https://github.com/apache/skywalking/pull/3203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[skywalking] branch master updated: Fix wrong time unit (#3203)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 4db007e Fix wrong time unit (#3203) 4db007

[GitHub] [skywalking] SevenBlue2018 commented on issue #3202: skywalking ttl

SevenBlue2018 commented on issue #3202: skywalking ttl URL: https://github.com/apache/skywalking/issues/3202#issuecomment-517564865 https://github.com/apache/skywalking/blob/5036e8334301322d49973005cd98513c17b0f28f/docs/en/setup/backend/ttl.md This document has not said that. --

[GitHub] [skywalking] maxiaolong commented on issue #1801: ProtectiveShieldMatcher error in agent log

maxiaolong commented on issue #1801: ProtectiveShieldMatcher error in agent log URL: https://github.com/apache/skywalking/issues/1801#issuecomment-517569487 it happened in 6.10 WARN 2019-07-23 20:21:50:621 main ProtectiveShieldMatcher : Byte-buddy occurs exception when match type.

[GitHub] [skywalking] wu-sheng commented on issue #3202: skywalking ttl

wu-sheng commented on issue #3202: skywalking ttl URL: https://github.com/apache/skywalking/issues/3202#issuecomment-517569934 How do you understand this?  I think it is

[GitHub] [skywalking] maxiaolong opened a new issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet

maxiaolong opened a new issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet URL: https://github.com/apache/skywalking/issues/3204 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] [skywalking] wu-sheng commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet

wu-sheng commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet URL: https://github.com/apache/skywalking/issues/3204#issuecomment-517574905 What is `6.10-beta`? This is an automated m

[GitHub] [skywalking] wu-sheng commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet

wu-sheng commented on issue #3204: java.lang.ClassCircularityError: java/util/LinkedHashMap$LinkedKeySet URL: https://github.com/apache/skywalking/issues/3204#issuecomment-517575297 Which class are you trying to enhance? This

[skywalking] branch version-header created (now f51aed6)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch version-header in repository https://gitbox.apache.org/repos/asf/skywalking.git. at f51aed6 Add agent version in gRPC connection establish stage This branch includes the following new co

[skywalking] 01/01: Add agent version in gRPC connection establish stage

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch version-header in repository https://gitbox.apache.org/repos/asf/skywalking.git commit f51aed6dbf6bc74f5608397309bdcb71b010588a Author: Wu Sheng AuthorDate: Fri Aug 2 14:45:53 2019 +0800 Ad

[GitHub] [skywalking] wu-sheng opened a new pull request #3205: Add agent version in gRPC connection establish stage

wu-sheng opened a new pull request #3205: Add agent version in gRPC connection establish stage URL: https://github.com/apache/skywalking/pull/3205 Make the OAP backend could get the agent version, in case that service vendors need to verify. ---