wu-sheng commented on issue #3374: How to setup istio to send metrics to
skywalking
URL: https://github.com/apache/skywalking/issues/3374#issuecomment-526468339
Yes. I just bring it by through #3376.
This is an automated
wu-sheng opened a new pull request #3376: Add istio bypass adaptor setup
document back
URL: https://github.com/apache/skywalking/pull/3376
@hanahmily I think we don't include the new istio setup document in latest
k8s, so I bring it back to main doc.
Resolves #3374
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch mesh-doc
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at 5b9e464 Update document.
This branch includes the following new commits:
new 5b9e464 Update
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch mesh-doc
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 5b9e4646dbafa95dcba9e9a959a5458d0c3c4af4
Author: Wu Sheng
AuthorDate: Fri Aug 30 13:54:48 2019 +0800
Update
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526466366
/run ci
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on issue #3375: Update powered-by.md
URL: https://github.com/apache/skywalking/pull/3375#issuecomment-526466391
/run ci
This is an automated message from the Apache Git Service.
To respond to the message,
kuaikuai opened a new pull request #3375: Update powered-by.md
URL: https://github.com/apache/skywalking/pull/3375
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
mytimes edited a comment on issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373#issuecomment-526451833
@wu-sheng i checked mysql only table register_lock be created. why?
This
mytimes commented on issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373#issuecomment-526451833
@wu-sheng only table register_lock be created. why?
This is an automated message
mytimes commented on issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373#issuecomment-526451670
only table register_lock be created ，this is log。
2019-08-16 14:01:03,189 -
stalary commented on a change in pull request #3369: [WIP] ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319345957
##
File path:
dmsolr commented on a change in pull request #3369: [WIP] ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319345122
##
File path:
This is an automated email from the ASF dual-hosted git repository.
zhaoyuguang pushed a change to branch beike/master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
at b58ef70 123
This branch includes the following new commits:
new b58ef70 123
The 1 revisions
This is an automated email from the ASF dual-hosted git repository.
zhaoyuguang pushed a commit to branch beike/master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit b58ef70904a7a5d684653e240a3d4cb92f307dbb
Author: 赵禹光 <769213...@qq.com>
AuthorDate: Fri Aug 30 11:11:53
stalary commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319342872
##
File path:
wu-sheng commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319342289
##
File path:
wu-sheng commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319342289
##
File path:
stalary commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319342023
##
File path:
stalary commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319341400
##
File path:
stalary commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319341305
##
File path:
wu-sheng commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319340889
##
File path:
wu-sheng commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319340827
##
File path:
wu-sheng commented on a change in pull request #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#discussion_r319340498
##
File path:
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319340193
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526435256
After you removed, who covers v1 use case? I haven't read codes, just have
context you discuss here. Header is required to make trace continued.
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526434557
> Server side is not of control, please don't consider to change message body
I have the same idea, so I want to remove the activity of adding headers
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526434059
Server side is not of control, please don't consider to change message body.
We just leverage existing header. If server side doesn't support it, so be it,
we
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526433732
> Not really. SW plugins nevenr change the original logic. This is Kafka's
businesses. I think.
>
> > I think if we delete the header we can support the
18965824402 commented on issue #3258: ScopeDefine name = All not found
URL: https://github.com/apache/skywalking/issues/3258#issuecomment-526433018
> 反馈，这是由JDK 11引起的。我们不支持这一点。
我也遇到同样的问题 那6.3版本需要什么版本的jdk
This is an
dmsolr commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526432930
Not really. SW plugins nevenr change the original logic. This is Kafka's
businesses. I think.
> I think if we delete the header we can support the old
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526432060
I think if we delete the header we can support the old version of kafka
This is an automated
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319337256
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319337165
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
hanahmily edited a comment on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526430145
> @JaredTan95 One thing crosses my mind, this is useful if SkyWalking
supports multiple HTTP peers, such as ES https, export https, dynamic
hanahmily commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526430145
> @JaredTan95 One thing crosses my mind, this is useful if SkyWalking
supports multiple HTTP peers, such as ES https, export https, dynamic
dmsolr commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526429744
I am not understand well what is your means.
`ApiVersions` can be witness class, because it is in every versions. The
MessageFormatVersion is none of the
wu-sheng commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526428694
@JaredTan95 One thing crosses my mind, this is useful if SkyWalking supports
multiple HTTP peers, such as ES https, export https, dynamic configuration
JaredTan95 commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526427704
> > As far as I know, there should be no difference. That's why I'm just
talking about which way we're going to choose. @hanahmily Any suggestions?
wu-sheng commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526427122
> As far as I know, there should be no difference. That's why I'm just
talking about which way we're going to choose. @hanahmily Any suggestions?
JaredTan95 commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526426865
As far as I know, there should be no difference. That's why I'm just talking
about which way we're going to choose. @hanahmily Any suggestions?
wu-sheng commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526424596
Then why should we change? Is there any difference between those two ways?
This is an
JaredTan95 commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526424268
> You prefer to add the JVM things you mentioned in the document, some
people may be not familiar with that.
What I mean is that, if we use
wu-sheng commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526423399
You prefer to add the JVM things you mentioned in the document, some people
may be not familiar with that.
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch es_https_ssl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 1c11e91 update docs.
add 5294ad9 refactoring var name.
No new revisions were added by this
stone-wlg commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526422332
> Please fix conflict, we have merged a new plugin.
done
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch es_https_ssl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from d87a5bf Merge branch 'master' into es_https_ssl
add 1c11e91 update docs.
No new revisions were
JaredTan95 commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319329500
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
wu-sheng commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526419641
@JaredTan95 Look like we need a document update at es storage section.
This is an
JaredTan95 commented on issue #3370: support es https ssl config.
URL: https://github.com/apache/skywalking/pull/3370#issuecomment-526418899
@hanahmily As we discussed before, we could also set SSL within
JDK-JVM-Options, like this:
```bash
-Djavax.net.ssl.keyStoreType=jks
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch es_https_ssl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 53df156 Merge branch 'master' into es_https_ssl
add 95ceacf Fix the zookeeper plugin has many
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526406616
> Did you connect to V0.10.x or lower using client-0.11.0.0? As far as I
know v0.11.0 uses message format V2(batch record).
@dmsolr Oh, that's right, so
dmsolr edited a comment on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526282865
> @wu-sheng I have another problem. My local test found that using v1 plugin
and kafka-client using 0.11.0.0 also appeared `Magic v1 does not support
dmsolr commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526282865
> @wu-sheng I have another problem. My local test found that using v1 plugin
and kafka-client using 0.11.0.0 also appeared `Magic v1 does not support record
ceastman-ibm opened a new issue #3374: How to setup istio to send metrics to
skywalking
URL: https://github.com/apache/skywalking/issues/3374
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [X ] Question or discussion
- [ ] Bug
wu-sheng merged pull request #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 57b345d add logstash logback plugin
wuxingye commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526221091
Thank you.
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526215529
Take your time. SkyWalking is a large ecosystem, even PMC member is not
familiar all parts of the project. So, don't worry. With your further
wuxingye commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526209100
It's my first PR at GitHub, i gained a lot, and i will pay attention to CI
in the later work
wu-sheng commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526206051
Click `Details` following CI. You will have Jenkins logs, it shows the
commands and logs. In the Apache, we are required to have javadoc.
wu-sheng commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526205639
I just find out from the CI, nothing more.
This is an automated message from the
wuxingye commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526205250
> @wuxingye Look like your comment break javadoc generation, could you
recheck?
@wu-sheng I find an error and a warning, if you fell there are
wu-sheng commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526199084
@wuxingye Look like your comment break javadoc generation, could you recheck?
This is
wuxingye commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526198539
> @wuxingye All core team members have no experience with this. So we
decided to accept this due to no obvious harm. If someone uses this in the
wu-sheng commented on issue #3365: add logstash logback plugin
URL: https://github.com/apache/skywalking/pull/3365#issuecomment-526195967
@wuxingye All core team members have no experience with this. So we decided
to accept this due to no obvious harm. If someone uses this in the future,
wu-sheng commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319073588
##
File path:
wuxingye commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319073194
##
File path:
wu-sheng commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319070688
##
File path:
wuxingye commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319067177
##
File path:
docs/en/setup/service-agent/java-agent/Application-toolkit-logback-1.x.md
##
@@ -55,3 +56,25 @@
```
wuxingye commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319064507
##
File path:
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319058428
##
File path:
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319055675
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
hanahmily commented on a change in pull request #3370: support es https ssl
config.
URL: https://github.com/apache/skywalking/pull/3370#discussion_r319060300
##
File path: docs/en/setup/backend/backend-storage.md
##
@@ -54,6 +56,34 @@ storage:
concurrentRequests:
wu-sheng commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319048167
##
File path:
wu-sheng commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319048868
##
File path:
docs/en/setup/service-agent/java-agent/Application-toolkit-logback-1.x.md
##
@@ -55,3 +56,25 @@
```
wu-sheng commented on a change in pull request #3365: add logstash logback
plugin
URL: https://github.com/apache/skywalking/pull/3365#discussion_r319051302
##
File path:
wu-sheng commented on issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373#issuecomment-526164496
Please check your startup logs, the table should be checked and
auto-creating.
wu-sheng closed issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526162031
> > I know I will continue to improve it tomorrow
>
> Take your time. And please fix the issues of verifications in old cases,
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526160317
> I know I will continue to improve it tomorrow
Take your time. And please fix the issues of verifications in old cases,
stalary commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526155383
> Integration test cases are required. Do you know how to do that?
I know I will continue to improve it tomorrow
mytimes opened a new issue #3373: storage mysql no create table
URL: https://github.com/apache/skywalking/issues/3373
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [* ] Question or discussion
- [*] Bug
- [ ] Requirement
- [
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526151828
Integration test cases are required. Do you know how to do that?
This is an automated message
wu-sheng closed issue #3371: Fix the zookeeper plugin has many nodes in the
cluster case
URL: https://github.com/apache/skywalking/issues/3371
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 95ceacf Fix the zookeeper plugin has many
wu-sheng merged pull request #3372: Fix the zookeeper plugin has many nodes in
the cluster case
URL: https://github.com/apache/skywalking/pull/3372
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng commented on issue #3372: Fix the zookeeper plugin has many nodes in
the cluster case
URL: https://github.com/apache/skywalking/pull/3372#issuecomment-526134753
/run ci
This is an automated message from the Apache
zhaoyuguang commented on issue #3372: Fix the zookeeper plugin has many nodes
in the cluster case
URL: https://github.com/apache/skywalking/pull/3372#issuecomment-526126817
> Here is the [test
SkyWalkingRobot commented on issue #3372: Fix the zookeeper plugin has many
nodes in the cluster case
URL: https://github.com/apache/skywalking/pull/3372#issuecomment-526123814
Here is the [test
zhaoyuguang commented on issue #3372: Fix the zookeeper plugin has many nodes
in the cluster case
URL: https://github.com/apache/skywalking/pull/3372#issuecomment-526122556
/run ci
This is an automated message from the
wu-sheng commented on issue #3372: Fix the zookeeper plugin has many nodes in
the cluster case
URL: https://github.com/apache/skywalking/pull/3372#issuecomment-52654
Resolves #3371
This is an automated message from the
zhaoyuguang opened a new pull request #3372: Fix the zookeeper plugin has many
nodes in the cluster case
URL: https://github.com/apache/skywalking/pull/3372
Please answer these questions before submitting pull request
- Why submit this pull request?
- [x] Bug fix
- [ ] New
zhaoyuguang opened a new issue #3371: Fix the zookeeper plugin has many nodes
in the cluster case
URL: https://github.com/apache/skywalking/issues/3371
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
-
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch service_props
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 01d8e21 agent support custom properties.
add 8bf7e34 Support play 2.x (#3207)
add 6502b81
wu-sheng commented on issue #3323: Add Light4j plugin
URL: https://github.com/apache/skywalking/pull/3323#issuecomment-526104315
Fix conflict please, Play Framework plugin has been merged, so the ID is
being used by it. Remember to change the test cases too.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a change to branch es_https_ssl
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from 488e1bd update
add 8bf7e34 Support play 2.x (#3207)
add 53df156 Merge branch 'master' into
wu-sheng commented on issue #3207: Support play 2.x
URL: https://github.com/apache/skywalking/pull/3207#issuecomment-526100585
@aiyanbo Twitter belongs to you :)
https://twitter.com/ASFSkyWalking/status/1167002935961669634
wu-sheng commented on issue #3330: Cassandra 3.x Plugin
URL: https://github.com/apache/skywalking/pull/3330#issuecomment-526098770
Please fix conflict, we have merged a new plugin.
This is an automated message from the Apache
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526097149
Another plugin merged, please fix conflicts
This is an automated message from the Apache Git
wu-sheng commented on issue #3369: ADD kafka-v2 plugin
URL: https://github.com/apache/skywalking/pull/3369#issuecomment-526095971
> Can I modify v1's witness class in instrumentation definition to make the
plugin selectively started? Otherwise I can only control whether the v2 plugin
1 - 100 of 149 matches
Mail list logo
