[GitHub] [skywalking] hi-sb commented on issue #3411: spring-cloud-gateway traceid does not transmit

2019-09-09 Thread GitBox
hi-sb commented on issue #3411: spring-cloud-gateway traceid does not transmit URL: https://github.com/apache/skywalking/issues/3411#issuecomment-529327398 -- 原始邮件 -- 发件人: "于玉桔"; 发送时间: 2019年9月9日(星期一) 下午2:41 收件人: "apache/skywalking"; 抄送: "1922327128

[GitHub] [skywalking] zhaoyuguang commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3440#issuecomment-529329500 > Just now, I used the full 6.5.0 plug-in package, and this problem still exists."delegate" is not an implementation

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-09-09 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-529329806 > ok, but i do not want to leave unnecessary log in git log. Check `git rebase`, you could do that then force push. -

[GitHub] [skywalking] hi-sb commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3440#issuecomment-529330888 org.springframework.web.server.DefaultServerWebExchangeBuilder$MutativeDecorator -

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529333012 @dmsolr Could you run tests locally? This is an automated message from the

[GitHub] [skywalking] zhaoyuguang commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3440: Issues:spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3440#issuecomment-529337175 > org.springframework.web.server.DefaultServerWebExchangeBuilder$MutativeDecorator I tried to recreate the sce

[GitHub] [skywalking] dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529338454 Yes, I run it now. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] yab119074412 commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

2019-09-09 Thread GitBox
yab119074412 commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index] URL: https://github.com/apache/skywalking/issues/3395#issuecomment-529342879 I have met the same problem too, and it has troubled me several days. -

[GitHub] [skywalking] dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529347520 The result is (here is `parallel_run_size=4`) > [INFO] ---Here is the test report context -

[GitHub] [skywalking] dmsolr edited a comment on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
dmsolr edited a comment on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529347520 The result is (here is `parallel_run_size=1`) > [INFO] ---Here is the test report context --

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-09-09 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-529351414 > > ok, but i do not want to leave unnecessary log in git log. > > Check `git rebase`, you could do that then force push. thanks

[GitHub] [skywalking] webb2019 opened a new issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 opened a new issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444 look for help how skywalking oap set elasticSearch requst like blow to anther timeout time [POST] service_inventory/type/hermes_0_0/_update?refresh=tr

[GitHub] [skywalking] zhaoyuguang opened a new pull request #3445: Gateway compatible with downstream loss

2019-09-09 Thread GitBox
zhaoyuguang opened a new pull request #3445: Gateway compatible with downstream loss URL: https://github.com/apache/skywalking/pull/3445 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [

[GitHub] [skywalking] zhaoyuguang commented on issue #3445: Gateway compatible with downstream loss

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3445: Gateway compatible with downstream loss URL: https://github.com/apache/skywalking/pull/3445#issuecomment-529412446 I am preparing testcase This is an automated message from the Apache Git

[GitHub] [skywalking] csullh commented on issue #3411: spring-cloud-gateway traceid does not transmit

2019-09-09 Thread GitBox
csullh commented on issue #3411: spring-cloud-gateway traceid does not transmit URL: https://github.com/apache/skywalking/issues/3411#issuecomment-529440287 @hi-sb,@zhaoyuguang Until just now,In the new version(NettyRoutingFilterInterceptor) I found the code can work correctly. And in the

[GitHub] [skywalking] hanlubiao commented on issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender

2019-09-09 Thread GitBox
hanlubiao commented on issue #3352: How to get the traceId in logback's LogstashTcpSocketAppender URL: https://github.com/apache/skywalking/issues/3352#issuecomment-529460300 thank you! This is an automated message from the A

[GitHub] [skywalking] hi-sb closed pull request #3440: Issues:spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb closed pull request #3440: Issues:spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3440 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [skywalking] kezhenxu94 closed issue #3442: why skywalking can work without config/datasource-settings.properties correct config?

2019-09-09 Thread GitBox
kezhenxu94 closed issue #3442: why skywalking can work without config/datasource-settings.properties correct config? URL: https://github.com/apache/skywalking/issues/3442 This is an automated message from the Apache Git Se

[GitHub] [skywalking] kezhenxu94 commented on issue #3442: why skywalking can work without config/datasource-settings.properties correct config?

2019-09-09 Thread GitBox
kezhenxu94 commented on issue #3442: why skywalking can work without config/datasource-settings.properties correct config? URL: https://github.com/apache/skywalking/issues/3442#issuecomment-529501425 @webb2019 `config/datasource-settings.properties` only takes effect when the storage is

[GitHub] [skywalking] hi-sb opened a new pull request #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb opened a new pull request #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446 skywalking-version:6.5.0 spring-gateway-version:2.1.2 Error Description: Customize the filter, traceid does not transmit.

[GitHub] [skywalking-website] x22x22 opened a new pull request #56: Add x22x22 committer

2019-09-09 Thread GitBox
x22x22 opened a new pull request #56: Add x22x22 committer URL: https://github.com/apache/skywalking-website/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529722176 We don't have it, I think. Contribution is welcome. This is an automat

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-52970 But 1m is very long, I think. This is an automated message from the Ap

[GitHub] [skywalking] wu-sheng closed issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng closed issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng closed issue #3441: Grpc server thread pool is full, rejecting the task

2019-09-09 Thread GitBox
wu-sheng closed issue #3441: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3441 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [skywalking] wu-sheng commented on issue #3441: Grpc server thread pool is full, rejecting the task

2019-09-09 Thread GitBox
wu-sheng commented on issue #3441: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3441#issuecomment-529722735 We added thread size control to make sure you wouldn't OOM. But two many connections are not acceptable. You should not have s

[GitHub] [skywalking] wu-sheng commented on issue #3443: client may not successfully re-registed after oapServer restarted

2019-09-09 Thread GitBox
wu-sheng commented on issue #3443: client may not successfully re-registed after oapServer restarted URL: https://github.com/apache/skywalking/issues/3443#issuecomment-529723408 In some env, 6.3.0 may have this issue, due to some other fixed. Try master codes or next release. It may relate

[GitHub] [skywalking] wu-sheng closed issue #3443: client may not successfully re-registed after oapServer restarted

2019-09-09 Thread GitBox
wu-sheng closed issue #3443: client may not successfully re-registed after oapServer restarted URL: https://github.com/apache/skywalking/issues/3443 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-website] kezhenxu94 commented on issue #56: Add x22x22 committer

2019-09-09 Thread GitBox
kezhenxu94 commented on issue #56: Add x22x22 committer URL: https://github.com/apache/skywalking-website/pull/56#issuecomment-529723946 And update the events, refer to other PR that adds committer or PMC This is an automated

[GitHub] [skywalking] zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529737728 Oh, I may understand, what do you think of using the recursive method, but I hope you add this scenario to the [gateway tes

[GitHub] [skywalking] dbones opened a new issue #3447: jaeger and istio setup.

2019-09-09 Thread GitBox
dbones opened a new issue #3447: jaeger and istio setup. URL: https://github.com/apache/skywalking/issues/3447 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ X] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Featur

[GitHub] [skywalking] webb2019 commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529750705 thanks . I've been learning the source code of skywalking and I'm looking forward to contributing ![image](https://user-images.

[GitHub] [skywalking] webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529750705 thanks . I've been learning the source code of skywalking and I'm looking forward to contributing ![image](https://user

[GitHub] [skywalking] webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529750705 thanks . I've been learning the source code of skywalking and I'm looking forward to contributing ![image](https://user

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529752062 Create is based on elasticsearch template, data driven. No timer related. -

[GitHub] [skywalking] hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529753897 my test pull request: https://github.com/SkyAPMTest/agent-auto-integration-testcases/pull/88 --

[GitHub] [skywalking-website] x22x22 commented on issue #56: Add x22x22 committer

2019-09-09 Thread GitBox
x22x22 commented on issue #56: Add x22x22 committer URL: https://github.com/apache/skywalking-website/pull/56#issuecomment-529754118 > And update the events, refer to other PR that adds committer or PMC done This is an

[GitHub] [skywalking] webb2019 commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
cpm-20190909, and es create index endpoint_relation_cpm-20190910, data driven. But the log shows that oap caused an error by dropping the index. I don't know why ![image](https://user-images.githubusercontent.com/52440226/64581927-829bb400-d3be-11e9-8b13-ca5a22b09abf.png) ![imag

[GitHub] [skywalking] webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
ted endpoint_relation_cpm-20190909, and es create index endpoint_relation_cpm-20190910, data driven. But the log shows that oap caused an error by dropping the index. I don't know why ![image](https://user-images.githubusercontent.com/52440226/64581927-829bb400-d3be-11e9-8b13-ca5a22b0

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529759197 Are you running 2 OAP clusters? Or 2 nodes without cluster management? I think this should not happen. ---

[GitHub] [skywalking] zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529763274 CI not pass, please check This is an automated message from

[GitHub] [skywalking] zhaoyuguang edited a comment on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang edited a comment on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529763274 CI not pass, please check checkStyle.xml This is an

[GitHub] [skywalking] wu-sheng commented on issue #3447: jaeger and istio setup.

2019-09-09 Thread GitBox
wu-sheng commented on issue #3447: jaeger and istio setup. URL: https://github.com/apache/skywalking/issues/3447#issuecomment-529766611 Hi, from your screenshot, I think the most possible reason is, you haven't changed the timezone in the right bottom of page. In docker/k8s, the timezone i

[GitHub] [skywalking] hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529768310 Modified style to meet "check style" This is an automated message

[GitHub] [skywalking-website] kezhenxu94 commented on issue #56: Add x22x22 committer

2019-09-09 Thread GitBox
kezhenxu94 commented on issue #56: Add x22x22 committer URL: https://github.com/apache/skywalking-website/pull/56#issuecomment-529769563 @x22x22 take https://github.com/apache/skywalking-website/pull/47 as an example This is

[GitHub] [skywalking] webb2019 commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529771338 > Are you running 2 OAP clusters? Or 2 nodes without cluster management? I think this should not happen. no , OAP standlone and

[GitHub] [skywalking] wu-sheng closed issue #3417: TTL e2e test

2019-09-09 Thread GitBox
wu-sheng closed issue #3417: TTL e2e test URL: https://github.com/apache/skywalking/issues/3417 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [skywalking] wu-sheng merged pull request #3437: Add TTL E2E test

2019-09-09 Thread GitBox
wu-sheng merged pull request #3437: Add TTL E2E test URL: https://github.com/apache/skywalking/pull/3437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[skywalking] branch master updated (ce20fe1 -> 721f864)

2019-09-09 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ce20fe1 Move to 6.5.0 (#3439) add 721f864 Add TTL E2E test (#3437) No new revisions were added by this u

[GitHub] [skywalking] wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
wu-sheng commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529772269 @dmsolr Have you run in parallel_run_size>1? This is an automated message f

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529772844 > I understand that oap deleted endpoint_relation_cpm-20190909, and es create index endpoint_relation_cpm-20190910, data dri

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529772969 We need to make sure, there is at least one index is there. Overwise, the no index found happens.

[GitHub] [skywalking-website] x22x22 commented on issue #56: Add x22x22 committer

2019-09-09 Thread GitBox
x22x22 commented on issue #56: Add x22x22 committer URL: https://github.com/apache/skywalking-website/pull/56#issuecomment-529774011 > @x22x22 take #47 as an example done This is an automated message from the Apache Git

[GitHub] [skywalking] dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
dmsolr commented on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529774694 > @dmsolr Have you run in parallel_run_size>1? Yes. But I miss another problem which `actualData.xml` is empty. And I am trying find ou

[GitHub] [skywalking] webb2019 commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529775246 > > I understand that oap deleted endpoint_relation_cpm-20190909, and es create index endpoint_relation_cpm-20190910, data

[GitHub] [skywalking] dmsolr edited a comment on issue #3410: provide cassandra java driver 3.x plugin

2019-09-09 Thread GitBox
dmsolr edited a comment on issue #3410: provide cassandra java driver 3.x plugin URL: https://github.com/apache/skywalking/pull/3410#issuecomment-529774694 > @dmsolr Have you run in parallel_run_size>1? Yes. But I met another problem which `actualData.xml` is empty. And I am trying f

[GitHub] [skywalking] webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 edited a comment on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529775246 > > I understand that oap deleted endpoint_relation_cpm-20190909, and es create index endpoint_relation_cpm-20190910

[GitHub] [skywalking] zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529779597 I had triggered the `gateway` and `webflux` auto tests, let's wait for the result -

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
SkyWalkingRobot commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529783202 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/9/hi-sb/testRe

[GitHub] [skywalking] zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
zhaoyuguang commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529785292 Look like @Component annotation cause more spans This is an

[GitHub] [skywalking] hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529786483 @zhaoyuguang This should be another issue.We can't restrict other people from using this annotation.

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529790143 In my test env, there is always keeping at least two indexes(default 2). And as I checked the source codes, it says so too. Unless you

[GitHub] [skywalking] webb2019 commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
webb2019 commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529794622 > > > I understand that oap deleted endpoint_relation_cpm-20190909, and es create index endpoint_relation_cpm-20190910, da

[GitHub] [skywalking] wu-sheng commented on issue #3444: where file can set es quest timeout in oap?

2019-09-09 Thread GitBox
wu-sheng commented on issue #3444: where file can set es quest timeout in oap? URL: https://github.com/apache/skywalking/issues/3444#issuecomment-529796525 ```yaml recordDataTTL: ${SW_CORE_RECORD_DATA_TTL:90} # Unit is minute minuteMetricsDataTTL: ${SW_CORE_MINUTE_METRIC_DATA_T

[GitHub] [skywalking] wu-sheng commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
wu-sheng commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529796918 > This should be another issue.We can't restrict other people from using this annotation. This is not an issue of this P

[GitHub] [skywalking] hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529798085 @wu-sheng I mean, in actual development, there may be people who write as they do in use cases. We can't avoid such problems. But

[GitHub] [skywalking] wu-sheng commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
wu-sheng commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529798109 The point is, I recommend you to add these spans to your verify files, as expected span. Because in tests, the Spring annotatio

[GitHub] [skywalking] hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411

2019-09-09 Thread GitBox
hi-sb commented on issue #3446: spring-cloud-gateway traceid does not transmit #3411 URL: https://github.com/apache/skywalking/pull/3446#issuecomment-529798884 I see what you mean. What you mean is that this annotation activates other plug-ins. I shouldn't do that in use cases. --