[GitHub] [skywalking] zhaoyuguang commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
zhaoyuguang commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531647906 @tsuilouis CI has some problem, please fix, may reason is ```

[GitHub] [skywalking] JaredTan95 edited a comment on issue #3367: agent support custom properties.

2019-09-15 Thread GitBox
JaredTan95 edited a comment on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-531632774 1. in my `agent.conf`, I set the following properties: ``` agent.properties[org]=apache-skywalking ``` 2. after my

[GitHub] [skywalking] SummerOfServenteen commented on issue #3408: fix springMVC4 noSuchMethod

2019-09-15 Thread GitBox
SummerOfServenteen commented on issue #3408: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3408#issuecomment-531637617 ![image](https://user-images.githubusercontent.com/31895647/64934504-d2c2bc80-d87d-11e9-8a47-bb761763fdb0.png)

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
SkyWalkingRobot commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531632878 Here is the [test

[GitHub] [skywalking] JaredTan95 commented on issue #3367: agent support custom properties.

2019-09-15 Thread GitBox
JaredTan95 commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-531632774 1. in my `agen.conf`, I set the following properties: ``` agent.properties[org]=apache-skywalking ``` 2. after my service/agent

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531630555 @tsuilouis This PR is facing CI issue. > [2019-09-16T02:04:56.507Z] [ERROR]

[GitHub] [skywalking] SkyWalkingRobot removed a comment on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
SkyWalkingRobot removed a comment on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531629209 Here is the [test

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
SkyWalkingRobot commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531629209 Here is the [test

[GitHub] [skywalking] zhaoyuguang commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
zhaoyuguang commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531627404 > @zhaoyuguang Nothing shows up in the report. Does the test case PR miss something? Is my mistake of forgot add `the scenario name`, I had triggered

[GitHub] [skywalking] wu-sheng commented on issue #3408: fix springMVC4 noSuchMethod

2019-09-15 Thread GitBox
wu-sheng commented on issue #3408: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3408#issuecomment-531626874 @SummerOfServenteen Update? This is an automated message from the Apache Git Service.

[GitHub] [skywalking] weiqiang333 commented on issue #2066: One trace segment has been abandoned, cause by buffer is full

2019-09-15 Thread GitBox
weiqiang333 commented on issue #2066: One trace segment has been abandoned, cause by buffer is full URL: https://github.com/apache/skywalking/issues/2066#issuecomment-531623546 > > we have the same issues , and i fix it by adding several es nodes to es cluster . > > i thought es

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531621360 @zhaoyuguang Nothing shows up in the report. Does the test case PR miss something? This is an

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
SkyWalkingRobot commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531621060 Here is the [test

[GitHub] [skywalking] zhaoyuguang commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
zhaoyuguang commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531620479 I had triggered the auto tests, let's wait for the result This is an automated message from

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531614932 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng removed a comment on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng removed a comment on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531614932 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng removed a comment on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng removed a comment on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531607635 /run e2e This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng removed a comment on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng removed a comment on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531609968 /run ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531609968 /run ci This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng removed a comment on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng removed a comment on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531607628 /run ci This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531607690 @zhaoyuguang Please run this test. @zhaoyuguang @kezhenxu94 Please continue the review.

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531607635 /run e2e This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3323: Add Light4j plugin

2019-09-15 Thread GitBox
wu-sheng commented on issue #3323: Add Light4j plugin URL: https://github.com/apache/skywalking/pull/3323#issuecomment-531607628 /run ci This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3367: agent support custom properties.

2019-09-15 Thread GitBox
wu-sheng commented on issue #3367: agent support custom properties. URL: https://github.com/apache/skywalking/pull/3367#issuecomment-531607613 Could you provide a UI screenshot for this? This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3441: Grpc server thread pool is full, rejecting the task

2019-09-15 Thread GitBox
wu-sheng commented on issue #3441: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3441#issuecomment-531554608 In 6.4.0, we use our own thread pool. Because in some cases, too many grpc thread created. That is expected.

[GitHub] [skywalking] jadezhong commented on issue #3441: Grpc server thread pool is full, rejecting the task

2019-09-15 Thread GitBox
jadezhong commented on issue #3441: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3441#issuecomment-531551986 strange thing is "grpc-default-executor-" is from the default thread pool in grpc, which use name in format of

[GitHub] [skywalking-query-protocol] JaredTan95 closed pull request #14: add props in query service results.

2019-09-15 Thread GitBox
JaredTan95 closed pull request #14: add props in query service results. URL: https://github.com/apache/skywalking-query-protocol/pull/14 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking] branch service_props updated (a946453 -> 2993c99)

2019-09-15 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from a946453 revert properties in service. add 2993c99 update query. No new revisions were added by

[skywalking] branch service_props updated (e08ae83 -> a946453)

2019-09-15 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch service_props in repository https://gitbox.apache.org/repos/asf/skywalking.git. from e08ae83 Merge branch 'master' into service_props add 5e4a2f9 move custom properties in service