[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544121819 @dmsolr Is this good? This is an automated message from the Apache Git S

[GitHub] [skywalking] dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336734609 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgre

[GitHub] [skywalking] dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336734789 ## File path: test/plugin/scenarios/postgresql-scenario/config/expectedData.yaml ## @@ -0,0 +1,150 @@ +

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 removed a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544139607 /run e2e This is an automated message from the Apache Gi

[GitHub] [skywalking] kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544139607 /run e2e This is an automated message from the Apache Git Servic

[GitHub] [skywalking] kezhenxu94 removed a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 removed a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544143077 /run e2e This is an automated message from the Apache Gi

[GitHub] [skywalking] kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544143077 /run e2e This is an automated message from the Apache Git Servic

[GitHub] [skywalking] aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336738174 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgres

[GitHub] [skywalking] aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336738192 ## File path: test/plugin/scenarios/postgresql-scenario/config/expectedData.yaml ## @@ -0,0 +1,150 @@ +#

[GitHub] [skywalking] kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544150803 > As [SkyAPMTest/e2e-container#5](https://github.com/SkyAPMTest/e2e-container/pull/5) merged, let's add JDK 11 and 12 to the tes

[GitHub] [skywalking] arugal commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
arugal commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544151012 hi, It's still closed twice, what did I miss? This is an automated message

[GitHub] [skywalking-website] wu-sheng merged pull request #64: Bump lodash.template from 4.4.0 to 4.5.0

2019-10-19 Thread GitBox
wu-sheng merged pull request #64: Bump lodash.template from 4.4.0 to 4.5.0 URL: https://github.com/apache/skywalking-website/pull/64 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking-website] branch master updated: Bump lodash.template from 4.4.0 to 4.5.0 (#64)

2019-10-19 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new e411c57 Bump lodash.template from

[GitHub] [skywalking] wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544151147 How about we keep all JDK related and reboot in group 1, and others are in group 2? --

[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544151292 > hi, It's still closed twice, what did I miss? We don't have answer for that, still.

[skywalking-website] branch asf-site updated (1aeb59e -> 9f8e3db)

2019-10-19 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 1aeb59e Update asf-site new 9f8e3db Update asf-site This update added new revisions after undo

[GitHub] [skywalking] wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544152419 Two questions 1. Is the agent application running in these JDKs too? 1. I thought UI is not running? So don't know whether is

[GitHub] [skywalking] kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544152828 > Two questions > > 1. Is the agent application running in these JDKs too? If I remember correctly, at the first step of

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 edited a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544152828 > Two questions > > 1. Is the agent application running in these JDKs too? If I remember correctly, at the fi

[GitHub] [skywalking] aderm commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544152900 @wu-sheng @arugal the reason for closed twice is the code reason. first close is closeConnection() in sqlExecute.dropTable(ConstSql.DROP_TAB

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 edited a comment on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544152828 > Two questions > > 1. Is the agent application running in these JDKs too? If I remember correctly, at the fi

[GitHub] [skywalking] wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
wu-sheng commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544153025 UI didn't depend, I mean webapp. Is it running in the tests? If yes, I think we have tested it. I remembered you said, it is not wo

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#discussion_r336740027 ## File path: apm-webapp/pom.xml ## @@ -70,11 +70,6 @@ spring-boot-configuration-

[GitHub] [skywalking] kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 commented on issue #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#issuecomment-544153822 > UI didn't depend, I mean webapp. Is it running in the tests? If yes, I think we have tested it. I remembered you said, it is no

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
wu-sheng commented on a change in pull request #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657#discussion_r336740103 ## File path: apm-webapp/pom.xml ## @@ -70,11 +70,6 @@ spring-boot-configuration-pr

[GitHub] [skywalking] arugal commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
arugal commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544154295 > @wu-sheng @arugal the reason for closed twice is the code reason. first close is closeConnection() in sqlExecute.dropTable(ConstSql.DROP_

[GitHub] [skywalking] aderm commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544155811 it is not a bug. Maybe ApmTest design for it. This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544156141 If test codes are written in that way, I am good for don't change anything.

[skywalking] branch master updated (0d9fe97 -> 50f398a)

2019-10-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 0d9fe97 sync ui (#3656) add 50f398a [CI] Make E2E tests run in multiple JDK versions (#3657) No new r

[GitHub] [skywalking] kezhenxu94 closed issue #3608: e2e for JDK 9/11/12

2019-10-19 Thread GitBox
kezhenxu94 closed issue #3608: e2e for JDK 9/11/12 URL: https://github.com/apache/skywalking/issues/3608 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544156438 @dmsolr You should be able to approve as a valid reviewer already. This

[GitHub] [skywalking] kezhenxu94 merged pull request #3657: [CI] Make E2E tests run in multiple JDK versions

2019-10-19 Thread GitBox
kezhenxu94 merged pull request #3657: [CI] Make E2E tests run in multiple JDK versions URL: https://github.com/apache/skywalking/pull/3657 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336742477 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgre

[GitHub] [skywalking] aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336742634 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgres

[GitHub] [skywalking] wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-19 Thread GitBox
wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#issuecomment-544179432 Please resolved the conflict. And as #3657 merged, more JVM versions are tested, please add your case to e2e test group 1, named as `Single

[GitHub] [skywalking] wu-sheng opened a new issue #3658: Make agent plugin tests in PR only necessary.

2019-10-19 Thread GitBox
wu-sheng opened a new issue #3658: Make agent plugin tests in PR only necessary. URL: https://github.com/apache/skywalking/issues/3658 Today, we have 3 agent test jobs, lead by @dmsolr and jenkins setup by @kezhenxu94. With many contributors' help, especially @arugal, over 1/3 cases have b

[GitHub] [skywalking] wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary.

2019-10-19 Thread GitBox
wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary. URL: https://github.com/apache/skywalking/issues/3658#issuecomment-544182010 This is only a high priority work, but we should do it. This is an a

[GitHub] [skywalking] wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary.

2019-10-19 Thread GitBox
wu-sheng commented on issue #3658: Make agent plugin tests in PR only necessary. URL: https://github.com/apache/skywalking/issues/3658#issuecomment-544181967 There is one hard job in this, which is the submodule update check. So, we have to compare the file after `submodule update`, but exc

[GitHub] [skywalking] wu-sheng edited a comment on issue #3658: Make agent plugin tests in PR only necessary.

2019-10-19 Thread GitBox
wu-sheng edited a comment on issue #3658: Make agent plugin tests in PR only necessary. URL: https://github.com/apache/skywalking/issues/3658#issuecomment-544182010 This is not a high priority work, but we should do it. This

[GitHub] [skywalking] wu-sheng commented on issue #3630: aliyun ons plugin

2019-10-19 Thread GitBox
wu-sheng commented on issue #3630: aliyun ons plugin URL: https://github.com/apache/skywalking/issues/3630#issuecomment-544189501 Any update? Are you going to host the plugin repo by yourself? This is an automated message from

[GitHub] [skywalking] aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336742634 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgres

[GitHub] [skywalking-kubernetes] hanahmily commented on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox
hanahmily commented on issue #21: modify role to clusterrole URL: https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544210430 Most of it looks great. Thanks @innerpeacez. We leverage oap permission here is because envoy recevier intends to access API server get informati

[GitHub] [skywalking-website] dmsolr opened a new pull request #65: add committer

2019-10-19 Thread GitBox
dmsolr opened a new pull request #65: add committer URL: https://github.com/apache/skywalking-website/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #65: add committer

2019-10-19 Thread GitBox
kezhenxu94 commented on a change in pull request #65: add committer URL: https://github.com/apache/skywalking-website/pull/65#discussion_r336760024 ## File path: docs/events/README.md ## @@ -1,5 +1,9 @@ # SkyWalking Events +## Welcome Haochao Zhuang as new committer R

[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #65: add committer

2019-10-19 Thread GitBox
kezhenxu94 commented on a change in pull request #65: add committer URL: https://github.com/apache/skywalking-website/pull/65#discussion_r336760008 ## File path: docs/zh/events/README.md ## @@ -1,5 +1,9 @@ # SkyWalking 事件概要 +## 欢迎庄浩潮成为新的committer +## 2019 年 10 月 20 日

[GitHub] [skywalking-website] kezhenxu94 commented on a change in pull request #65: add committer

2019-10-19 Thread GitBox
kezhenxu94 commented on a change in pull request #65: add committer URL: https://github.com/apache/skywalking-website/pull/65#discussion_r336760024 ## File path: docs/events/README.md ## @@ -1,5 +1,9 @@ # SkyWalking Events +## Welcome Haochao Zhuang as new committer R

[GitHub] [skywalking-website] kezhenxu94 merged pull request #65: add committer

2019-10-19 Thread GitBox
kezhenxu94 merged pull request #65: add committer URL: https://github.com/apache/skywalking-website/pull/65 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[skywalking-website] branch master updated: add committer (#65)

2019-10-19 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new c53655b add committer (#65) c53

[skywalking-website] branch asf-site updated (9f8e3db -> aa9b9d4)

2019-10-19 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 9f8e3db Update asf-site new aa9b9d4 Update asf-site This update added new revisions after undo

[GitHub] [skywalking] aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
aderm commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336761804 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgres

[GitHub] [skywalking] dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336762336 ## File path: test/plugin/scenarios/postgresql-scenario/src/main/java/org/apache/skywalking/apm/testcase/postgre

[GitHub] [skywalking] dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
dmsolr commented on a change in pull request #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#discussion_r336762392 ## File path: test/plugin/scenarios/postgresql-scenario/pom.xml ## @@ -36,26 +36,47 @@ 2.1.4

[GitHub] [skywalking] wu-sheng closed issue #3588: Endpoint Topology

2019-10-19 Thread GitBox
wu-sheng closed issue #3588: Endpoint Topology URL: https://github.com/apache/skywalking/issues/3588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking-kubernetes] wu-sheng commented on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox
wu-sheng commented on issue #21: modify role to clusterrole URL: https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544222778 > Most of it looks great. Thanks @innerpeacez. We leverage oap permission here is because envoy recevier intends to access API server get informat

[GitHub] [skywalking-kubernetes] wu-sheng commented on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox
wu-sheng commented on issue #21: modify role to clusterrole URL: https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544222916 Change the document step 2-3 and guide the user to use the helm, please This is a

[GitHub] [skywalking] x22x22 opened a new pull request #3659: sync ui

2019-10-19 Thread GitBox
x22x22 opened a new pull request #3659: sync ui URL: https://github.com/apache/skywalking/pull/3659 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544223417 /run agent-plugin-test-3 This is an automated message from the Apache Gi

[GitHub] [skywalking] wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario

2019-10-19 Thread GitBox
wu-sheng commented on issue #3644: [test/plugin] immigrate postgresql scenario URL: https://github.com/apache/skywalking/pull/3644#issuecomment-544223607 @aderm The workload 3 is back online. Please move the job to workload 3, group 2. --

[GitHub] [skywalking-kubernetes] innerpeacez commented on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox
innerpeacez commented on issue #21: modify role to clusterrole URL: https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544223683 I will add a `oap.envoy.sla.enabled` key to the values.yaml file to control whether envoy sla is turned on. And when turned on, clusterrole wil

[GitHub] [skywalking-kubernetes] innerpeacez edited a comment on issue #21: modify role to clusterrole

2019-10-19 Thread GitBox
innerpeacez edited a comment on issue #21: modify role to clusterrole URL: https://github.com/apache/skywalking-kubernetes/pull/21#issuecomment-544223683 I will add a `oap.envoy.als.enabled` key to the values.yaml file to control whether envoy sla is turned on. And when turned on, clusterr