[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545293564 Sorry to hide some information for security reasons. This is an automated

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290859 "Hystrix/..." in screenshot #1 is rgb(110, 64, 170) color, which is the color of service "...-center" in red arrow pointed in scre

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290859 "Hystrix/..." in screenshot #1 is rgb(110, 64, 170) color, which is the color of service "...-center" in red arrow pointed in scre

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290859 "Hystrix/..." in screenshot #1 is rgb(110, 64, 170) color, which is the color of service "...-center" in red arrow pointed in scre

[GitHub] [skywalking] jadezhong edited a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong edited a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290859 "Hystrix/..." in screenshot #1 is rgb(110, 64, 170) color, which is the color of service in red arrow pointed in screenshot #2, so

[GitHub] [skywalking] wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545291510 Make sense to me. Please continue. This is an automat

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290859 "Hystrix/..." in red block is blong to rgb(65, 125, 224) color, which is the color of service "...-api", so it should belong to this servi

[GitHub] [skywalking] dmsolr commented on a change in pull request #3591: feat: add support of mongodb v3.7.x or higher

2019-10-22 Thread GitBox
dmsolr commented on a change in pull request #3591: feat: add support of mongodb v3.7.x or higher URL: https://github.com/apache/skywalking/pull/3591#discussion_r337869095 ## File path: apm-sniffer/apm-sdk-plugin/mongodb-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/mon

[GitHub] [skywalking] jadezhong removed a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong removed a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545289949 ![image](https://user-images.githubusercontent.com/49858897/67364188-a3504f80-f5a1-11e9-89e4-dccdd74ee607.png) -

[GitHub] [skywalking] kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545290322 - [ ] list the changed file sets to trigger/skip E2E, CI, Agent Test - [ ] changed file sets to trigger E2E

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545290302 ![image](https://user-images.githubusercontent.com/49858897/67364269-cbd84980-f5a1-11e9-8fc5-ae846fe1defe.png) --

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545289949 ![image](https://user-images.githubusercontent.com/49858897/67364188-a3504f80-f5a1-11e9-89e4-dccdd74ee607.png) --

[GitHub] [skywalking] wu-sheng commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI. URL: https://github.com/apache/skywalking/pull/3682#issuecomment-545289676 But it will still misguide user. I want to offer a branch, istio-ci, which could use jenkins and our infra too, and don'

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545289566 ![image](https://user-images.githubusercontent.com/49858897/67364112-756b0b00-f5a1-11e9-8047-b184e6f25bf1.png) --

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545289186 ![image](https://user-images.githubusercontent.com/49858897/67364019-494f8a00-f5a1-11e9-9320-433804ca9ed0.png) --

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545288818 ![image](https://user-images.githubusercontent.com/49858897/67363945-17d6be80-f5a1-11e9-8d5e-541455a4365c.png) --

[GitHub] [skywalking] jadezhong removed a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong removed a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545288149 ![image](https://user-images.githubusercontent.com/49858897/67363836-c6c6ca80-f5a0-11e9-886b-9f60f42666d5.png) -

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545288149 ![image](https://user-images.githubusercontent.com/49858897/67363836-c6c6ca80-f5a0-11e9-886b-9f60f42666d5.png) --

[GitHub] [skywalking] jadezhong removed a comment on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong removed a comment on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545287328 ![image](https://user-images.githubusercontent.com/49858897/67363085-27ed9e80-f59f-11e9-9fe8-28e29f59d480.png) "Hystrix/..." i

[GitHub] [skywalking] jadezhong commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545287328 ![image](https://user-images.githubusercontent.com/49858897/67363085-27ed9e80-f59f-11e9-9fe8-28e29f59d480.png) "Hystrix/..." in red blo

[GitHub] [skywalking] hanahmily commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI.

2019-10-22 Thread GitBox
hanahmily commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI. URL: https://github.com/apache/skywalking/pull/3682#issuecomment-545280238 I prefer to upstream/master branch. we need latest code base to verify the process, especially in the CI step. a

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#discussion_r337853610 ## File path: test/e2e/e2e-mysql/pom.xml ## @@ -0,0 +1,145 @@ + + + +http://maven.apache.org/POM/4.0.

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#discussion_r337853698 ## File path: test/e2e/e2e-mysql/pom.xml ## @@ -0,0 +1,145 @@ + + + +http://maven.apache.org/POM/4.0.

[GitHub] [skywalking] wu-sheng commented on issue #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
wu-sheng commented on issue #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#issuecomment-545259656 @JaredTan95 Is this good? This is an automated message from t

[GitHub] [skywalking] wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#issuecomment-545257154 @kezhenxu94 I think more guide is required This is an automated message fr

[GitHub] [skywalking] wu-sheng commented on issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
wu-sheng commented on issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687#issuecomment-545256901 Screenshot? All endpoints belong to service for sure. This is an automated

[GitHub] [skywalking] tristaZero commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
tristaZero commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#issuecomment-545254407 > @tristaZero Any update about this? @wu-sheng @kezhenxu94 I just followed the steps of #3648 (comment), but actually, i don't wha

[GitHub] [skywalking] wu-sheng commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI. URL: https://github.com/apache/skywalking/pull/3682#issuecomment-545253569 Do you two need to collaborate in upstream code base? Or just a fork repo is good enough? Your process is clear to me

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337829296 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/so

[GitHub] [skywalking] mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
mrproliu commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337825252 ## File path: test/plugin/scenarios/netty-socketio-scenario/config/expectedData.yaml ## @@ -0,0 +1,97 @@ +#

[GitHub] [skywalking] dominicqi commented on a change in pull request #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
dominicqi commented on a change in pull request #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#discussion_r337824231 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/w

[GitHub] [skywalking] hanahmily commented on issue #3685: How to config envoy to upload the trace data

2019-10-22 Thread GitBox
hanahmily commented on issue #3685: How to config envoy to upload the trace data URL: https://github.com/apache/skywalking/issues/3685#issuecomment-545233581 @UchihaWen if your listener config comes from static config file instead of LDS, I think I can help. pls follow this example: ```

[GitHub] [skywalking] jadezhong opened a new issue #3687: Some endpoint not belong to any service

2019-10-22 Thread GitBox
jadezhong opened a new issue #3687: Some endpoint not belong to any service URL: https://github.com/apache/skywalking/issues/3687 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requireme

[GitHub] [skywalking] hanahmily commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI.

2019-10-22 Thread GitBox
hanahmily commented on issue #3682: pre-requirement to make istio/envoy ci test happen in CI. URL: https://github.com/apache/skywalking/pull/3682#issuecomment-545230476 Sure, let me clarify it more clear. I don’t intend to finish this task before the next release. The process should be l

[GitHub] [skywalking] aderm commented on a change in pull request #3618: add postgresql plugin agent sql param show

2019-10-22 Thread GitBox
aderm commented on a change in pull request #3618: add postgresql plugin agent sql param show URL: https://github.com/apache/skywalking/pull/3618#discussion_r337819155 ## File path: apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/define/

[GitHub] [skywalking] aderm commented on issue #3618: add postgresql plugin agent sql param show

2019-10-22 Thread GitBox
aderm commented on issue #3618: add postgresql plugin agent sql param show URL: https://github.com/apache/skywalking/pull/3618#issuecomment-545225647 ok This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] aderm edited a comment on issue #3583: Plugin test-cases immigrate plan

2019-10-22 Thread GitBox
aderm edited a comment on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-545190113 > > I will immigrate elasticsearch-5.x-scenario > > For elasticsearch client, I could 6.x and 7.x could be tested, if not supported, I

[GitHub] [skywalking] x22x22 commented on issue #3683: ServiceInstanceRelation set error id

2019-10-22 Thread GitBox
x22x22 commented on issue #3683: ServiceInstanceRelation set error id URL: https://github.com/apache/skywalking/pull/3683#issuecomment-545191668 > @x22x22 This seems interesting. If we could enhance the topology, I think we should do this in 6.6 too. ok -

[GitHub] [skywalking] aderm commented on issue #3583: Plugin test-cases immigrate plan

2019-10-22 Thread GitBox
aderm commented on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-545190113 > > I will immigrate elasticsearch-5.x-scenario > > For elasticsearch client, I could 6.x and 7.x could be tested, if not supported, I hope it

[GitHub] [skywalking-ui] wu-sheng closed issue #242: How to establish the relationship between icon in public/img/node and component ID?

2019-10-22 Thread GitBox
wu-sheng closed issue #242: How to establish the relationship between icon in public/img/node and component ID? URL: https://github.com/apache/skywalking-ui/issues/242 This is an automated message from the Apache Git Service

[GitHub] [skywalking-ui] wu-sheng commented on issue #242: How to establish the relationship between icon in public/img/node and component ID?

2019-10-22 Thread GitBox
wu-sheng commented on issue #242: How to establish the relationship between icon in public/img/node and component ID? URL: https://github.com/apache/skywalking-ui/issues/242#issuecomment-545166025 No activity in this repo. Th

[GitHub] [skywalking] wu-sheng merged pull request #3667: feat: add test case for mongodb-3.x-plugin

2019-10-22 Thread GitBox
wu-sheng merged pull request #3667: feat: add test case for mongodb-3.x-plugin URL: https://github.com/apache/skywalking/pull/3667 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [skywalking] wu-sheng commented on issue #3667: feat: add test case for mongodb-3.x-plugin

2019-10-22 Thread GitBox
wu-sheng commented on issue #3667: feat: add test case for mongodb-3.x-plugin URL: https://github.com/apache/skywalking/pull/3667#issuecomment-545113420 Welcome to be our new contributor. This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#issuecomment-545113290 @tristaZero Any update about this? This is an automated message from the A

[GitHub] [skywalking] wu-sheng merged pull request #3686: [test/plugin] immigrate elasticsearch-5.x scenario

2019-10-22 Thread GitBox
wu-sheng merged pull request #3686: [test/plugin] immigrate elasticsearch-5.x scenario URL: https://github.com/apache/skywalking/pull/3686 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking] branch master updated: [test/plugin] immigrate elasticsearch-5.x scenario (#3686)

2019-10-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7273e63 [test/plugin] immigrate elasticsea

[GitHub] [skywalking] wu-sheng commented on issue #3686: [test/plugin] immigrate elasticsearch-5.x scenario

2019-10-22 Thread GitBox
wu-sheng commented on issue #3686: [test/plugin] immigrate elasticsearch-5.x scenario URL: https://github.com/apache/skywalking/pull/3686#issuecomment-545061309 Related to #3583 This is an automated message from the Apache Gi

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#discussion_r337638541 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/wo

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#discussion_r337638729 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/wo

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#discussion_r337639252 ## File path: docs/en/setup/backend/telemetry/trace-mode-grafana.json ## @@ -1158,14 +1158,

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671

2019-10-22 Thread GitBox
wu-sheng commented on a change in pull request #3677: Add register persistent worker latency metrics #3671 URL: https://github.com/apache/skywalking/pull/3677#discussion_r337636990 ## File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/register/wo

[GitHub] [skywalking] wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545051907 I think this is a good todo list. Follow this please

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
kezhenxu94 edited a comment on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545050780 TODO list in this PR (or maybe following PR) for record - [x] submodule changes should trigger build

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
kezhenxu94 edited a comment on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545050780 TODO list in this PR (or maybe following PR) for record - [x] submodule changes should trigger build

[GitHub] [skywalking] kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545050780 TODO list in this PR (or maybe following PR) for record [x] submodule changes should trigger build [ ] comm

[GitHub] [skywalking] wu-sheng commented on issue #3672: Alarm Message

2019-10-22 Thread GitBox
wu-sheng commented on issue #3672: Alarm Message URL: https://github.com/apache/skywalking/issues/3672#issuecomment-545048346 Added. This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [skywalking] wu-sheng merged pull request #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
wu-sheng merged pull request #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680 This is an automated message from the Apache Git Service. To respond to the message, ple

[skywalking] branch master updated (26b1d41 -> 2f3d009)

2019-10-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 26b1d41 Supporting RequestRateLimiterGatewayFilterFactory (#3538) add 2f3d009 Makes the scope of alarm me

[GitHub] [skywalking] wu-sheng closed issue #3672: Alarm Message

2019-10-22 Thread GitBox
wu-sheng closed issue #3672: Alarm Message URL: https://github.com/apache/skywalking/issues/3672 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [skywalking] aderm commented on issue #3686: [test/plugin] immigrate elasticsearch-5.x scenario

2019-10-22 Thread GitBox
aderm commented on issue #3686: [test/plugin] immigrate elasticsearch-5.x scenario URL: https://github.com/apache/skywalking/pull/3686#issuecomment-545039869 /run agent-plugin-test-3 This is an automated message from the Apac

[GitHub] [skywalking] aderm opened a new pull request #3686: [test/plugin] immigrate elasticsearch-5.x scenario

2019-10-22 Thread GitBox
aderm opened a new pull request #3686: [test/plugin] immigrate elasticsearch-5.x scenario URL: https://github.com/apache/skywalking/pull/3686 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided

[GitHub] [skywalking] laojiang342200 commented on issue #3557: Support dynamically configure alarm settings

2019-10-22 Thread GitBox
laojiang342200 commented on issue #3557: Support dynamically configure alarm settings URL: https://github.com/apache/skywalking/pull/3557#issuecomment-545019298 Thank you very much! @kezhenxu94 @wu-sheng This is an automated

[GitHub] [skywalking] laojiang342200 commented on issue #3557: Support dynamically configure alarm settings

2019-10-22 Thread GitBox
laojiang342200 commented on issue #3557: Support dynamically configure alarm settings URL: https://github.com/apache/skywalking/pull/3557#issuecomment-545018898 Thank you very much!We really need this feature! This is an auto

[GitHub] [skywalking] wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680#issuecomment-545015018 /run agent-plugin-test-3 This is an automated message from the Apac

[GitHub] [skywalking] JaredTan95 commented on issue #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
JaredTan95 commented on issue #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680#issuecomment-545014292 /run ci This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-545011899 After you verify the submodule, we could work on the rules, and notify the dev ml and committer team. ---

[GitHub] [skywalking] kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
kezhenxu94 commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-544997176 @wu-sheng the effect should look like this, if it looks good to you, I'll start to fill up the rules, and try to fee

[skywalking] branch scope_name updated (aa514ab -> bddcac4)

2019-10-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from aa514ab fix coveralls. add bddcac4 fix ci. No new revisions were added by this update. Summary of c

[GitHub] [skywalking] wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680#issuecomment-544987679 @JaredTan95 unit test fails. Please recheck. This is an automated m

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#discussion_r337527593 ## File path: test/e2e/run.sh ## @@ -59,8 +68,23 @@ do # Some of the tests will modify files in th

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#discussion_r337527663 ## File path: test/e2e/run.sh ## @@ -59,8 +68,23 @@ do # Some of the tests will modify files in th

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on a change in pull request #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#discussion_r337527303 ## File path: test/e2e/run.sh ## @@ -59,8 +68,23 @@ do # Some of the tests will modify files in th

[GitHub] [skywalking] wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680#issuecomment-544971519 /run ci This is an automated message from the Apache Git Service. T

[GitHub] [skywalking] kezhenxu94 commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider.

2019-10-22 Thread GitBox
kezhenxu94 commented on issue #3648: Add Jenkinsfile-E2E using MySQL provider. URL: https://github.com/apache/skywalking/pull/3648#issuecomment-544966175 > @kezhenxu94 I remember you said, this test should be separated from the existing one, to avoid further conflict? Is it? If YES, I think

[GitHub] [skywalking] kezhenxu94 commented on issue #3682: for #3669

2019-10-22 Thread GitBox
kezhenxu94 commented on issue #3682: for #3669 URL: https://github.com/apache/skywalking/pull/3682#issuecomment-544964443 @innerpeacez can you re-title this PR? It's too vague, note that it will become the commit message in our codebase commit history --

[GitHub] [skywalking] wu-sheng commented on issue #3685: How to config envoy to upload the trace data

2019-10-22 Thread GitBox
wu-sheng commented on issue #3685: How to config envoy to upload the trace data URL: https://github.com/apache/skywalking/issues/3685#issuecomment-544960581 Envoy must be controlled by istio, read #3682 , search my speech at KubeCon China about als solution. ---

[GitHub] [skywalking] wu-sheng closed issue #3685: How to config envoy to upload the trace data

2019-10-22 Thread GitBox
wu-sheng closed issue #3685: How to config envoy to upload the trace data URL: https://github.com/apache/skywalking/issues/3685 This is an automated message from the Apache Git Service. To respond to the message, please log o

[skywalking] branch scope_name updated (b27a7c1 -> aa514ab)

2019-10-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b27a7c1 fix coveralls. add aa514ab fix coveralls. No new revisions were added by this update. Summa

[skywalking] branch scope_name updated (6dd303f -> b27a7c1)

2019-10-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6dd303f Merge branch 'master' into scope_name add b27a7c1 fix coveralls. No new revisions were added

[GitHub] [skywalking] wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3680: Makes the scope of alarm message more semantic. URL: https://github.com/apache/skywalking/pull/3680#issuecomment-544937388 /run agent-plugin-test-1 This is an automated message from the Apac

[GitHub] [skywalking] surechen commented on a change in pull request #3676: Add componentId for apache servicecomb.

2019-10-22 Thread GitBox
surechen commented on a change in pull request #3676: Add componentId for apache servicecomb. URL: https://github.com/apache/skywalking/pull/3676#discussion_r337482768 ## File path: oap-server/server-starter/src/main/resources/component-libraries.yml ## @@ -254,6 +254,9 @@

[GitHub] [skywalking] UchihaWen opened a new issue #3685: How to config envoy to upload the trace data

2019-10-22 Thread GitBox
UchihaWen opened a new issue #3685: How to config envoy to upload the trace data URL: https://github.com/apache/skywalking/issues/3685 help needed!!! When I use the example https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md I can not find

[GitHub] [skywalking] dmsolr commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
dmsolr commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337475410 ## File path: apm-sniffer/apm-sdk-plugin/netty-socketio-plugin/src/main/java/org/apache/skywalking/apm/plugin/netty/sock

[GitHub] [skywalking] dmsolr commented on a change in pull request #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
dmsolr commented on a change in pull request #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#discussion_r337468920 ## File path: test/plugin/scenarios/netty-socketio-scenario/config/expectedData.yaml ## @@ -0,0 +1,97 @@ +# Li

[GitHub] [skywalking] wu-sheng commented on issue #3618: add postgresql plugin agent sql param show

2019-10-22 Thread GitBox
wu-sheng commented on issue #3618: add postgresql plugin agent sql param show URL: https://github.com/apache/skywalking/pull/3618#issuecomment-544925783 This should continue. This is an automated message from the Apache Git S

[GitHub] [skywalking] wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds

2019-10-22 Thread GitBox
wu-sheng commented on issue #3662: [WIP] Add CI build job barriers to prevent unnecessary builds URL: https://github.com/apache/skywalking/pull/3662#issuecomment-544924510 ~400/700+ test cases have been moved. Seems the priority of this PR is increasing :P @arugal is super crazy ab

[skywalking] branch scope_name updated (7f8aa3b -> 6dd303f)

2019-10-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 7f8aa3b Merge branch 'master' into scope_name add 26b1d41 Supporting RequestRateLimiterGatewayFilterF

[skywalking] branch master updated (9996fbb -> 26b1d41)

2019-10-22 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 9996fbb [test/plugin] docker prune at cleanup (#3679) add 26b1d41 Supporting RequestRateLimiterGatewayFil

[GitHub] [skywalking] wu-sheng merged pull request #3538: Supporting RequestRateLimiterGatewayFilterFactory

2019-10-22 Thread GitBox
wu-sheng merged pull request #3538: Supporting RequestRateLimiterGatewayFilterFactory URL: https://github.com/apache/skywalking/pull/3538 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [skywalking] wu-sheng closed issue #3526: Asynchronous use feign, lost link

2019-10-22 Thread GitBox
wu-sheng closed issue #3526: Asynchronous use feign, lost link URL: https://github.com/apache/skywalking/issues/3526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #3526: Asynchronous use feign, lost link

2019-10-22 Thread GitBox
wu-sheng commented on issue #3526: Asynchronous use feign, lost link URL: https://github.com/apache/skywalking/issues/3526#issuecomment-544914292 No update in 26 days. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng closed issue #3630: aliyun ons plugin

2019-10-22 Thread GitBox
wu-sheng closed issue #3630: aliyun ons plugin URL: https://github.com/apache/skywalking/issues/3630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] wu-sheng commented on issue #3630: aliyun ons plugin

2019-10-22 Thread GitBox
wu-sheng commented on issue #3630: aliyun ons plugin URL: https://github.com/apache/skywalking/issues/3630#issuecomment-544914106 Closing with no response. This is an automated message from the Apache Git Service. To respond t

[GitHub] [skywalking] mrproliu commented on issue #3640: Provide agent plugin netty-socketio

2019-10-22 Thread GitBox
mrproliu commented on issue #3640: Provide agent plugin netty-socketio URL: https://github.com/apache/skywalking/pull/3640#issuecomment-544913938 /run agent-plugin-test This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #3676: Add componentId for apache servicecomb.

2019-10-22 Thread GitBox
wu-sheng commented on issue #3676: Add componentId for apache servicecomb. URL: https://github.com/apache/skywalking/pull/3676#issuecomment-544913653 More discussion happens here, https://issues.apache.org/jira/browse/SCB-1497

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3676: Add componentId for apache servicecomb.

2019-10-22 Thread GitBox
wu-sheng commented on a change in pull request #3676: Add componentId for apache servicecomb. URL: https://github.com/apache/skywalking/pull/3676#discussion_r337454596 ## File path: oap-server/server-starter/src/main/resources/component-libraries.yml ## @@ -254,6 +254,9 @@

[GitHub] [skywalking] wu-sheng commented on issue #3583: Plugin test-cases immigrate plan

2019-10-22 Thread GitBox
wu-sheng commented on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-544911947 > l will immigreate undertow scenario and test whether to support undertow1.x . If it is, please update the supported-list.md document. --

[GitHub] [skywalking] arugal commented on issue #3583: Plugin test-cases immigrate plan

2019-10-22 Thread GitBox
arugal commented on issue #3583: Plugin test-cases immigrate plan URL: https://github.com/apache/skywalking/issues/3583#issuecomment-544907846 l will immigreate undertow scenario and test whether to support undertow1.x . This

[skywalking] branch scope_name updated (1d43030 -> 7f8aa3b)

2019-10-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1d43030 update test case. add 9996fbb [test/plugin] docker prune at cleanup (#3679) add 7f8aa3b

[skywalking] branch scope_name updated (57f106c -> 1d43030)

2019-10-22 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch scope_name in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 57f106c Merge branch 'master' into scope_name add 1d43030 update test case. No new revisions were ad

  1   2   >