[GitHub] [skywalking] codecov-io commented on issue #3904: [WIP] Add OAP+Istio(mixer) to CI pipeline

2019-11-29 Thread GitBox
codecov-io commented on issue #3904: [WIP] Add OAP+Istio(mixer) to CI pipeline URL: https://github.com/apache/skywalking/pull/3904#issuecomment-559923266 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3904?src=pr&el=h1) Report > Merging [#3904](https://codecov.io/gh/apache/sky

[GitHub] [skywalking] aderm commented on issue #3984: trace is not displayed complete in the UI

2019-11-29 Thread GitBox
aderm commented on issue #3984: trace is not displayed complete in the UI URL: https://github.com/apache/skywalking/issues/3984#issuecomment-559922833 OK, let ’s take a closer look at this question This is an automated message

[GitHub] [skywalking] codecov-io commented on issue #3948: Immigrate test mysql scenario.

2019-11-29 Thread GitBox
codecov-io commented on issue #3948: Immigrate test mysql scenario. URL: https://github.com/apache/skywalking/pull/3948#issuecomment-559921525 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3948?src=pr&el=h1) Report > Merging [#3948](https://codecov.io/gh/apache/skywalking/pul

[GitHub] [skywalking] wu-sheng commented on issue #3985: skywalking springcloud gateway plugin not suppot springcloud greenwish sr4

2019-11-29 Thread GitBox
wu-sheng commented on issue #3985: skywalking springcloud gateway plugin not suppot springcloud greenwish sr4 URL: https://github.com/apache/skywalking/issues/3985#issuecomment-559920848 Gateway is a very complex scenario, @zhaoyuguang @ascrutae Please take a look. @seifeHu Please t

[GitHub] [skywalking] wu-sheng commented on issue #3984: trace is not displayed complete in the UI

2019-11-29 Thread GitBox
wu-sheng commented on issue #3984: trace is not displayed complete in the UI URL: https://github.com/apache/skywalking/issues/3984#issuecomment-559920684 @aderm Also, you should have been familiar with SkyWalking plugin system, you could try to debug and find out why first. ---

[GitHub] [skywalking] wu-sheng commented on issue #3984: trace is not displayed complete in the UI

2019-11-29 Thread GitBox
wu-sheng commented on issue #3984: trace is not displayed complete in the UI URL: https://github.com/apache/skywalking/issues/3984#issuecomment-559920635 Basically, you are talking about ShardingSphere plugin issue. So I am forwarding this to @tuohai666 @tristaZero @terrymanu

[GitHub] [skywalking] wu-sheng commented on issue #3984: trace is not displayed complete in the UI

2019-11-29 Thread GitBox
wu-sheng commented on issue #3984: trace is not displayed complete in the UI URL: https://github.com/apache/skywalking/issues/3984#issuecomment-559920645 Ref to #3777 due to related maybe. This is an automated message from the

[GitHub] [skywalking] seifeHu opened a new issue #3985: skywalking springcloud gateway plugin not suppot springcloud greenwish sr4

2019-11-29 Thread GitBox
seifeHu opened a new issue #3985: skywalking springcloud gateway plugin not suppot springcloud greenwish sr4 URL: https://github.com/apache/skywalking/issues/3985 ### Bug - Which version of SkyWalking, OS and JRE? skywalking version 6.5 springcloud version greenwish SR4 (Spri

[GitHub] [skywalking] wayilau commented on issue #3948: Immigrate test mysql scenario.

2019-11-29 Thread GitBox
wayilau commented on issue #3948: Immigrate test mysql scenario. URL: https://github.com/apache/skywalking/pull/3948#issuecomment-559919197 > You should add MySQL As a separated group in that test case, named As MySQL case like others. ok

[GitHub] [skywalking] codecov-io edited a comment on issue #3945: webflux-reactive

2019-11-29 Thread GitBox
codecov-io edited a comment on issue #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr&el=h1) Report > Merging [#3945](https://codecov.io/gh/apache/skywalking/pull/3945?

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352268800 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the speci

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352268740 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the specif

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352268601 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the speci

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352268304 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the specif

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352267608 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the speci

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352267479 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the specif

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352267319 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -2,7 +2,7 @@ # or more contributor license agreem

[GitHub] [skywalking] codecov-io commented on issue #3978: [Feature] Service instance dependency

2019-11-29 Thread GitBox
codecov-io commented on issue #3978: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-559912552 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3978?src=pr&el=h1) Report > Merging [#3978](https://codecov.io/gh/apache/skywalk

[GitHub] [skywalking] codecov-io commented on issue #3945: webflux-reactive

2019-11-29 Thread GitBox
codecov-io commented on issue #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr&el=h1) Report > Merging [#3945](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr&

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352265150 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -2,7 +2,7 @@ # or more contributor license agree

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352265306 ## File path: test/plugin/scenarios/webflux-scenario/support-version.list ## @@ -14,21 +14,10 @@ # See the License for the speci

[GitHub] [skywalking] wu-sheng commented on issue #3978: [Feature] Service instance dependency

2019-11-29 Thread GitBox
wu-sheng commented on issue #3978: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-559909622 Generally, it is good. Please add test in e2e. This is an automated message fr

[skywalking] branch master updated: Bring coverage and comment back (#3972)

2019-11-29 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new bdc0609 Bring coverage and comment back

[GitHub] [skywalking] codecov-io edited a comment on issue #3972: Add coverage and comment

2019-11-29 Thread GitBox
codecov-io edited a comment on issue #3972: Add coverage and comment URL: https://github.com/apache/skywalking/pull/3972#issuecomment-559905009 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3972?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (

[GitHub] [skywalking] kezhenxu94 merged pull request #3972: Add coverage and comment

2019-11-29 Thread GitBox
kezhenxu94 merged pull request #3972: Add coverage and comment URL: https://github.com/apache/skywalking/pull/3972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [skywalking] aderm opened a new issue #3984: trace is not displayed complete in the UI

2019-11-29 Thread GitBox
aderm opened a new issue #3984: trace is not displayed complete in the UI URL: https://github.com/apache/skywalking/issues/3984 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [x] Requirement

[GitHub] [skywalking] codecov-io edited a comment on issue #3972: Add coverage and comment

2019-11-29 Thread GitBox
codecov-io edited a comment on issue #3972: Add coverage and comment URL: https://github.com/apache/skywalking/pull/3972#issuecomment-559905009 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3972?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (

[GitHub] [skywalking] codecov-io commented on issue #3972: Add coverage and comment

2019-11-29 Thread GitBox
codecov-io commented on issue #3972: Add coverage and comment URL: https://github.com/apache/skywalking/pull/3972#issuecomment-559905009 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3972?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master

[GitHub] [skywalking] dmsolr closed pull request #3983: Green Jenkins

2019-11-29 Thread GitBox
dmsolr closed pull request #3983: Green Jenkins URL: https://github.com/apache/skywalking/pull/3983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] dmsolr opened a new pull request #3983: Green Jenkins

2019-11-29 Thread GitBox
dmsolr opened a new pull request #3983: Green Jenkins URL: https://github.com/apache/skywalking/pull/3983 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [skywalking] wu-sheng closed pull request #3982: Update README.md

2019-11-29 Thread GitBox
wu-sheng closed pull request #3982: Update README.md URL: https://github.com/apache/skywalking/pull/3982 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[skywalking] 01/01: Update README.md

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 642239ae5a44f037c1af1f22575cc27338c75c35 Author: 吴晟 Wu Sheng AuthorDate: Sat Nov 30 09:10:00 2019 +0800

[GitHub] [skywalking] wu-sheng opened a new pull request #3982: Update README.md

2019-11-29 Thread GitBox
wu-sheng opened a new pull request #3982: Update README.md URL: https://github.com/apache/skywalking/pull/3982 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[skywalking] branch wu-sheng-patch-1 created (now 642239a)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 642239a Update README.md This branch includes the following new commits: new 642239a Update R

[GitHub] [skywalking] wu-sheng closed pull request #3981: Update README.md

2019-11-29 Thread GitBox
wu-sheng closed pull request #3981: Update README.md URL: https://github.com/apache/skywalking/pull/3981 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng opened a new pull request #3981: Update README.md

2019-11-29 Thread GitBox
wu-sheng opened a new pull request #3981: Update README.md URL: https://github.com/apache/skywalking/pull/3981 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[skywalking] branch wu-sheng-patch-1 created (now 11b8d7b)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 11b8d7b Update README.md No new revisions were added by this update.

[GitHub] [skywalking] wu-sheng opened a new pull request #3980: Update README.md

2019-11-29 Thread GitBox
wu-sheng opened a new pull request #3980: Update README.md URL: https://github.com/apache/skywalking/pull/3980 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[GitHub] [skywalking] wu-sheng closed pull request #3980: Update README.md

2019-11-29 Thread GitBox
wu-sheng closed pull request #3980: Update README.md URL: https://github.com/apache/skywalking/pull/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking] wu-sheng closed pull request #3980: Update README.md

2019-11-29 Thread GitBox
wu-sheng closed pull request #3980: Update README.md URL: https://github.com/apache/skywalking/pull/3980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[skywalking] 01/01: Update README.md

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 45be645cdc949a853ee1e650fd72e1a19cf711ba Author: 吴晟 Wu Sheng AuthorDate: Sat Nov 30 08:40:07 2019 +0800

[GitHub] [skywalking] wu-sheng opened a new pull request #3980: Update README.md

2019-11-29 Thread GitBox
wu-sheng opened a new pull request #3980: Update README.md URL: https://github.com/apache/skywalking/pull/3980 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance

[skywalking] branch wu-sheng-patch-1 created (now 45be645)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 45be645 Update README.md This branch includes the following new commits: new 45be645 Update R

[GitHub] [skywalking] wu-sheng commented on issue #3948: Immigrate test mysql scenario.

2019-11-29 Thread GitBox
wu-sheng commented on issue #3948: Immigrate test mysql scenario. URL: https://github.com/apache/skywalking/pull/3948#issuecomment-559897221 You should add MySQL As a separated group in that test case, named As MySQL case like others. ---

[GitHub] [skywalking] wu-sheng commented on issue #3948: Immigrate test mysql scenario.

2019-11-29 Thread GitBox
wu-sheng commented on issue #3948: Immigrate test mysql scenario. URL: https://github.com/apache/skywalking/pull/3948#issuecomment-559897136 Jenkins is not there any more. We are working out with Apache why those are still there.

[GitHub] [skywalking] wu-sheng closed pull request #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server

2019-11-29 Thread GitBox
wu-sheng closed pull request #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server URL: https://github.com/apache/skywalking/pull/3979 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] dependabot[bot] commented on issue #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server

2019-11-29 Thread GitBox
dependabot[bot] commented on issue #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server URL: https://github.com/apache/skywalking/pull/3979#issuecomment-559897063 OK, I won't notify you again about this release, but will get in touch when a new version is avail

[GitHub] [skywalking] dependabot[bot] opened a new pull request #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server

2019-11-29 Thread GitBox
dependabot[bot] opened a new pull request #3979: Bump jetty.version from 9.4.2.v20170220 to 9.4.24.v20191120 in /oap-server URL: https://github.com/apache/skywalking/pull/3979 Bumps `jetty.version` from 9.4.2.v20170220 to 9.4.24.v20191120. Updates `jetty-server` from 9.4.2.v20170220

[skywalking] branch dependabot/maven/oap-server/jetty.version-9.4.24.v20191120 created (now a6aa786)

2019-11-29 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/oap-server/jetty.version-9.4.24.v20191120 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at a6aa786 Bump jetty.version in /oap-server No new revis

[GitHub] [skywalking] wayilau commented on issue #3948: Immigrate test mysql scenario.

2019-11-29 Thread GitBox
wayilau commented on issue #3948: Immigrate test mysql scenario. URL: https://github.com/apache/skywalking/pull/3948#issuecomment-559837090 > It is very sad to tell you that you need to update the Action configuration (resolve conflicts) because those are updated after #3956 merged. Maybe

[GitHub] [skywalking] arugal commented on issue #3978: [Feature] Service instance dependency

2019-11-29 Thread GitBox
arugal commented on issue #3978: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-559832316 works like this: https://user-images.githubusercontent.com/26432832/69820525-38e39c80-123c-11ea-9a5f-0c31aade8cbc.png";> https://user-i

[GitHub] [skywalking] arugal opened a new pull request #3978: [Feature] Service instance dependency

2019-11-29 Thread GitBox
arugal opened a new pull request #3978: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improv

[skywalking] branch master updated: Delete Jenkinsfile (#3977)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 19add86 Delete Jenkinsfile (#3977) 19add86

[GitHub] [skywalking] wu-sheng merged pull request #3977: Delete Jenkinsfile due to CI on GitHub Action now

2019-11-29 Thread GitBox
wu-sheng merged pull request #3977: Delete Jenkinsfile due to CI on GitHub Action now URL: https://github.com/apache/skywalking/pull/3977 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [skywalking] arugal closed pull request #3950: [Feature] Service instance dependency

2019-11-29 Thread GitBox
arugal closed pull request #3950: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3950 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch wu-sheng-patch-1 updated (88d3b59 -> 7a20643)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 88d3b59 Delete Jenkinsfile add 87b7afc Distribute "service-apdex-threshold.yml" (#3976) ad

[skywalking] branch master updated (244ec55 -> 87b7afc)

2019-11-29 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 244ec55 skip unnecessary action (#3973) add 87b7afc Distribute "service-apdex-threshold.yml" (#3976) N

[GitHub] [skywalking] hanahmily merged pull request #3976: Distribute "service-apdex-threshold.yml"

2019-11-29 Thread GitBox
hanahmily merged pull request #3976: Distribute "service-apdex-threshold.yml" URL: https://github.com/apache/skywalking/pull/3976 This is an automated message from the Apache Git Service. To respond to the message, please log

[skywalking] branch wu-sheng-patch-1 created (now 88d3b59)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 88d3b59 Delete Jenkinsfile This branch includes the following new commits: new 88d3b59 Delete

[skywalking] 01/01: Delete Jenkinsfile

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 88d3b59d3383a1c3515853abcf02d8bff6d0b172 Author: 吴晟 Wu Sheng AuthorDate: Fri Nov 29 22:29:33 2019 +0800

[GitHub] [skywalking] wu-sheng opened a new pull request #3977: Delete Jenkinsfile due to CI on GitHub Action now

2019-11-29 Thread GitBox
wu-sheng opened a new pull request #3977: Delete Jenkinsfile due to CI on GitHub Action now URL: https://github.com/apache/skywalking/pull/3977 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [skywalking] cyejing commented on issue #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on issue #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559802428 > Are your plugin codes using JDK8 class? Could give me an example? The target codes are not related. If Your plugin could be compiled in 1.6, keep it in that way,

[skywalking] branch oap/bootstrap updated (de9fb01 -> 91a298b)

2019-11-29 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap/bootstrap in repository https://gitbox.apache.org/repos/asf/skywalking.git. from de9fb01 Update pom.xml add 91a298b Add service-apdex-threshold.yml to the config folder of rele

[GitHub] [skywalking] hanahmily opened a new pull request #3976: Update pom.xml

2019-11-29 Thread GitBox
hanahmily opened a new pull request #3976: Update pom.xml URL: https://github.com/apache/skywalking/pull/3976 Exclude "service-apdex-threshold.yml" from jar This is an automated message from the Apache Git Service. To respond

[skywalking] 01/01: Update pom.xml

2019-11-29 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch oap/bootstrap in repository https://gitbox.apache.org/repos/asf/skywalking.git commit de9fb01ef6e63762f77e94d26a4ca4db4449ec0f Author: Gao Hongtao AuthorDate: Fri Nov 29 22:04:06 2019 +0800

[skywalking] branch oap/bootstrap created (now de9fb01)

2019-11-29 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap/bootstrap in repository https://gitbox.apache.org/repos/asf/skywalking.git. at de9fb01 Update pom.xml This branch includes the following new commits: new de9fb01 Update pom.

[GitHub] [skywalking] wu-sheng commented on issue #3945: webflux-reactive

2019-11-29 Thread GitBox
wu-sheng commented on issue #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559795576 Are your plugin codes using JDK8 class? Could give me an example? The target codes are not related. If Your plugin could be compiled in 1.6, keep it in that way, r

[GitHub] [skywalking] cyejing commented on issue #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on issue #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559794701 1. Because jdk8 support is required, the general use of webflux is jdk 2. It may be because of moving the directory. Most of the content is the same.Modified oper

[GitHub] [skywalking] wu-sheng closed issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration

2019-11-29 Thread GitBox
wu-sheng closed issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration URL: https://github.com/apache/skywalking/issues/3975 This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration

2019-11-29 Thread GitBox
wu-sheng commented on issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration URL: https://github.com/apache/skywalking/issues/3975#issuecomment-559774831 Follow the document please, make sure you set the time and TZ matched among the target

[GitHub] [skywalking] wu-sheng closed issue #3974: Can edit alarm configuration directly in skywalking's console?

2019-11-29 Thread GitBox
wu-sheng closed issue #3974: Can edit alarm configuration directly in skywalking's console? URL: https://github.com/apache/skywalking/issues/3974 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [skywalking] wu-sheng commented on issue #3974: Can edit alarm configuration directly in skywalking's console?

2019-11-29 Thread GitBox
wu-sheng commented on issue #3974: Can edit alarm configuration directly in skywalking's console? URL: https://github.com/apache/skywalking/issues/3974#issuecomment-559774404 Alarm rule could be changed by Dynamic Configuration, including DCS(gRPC), ZK, or other config centers. You could r

[GitHub] [skywalking] Passeng-LUCA opened a new issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration

2019-11-29 Thread GitBox
Passeng-LUCA opened a new issue #3975: Why the skywalking UI does not show the Service,the oap and agent use default configuration URL: https://github.com/apache/skywalking/issues/3975 Please answer these questions before submitting your issue. - Why do you submit this issue? - [*

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352072508 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-reactive-plugin/src/main/java/org/apache/skywalking/a

[GitHub] [skywalking] xiaoy00 commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
xiaoy00 commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352063278 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-reactive-plugin/src/main/java/org/apache/skywalking/a

[GitHub] [skywalking] wu-sheng merged pull request #3973: skip unnecessary action

2019-11-29 Thread GitBox
wu-sheng merged pull request #3973: skip unnecessary action URL: https://github.com/apache/skywalking/pull/3973 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[skywalking] branch master updated (6475ab3 -> 244ec55)

2019-11-29 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6475ab3 Add apdex function to OAL (#3855) add 244ec55 skip unnecessary action (#3973) No new revisions w

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: webflux-reactive

2019-11-29 Thread GitBox
cyejing commented on a change in pull request #3945: webflux-reactive URL: https://github.com/apache/skywalking/pull/3945#discussion_r352051002 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-reactive-plugin/src/main/java/org/apache/skywalking/a

[GitHub] [skywalking] wu-sheng commented on issue #3950: [Feature] Service instance dependency

2019-11-29 Thread GitBox
wu-sheng commented on issue #3950: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3950#issuecomment-559726119 > Need to update the e2e test? Yes. We should. But maybe after @kezhenxu94 basic code review? --

[GitHub] [skywalking] stalary opened a new issue #3974: Can edit alarm configuration directly in skywalking's console

2019-11-29 Thread GitBox
stalary opened a new issue #3974: Can edit alarm configuration directly in skywalking's console URL: https://github.com/apache/skywalking/issues/3974 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] B

[GitHub] [skywalking] arugal commented on issue #3950: [Feature] Service instance dependency

2019-11-29 Thread GitBox
arugal commented on issue #3950: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3950#issuecomment-559721979 @wu-sheng @kezhenxu94 Need to update the e2e test? This is an automated messa

[GitHub] [skywalking] arugal commented on issue #3950: [Feature] Service instance dependency

2019-11-29 Thread GitBox
arugal commented on issue #3950: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3950#issuecomment-559721282 > @arugal For you, I think you need to update a document about storage extension. https://github.com/apache/skywalking/blob/master/docs/en/guide

[GitHub] [skywalking] wu-sheng commented on issue #3973: skip unnecessary action

2019-11-29 Thread GitBox
wu-sheng commented on issue #3973: skip unnecessary action URL: https://github.com/apache/skywalking/pull/3973#issuecomment-559718463 > Why not add skip condition to the other checks Because I required the `required check`. In GitHub Action, if skip happens, it never shows as passed

[GitHub] [skywalking] wu-sheng commented on issue #3950: [Feature] Service instance dependency

2019-11-29 Thread GitBox
wu-sheng commented on issue #3950: [Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3950#issuecomment-559716608 First, codes look good enough, but I also prefer others could review too. @kezhenxu94 Do you have time to do this? @arugal For you, I th

[GitHub] [skywalking] wu-sheng commented on issue #3973: skip unnecessary action

2019-11-29 Thread GitBox
wu-sheng commented on issue #3973: skip unnecessary action URL: https://github.com/apache/skywalking/pull/3973#issuecomment-559704873 Skip successfully. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [skywalking] wu-sheng closed issue #3957: Is possible can do search log with traceId from elasticSearch In skywalking UI

2019-11-29 Thread GitBox
wu-sheng closed issue #3957: Is possible can do search log with traceId from elasticSearch In skywalking UI URL: https://github.com/apache/skywalking/issues/3957 This is an automated message from the Apache Git Service. To