[GitHub] [skywalking] YangXueJun opened a new issue #3996: javassist.compiler.CompileError: setSkyWalkingDynamicField(java.lang.Object)

2019-12-02 Thread GitBox
YangXueJun opened a new issue #3996: javassist.compiler.CompileError: setSkyWalkingDynamicField(java.lang.Object) URL: https://github.com/apache/skywalking/issues/3996 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or d

[GitHub] [skywalking] innerpeacez commented on issue #3904: [WIP] Add OAP+Istio(mixer) to CI pipeline

2019-12-02 Thread GitBox
innerpeacez commented on issue #3904: [WIP] Add OAP+Istio(mixer) to CI pipeline URL: https://github.com/apache/skywalking/pull/3904#issuecomment-560963278 @wu-sheng conflict fixed.I think it can be merged, I will create a new pr to complete the data verification steps.

[GitHub] [skywalking] seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560514817 > Header is for propagation, it is just required in the HTTP header. But you n

[GitHub] [skywalking] arugal edited a comment on issue #3978: [WIP][Feature] Service instance dependency

2019-12-02 Thread GitBox
arugal edited a comment on issue #3978: [WIP][Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-560466042 e2e cluster is not yet complete. This is an automated message from

[GitHub] [skywalking] arugal commented on issue #3978: [WIP][Feature] Service instance dependency

2019-12-02 Thread GitBox
arugal commented on issue #3978: [WIP][Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-560466042 E2e cluster is not yet complete. This is an automated message from the Apac

[GitHub] [skywalking] arugal commented on issue #3978: [WIP][Feature] Service instance dependency

2019-12-02 Thread GitBox
arugal commented on issue #3978: [WIP][Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#issuecomment-560449314 From the latest query protocol. ![image](https://user-images.githubusercontent.com/26432832/69972482-a6edd380-155c-11ea-84f8-71f8ba70cff0

[skywalking] branch master updated: apdex include for es7 (#3995)

2019-12-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d62f29c apdex include for es7 (#3995) d62f

[GitHub] [skywalking] wu-sheng merged pull request #3995: Distribute "service-apdex-threshold.yml" for es7

2019-12-02 Thread GitBox
wu-sheng merged pull request #3995: Distribute "service-apdex-threshold.yml" for es7 URL: https://github.com/apache/skywalking/pull/3995 This is an automated message from the Apache Git Service. To respond to the message, pl

[skywalking-cli] branch master updated: [Feature] Add endpoint command, refactor Makefile to cross build target (#17)

2019-12-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new f6aad1f [Feature] Add endpoint command

[GitHub] [skywalking-cli] wu-sheng merged pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
wu-sheng merged pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17 This is an automated message from the Apache Git Service. To res

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
kezhenxu94 commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#discussion_r352658605 ## File path: README.md ## @@ -77,83 +75,192 @@ This section covers all

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#issuecomment-560085007 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/17?src=pr&el=h1) Report > Merging

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#issuecomment-560085007 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/17?src=pr&el=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560440910 Header is for propagation, it is just required in the HTTP header. But you ne

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3978: [WIP][Feature] Service instance dependency

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #3978: [WIP][Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#discussion_r352638313 ## File path: test/e2e/e2e-base/src/main/resources/instanceTopo.gql ## @@ -0,0 +1,43 @@ +# Licensed to

[GitHub] [skywalking] arugal opened a new pull request #3995: Distribute "service-apdex-threshold.yml" for es7

2019-12-02 Thread GitBox
arugal opened a new pull request #3995: Distribute "service-apdex-threshold.yml" for es7 URL: https://github.com/apache/skywalking/pull/3995 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#discussion_r352635730 ## File path: README.md ## @@ -77,83 +75,192 @@ This section covers all t

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#discussion_r352629947 ## File path: README.md ## @@ -169,5 +169,98 @@ This section covers all t

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#issuecomment-560085007 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/17?src=pr&el=h1) Report > Merging

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #17: [Feature] Add endpoint command, refactor Makefile to cross build target URL: https://github.com/apache/skywalking-cli/pull/17#issuecomment-560085007 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/17?src=pr&el=h1) Report > Merging

[GitHub] [skywalking] seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560391648 > it is possible, but the cost will be high on network. You need to build your

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3978: [WIP][Feature] Service instance dependency

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #3978: [WIP][Feature] Service instance dependency URL: https://github.com/apache/skywalking/pull/3978#discussion_r352585192 ## File path: oap-server/server-bootstrap/src/main/resources/official_analysis.oal ## @@ -53,6 +53,24

[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng commented on issue #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#issuecomment-560378484 Done. You could work on main repo PR now. This is an

[skywalking-query-protocol] branch master updated: Add ServiceInstanceTopology & ServiceInstanceNode (#20)

2019-12-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new e47462f Add ServiceInstance

[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng merged pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-query-protocol] arugal commented on issue #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
arugal commented on issue #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#issuecomment-560377142 @wu-sheng Completed, please review. This is an automated

[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#discussion_r352568390 ## File path: topology.graphqls ## @@ -36,6 +42,26 @@ type Node { isReal: Bool

[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#discussion_r352566570 ## File path: topology.graphqls ## @@ -36,6 +42,26 @@ type Node { isReal: Bool

[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#discussion_r352566320 ## File path: topology.graphqls ## @@ -36,6 +42,26 @@ type Node { isReal: Bool

[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20#discussion_r352566161 ## File path: topology.graphqls ## @@ -36,6 +42,26 @@ type Node { isReal: Bool

[GitHub] [skywalking-query-protocol] arugal opened a new pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode

2019-12-02 Thread GitBox
arugal opened a new pull request #20: Add ServiceInstanceTopology & ServiceInstanceNode URL: https://github.com/apache/skywalking-query-protocol/pull/20 Ref: [apache/skywalking#3950](https://github.com/apache/skywalking/pull/3950) ---

[GitHub] [skywalking] wu-sheng merged pull request #3994: Fix official_analysis.oal url path at README.md

2019-12-02 Thread GitBox
wu-sheng merged pull request #3994: Fix official_analysis.oal url path at README.md URL: https://github.com/apache/skywalking/pull/3994 This is an automated message from the Apache Git Service. To respond to the message, ple

[skywalking] branch master updated: Fix official_analysis.oal url path at README.md (#3994)

2019-12-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new de7987d Fix official_analysis.oal url path

[GitHub] [skywalking] wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560324556 No, we don't have that. In theory, it is possible, but the cost will be high

[GitHub] [skywalking] wu-sheng closed issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
wu-sheng closed issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993 This is an automated message from the Ap

[GitHub] [skywalking] seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
seifeHu commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560323727 > What do you mean webUI? Are you talking about Browser? Yes . I am tal

[GitHub] [skywalking] zhaoyuguang opened a new pull request #3994: Fix official_analysis.oal url path at README.md

2019-12-02 Thread GitBox
zhaoyuguang opened a new pull request #3994: Fix official_analysis.oal url path at README.md URL: https://github.com/apache/skywalking/pull/3994 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided

[skywalking] 01/01: Fix official_analysis.oal url path at README.md

2019-12-02 Thread zhaoyuguang
This is an automated email from the ASF dual-hosted git repository. zhaoyuguang pushed a commit to branch zhaoyuguang-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit dc844dd3723384ac8d7979078fbc9432b91132e2 Author: 于玉桔 AuthorDate: Mon Dec 2 17:48:32 2019 +0800

[skywalking] branch zhaoyuguang-patch-1 created (now dc844dd)

2019-12-02 Thread zhaoyuguang
This is an automated email from the ASF dual-hosted git repository. zhaoyuguang pushed a change to branch zhaoyuguang-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at dc844dd Fix official_analysis.oal url path at README.md This branch includes the following ne

[GitHub] [skywalking] wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
wu-sheng commented on issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993#issuecomment-560312329 What do you mean webUI? Are you talking about Browser? --

[GitHub] [skywalking] wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560309535 > I tried this way, If two threads switch, will produce two spans with very short time spans, but the entire request t

[GitHub] [skywalking] wu-sheng edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560307961 For snapshot, yes, this could happen. But when you choose solution 2, you finish the span in another thread, wh

[GitHub] [skywalking] wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560307961 For snapshot, yes, this could happen. But when you choose solution 2, you finish the span in another thread, why the d

[GitHub] [skywalking] seifeHu opened a new issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)?

2019-12-02 Thread GitBox
seifeHu opened a new issue #3993: Is any sulotion send a traceId from web front page to app server(which run with skywalking agent)? URL: https://github.com/apache/skywalking/issues/3993 ### Question If I want to know a trace chain from webUi ->app->mysql How can I do ? ---

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560296989 > 1. Create a snapshot to propagate. Or 2. Create an async span to finish in another thread. I tried this way, I

[GitHub] [skywalking] xiaoy00 commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
xiaoy00 commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560292742 > @cyejing Friendly ping, Look like you have lots experience in spring reactive, from this testcase, SkyWalking agent n

[GitHub] [skywalking] wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-560287240 Such as in your expected data file, https://github.com/apache/skywalking/blob/86c35228991776eb53e208800f5159aa32d6909a

[GitHub] [skywalking] codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
codecov-io edited a comment on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-559911704 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/3945?src=pr&el=h1) Report > Merging [#3945](http

[skywalking] branch master updated (52de0c6 -> e67d7b8)

2019-12-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 52de0c6 Immigrate test gson scenario. (#3989) add e67d7b8 [test/e2e] Enhancement TopoMatcher (#3990) No

[GitHub] [skywalking] wu-sheng merged pull request #3990: [test/e2e] Enhancement TopoMatcher

2019-12-02 Thread GitBox
wu-sheng merged pull request #3990: [test/e2e] Enhancement TopoMatcher URL: https://github.com/apache/skywalking/pull/3990 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r352462478 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plugin

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r352461993 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plugin

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
cyejing commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r352460986 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plugin/

[GitHub] [skywalking] zhaoyuguang commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
zhaoyuguang commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r352460658 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plu

[GitHub] [skywalking] cyejing commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

2019-12-02 Thread GitBox
cyejing commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r352458267 ## File path: apm-sniffer/optional-plugins/optional-spring-plugins/spring-webflux-5.x-plugin/