[GitHub] [skywalking] kezhenxu94 commented on issue #4019: Add instructions for logback with logstash in custom json format

kezhenxu94 commented on issue #4019: Add instructions for logback with logstash in custom json format URL: https://github.com/apache/skywalking/pull/4019#issuecomment-562830097 > LGTM. @kezhenxu94 @JaredTan95 @zhaoyuguang Are you familiar with this encoder? If so, please recheck. I'

[GitHub] [skywalking] codecov-io commented on issue #4019: Add instructions for logback with logstash in custom json format

codecov-io commented on issue #4019: Add instructions for logback with logstash in custom json format URL: https://github.com/apache/skywalking/pull/4019#issuecomment-562830684 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4019?src=pr&el=h1) Report > Merging [#4019](https://

[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #23: Set default version in release script

kezhenxu94 opened a new pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23 ...and include the LICENSE, NOTICE, documentation files in binary tar This is an automated m

[GitHub] [skywalking-cli] codecov-io commented on issue #23: Set default version in release script

codecov-io commented on issue #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#issuecomment-562832849 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/23?src=pr&el=h1) Report > Merging [#23](https://codecov.io/gh/apache/skywal

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #23: Set default version in release script

wu-sheng commented on a change in pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355111578 ## File path: Makefile ## @@ -15,7 +15,7 @@ # limitations under the License. # -VERSION ?= latest +VERS

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #23: Set default version in release script

kezhenxu94 commented on a change in pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355112574 ## File path: Makefile ## @@ -15,7 +15,7 @@ # limitations under the License. # -VERSION ?= latest +VE

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #23: Set default version in release script

wu-sheng commented on a change in pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355113486 ## File path: Makefile ## @@ -15,7 +15,7 @@ # limitations under the License. # -VERSION ?= latest +VERS

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #23: Set default version in release script

kezhenxu94 commented on a change in pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355113644 ## File path: Makefile ## @@ -15,7 +15,7 @@ # limitations under the License. # -VERSION ?= latest +VE

[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #23: Set default version in release script

wu-sheng commented on a change in pull request #23: Set default version in release script URL: https://github.com/apache/skywalking-cli/pull/23#discussion_r355113740 ## File path: Makefile ## @@ -15,7 +15,7 @@ # limitations under the License. # -VERSION ?= latest +VERS

[GitHub] [skywalking] jackiechan1981 opened a new issue #4020: How should we handle the cross-cloud invocation scenario?

jackiechan1981 opened a new issue #4020: How should we handle the cross-cloud invocation scenario? URL: https://github.com/apache/skywalking/issues/4020 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [

[GitHub] [skywalking] wu-sheng commented on issue #4020: How should we handle the cross-cloud invocation scenario?

wu-sheng commented on issue #4020: How should we handle the cross-cloud invocation scenario? URL: https://github.com/apache/skywalking/issues/4020#issuecomment-562841888 As what you are doing, we don't expect have trace, topology and metrics across cloud, then why don't you simply use name

[GitHub] [skywalking] jackiechan1981 commented on issue #4020: How should we handle the cross-cloud invocation scenario?

jackiechan1981 commented on issue #4020: How should we handle the cross-cloud invocation scenario? URL: https://github.com/apache/skywalking/issues/4020#issuecomment-562845180 I think maybe this is a complicated discussion, I will send the detail of my questions to d...@skywalking.apache.o

[GitHub] [skywalking] jackiechan1981 closed issue #4020: How should we handle the cross-cloud invocation scenario?

jackiechan1981 closed issue #4020: How should we handle the cross-cloud invocation scenario? URL: https://github.com/apache/skywalking/issues/4020 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [skywalking] wu-sheng commented on issue #4020: How should we handle the cross-cloud invocation scenario?

wu-sheng commented on issue #4020: How should we handle the cross-cloud invocation scenario? URL: https://github.com/apache/skywalking/issues/4020#issuecomment-562845574 Welcome to join the mail list. Let's discuss there. Thi

[GitHub] [skywalking] seifeHu opened a new issue #4021: About Consul I think can describe better 。

seifeHu opened a new issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021 In this doc https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/backend-cluster.md suggest write consul cluster nodes . But

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562848194 What are you proposing? I am not following. This is an automated messa

[GitHub] [skywalking] wu-sheng edited a comment on issue #4021: About Consul I think can describe better 。

wu-sheng edited a comment on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562848410 > suggest write consul cluster nodes . We are not suggest to write consule node. We are giving configurations example to

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562848410 > suggest write consul cluster nodes . We are not suggest to write consule node. We are giving configurations to the users about

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562849076 If you want to propose another implementation of cluster management for Consul. You should propose the changes. I and SkyWalking team a

[GitHub] [skywalking] seifeHu commented on issue #4021: About Consul I think can describe better 。

seifeHu commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562849299 > What are you proposing? I am not following. I suggest use " the consul agents " to instead

[GitHub] [skywalking] seifeHu edited a comment on issue #4021: About Consul I think can describe better 。

seifeHu edited a comment on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562849299 > What are you proposing? I am not following. I suggest use " the consul agents " to instead 。Can I write this one to push

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562851651 > Can I write this one to push? I am not following your change. How you deploy the Consul is your choice. The node we talked is

[GitHub] [skywalking] seifeHu commented on issue #4021: About Consul I think can describe better 。

seifeHu commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562852191 > > Can I write this one to push? > > I am not following your change. How you deploy the Consul is your choice. The node we talke

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562852436 > this ' consul cluster nodes.' can replace by 'the consul agents' . sorry for My description is not very clear Is there any dif

[GitHub] [skywalking] seifeHu opened a new issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes

seifeHu opened a new issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes URL: https://github.com/apache/skywalking/issues/4022 ### Question - What do you want to know? what's the different betweens many standalone oap nodes and many oap

[GitHub] [skywalking] seifeHu commented on issue #4021: About Consul I think can describe better 。

seifeHu commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562852545 > > this ' consul cluster nodes.' can replace by 'the consul agents' . sorry for My description is not very clear > > Is there an

[GitHub] [skywalking] wu-sheng commented on issue #4021: About Consul I think can describe better 。

wu-sheng commented on issue #4021: About Consul I think can describe better 。 URL: https://github.com/apache/skywalking/issues/4021#issuecomment-562853050 Go for it. This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes

wu-sheng commented on issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes URL: https://github.com/apache/skywalking/issues/4022#issuecomment-562853301 > If I deploy 3 standalone oap nodes or deploy cluster nodes with consul ,what 's the differ

[GitHub] [skywalking] wu-sheng closed issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes

wu-sheng closed issue #4022: what's the different betweens many standalone oap nodes and many oap cluster nodes URL: https://github.com/apache/skywalking/issues/4022 This is an automated message from the Apache Git Servic

[GitHub] [skywalking] seifeHu opened a new pull request #4023: Update backend-cluster.md

seifeHu opened a new pull request #4023: Update backend-cluster.md URL: https://github.com/apache/skywalking/pull/4023 'Consul cluster node ' can be replaced by 'The consul cluster agents' Please answer these questions before submitting pull request - Why submit this pull reque

[GitHub] [skywalking] wu-sheng commented on issue #4023: Modify The Consul cluster nodes 's Description

wu-sheng commented on issue #4023: Modify The Consul cluster nodes 's Description URL: https://github.com/apache/skywalking/pull/4023#issuecomment-562855503 Related to #4021 This is an automated message from the Apache Git S

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4023: Modify The Consul cluster nodes 's Description

wu-sheng commented on a change in pull request #4023: Modify The Consul cluster nodes 's Description URL: https://github.com/apache/skywalking/pull/4023#discussion_r355124554 ## File path: docs/en/setup/backend/backend-cluster.md ## @@ -85,7 +85,7 @@ the yml to active. c

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4023: Modify The Consul cluster nodes 's Description

wu-sheng commented on a change in pull request #4023: Modify The Consul cluster nodes 's Description URL: https://github.com/apache/skywalking/pull/4023#discussion_r355124822 ## File path: docs/en/setup/backend/backend-cluster.md ## @@ -85,7 +85,7 @@ the yml to active. c

[GitHub] [skywalking] codecov-io commented on issue #4023: Modify The Consul cluster nodes 's Description

codecov-io commented on issue #4023: Modify The Consul cluster nodes 's Description URL: https://github.com/apache/skywalking/pull/4023#issuecomment-562858510 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4023?src=pr&el=h1) Report > Merging [#4023](https://codecov.io/gh/apa

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4024: Add Armeria Java agent plugin

kezhenxu94 opened a new pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve pe

[GitHub] [skywalking] wu-sheng commented on issue #4024: Add Armeria Java agent plugin

wu-sheng commented on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562864355 Why tests cancelled? I knew America auther. I will try to invite him to review after we think this PR is ready. One question, how it works when

[GitHub] [skywalking] kezhenxu94 commented on issue #4024: Add Armeria Java agent plugin

kezhenxu94 commented on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562864669 > Why tests cancelled? I cancelled the tests before I update the commit, to save unnecessary tests. > I knew America auther. I will try

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4024: Add Armeria Java agent plugin

kezhenxu94 edited a comment on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562864669 > Why tests cancelled? I cancelled the tests before I update the commit, to save unnecessary tests. > I knew America auther. I wi

[GitHub] [skywalking] codecov-io commented on issue #4024: Add Armeria Java agent plugin

codecov-io commented on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562867476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4024?src=pr&el=h1) Report > Merging [#4024](https://codecov.io/gh/apache/skywalking/pull

[GitHub] [skywalking] wu-sheng commented on issue #4024: Add Armeria Java agent plugin

wu-sheng commented on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562899944 > Hah, that makes me nervous, I knew him too but this may be too trivial for him I think we should at least invite him to do recheck. This is g

[GitHub] [skywalking] wu-sheng commented on issue #4024: Add Armeria Java agent plugin

wu-sheng commented on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-56289 @kezhenxu94 Armeria test should be fast enough, merge it into `Feign_Canal` group? Th

[GitHub] [skywalking] codecov-io edited a comment on issue #4024: Add Armeria Java agent plugin

codecov-io edited a comment on issue #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#issuecomment-562867476 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4024?src=pr&el=h1) Report > Merging [#4024](https://codecov.io/gh/apache/skywalki

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin

wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355162434 ## File path: test/plugin/scenarios/armeria-scenario/config/expectedData.yaml ## @@ -0,0 +1,141 @@ +# Licensed to t

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin

wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355162438 ## File path: test/plugin/scenarios/armeria-scenario/config/expectedData.yaml ## @@ -0,0 +1,141 @@ +# Licensed to t

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin

wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355162617 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/define/

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4025: Clean up unused CI tool codes

kezhenxu94 opened a new pull request #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025 Don't need these in GitHub Actions, clean them up now This is an automated message from the Apache G

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4025: Clean up unused CI tool codes

kezhenxu94 edited a comment on issue #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025#issuecomment-562916764 @wu-sheng are the Jenkins check statuses removed now? some of the PRs show the failure but others not? Is there a ticket to track it? ---

[GitHub] [skywalking] kezhenxu94 commented on issue #4025: Clean up unused CI tool codes

kezhenxu94 commented on issue #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025#issuecomment-562916764 @wu-sheng did the Jenkins check statuses removed now? some of the PRs show the failure but others not? Is there a ticket to track it? --

[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4025: Clean up unused CI tool codes

kezhenxu94 edited a comment on issue #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025#issuecomment-562916764 @wu-sheng are the Jenkins check statuses removed now? some of the PRs show the failures but others not? Is there a ticket to track it? --

[GitHub] [skywalking] wu-sheng commented on issue #4025: Clean up unused CI tool codes

wu-sheng commented on issue #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025#issuecomment-562916900 Yes, the remove is still on going. I and INFRA are not sure why they keep showing up if the PR submitted by committer. https://issues.apache.org/jira/

[GitHub] [skywalking] codecov-io commented on issue #4025: Clean up unused CI tool codes

codecov-io commented on issue #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025#issuecomment-562918827 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4025?src=pr&el=h1) Report > Merging [#4025](https://codecov.io/gh/apache/skywalking/pull

[GitHub] [skywalking] arugal commented on a change in pull request #4024: Add Armeria Java agent plugin

arugal commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355164901 ## File path: test/plugin/scenarios/armeria-scenario/bin/startup.sh ## @@ -0,0 +1,21 @@ +#!/bin/bash +# +# Licensed t

[GitHub] [skywalking] arugal commented on a change in pull request #4024: Add Armeria Java agent plugin

arugal commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355165206 ## File path: test/plugin/scenarios/armeria-scenario/bin/startup.sh ## @@ -0,0 +1,21 @@ +#!/bin/bash +# +# Licensed t

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin

kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355165738 ## File path: test/plugin/scenarios/armeria-scenario/config/expectedData.yaml ## @@ -0,0 +1,141 @@ +# Licensed to

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin

kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355165955 ## File path: test/plugin/scenarios/armeria-scenario/bin/startup.sh ## @@ -0,0 +1,21 @@ +#!/bin/bash +# +# Licens

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin

kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166072 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/defin

[GitHub] [skywalking] ikhoon commented on a change in pull request #4024: Add Armeria Java agent plugin

ikhoon commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166243 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/armeria/define/Ar

[GitHub] [skywalking] arugal commented on a change in pull request #4024: Add Armeria Java agent plugin

arugal commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166297 ## File path: test/plugin/scenarios/armeria-scenario/config/expectedData.yaml ## @@ -0,0 +1,141 @@ +# Licensed to the

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin

kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166635 ## File path: test/plugin/scenarios/armeria-scenario/config/expectedData.yaml ## @@ -0,0 +1,141 @@ +# Licensed to

[GitHub] [skywalking] ikhoon commented on a change in pull request #4024: Add Armeria Java agent plugin

ikhoon commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166347 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/pom.xml ## @@ -0,0 +1,41 @@ + + + +http://maven.apache.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin

wu-sheng commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355166970 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/pom.xml ## @@ -0,0 +1,41 @@ + + + +http://maven.apach

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin

kezhenxu94 commented on a change in pull request #4024: Add Armeria Java agent plugin URL: https://github.com/apache/skywalking/pull/4024#discussion_r355167049 ## File path: apm-sniffer/apm-sdk-plugin/armeria-0.8.x-plugin/pom.xml ## @@ -0,0 +1,41 @@ + + + +http://maven.apa

[skywalking] branch master updated: Clean up unused codes (#4025)

This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 14a81c8 Clean up unused codes (#4025) 1

[GitHub] [skywalking] kezhenxu94 merged pull request #4025: Clean up unused CI tool codes

kezhenxu94 merged pull request #4025: Clean up unused CI tool codes URL: https://github.com/apache/skywalking/pull/4025 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git