[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565693137 @kezhenxu94 @ascrutae All tests passed, but I think you should run a local test to re-verify.

[GitHub] [skywalking-kubernetes] JaredTan95 opened a new pull request #31: helm dep up skywalking

JaredTan95 opened a new pull request #31: helm dep up skywalking URL: https://github.com/apache/skywalking-kubernetes/pull/31 typo This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking-kubernetes] branch typo created (now 3d2470f)

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch typo in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. at 3d2470f helm dep up skywalking This branch includes the following new commits: new 3d2470f

[skywalking-kubernetes] 01/01: helm dep up skywalking

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch typo in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git commit 3d2470f25068b0307c03980c48d7090d16ea1c5f Author: JaredTan95 AuthorDate: Sat Dec 14 15:45:00 2019 +0800

[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging

[skywalking-kubernetes] branch master updated: Update README.md

This is an automated email from the ASF dual-hosted git repository. tanjian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git The following commit(s) were added to refs/heads/master by this push: new e9d4013 Update README.md

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng commented on a change in pull request #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#discussion_r357899439 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565687108 FYI @cyejing This is an automated message

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565687095 @dmsolr @wayilau @arugal I already updated the plugin test document and existing plugin test cases. Please

[skywalking] branch reduce-register-load updated (4b5a964 -> e435c78)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 4b5a964 Fix toolkit case. add e435c78 Remove exit span from plugin test framework

[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

codecov-io edited a comment on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging

[skywalking] branch reduce-register-load updated (3288283 -> 4b5a964)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 3288283 Try to fix the test case expected data due to no register for exit span. add

[GitHub] [skywalking] tristaZero commented on issue #4047: Modify query SQL for MySQLDAO

tristaZero commented on issue #4047: Modify query SQL for MySQLDAO URL: https://github.com/apache/skywalking/pull/4047#issuecomment-565677951 @kezhenxu94, Thanks feedback, i will review those log after my airplane arrives in shenzhen...

[skywalking] branch reduce-register-load updated (2885ccb -> 3288283)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2885ccb Fix config, plugin, and document, as exit span is not required register anymore.

[GitHub] [skywalking] codecov-io commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

codecov-io commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565673265 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4059?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng commented on issue #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059#issuecomment-565672767 We include exit span in the plugin test cases, I have to remove them one by one, sadly

[GitHub] [skywalking] wu-sheng opened a new pull request #4059: Remove the local/exit span register mechanism in Java agent scenario

wu-sheng opened a new pull request #4059: Remove the local/exit span register mechanism in Java agent scenario URL: https://github.com/apache/skywalking/pull/4059 Resolves #4056 **Key**, reduce the load of register and amount of operation id. Also, reduce the agent memory cost.

[skywalking] branch reduce-register-load updated: Fix config, plugin, and document, as exit span is not required register anymore.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/reduce-register-load by this push: new 2885ccb Fix

[skywalking] branch reduce-register-load created (now fafb737)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git. at fafb737 Remove the local span and exit span register mechanism in Java agent scenario. This

[skywalking] 01/01: Remove the local span and exit span register mechanism in Java agent scenario.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch reduce-register-load in repository https://gitbox.apache.org/repos/asf/skywalking.git commit fafb7374e077bb40165e1431285f900ed6a7f609 Author: Wu Sheng AuthorDate: Sat Dec 14 00:12:18 2019 +0800

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #25: fix schema TraceBrief definition bug

codecov-io edited a comment on issue #25: fix schema TraceBrief definition bug URL: https://github.com/apache/skywalking-cli/pull/25#issuecomment-565310861 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/25?src=pr=h1) Report > Merging

[skywalking] branch more-users updated: Adjust some descriptions.

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch more-users in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/more-users by this push: new 752f85d Adjust some descriptions.

[GitHub] [skywalking-cli] clk1st commented on a change in pull request #25: fix schema TraceBrief definition bug

clk1st commented on a change in pull request #25: fix schema TraceBrief definition bug URL: https://github.com/apache/skywalking-cli/pull/25#discussion_r357682953 ## File path: graphql/schema/schema.go ## @@ -247,8 +247,8 @@ type Trace struct { } type TraceBrief

[skywalking] branch docker-es7 updated (8a82a89 -> baeb0d5)

This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8a82a89 Add es7 support to docker add 4ec2cb0 [test/plugin] immigrate test cassandra scenario.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r357620033 ## File path: test/plugin/scenarios/webflux-scenario/pom.xml ## @@ -23,36 +23,85

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r357619417 ## File path: test/plugin/scenarios/gateway-scenario/config/expectedData.yaml ##

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

wu-sheng commented on a change in pull request #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#discussion_r357622617 ## File path: test/plugin/scenarios/webflux-scenario/config/expectedData.yaml ##

[GitHub] [skywalking] cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too.

cyejing commented on issue #3945: Enhance webflux plugin, related to Spring Gateway plugin too. URL: https://github.com/apache/skywalking/pull/3945#issuecomment-565410399 ``OperationName`` use url pattern, and use OkHttpClient add webflux exitSpan test case

[GitHub] [skywalking-cli] kezhenxu94 commented on a change in pull request #25: fix schema TraceBrief definition bug

kezhenxu94 commented on a change in pull request #25: fix schema TraceBrief definition bug URL: https://github.com/apache/skywalking-cli/pull/25#discussion_r357559456 ## File path: graphql/schema/schema.go ## @@ -247,8 +247,8 @@ type Trace struct { } type TraceBrief

[GitHub] [skywalking] kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO

kezhenxu94 commented on issue #4047: Modify query SQL for MySQLDAO URL: https://github.com/apache/skywalking/pull/4047#issuecomment-565373025 > @kezhenxu94 Do we have e2e for H2 storage? no now This is an automated

[GitHub] [skywalking] wu-sheng closed issue #4058: no suitable driver found

wu-sheng closed issue #4058: no suitable driver found URL: https://github.com/apache/skywalking/issues/4058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] wu-sheng commented on issue #4058: no suitable driver found

wu-sheng commented on issue #4058: no suitable driver found URL: https://github.com/apache/skywalking/issues/4058#issuecomment-565368269 Yes, you can't find. Because you need to add manually. MySQL driver is GPL licensed, it is not allowed to include in Apache release.

[GitHub] [skywalking] alishangtian commented on issue #4058: no suitable driver found

alishangtian commented on issue #4058: no suitable driver found URL: https://github.com/apache/skywalking/issues/4058#issuecomment-565363714 my skywalking version is 6.5 This is an automated message from the Apache Git

[GitHub] [skywalking] alishangtian opened a new issue #4058: no suitable driver found

alishangtian opened a new issue #4058: no suitable driver found URL: https://github.com/apache/skywalking/issues/4058 2019-12-13 17:10:35,926 - com.zaxxer.hikari.HikariDataSource - 80 [main] INFO [] - HikariPool-1 - Starting... 2019-12-13 17:10:35,971 -

[skywalking] branch master updated: Remove client side endpoint register of service mesh (#4054)

This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 16d7782 Remove client side endpoint

[GitHub] [skywalking] hanahmily merged pull request #4054: Remove client side endpoint register of service mesh

hanahmily merged pull request #4054: Remove client side endpoint register of service mesh URL: https://github.com/apache/skywalking/pull/4054 This is an automated message from the Apache Git Service. To respond to the