[GitHub] [skywalking] wu-sheng commented on a change in pull request #4173: Support plugin for mongodb v3.6.x

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4173: Support plugin for mongodb v3.6.x URL: https://github.com/apache/skywalking/pull/4173#discussion_r363075827 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4173: Support plugin for mongodb v3.6.x

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4173: Support plugin for mongodb v3.6.x URL: https://github.com/apache/skywalking/pull/4173#discussion_r363075808 ## File path:

[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #3: Feat: add report ways and support JS errors

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #3: Feat: add report ways and support JS errors URL: https://github.com/apache/skywalking-client-js/pull/3#discussion_r363075377 ## File path: package.json ## @@ -1,10 +1,8 @@ { "name": "skywalking-client-js", -

[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #3: Feat: add report ways and support JS errors

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #3: Feat: add report ways and support JS errors URL: https://github.com/apache/skywalking-client-js/pull/3#discussion_r363075438 ## File path: src/services/trace.ts ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software

[GitHub] [skywalking] dengliming opened a new pull request #4173: Support plugin for mongodb v3.6.x

2020-01-04 Thread GitBox
dengliming opened a new pull request #4173: Support plugin for mongodb v3.6.x URL: https://github.com/apache/skywalking/pull/4173 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ]

[GitHub] [skywalking-client-js] Fine0830 opened a new pull request #3: Feat: add report ways and support JS errors

2020-01-04 Thread GitBox
Fine0830 opened a new pull request #3: Feat: add report ways and support JS errors URL: https://github.com/apache/skywalking-client-js/pull/3 support JS errors https://github.com/apache/skywalking/issues/4061 report ways https://github.com/apache/skywalking/issues/4060

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363071592 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363071502 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4043: Add es7 support to docker

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-569514653 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4043?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4043: Add es7 support to docker

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#discussion_r363066060 ## File path: docs/en/guides/How-to-build.md ## @@ -51,18 +51,7 @@ or ### Build docker images We can build docker

[GitHub] [skywalking] hanahmily commented on a change in pull request #4043: Add es7 support to docker

2020-01-04 Thread GitBox
hanahmily commented on a change in pull request #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#discussion_r363066006 ## File path: docs/en/guides/How-to-build.md ## @@ -51,18 +51,7 @@ or ### Build docker images We can build docker

[GitHub] [skywalking] codecov-io edited a comment on issue #4043: Add es7 support to docker

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-569514653 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4043?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4043: Add es7 support to docker

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-569514653 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4043?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4043: Add es7 support to docker

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#discussion_r363065283 ## File path: docs/en/guides/How-to-build.md ## @@ -51,18 +51,7 @@ or ### Build docker images We can build docker

[skywalking] branch docker-es7 updated (c2cc775 -> bd09843)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from c2cc775 Add document add 1ee14fb Support customized instance name by a new UUID naming policy.

[skywalking] branch docker-es7 updated (01c0740 -> c2cc775)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 01c0740 Merge branch 'master' into docker-es7 discard 0f8b4b6 Add document omit 4e03d5e Add

[GitHub] [skywalking] hanahmily commented on issue #4043: Add es7 support to docker

2020-01-04 Thread GitBox
hanahmily commented on issue #4043: Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-570837022 > Does this plan to fix #3920? yep. it will fix #3920 This is an automated

[skywalking] branch docker-es7 updated (0f8b4b6 -> 01c0740)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 0f8b4b6 Add document add 1ee14fb Support customized instance name by a new UUID naming policy.

[skywalking] branch docker-es7 updated (ae81049 -> 0f8b4b6)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from ae81049 Set oap tag add 0f8b4b6 Add document No new revisions were added by this update. Summary

[GitHub] [skywalking] codecov-io edited a comment on issue #4043: [WIP]Add es7 support to docker

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4043: [WIP]Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-569514653 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4043?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4043: [WIP]Add es7 support to docker

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4043: [WIP]Add es7 support to docker URL: https://github.com/apache/skywalking/pull/4043#issuecomment-569514653 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4043?src=pr=h1) Report > Merging

[skywalking] branch docker-es7 updated (04bb004 -> ae81049)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 04bb004 Set oap tag add ae81049 Set oap tag This update added new revisions after undoing

[skywalking] branch docker-es7 updated (19e6cac -> 04bb004)

2020-01-04 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch docker-es7 in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 19e6cac Update matrix es name add 04bb004 Set oap tag No new revisions were added by this update.

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[skywalking-query-protocol] branch master updated: add max sampling count to the profile task (#27)

2020-01-04 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new dde9a0d add max sampling

[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #27: add max sampling count to the profile task

2020-01-04 Thread GitBox
wu-sheng merged pull request #27: add max sampling count to the profile task URL: https://github.com/apache/skywalking-query-protocol/pull/27 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking-query-protocol] mrproliu opened a new pull request #27: add max sampling count to the profile task

2020-01-04 Thread GitBox
mrproliu opened a new pull request #27: add max sampling count to the profile task URL: https://github.com/apache/skywalking-query-protocol/pull/27 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > :exclamation: No coverage uploaded for

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363042059 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363042059 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041943 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041855 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
kezhenxu94 commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041595 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041057 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363040974 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041066 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363041057 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] codecov-io commented on issue #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
codecov-io commented on issue #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#issuecomment-570794610 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4172?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
kezhenxu94 commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363040810 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363040040 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363039897 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java

[GitHub] [skywalking] mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363039826 ## File path:

[GitHub] [skywalking] mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363039766 ## File path:

[GitHub] [skywalking] mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363039766 ## File path:

[skywalking] branch master updated (6be84cf -> 4e03d5e)

2020-01-04 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 6be84cf update elasticsearch-7.x agent support version. (#4171) add 4e03d5e Add kotlin coroutine plugin

[GitHub] [skywalking] wu-sheng merged pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng merged pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363039131 ## File path:

[GitHub] [skywalking] seifeHu commented on issue #4169: Update log4j2.xml

2020-01-04 Thread GitBox
seifeHu commented on issue #4169: Update log4j2.xml URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570790276 ok. I will make this content into FAQ This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363038130 ## File path:

[GitHub] [skywalking] mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
mrproliu commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363038065 ## File path:

[GitHub] [skywalking] arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
arugal commented on a change in pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172#discussion_r363037822 ## File path:

[GitHub] [skywalking] mrproliu opened a new pull request #4172: Provide profile task downstream to sniffer

2020-01-04 Thread GitBox
mrproliu opened a new pull request #4172: Provide profile task downstream to sniffer URL: https://github.com/apache/skywalking/pull/4172 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [

[GitHub] [skywalking] codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570608160 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4165?src=pr=h1) Report > Merging

[GitHub] [skywalking] codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570608160 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4165?src=pr=h1) Report > Merging

[GitHub] [skywalking] arugal commented on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
arugal commented on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570783236 Good for me. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] kezhenxu94 merged pull request #4171: update elasticsearch-7.x agent support version.

2020-01-04 Thread GitBox
kezhenxu94 merged pull request #4171: update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4171 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking] branch master updated (99100ed -> 6be84cf)

2020-01-04 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 99100ed Split the `collect_http_params` as per plugins for better performance (#4170) add 6be84cf

[GitHub] [skywalking] codecov-io commented on issue #4171: update elasticsearch-7.x agent support version.

2020-01-04 Thread GitBox
codecov-io commented on issue #4171: update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4171#issuecomment-570779195 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4171?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029658 ## File path: docs/en/setup/service-agent/java-agent/README.md ## @@ -135,6 +135,7 @@ Now, we have the following

[GitHub] [skywalking] aderm commented on issue #4171: update elasticsearch-7.x agent support version.

2020-01-04 Thread GitBox
aderm commented on issue #4171: update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4171#issuecomment-570776838 done This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029409 ## File path: docs/en/setup/service-agent/java-agent/Supported-list.md ## @@ -86,6 +86,8 @@ * [Spring

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029514 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029663 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029735 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029418 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363029761 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570608160 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4165?src=pr=h1) Report > Merging

[GitHub] [skywalking] devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363027906 ## File path: test/plugin/scenarios/kotlin-coroutine-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed

[GitHub] [skywalking] codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570608160 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4165?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on issue #4169: Update log4j2.xml

2020-01-04 Thread GitBox
kezhenxu94 commented on issue #4169: Update log4j2.xml URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570773296 I'm totally agree to keep it unchanged because the changes here are just configurations from third-party framework (log4j), users should modify the

[skywalking-website] branch asf-site updated (81fcfda -> bfc5fbb)

2020-01-04 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 81fcfda Update asf-site new bfc5fbb Update asf-site This update added new revisions after

[GitHub] [skywalking-website] kezhenxu94 merged pull request #76: Add kotlin coroutine plugin screenshots

2020-01-04 Thread GitBox
kezhenxu94 merged pull request #76: Add kotlin coroutine plugin screenshots URL: https://github.com/apache/skywalking-website/pull/76 This is an automated message from the Apache Git Service. To respond to the message,

[skywalking-website] branch master updated: Add kotlin coroutine plugin screenshots (#76)

2020-01-04 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 1f62ddb Add kotlin coroutine

[GitHub] [skywalking] devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363026285 ## File path: test/plugin/scenarios/kotlin-coroutine-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed

[GitHub] [skywalking] devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363026020 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking-website] devkanro opened a new pull request #76: Add kotlin coroutine plugin screenshots

2020-01-04 Thread GitBox
devkanro opened a new pull request #76: Add kotlin coroutine plugin screenshots URL: https://github.com/apache/skywalking-website/pull/76 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363025503 ## File path: test/plugin/scenarios/kotlin-coroutine-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed

[GitHub] [skywalking] devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363025338 ## File path: test/plugin/scenarios/kotlin-coroutine-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed

[GitHub] [skywalking] codecov-io edited a comment on issue #4169: Update log4j2.xml

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4169: Update log4j2.xml URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570536635 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4169?src=pr=h1) Report > Merging

[GitHub] [skywalking] wu-sheng commented on issue #4169: Update log4j2.xml

2020-01-04 Thread GitBox
wu-sheng commented on issue #4169: Update log4j2.xml URL: https://github.com/apache/skywalking/pull/4169#issuecomment-570769428 @kezhenxu94 @arugal @JaredTan95 Any suggestion about this? This is an automated message from the

[GitHub] [skywalking] wu-sheng edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570769206 The four cases look good enough. @kezhenxu94 @arugal @dmsolr What do you think? Do we move this into the default? Or stay in the option

[GitHub] [skywalking] wu-sheng commented on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570769206 The four cases look good enough. @kezhenxu94 @arugal @dmsolr What do you think? This

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363024593 ## File path: test/plugin/scenarios/kotlin-coroutine-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363024368 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
wu-sheng commented on a change in pull request #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#discussion_r363024398 ## File path: docs/en/setup/service-agent/java-agent/agent-optional-plugins/Kotlin-Coroutine-plugin.md ## @@ -0,0

[GitHub] [skywalking] aderm opened a new pull request #4171: update elasticsearch-7.x agent support version.

2020-01-04 Thread GitBox
aderm opened a new pull request #4171: update elasticsearch-7.x agent support version. URL: https://github.com/apache/skywalking/pull/4171 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided -

[GitHub] [skywalking] devkanro edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570762748 > One question to all, does this plugin suppose to optional or default. How wide does routine use in kotlin? Could it have side effect as default

[GitHub] [skywalking] devkanro commented on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
devkanro commented on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570766742 @wu-sheng @kezhenxu94 It seems like all CI passed This is an automated message from

[GitHub] [skywalking] codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin

2020-01-04 Thread GitBox
codecov-io edited a comment on issue #4165: Add kotlin coroutine plugin URL: https://github.com/apache/skywalking/pull/4165#issuecomment-570608160 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4165?src=pr=h1) Report > Merging