[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr&el=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/41

[GitHub] [skywalking] wu-sheng opened a new pull request #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`

2020-01-28 Thread GitBox
wu-sheng opened a new pull request #4289: Refactor the storage to support `getSubsetOfMultipleLinearIntValues` URL: https://github.com/apache/skywalking/pull/4289 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] Ne

[skywalking] branch specific-linear created (now cbf400a)

2020-01-28 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch specific-linear in repository https://gitbox.apache.org/repos/asf/skywalking.git. at cbf400a Refactor the storage to support `getSubsetOfMultipleLinearIntValues` This branch includes th

[skywalking] 01/01: Refactor the storage to support `getSubsetOfMultipleLinearIntValues`

2020-01-28 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch specific-linear in repository https://gitbox.apache.org/repos/asf/skywalking.git commit cbf400a0eb93bb8cc8506a025c2a822b8b7f5871 Author: Wu Sheng AuthorDate: Wed Jan 29 15:35:50 2020 +0800

[skywalking-query-protocol] branch master updated: Update metric.graphqls

2020-01-28 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new 03ed785 Update metric.graph

[GitHub] [skywalking] wu-sheng opened a new issue #4288: Support specific linear query for new `getMultipleLinearIntValues`

2020-01-28 Thread GitBox
wu-sheng opened a new issue #4288: Support specific linear query for new `getMultipleLinearIntValues` URL: https://github.com/apache/skywalking/issues/4288 In the current query protocol, you have the only option to provide the total line number. As a result, such as for percentile, you hav

[skywalking] branch master updated (2d6626e -> 0e105a4)

2020-01-28 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2d6626e Add pom exclude license file dir. (#4217) add 0e105a4 Upgrade remainder java compiler versions to

[GitHub] [skywalking] wu-sheng closed issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
wu-sheng closed issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng merged pull request #4286: Upgrade remainder java compiler versions to 1.8

2020-01-28 Thread GitBox
wu-sheng merged pull request #4286: Upgrade remainder java compiler versions to 1.8 URL: https://github.com/apache/skywalking/pull/4286 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr&el=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/41

[GitHub] [skywalking] fadeli1 edited a comment on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
fadeli1 edited a comment on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283#issuecomment-579607569 Okay, thank you This is an automa

[GitHub] [skywalking] codecov-io edited a comment on issue #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-576318626 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4276?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`mast

[GitHub] [skywalking] fadeli1 commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
fadeli1 commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283#issuecomment-579607569 Okay thank you This is an automated mess

[GitHub] [skywalking] codecov-io edited a comment on issue #4286: Upgrade remainder java compiler versions to 1.8

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4286: Upgrade remainder java compiler versions to 1.8 URL: https://github.com/apache/skywalking/pull/4286#issuecomment-579589035 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4286?src=pr&el=h1) Report > Merging [#4286](https://codecov.io

[skywalking] branch master updated: Add pom exclude license file dir. (#4217)

2020-01-28 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2d6626e Add pom exclude license file di

[GitHub] [skywalking] kezhenxu94 merged pull request #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
kezhenxu94 merged pull request #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr&el=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/41

[GitHub] [skywalking] codecov-io commented on issue #4286: Upgrade remainder java compiler versions to 1.8

2020-01-28 Thread GitBox
codecov-io commented on issue #4286: Upgrade remainder java compiler versions to 1.8 URL: https://github.com/apache/skywalking/pull/4286#issuecomment-579589035 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4286?src=pr&el=h1) Report > Merging [#4286](https://codecov.io/gh/apa

[GitHub] [skywalking] kezhenxu94 closed issue #4287: Can I integrate Kafka with skywalking?

2020-01-28 Thread GitBox
kezhenxu94 closed issue #4287: Can I integrate Kafka with skywalking? URL: https://github.com/apache/skywalking/issues/4287 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] kezhenxu94 commented on issue #4287: Can I integrate Kafka with skywalking?

2020-01-28 Thread GitBox
kezhenxu94 commented on issue #4287: Can I integrate Kafka with skywalking? URL: https://github.com/apache/skywalking/issues/4287#issuecomment-579588406 Please refer to https://github.com/apache/skywalking/blob/master/docs/en/FAQ/why_mq_not_involved.md may be duplicate of #4282 ---

[GitHub] [skywalking] sujithkumar28 opened a new issue #4287: Can I integrate Kafka with skywalking?

2020-01-28 Thread GitBox
sujithkumar28 opened a new issue #4287: Can I integrate Kafka with skywalking? URL: https://github.com/apache/skywalking/issues/4287 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question - [ ] Requirement - [ ] Feature

[GitHub] [skywalking] JohnNiang opened a new pull request #4286: Upgrade remainder java compiler versions to 1.8

2020-01-28 Thread GitBox
JohnNiang opened a new pull request #4286: Upgrade remainder java compiler versions to 1.8 URL: https://github.com/apache/skywalking/pull/4286 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided

[GitHub] [skywalking] JohnNiang commented on issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
JohnNiang commented on issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285#issuecomment-579578370 A little while. This is an automated message from the Apache Git Servi

[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report > Merging [#4217](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] codecov-io edited a comment on issue #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-573404570 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4217?src=pr&el=h1) Report > Merging [#4217](https://codecov.io/gh/apache/skyw

[GitHub] [skywalking] kezhenxu94 commented on issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
kezhenxu94 commented on issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285#issuecomment-579577619 > Maybe there's somewhere missing: > > 1. https://github.com/apache/skywalking/blob/8e4c1e95d64f5fafda45629fa294270864f3ff1b/ap

[GitHub] [skywalking] JohnNiang commented on issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
JohnNiang commented on issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285#issuecomment-579577306 Maybe there's somewhere missing: 1.

[GitHub] [skywalking] wu-sheng commented on issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
wu-sheng commented on issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285#issuecomment-579574804 What is the issue? This should have been updated already. This is an au

[GitHub] [skywalking] GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r372171690 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the

[GitHub] [skywalking] JohnNiang opened a new issue #4285: Upgrade all java compiler versions to 1.8

2020-01-28 Thread GitBox
JohnNiang opened a new issue #4285: Upgrade all java compiler versions to 1.8 URL: https://github.com/apache/skywalking/issues/4285 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requir

[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
aderm commented on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579570338 Ok, let me update This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] JohnNiang opened a new issue #4284: Add lombok dependency into root pom globally

2020-01-28 Thread GitBox
JohnNiang opened a new issue #4284: Add lombok dependency into root pom globally URL: https://github.com/apache/skywalking/issues/4284 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Re

[GitHub] [skywalking] wu-sheng commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
wu-sheng commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283#issuecomment-579563057 We have downgraded the log level to ease this concern, check #4156. ---

[GitHub] [skywalking] wu-sheng commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
wu-sheng commented on issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283#issuecomment-579562735 Basically, this is harmless, as this class is never enhanced by SkyWalking. My guess, **ofbiz** uses som

[GitHub] [skywalking] wu-sheng closed issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
wu-sheng closed issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283 This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking] wu-sheng commented on issue #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
wu-sheng commented on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579561820 > so i close it? My point is `**/apm-dist/logs/**` shoule be removed. The workspace one makes sense to me.

[GitHub] [skywalking] aderm commented on issue #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
aderm commented on issue #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#issuecomment-579557183 so i close it? This is an automated message from the Apache Git Service. To respond t

[GitHub] [skywalking] aderm commented on a change in pull request #4217: Add pom exclude license file dir.

2020-01-28 Thread GitBox
aderm commented on a change in pull request #4217: Add pom exclude license file dir. URL: https://github.com/apache/skywalking/pull/4217#discussion_r372154315 ## File path: pom.xml ## @@ -450,6 +450,12 @@ tools/dependencies/known-oap-backend-depen

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#discussion_r372142601 ## File path: test/plugin/scenarios/avro-scenario/config/expectedData.yaml ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Softw

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#discussion_r372142050 ## File path: apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/SWClientRPCPlugin.java ##

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#discussion_r372141227 ## File path: apm-sniffer/apm-sdk-plugin/avro-plugin/src/main/java/org/apache/skywalking/apm/plugin/avro/AbstractRequestInterceptor.jav

[GitHub] [skywalking] wu-sheng commented on issue #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
wu-sheng commented on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579544796 Please fix the icon related PR. This is an automated message from the Apache Git Service. To res

[GitHub] [skywalking] fadeli1 opened a new issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter

2020-01-28 Thread GitBox
fadeli1 opened a new issue #4283: Cannot resolve type description for javax.persistence.AttributeConverter URL: https://github.com/apache/skywalking/issues/4283 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussio

[GitHub] [skywalking] dmsolr commented on issue #4276: Provide AVRO plugin

2020-01-28 Thread GitBox
dmsolr commented on issue #4276: Provide AVRO plugin URL: https://github.com/apache/skywalking/pull/4276#issuecomment-579305201 > One question, In `Avro` document, it is > > 1. Apache Avro™ is a data serialization system. > 2. Remote procedure call (RPC). > > How does this P

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371777178 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the L

[GitHub] [skywalking] wu-sheng commented on issue #4282: Collector base on async stack

2020-01-28 Thread GitBox
wu-sheng commented on issue #4282: Collector base on async stack URL: https://github.com/apache/skywalking/issues/4282#issuecomment-579225787 Do you read this FAQ? https://github.com/apache/skywalking/blob/master/docs/en/FAQ/why_mq_not_involved.md For questions not included in the FA

[GitHub] [skywalking] GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371718269 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the

[GitHub] [skywalking] GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371717846 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the

[GitHub] [skywalking] GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371717507 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the

[GitHub] [skywalking] GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
GuoDuanLZ commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371717507 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the

[GitHub] [skywalking] devkanro opened a new issue #4282: Collector base on async stack

2020-01-28 Thread GitBox
devkanro opened a new issue #4282: Collector base on async stack URL: https://github.com/apache/skywalking/issues/4282 ## Theme This issue discusses async segment collectors. ## Problem I found there is bad throughput about OAP server collect tracing. I have tried to use skyw

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371669532 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the L

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
wu-sheng commented on a change in pull request #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#discussion_r371669444 ## File path: test/plugin/scenarios/grpc-scenario/config/expectedData.yaml ## @@ -15,239 +15,524 @@ # limitations under the L

[GitHub] [skywalking] codecov-io edited a comment on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
codecov-io edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-575098453 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4177?src=pr&el=h1) Report > Merging [#4177](https://codecov.io/gh/apache/skywalking/pull/41

[GitHub] [skywalking] wu-sheng commented on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
wu-sheng commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-579136931 You could use another issue or mail list to discuss this. But to be honest, I can't see much difference. Many discussions have been done about this. ---

[GitHub] [skywalking] devkanro edited a comment on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
devkanro edited a comment on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-579134965 Some discuss not about this PR. I found there is bad throughput about OAP server collect tracing. I have tried to use skywalking in my productio

[GitHub] [skywalking] devkanro commented on issue #4177: Enhance gRPC plugin

2020-01-28 Thread GitBox
devkanro commented on issue #4177: Enhance gRPC plugin URL: https://github.com/apache/skywalking/pull/4177#issuecomment-579134965 Some discuss not about this PR. I found there is bad throughput about OAP server collect tracing. I have tried to use skywalking in my production env, b