[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r381126590 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/serv

[GitHub] [skywalking] lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381125588 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/apac

[GitHub] [skywalking] dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
dmsolr commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r381125075 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/serv

[GitHub] [skywalking] mrproliu commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
mrproliu commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381121129 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/

[GitHub] [skywalking] webb2019 opened a new issue #4382: about k8s as cluster coordinator question

2020-02-18 Thread GitBox
webb2019 opened a new issue #4382: about k8s as cluster coordinator question URL: https://github.com/apache/skywalking/issues/4382 Please answer these questions before submitting your issue. - Why do you submit this issue? - [x] Question or discussion - [ ] Bug - [ ] Requirem

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588049040 > What you concerned is to provide certain rules for tables without sharding, right? No, the concer

[GitHub] [skywalking] aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r381083645 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/serve

[GitHub] [skywalking] aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r381080169 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/serve

[GitHub] [skywalking] aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
aderm commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r381078944 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/serve

[GitHub] [skywalking] codecov-io commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
codecov-io commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#issuecomment-588035622 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4379?src=pr&el=h1) Report > Merging [#437

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588034509 My first idea of sharding stratergy is to shard certain table, taking `alarm_record` for example, into 4

[GitHub] [skywalking] aderm opened a new issue #4381: Add rest-high-level-client enhancements about class ClusterClient's method

2020-02-18 Thread GitBox
aderm opened a new issue #4381: Add rest-high-level-client enhancements about class ClusterClient's method URL: https://github.com/apache/skywalking/issues/4381 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-588029909 > Most of SkyWalking tables are created by OAL scripts. Do you know what is it? > > Limited table

[GitHub] [skywalking] wu-sheng commented on issue #1071: Support nginx opentracing moudle or openresty lua

2020-02-18 Thread GitBox
wu-sheng commented on issue #1071: Support nginx opentracing moudle or openresty lua URL: https://github.com/apache/skywalking/issues/1071#issuecomment-588020233 @JaredTan95 Could you push that pull request? I have begun the Nginx LUA subproject process. -

[GitHub] [skywalking] wu-sheng commented on issue #4258: Nginx plugin/module

2020-02-18 Thread GitBox
wu-sheng commented on issue #4258: Nginx plugin/module URL: https://github.com/apache/skywalking/issues/4258#issuecomment-588019860 Another repo creation proposal has sent to the mail list. This is an automated message from th

[GitHub] [skywalking] lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381051680 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/apac

[GitHub] [skywalking] wu-sheng commented on issue #4258: Nginx plugin/module

2020-02-18 Thread GitBox
wu-sheng commented on issue #4258: Nginx plugin/module URL: https://github.com/apache/skywalking/issues/4258#issuecomment-588008759 A discussion landed here. https://lists.apache.org/thread.html/re075d6888bca580321c9d661596a819e2286798b6698695ad6d4abbc%40%3Cdev.apisix.apache.org%3E ---

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
wu-sheng commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381049791 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/

[GitHub] [skywalking] lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381049349 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/apac

[GitHub] [skywalking] wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587991903 Feel free to choose anything you like. If you are considering Zipkin, in the

[GitHub] [skywalking] justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587990523 > The error means, your OAP inside the cluster can't communicate with each

[GitHub] [skywalking] dmsolr commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
dmsolr commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587986612 We have 4 kinds of data(table). They are `record`, `metadata`(inventory + lock), `metrics` and `none stream`

[GitHub] [skywalking] wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587981911 The error means, your OAP inside the cluster can't communicate with each ot

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
wu-sheng commented on a change in pull request #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#discussion_r381014400 ## File path: apm-sniffer/apm-sdk-plugin/ehcache-2.x-plugin/src/main/java/org/

[GitHub] [skywalking] lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#issuecomment-587506869 The weird thing is that I haven't changed the test cases and they will go wrong. --

[GitHub] [skywalking] lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#issuecomment-587502984 > Also, your plugin test is fail, please test locally. sorry. My computer operating system is windows.

[GitHub] [skywalking] lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method

2020-02-18 Thread GitBox
lsyf commented on issue #4379: Fix ehcache:  missing interceptor of private constructor and setName method URL: https://github.com/apache/skywalking/pull/4379#issuecomment-587496796 > I think this fix needs to be improved. The reason of `#clone` not working is not caused by it is a private

[GitHub] [skywalking] justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587492221 2020-02-18 13:05:42,837 - org.apache.skywalking.oap.server.receiver.envoy

[GitHub] [skywalking] justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
justmine66 commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587490121 > That is the only config you need to set. https://github.com/apache/skyw

[GitHub] [skywalking] wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
wu-sheng commented on issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380#issuecomment-587481663 That is the only config you need to set. https://github.com/apache/skywalki

[GitHub] [skywalking] wu-sheng closed issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
wu-sheng closed issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380 This is an automated message from the

[GitHub] [skywalking] justmine66 opened a new issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters?

2020-02-18 Thread GitBox
justmine66 opened a new issue #4380: when ues helm install, In addition to oap.envoy.als.enabled parameter, where are the other parameters? URL: https://github.com/apache/skywalking/issues/4380 Please answer these questions before submitting your issue. - Why do you submit this issue

[GitHub] [skywalking] codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1) Report > Merging [#4239](https://codecov.io/gh/apa

[GitHub] [skywalking] wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
wu-sheng commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587410043 Most of SkyWalking tables are created by OAL scripts. Do you know what is it? Limited tables are t

[GitHub] [skywalking] wu-sheng commented on issue #4371: fix topology node type unknown.

2020-02-18 Thread GitBox
wu-sheng commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-587409041 Yes. They should be. All request starts from es client jar, should be wrapped inside the es exit span. -

[GitHub] [skywalking] aderm commented on issue #4371: fix topology node type unknown.

2020-02-18 Thread GitBox
aderm commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-587405183 > > For httyasyncclient (componentId = 26) the plugin scenario test healthCheck interface ClusterHealthResponse response = client.cluster ()

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587390211 > Another reminder is, Could you use a consistent-hash-func(table_name) and an exclusion rule for limite

[GitHub] [skywalking] tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587390211 > Another reminder is, Could you use a consistent-hash-func(table_name) and an exclusion rule for

[GitHub] [skywalking] tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-18 Thread GitBox
tristaZero edited a comment on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-587390211 > Another reminder is, Could you use a consistent-hash-func(table_name) and an exclusion rule for

[GitHub] [skywalking] codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
codecov-io edited a comment on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1) Report > Merging [#4239](https://codecov.io/gh/apa

[GitHub] [skywalking] wu-sheng commented on issue #4371: fix topology node type unknown.

2020-02-18 Thread GitBox
wu-sheng commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-587353320 > For httyasyncclient (componentId = 26) the plugin scenario test healthCheck interface ClusterHealthResponse response = client.cluster (). Health (

[GitHub] [skywalking] aderm commented on issue #4371: fix topology node type unknown.

2020-02-18 Thread GitBox
aderm commented on issue #4371: fix topology node type unknown. URL: https://github.com/apache/skywalking/pull/4371#issuecomment-587352319 > We need to look deeper what the scenario you described. Inside `elasticsearch-7.x-scenario`, I can't find the span you described, is it missed?

[GitHub] [skywalking] wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
wu-sheng commented on issue #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#issuecomment-587352263 e2e fail because the profile task DAO is still accessing the H2/MySQL. It seems you miss a change. Please fix it. -

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin

2020-02-18 Thread GitBox
wu-sheng commented on a change in pull request #4239: Provide influxdb as a new storage plugin URL: https://github.com/apache/skywalking/pull/4239#discussion_r380509427 ## File path: oap-server/server-storage-plugin/storage-influxdb-plugin/src/main/java/org/apache/skywalking/oap/se