[GitHub] [skywalking] wu-sheng commented on issue #4414: wrong index name when automatically metrics data delete

2020-02-24 Thread GitBox
wu-sheng commented on issue #4414: wrong index name when automatically metrics data delete URL: https://github.com/apache/skywalking/issues/4414#issuecomment-590721043 Simple answer, upgrade your SkyWalking to latest. The ES storage implementation has been optimized several times since

[GitHub] [skywalking] wu-sheng closed issue #4414: wrong index name when automatically metrics data delete

2020-02-24 Thread GitBox
wu-sheng closed issue #4414: wrong index name when automatically metrics data delete URL: https://github.com/apache/skywalking/issues/4414 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] f02061232-1 opened a new issue #4414: wrong index name when automatically metrics data delete

2020-02-24 Thread GitBox
f02061232-1 opened a new issue #4414: wrong index name when automatically metrics data delete URL: https://github.com/apache/skywalking/issues/4414 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [X]

[skywalking-website] branch asf-site updated (583eeb2 -> 85eb1bc)

2020-02-24 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 583eeb2 Update asf-site new 85eb1bc Update asf-site This update added new revisions after

[skywalking-website] branch master updated: Update language agents

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new ff7f3b4 Update language agents

[skywalking] branch rest_api updated (c2a6ca5 -> 5e13faa)

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch rest_api in repository https://gitbox.apache.org/repos/asf/skywalking.git. from c2a6ca5 add protobuf java utils license. add d63f2c9 Support topology with multiple selected services

[skywalking-nginx-lua] branch master updated: doc: emphasize that the finish should be called only when the output is finished (#2)

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-nginx-lua.git The following commit(s) were added to refs/heads/master by this push: new 7e4fd14 doc: emphasize that the

[GitHub] [skywalking-nginx-lua] wu-sheng merged pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
wu-sheng merged pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-nginx-lua] moonming commented on issue #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
moonming commented on issue #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#issuecomment-590699140 yes, LGTM This is an automated message

[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383666410 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking] mrproliu commented on issue #4104: [FEATURE] Performance profile at method level in production environment

2020-02-24 Thread GitBox
mrproliu commented on issue #4104: [FEATURE] Performance profile at method level in production environment URL: https://github.com/apache/skywalking/issues/4104#issuecomment-590665221 Hi, @Fine0830. I missed the profiled segment query in GraphQL, now has added. I create the new docker

[GitHub] [skywalking-nginx-lua] wu-sheng commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
wu-sheng commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383630996 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking] wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412#issuecomment-590654060 I would suggest you to debug codes for older version to see where `SWTransmitter` created, then you may could find the

[GitHub] [skywalking] cai-ti commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
cai-ti commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412#issuecomment-590653635 > English only. I am not sure the status of 2.2.1, these are versions we tested.

[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383629135 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking-nginx-lua] spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383628455 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking] wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412#issuecomment-590651312 English only. I am not sure the status of 2.2.1, these are versions we tested.

[GitHub] [skywalking] wu-sheng closed issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
wu-sheng closed issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] cai-ti commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
cai-ti commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412#issuecomment-590650596 > What do you mean? Why do you put that optional plugin into the gateway? skywalking-agentr:6.6.0

[GitHub] [skywalking-website] aderm opened a new pull request #79: Add Zhusheng Xu as a new committer.

2020-02-24 Thread GitBox
aderm opened a new pull request #79: Add Zhusheng Xu as a new committer. URL: https://github.com/apache/skywalking-website/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] wu-sheng merged pull request #4413: Add missed profiled segment query

2020-02-24 Thread GitBox
wu-sheng merged pull request #4413: Add missed profiled segment query URL: https://github.com/apache/skywalking/pull/4413 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch master updated: Add missed profiled segment query (#4413)

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 2ea341b Add missed profiled segment query

[GitHub] [skywalking] wu-sheng commented on issue #4252: Release 6.6 Not fixed the bug. skywalking springcloud gateway plugin not suppot springcloud greenwish sr4

2020-02-24 Thread GitBox
wu-sheng commented on issue #4252: Release 6.6 Not fixed the bug. skywalking springcloud gateway plugin not suppot springcloud greenwish sr4 URL: https://github.com/apache/skywalking/issues/4252#issuecomment-590645612 @seifeHu Any update about this?

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
wu-sheng commented on a change in pull request #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#discussion_r383622020 ## File path: tools/dependencies/known-oap-backend-dependencies-es7.txt ## @@ -143,6 +143,7 @@

[GitHub] [skywalking] wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
wu-sheng commented on issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412#issuecomment-590644578 What do you mean? Why do you put that optional plugin into the gateway?

[GitHub] [skywalking-nginx-lua] moonming commented on issue #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
moonming commented on issue #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#issuecomment-590636936 > @moonming Please take a look. When this wouldn't be `eof`? We may need more checks if there is

[GitHub] [skywalking-nginx-lua] moonming commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
moonming commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383613341 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking] mrproliu opened a new pull request #4413: Add missed profiled segment query

2020-02-24 Thread GitBox
mrproliu opened a new pull request #4413: Add missed profiled segment query URL: https://github.com/apache/skywalking/pull/4413 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve

[skywalking] branch master updated: Support topology with multiple selected services (#4408)

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d63f2c9 Support topology with multiple

[GitHub] [skywalking] wu-sheng merged pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
wu-sheng merged pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking-nginx-lua] wu-sheng commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
wu-sheng commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383315487 ## File path: README.md ## @@ -48,7 +48,9 @@ http {

[GitHub] [skywalking] wu-sheng commented on issue #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
wu-sheng commented on issue #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#issuecomment-590359610 Hi everyone, this PR becomes a block to @mrproliu . I plan to merge this to adopt the new protocol.

[GitHub] [skywalking-nginx-lua] wu-sheng commented on issue #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
wu-sheng commented on issue #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2#issuecomment-590354350 @moonming Please take a look. When this wouldn't be `eof`? We may need more checks if there is another

[GitHub] [skywalking] cai-ti opened a new issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x

2020-02-24 Thread GitBox
cai-ti opened a new issue #4412: optional-spring-plugins Support spring-cloud-gateway-2.2.x URL: https://github.com/apache/skywalking/issues/4412 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug

[GitHub] [skywalking] aderm commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
aderm commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383274663 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
aderm commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383274663 ## File path:

[skywalking] branch rest_api updated (b922fe3 -> c2a6ca5)

2020-02-24 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch rest_api in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b922fe3 update register logical. add c2a6ca5 add protobuf java utils license. No new revisions were

[GitHub] [skywalking-nginx-lua] spacewander opened a new pull request #2: doc: emphasize that the finish should be called only when the output …

2020-02-24 Thread GitBox
spacewander opened a new pull request #2: doc: emphasize that the finish should be called only when the output … URL: https://github.com/apache/skywalking-nginx-lua/pull/2 …is finished This is an automated message from the

[GitHub] [skywalking] wu-sheng commented on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
wu-sheng commented on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590315491 They seem same, I don't know what is the difference. This is an automated

[GitHub] [skywalking] JaredTan95 commented on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
JaredTan95 commented on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590312480 `com.google.protobuf.util.JsonFormat` couldn't be imported from `guava`. And there may be duplicated dependency if do not `exclusion` it.

[GitHub] [skywalking] wu-sheng commented on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
wu-sheng commented on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590305927 > Yes, I added protobuf-java-util. I saw you add `exclusion` to guava in the root pom, are you adding it or changing the version? I am a

[GitHub] [skywalking] JaredTan95 commented on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
JaredTan95 commented on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590305053 > Are you adding new dependency? The dependency check fails. Yes, I added `protobuf-java-util`.

[GitHub] [skywalking] wu-sheng commented on issue #4411: Whether to support the collection of trace data through Kafka like zipkin

2020-02-24 Thread GitBox
wu-sheng commented on issue #4411: Whether to support the collection of trace data through Kafka like zipkin URL: https://github.com/apache/skywalking/issues/4411#issuecomment-590280058 Read FAQ https://github.com/apache/skywalking/blob/master/docs/en/FAQ/README.md#design

[GitHub] [skywalking] wu-sheng closed issue #4411: Whether to support the collection of trace data through Kafka like zipkin

2020-02-24 Thread GitBox
wu-sheng closed issue #4411: Whether to support the collection of trace data through Kafka like zipkin URL: https://github.com/apache/skywalking/issues/4411 This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] HarryZheng0907 opened a new issue #4411: Whether to support the collection of trace data through Kafka like zipkin

2020-02-24 Thread GitBox
HarryZheng0907 opened a new issue #4411: Whether to support the collection of trace data through Kafka like zipkin URL: https://github.com/apache/skywalking/issues/4411 Whether to support the collection of trace data through Kafka like zipkin, if it is supported, whether there are related

[GitHub] [skywalking] tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7

2020-02-24 Thread GitBox
tristaZero commented on issue #4131: ShardingSphere storage configuration, e2e test and doc for SkyWalking 7 URL: https://github.com/apache/skywalking/issues/4131#issuecomment-590262740 Got it, therefore i will push it forward following the our existing plan.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
wu-sheng commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383170169 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
aderm commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383169444 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
wu-sheng commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383162223 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #4408: Support topology with multiple selected services

2020-02-24 Thread GitBox
aderm commented on a change in pull request #4408: Support topology with multiple selected services URL: https://github.com/apache/skywalking/pull/4408#discussion_r383153154 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
wu-sheng commented on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590231364 Are you adding new dependency? The dependency check fails. This is an

[GitHub] [skywalking] codecov-io edited a comment on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
codecov-io edited a comment on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590023100 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4399?src=pr=h1) Report > :exclamation: No coverage uploaded for pull

[GitHub] [skywalking] wu-sheng edited a comment on issue #4399: support http api for upstream trace.

2020-02-24 Thread GitBox
wu-sheng edited a comment on issue #4399: support http api for upstream trace. URL: https://github.com/apache/skywalking/pull/4399#issuecomment-590064256 By following @JaredTan95 feedback, I just re-format the trace_id and segment_id to adopt the proto ```json { "spans": [

[GitHub] [skywalking] wu-sheng commented on issue #4404: Whether Java agent supports fetching exception stack trace?

2020-02-24 Thread GitBox
wu-sheng commented on issue #4404: Whether Java agent supports fetching exception stack trace? URL: https://github.com/apache/skywalking/issues/4404#issuecomment-590212164 If they catched, there is nothing we could do. Instrumenting exception is not a good idea, if you were thinking about

[GitHub] [skywalking] long187 commented on issue #4404: Whether Java agent supports fetching exception stack trace?

2020-02-24 Thread GitBox
long187 commented on issue #4404: Whether Java agent supports fetching exception stack trace? URL: https://github.com/apache/skywalking/issues/4404#issuecomment-590211476 No I haven't. Sometimes, developers catch exceptions, but they don't print them to the log. Can SkyWalking Java

[skywalking] branch rest_api updated (fa74d0d -> b922fe3)

2020-02-24 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch rest_api in repository https://gitbox.apache.org/repos/asf/skywalking.git. from fa74d0d update test add b922fe3 update register logical. No new revisions were added by this update.

[skywalking-query-protocol] branch master updated: provide query profiled segment (#34)

2020-02-24 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git The following commit(s) were added to refs/heads/master by this push: new 6b26dda provide query

[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #34: provide query profiled segment

2020-02-24 Thread GitBox
wu-sheng merged pull request #34: provide query profiled segment URL: https://github.com/apache/skywalking-query-protocol/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please