wu-sheng commented on a change in pull request #3: feature: add CI and test
cases for ngx lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3#discussion_r384317263
##
File path: lib/skywalking/segment_ref.lua
##
@@ -1,20 +1,20 @@
---
+--
-- Licensed to the
wu-sheng commented on a change in pull request #3: feature: add CI and test
cases for ngx lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3#discussion_r384319605
##
File path: t/util.t
##
@@ -0,0 +1,96 @@
+use Test::Nginx::Socket 'no_plan';
Review
wu-sheng commented on a change in pull request #3: feature: add CI and test
cases for ngx lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3#discussion_r384318472
##
File path: lib/skywalking/util.lua
##
@@ -1,34 +1,92 @@
---
+--
-- Licensed to the Apache
wu-sheng commented on a change in pull request #3: feature: add CI and test
cases for ngx lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3#discussion_r384317008
##
File path: lib/skywalking/segment_ref.lua
##
@@ -1,20 +1,20 @@
---
+--
-- Licensed to the
wu-sheng commented on a change in pull request #3: feature: add CI and test
cases for ngx lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3#discussion_r384319371
##
File path: lib/skywalking/util.lua
##
@@ -1,34 +1,92 @@
---
+--
-- Licensed to the Apache
codecov-io commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591279244
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4418?src=pr=h1)
Report
> Merging
wu-sheng commented on issue #4: [WIP] set up e2e
URL:
https://github.com/apache/skywalking-nginx-lua/pull/4#issuecomment-591273508
> We should move the mock-collector and validator code to a new repo, other
agent repo can also be used
If you intend to do this, we will need a
wayilau commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384305459
##
File path: api/v1alpha1/oapserver_types.go
##
@@ -0,0 +1,86 @@
+// Licensed to Apache Software Foundation (ASF) under one or
arugal commented on issue #4: [WIP] set up e2e
URL:
https://github.com/apache/skywalking-nginx-lua/pull/4#issuecomment-591270752
We should move the `mock-collector` and `validator` code to a new repo,
other agent repo can also be used, @dmsolr what do you think?
wu-sheng commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591268429
I am not sure what happens in GitHub action, but the CI tasks seem strange
to me.
This is
arugal commented on a change in pull request #4: [WIP] set up e2e
URL: https://github.com/apache/skywalking-nginx-lua/pull/4#discussion_r384300086
##
File path: .github/workflows/e2e.yaml
##
@@ -0,0 +1,48 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
wu-sheng commented on issue #4: [WIP] set up e2e
URL:
https://github.com/apache/skywalking-nginx-lua/pull/4#issuecomment-591266861
Please merge the master, since we haven't opened the branch sync. But I have
submitted the JIRA.
aderm commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591265489
> force push to change the commit id
`--force` not work, so change commit.
This is an
wu-sheng commented on issue #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418#issuecomment-591261728
Seems facing the github pull issue again. You may need to force push to
change the commit id.
dmsolr opened a new pull request #4: [WIP] set up e2e
URL: https://github.com/apache/skywalking-nginx-lua/pull/4
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aderm opened a new pull request #4418: refactor Metrics class.
URL: https://github.com/apache/skywalking/pull/4418
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
hanahmily commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384268912
##
File path: api/v1alpha1/oapserver_types.go
##
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one
withlin commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384263827
##
File path: api/v1alpha1/oapserver_types.go
##
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one or
withlin commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384263827
##
File path: api/v1alpha1/oapserver_types.go
##
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one or
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1)
Report
> :exclamation: No coverage uploaded for pull request
hanahmily commented on issue #4373: [SWCK] Initiate Backend Operator
URL: https://github.com/apache/skywalking/issues/4373#issuecomment-591225454
@clk1st @MAlj11 Glad to see you interested in this project.
I have told with @clk1st about the details of the whole procedure. He is
moonming opened a new pull request #3: feature: add CI and test cases for ngx
lua.
URL: https://github.com/apache/skywalking-nginx-lua/pull/3
This is an automated message from the Apache Git Service.
To respond to the
hanahmily opened a new pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1
Tips for reviewers, we should pay attention to `oapserver_types.go` because
most of the files are generated by kubebuilder.
Signed-off-by: Gao Hongtao
wu-sheng commented on issue #4400: Feature/check style refactor
URL: https://github.com/apache/skywalking/pull/4400#issuecomment-591211407
Due to `no update`, add new tag and remove milestone. Seems no response from
the author.
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new fa0b3df provide multiple time ranges to
wu-sheng merged pull request #4417: provide multiple time ranges to query
profile analyze
URL: https://github.com/apache/skywalking/pull/4417
This is an automated message from the Apache Git Service.
To respond to the
wu-sheng commented on a change in pull request #4417: provide multiple time
ranges to query profile analyze
URL: https://github.com/apache/skywalking/pull/4417#discussion_r384239040
##
File path:
mrproliu commented on a change in pull request #4417: provide multiple time
ranges to query profile analyze
URL: https://github.com/apache/skywalking/pull/4417#discussion_r384237276
##
File path:
wu-sheng commented on a change in pull request #4417: provide multiple time
ranges to query profile analyze
URL: https://github.com/apache/skywalking/pull/4417#discussion_r384231994
##
File path:
mrproliu opened a new pull request #4417: provide multiple time ranges to query
profile analyze
URL: https://github.com/apache/skywalking/pull/4417
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new 8c9a8c4 change profile
wu-sheng merged pull request #36: change profile analyze time range data type
URL: https://github.com/apache/skywalking-query-protocol/pull/36
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a commit to branch profile
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
commit e70a3bdc86794be49d102ecb9d68712a1fb85e47
Author: Mrproliu
AuthorDate: Wed Feb 26 00:04:21 2020
mrproliu opened a new pull request #36: change profile analyze time range data
type
URL: https://github.com/apache/skywalking-query-protocol/pull/36
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
liuhan pushed a change to branch profile
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git.
at e70a3bd change profile analyze time range data type
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-query-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new aee4357 add profile
wu-sheng merged pull request #35: add profile analyze query time range
URL: https://github.com/apache/skywalking-query-protocol/pull/35
This is an automated message from the Apache Git Service.
To respond to the message,
mrproliu opened a new pull request #35: add profile analyze query time range
URL: https://github.com/apache/skywalking-query-protocol/pull/35
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard 9f47a5d Update asf-site
new 2c261b7 Update asf-site
This update added new revisions after
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new 89a3c02 Add timeline (#80)
wu-sheng merged pull request #80: Add timeline
URL: https://github.com/apache/skywalking-website/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/master by this push:
new b879917 Add Zhusheng Xu as a new
wu-sheng merged pull request #79: Add Zhusheng Xu as a new committer.
URL: https://github.com/apache/skywalking-website/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
discard 85eb1bc Update asf-site
new 9f47a5d Update asf-site
This update added new revisions after
aderm commented on a change in pull request #79: Add Zhusheng Xu as a new
committer.
URL: https://github.com/apache/skywalking-website/pull/79#discussion_r383794002
##
File path: docs/README.md
##
@@ -20,11 +20,14 @@ feature:
user:
title: Who is using SkyWalking
-
aderm commented on a change in pull request #79: Add Zhusheng Xu as a new
committer.
URL: https://github.com/apache/skywalking-website/pull/79#discussion_r383794165
##
File path: docs/team/README.md
##
@@ -35,6 +35,7 @@ Members include Project Management Committee members
heyanlong opened a new pull request #80: Add timeline
URL: https://github.com/apache/skywalking-website/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
This is an automated email from the ASF dual-hosted git repository.
heyanlong pushed a commit to branch heyanlong-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/heyanlong-patch-1 by this push:
new a7c2250
This is an automated email from the ASF dual-hosted git repository.
heyanlong pushed a change to branch heyanlong-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git.
at da8ea4c Update README.md
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
heyanlong pushed a commit to branch heyanlong-patch-1
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
commit da8ea4c062a555a194a158af8ea3ac1a15e5b64b
Author: 何延龙
AuthorDate: Tue Feb 25 18:15:33 2020
Lovnx commented on issue #4415: Which index saving the service_id information？
URL: https://github.com/apache/skywalking/issues/4415#issuecomment-590780741
*_inventory index: field `sequence` is the id I'm looking for.
This
mrproliu opened a new pull request #4416: Provide profile exporter tool
URL: https://github.com/apache/skywalking/pull/4416
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve
wu-sheng commented on issue #4415: Which index saving the service_id
information？
URL: https://github.com/apache/skywalking/issues/4415#issuecomment-590774236
There are several *_inventory indexes representing these.
This is
wu-sheng closed issue #4415: Which index saving the service_id information？
URL: https://github.com/apache/skywalking/issues/4415
This is an automated message from the Apache Git Service.
To respond to the message, please
Lovnx opened a new issue #4415: Which index saving the service_id information？
URL: https://github.com/apache/skywalking/issues/4415
index `segment-2020xxx` data structure is:
```
{
"_index": "segment-20200224",
"_type": "_doc",
"_id": "97.206.15824787537508774",
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-nginx-lua.git
The following commit(s) were added to refs/heads/master by this push:
new 4fa848b Update .asf.yaml
wu-sheng commented on a change in pull request #79: Add Zhusheng Xu as a new
committer.
URL: https://github.com/apache/skywalking-website/pull/79#discussion_r383722095
##
File path: docs/team/README.md
##
@@ -35,6 +35,7 @@ Members include Project Management Committee
wu-sheng commented on a change in pull request #79: Add Zhusheng Xu as a new
committer.
URL: https://github.com/apache/skywalking-website/pull/79#discussion_r383721744
##
File path: docs/README.md
##
@@ -20,11 +20,14 @@ feature:
user:
title: Who is using SkyWalking
58 matches
Mail list logo
