[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344994 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344993 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[skywalking] branch exist-span-inject updated (3be6195 -> 9795dbc)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch exist-span-inject in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 3be6195 Merge branch 'master' into exist-span-inject add 9795dbc Follow the review. No new re

[GitHub] [skywalking] codecov-io commented on issue #4443: ClassCastException

2020-03-07 Thread GitBox
codecov-io commented on issue #4443: ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596177065 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4443?src=pr&el=h1) Report > Merging [#4443](https://codecov.io/gh/apache/skywalking/pull/4443?src=p

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344616 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] codecov-io edited a comment on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
codecov-io edited a comment on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#issuecomment-596176455 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=h1) Report > Mergin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344282 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344282 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344282 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] codecov-io commented on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
codecov-io commented on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#issuecomment-596176455 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4462?src=pr&el=h1) Report > Merging [#44

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389344185 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343743 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343743 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343461 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343447 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389342564 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
kezhenxu94 commented on a change in pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462#discussion_r389343319 ## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4443: ClassCastException

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4443: ClassCastException URL: https://github.com/apache/skywalking/pull/4443#discussion_r389342840 ## File path: test/plugin/scenarios/resttemplate-4.x-scenario/support-version.list ## @@ -0,0 +1,16 @@ +# Licensed to the Apach

[skywalking-cli] branch master updated: [Feature] Support visualization of heat map and enhance Display logic (#34)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new f2b51ae [Feature] Support visualizatio

[GitHub] [skywalking] wu-sheng closed issue #4461: [CLI] Heat map visualization

2020-03-07 Thread GitBox
wu-sheng closed issue #4461: [CLI] Heat map visualization URL: https://github.com/apache/skywalking/issues/4461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking-cli] wu-sheng merged pull request #34: [Feature] Support visualization of heat map and enhance display logic

2020-03-07 Thread GitBox
wu-sheng merged pull request #34: [Feature] Support visualization of heat map and enhance display logic URL: https://github.com/apache/skywalking-cli/pull/34 This is an automated message from the Apache Git Service. To respo

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389341840 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationIntercep

[skywalking] branch exist-span-inject updated (05a4e68 -> 3be6195)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch exist-span-inject in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 05a4e68 Close the set component id for exit and local spans add 0439dcc Update Plugin-test.md

[GitHub] [skywalking] wu-sheng opened a new pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

2020-03-07 Thread GitBox
wu-sheng opened a new pull request #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting URL: https://github.com/apache/skywalking/pull/4462 This PR's idea was beginning when I am reviewing @huangyoje 's PR #4441. He did hijacking the ContextCarrier, which is

[GitHub] [skywalking-cli] kezhenxu94 commented on issue #34: [Feature] Support visualization of heat map and enhance display logic

2020-03-07 Thread GitBox
kezhenxu94 commented on issue #34: [Feature] Support visualization of heat map and enhance display logic URL: https://github.com/apache/skywalking-cli/pull/34#issuecomment-596173753 screenshot https://user-images.githubusercontent.com/15965696/76158126-7023ec80-614d-11ea-9445-95e68ed

[skywalking] branch exist-span-inject updated: Close the set component id for exit and local spans

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch exist-span-inject in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/exist-span-inject by this push: new 05a4e68 Close the se

[GitHub] [skywalking-cli] kezhenxu94 opened a new pull request #34: [Feature] Support visualization of heat map and enhance display logic

2020-03-07 Thread GitBox
kezhenxu94 opened a new pull request #34: [Feature] Support visualization of heat map and enhance display logic URL: https://github.com/apache/skywalking-cli/pull/34 ### Motivation Visualize heat map and enhance Display logic ### Modification - Add HeatMap widget to vis

[skywalking-cli] 01/01: [Feature] Support visualization of heat map and enhance Display logic

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git commit fa4233b23065ef7e429203bfec35538f232c19b6 Author: kezhenxu94 AuthorDate: Sun Mar 8 14:54:30 20

[skywalking-cli] branch feature/thermodynamic updated (fadc3a4 -> fa4233b)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git. discard fadc3a4 [Feature] Support visualization of heat map and enhance Display logic omit 0

[skywalking-cli] 01/01: [Feature] Support visualization of heat map and enhance Display logic

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git commit fadc3a47f263389de7b80e0f3474ec972ddc42ee Author: kezhenxu94 AuthorDate: Sun Mar 8 14:54:30 20

[skywalking-cli] branch feature/thermodynamic created (now fadc3a4)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git. at fadc3a4 [Feature] Support visualization of heat map and enhance Display logic This bran

[skywalking] branch exist-span-inject created (now 1414ce7)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch exist-span-inject in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 1414ce7 Support lazy ContextCarrier injection and lazy peer id setting for exit span This branch i

[skywalking] 01/01: Support lazy ContextCarrier injection and lazy peer id setting for exit span

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch exist-span-inject in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 1414ce7cdb16ccc051646f238e1040279bb4a3ce Author: Wu Sheng AuthorDate: Sun Mar 8 14:46:57 2020 +0800

[GitHub] [skywalking] kezhenxu94 opened a new issue #4461: [CLI] Heat map visualization

2020-03-07 Thread GitBox
kezhenxu94 opened a new issue #4461: [CLI] Heat map visualization URL: https://github.com/apache/skywalking/issues/4461 Currently, we only display the heat map data in JSON/YAML format, it'd be nice to visualize it This is an

[GitHub] [skywalking-agent-test-tool] kezhenxu94 merged pull request #7: Add link to expected file doc.

2020-03-07 Thread GitBox
kezhenxu94 merged pull request #7: Add link to expected file doc. URL: https://github.com/apache/skywalking-agent-test-tool/pull/7 This is an automated message from the Apache Git Service. To respond to the message, please lo

[skywalking-agent-test-tool] branch master updated: Update README.md (#7)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git The following commit(s) were added to refs/heads/master by this push: new 00f461d Update README.m

[skywalking] branch master updated: Update Plugin-test.md (#4459)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 0439dcc Update Plugin-test.md (#4459) 0

[GitHub] [skywalking] kezhenxu94 merged pull request #4459: Fix the wrong nouns in plugin test doc

2020-03-07 Thread GitBox
kezhenxu94 merged pull request #4459: Fix the wrong nouns in plugin test doc URL: https://github.com/apache/skywalking/pull/4459 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] huangyoje commented on issue #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on issue #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#issuecomment-596164519 > I noticed, this PR fails every time on AppVeyor. Strange. I will check this issue. This

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r38963 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilt

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389333225 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationInterce

[GitHub] [skywalking] codecov-io commented on issue #4459: Fix the wrong nouns in plugin test doc

2020-03-07 Thread GitBox
codecov-io commented on issue #4459: Fix the wrong nouns in plugin test doc URL: https://github.com/apache/skywalking/pull/4459#issuecomment-596164133 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4459?src=pr&el=h1) Report > Merging [#4459](https://codecov.io/gh/apache/skywal

[GitHub] [skywalking] wu-sheng commented on issue #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on issue #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#issuecomment-596163647 I noticed, this PR fails every time on AppVeyor. Strange. This is an automated message from the A

[GitHub] [skywalking] wu-sheng opened a new issue #4460: Support service name in the ref verification.

2020-03-07 Thread GitBox
wu-sheng opened a new issue #4460: Support service name in the ref verification. URL: https://github.com/apache/skywalking/issues/4460 There is a ref check feature missing in the current version. We are checking the instance id != 0 today, which is helpful but not enough, we should add ser

[GitHub] [skywalking] wu-sheng opened a new pull request #4459: Fix the wrong nouns in plugin test doc

2020-03-07 Thread GitBox
wu-sheng opened a new pull request #4459: Fix the wrong nouns in plugin test doc URL: https://github.com/apache/skywalking/pull/4459 @dmsolr I need to head up for you. There is a ref check feature missing in the current version. We are checking the `instance id != 0` today, which is helpfu

[skywalking] branch wu-sheng-patch-1-1 created (now dc5e193)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at dc5e193 Update Plugin-test.md This branch includes the following new commits: new dc5e193 U

[skywalking] 01/01: Update Plugin-test.md

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 70817211e6431805882fed2f59be029d74073d0b Author: 吴晟 Wu Sheng AuthorDate: Sun Mar 8 11:15:39 2020 +0800

[skywalking] branch wu-sheng-patch-1 created (now 7081721)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 7081721 Update Plugin-test.md This branch includes the following new commits: new 7081721 Upd

[skywalking] 01/01: Update Plugin-test.md

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit dc5e193509bc91051b34213b1b6bb6141f18d050 Author: 吴晟 Wu Sheng AuthorDate: Sun Mar 8 11:15:50 2020 +0800

[GitHub] [skywalking] huangyoje commented on issue #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on issue #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#issuecomment-596161248 > As #4458 merged, the expected YAML file has fields been renamed. Take a look the PR and updated plugin test doc. OK. -

[GitHub] [skywalking-agent-test-tool] wu-sheng opened a new pull request #7: Add link to expected file doc.

2020-03-07 Thread GitBox
wu-sheng opened a new pull request #7: Add link to expected file doc. URL: https://github.com/apache/skywalking-agent-test-tool/pull/7 This is an automated message from the Apache Git Service. To respond to the message, pleas

[skywalking-agent-test-tool] 01/01: Update README.md

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git commit 3099bb1cf90238f2ce3a6f54f9eb4a8fd24af494 Author: 吴晟 Wu Sheng AuthorDate: Sun Mar 8 10:58:

[skywalking-agent-test-tool] branch wu-sheng-patch-1 created (now 3099bb1)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git. at 3099bb1 Update README.md This branch includes the following new commits: new

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389329984 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilt

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389329984 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilt

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389329322 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/scala/org/apache/skywalking/apm/plugin/finagle/SWContextCarrier.

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389328863 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/scala/org/apache/skywalking/apm/plugin/finagle/SWContextCarrier

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389328512 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationIntercep

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389327492 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationInterce

[GitHub] [skywalking] wu-sheng commented on issue #4443: ClassCastException

2020-03-07 Thread GitBox
wu-sheng commented on issue #4443: ClassCastException URL: https://github.com/apache/skywalking/pull/4443#issuecomment-596154964 As #4458 merged, the expected YAML file has fields been renamed. Take a look the PR and updated plugin test doc.

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389325508 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationInterce

[GitHub] [skywalking] wu-sheng commented on issue #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on issue #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#issuecomment-596154880 As #4458 merged, the expected YAML file has fields been renamed. Take a look the PR and updated plugin test doc.

[skywalking] branch master updated (8e1530d -> da44d28)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 8e1530d UI update, new topology implementation refactor. No new feature. (#4457) add da44d28 Introduce A

[GitHub] [skywalking] wu-sheng merged pull request #4458: Introduce Agent-Test-Tool suite

2020-03-07 Thread GitBox
wu-sheng merged pull request #4458: Introduce Agent-Test-Tool suite URL: https://github.com/apache/skywalking/pull/4458 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [skywalking] codecov-io commented on issue #4458: Introduce Agent-Test-Tool suite

2020-03-07 Thread GitBox
codecov-io commented on issue #4458: Introduce Agent-Test-Tool suite URL: https://github.com/apache/skywalking/pull/4458#issuecomment-596127060 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4458?src=pr&el=h1) Report > Merging [#4458](https://codecov.io/gh/apache/skywalking/pu

[GitHub] [skywalking] dmsolr opened a new pull request #4458: Introduce Agent-Test-Tool suite

2020-03-07 Thread GitBox
dmsolr opened a new pull request #4458: Introduce Agent-Test-Tool suite URL: https://github.com/apache/skywalking/pull/4458 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve perf

[GitHub] [skywalking] wu-sheng closed pull request #4385: Fix NPE of decoding IntKeyLongValuesHashMap

2020-03-07 Thread GitBox
wu-sheng closed pull request #4385: Fix NPE of decoding IntKeyLongValuesHashMap URL: https://github.com/apache/skywalking/pull/4385 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389264350 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389264270 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389263554 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationIntercep

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389263366 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389264528 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389263325 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389263814 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/scala/org/apache/skywalking/apm/plugin/finagle/SWContextCarrier.

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389263432 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/AnnotationIntercep

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389260826 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilt

[skywalking-cli] branch master updated: [Feature] Support top N entities and thermodynamic metrics (#33)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new c38c595 [Feature] Support top N entiti

[GitHub] [skywalking-cli] wu-sheng merged pull request #33: [Feature] Support top N entities and thermodynamic metrics

2020-03-07 Thread GitBox
wu-sheng merged pull request #33: [Feature] Support top N entities and thermodynamic metrics URL: https://github.com/apache/skywalking-cli/pull/33 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [skywalking] wu-sheng closed issue #3898: [CLI] Top N list for CLI

2020-03-07 Thread GitBox
wu-sheng closed issue #3898: [CLI] Top N list for CLI URL: https://github.com/apache/skywalking/issues/3898 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [skywalking] wu-sheng closed issue #3897: [CLI] Heatmap graph for CLI

2020-03-07 Thread GitBox
wu-sheng closed issue #3897: [CLI] Heatmap graph for CLI URL: https://github.com/apache/skywalking/issues/3897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [skywalking] huangyoje commented on issue #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on issue #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#issuecomment-596097518 > I think you update the query-protocol submodule by a mistake. This has been corrected.

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389260458 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilt

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics

2020-03-07 Thread GitBox
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report > Merging [#33](https:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389256712 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/ClientTracingFilte

[skywalking-cli] branch feature/thermodynamic updated (2c5c624 -> 09852ce)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git. discard 2c5c624 [Feature] Support top N entities and thermodynamic metrics add 09852ce [Fea

[GitHub] [skywalking-cli] codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics

2020-03-07 Thread GitBox
codecov-io edited a comment on issue #33: [Feature] Support top N entities and thermodynamic metrics URL: https://github.com/apache/skywalking-cli/pull/33#issuecomment-596072259 # [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/33?src=pr&el=h1) Report > Merging [#33](https:

[skywalking-cli] branch feature/thermodynamic updated (d7ba925 -> 2c5c624)

2020-03-07 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch feature/thermodynamic in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git. discard d7ba925 [Feature] Support top N entities and thermodynamic metrics add 2c5c624 [Fea

[skywalking] branch master updated (698376e -> 8e1530d)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 698376e Remove a wrong statement in the release guide (#4456) add 8e1530d UI update, new topology impleme

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389255176 ## File path: .github/workflows/plugins-test.yaml ## @@ -271,6 +271,12 @@ jobs: run: bash test/plugin/run.sh undertow-

[GitHub] [skywalking] wu-sheng merged pull request #4457: UI update, new topology implementation refactor. No new feature.

2020-03-07 Thread GitBox
wu-sheng merged pull request #4457: UI update, new topology implementation refactor. No new feature. URL: https://github.com/apache/skywalking/pull/4457 This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] codecov-io commented on issue #4457: UI update, new topology implementation refactor. No new feature.

2020-03-07 Thread GitBox
codecov-io commented on issue #4457: UI update, new topology implementation refactor. No new feature. URL: https://github.com/apache/skywalking/pull/4457#issuecomment-596088147 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4457?src=pr&el=h1) Report > Merging [#4457](https://

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389254457 ## File path: .github/workflows/plugins-test.yaml ## @@ -271,6 +271,12 @@ jobs: run: bash test/plugin/run.sh undertow

[skywalking] branch ui-update updated (1f63b5d -> 7bb7476)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1f63b5d UI update, new topology implementation. add 7bb7476 Update license. No new revisions were add

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389251592 ## File path: .github/workflows/plugins-test.yaml ## @@ -271,6 +271,12 @@ jobs: run: bash test/plugin/run.sh undertow-

[GitHub] [skywalking] wu-sheng opened a new pull request #4457: UI update, new topology implementation.

2020-03-07 Thread GitBox
wu-sheng opened a new pull request #4457: UI update, new topology implementation. URL: https://github.com/apache/skywalking/pull/4457 I am helping @TinyAllen to sync the latest UI. This is an automated message from the Apache

[skywalking] branch ui-update created (now 1f63b5d)

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 1f63b5d UI update, new topology implementation. This branch includes the following new commits: new 1

[skywalking] 01/01: UI update, new topology implementation.

2020-03-07 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 1f63b5d7ce2d809dd626430f31aadd932415282e Author: Wu Sheng AuthorDate: Sat Mar 7 20:24:19 2020 +0800 UI upda

[GitHub] [skywalking] huangyoje commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
huangyoje commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389249047 ## File path: apm-sniffer/apm-sdk-plugin/finagle-6.25.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/finagle/CompatibilityChec

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389247585 ## File path: .github/workflows/plugins-test.yaml ## @@ -271,6 +271,12 @@ jobs: run: bash test/plugin/run.sh undertow-

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4441: Add finagle plugin

2020-03-07 Thread GitBox
wu-sheng commented on a change in pull request #4441: Add finagle plugin URL: https://github.com/apache/skywalking/pull/4441#discussion_r389247511 ## File path: .github/workflows/plugins-test.yaml ## @@ -271,6 +271,12 @@ jobs: run: bash test/plugin/run.sh undertow-

  1   2   >