[GitHub] [skywalking] wu-sheng commented on issue #4510: [WIP] Rewrite the E2E test framework and tests

2020-03-13 Thread GitBox
wu-sheng commented on issue #4510: [WIP] Rewrite the E2E test framework and tests URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599012475 You need to keep name same, especially all CI required tasks. Otherwise, this can't be merged.

[GitHub] [skywalking] codecov-io commented on issue #4509: Provide the data transmission protocol document

2020-03-13 Thread GitBox
codecov-io commented on issue #4509: Provide the data transmission protocol document URL: https://github.com/apache/skywalking/pull/4509#issuecomment-599012177 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4509?src=pr=h1) Report > Merging

[GitHub] [skywalking] kezhenxu94 commented on issue #4510: [WIP] Rewrite the E2E test framework and tests

2020-03-13 Thread GitBox
kezhenxu94 commented on issue #4510: [WIP] Rewrite the E2E test framework and tests URL: https://github.com/apache/skywalking/pull/4510#issuecomment-599012183 It's hard to review the diff, so just checkout the branch locally and review the final codes

[GitHub] [skywalking] kezhenxu94 opened a new pull request #4510: Rewite the E2E test framework and tests

2020-03-13 Thread GitBox
kezhenxu94 opened a new pull request #4510: Rewite the E2E test framework and tests URL: https://github.com/apache/skywalking/pull/4510 Motivation: According the feedback from the community, the e2e tests are hard for them to understand and get them started, so this pull request

[GitHub] [skywalking] mrproliu opened a new pull request #4509: Provide the data transmission protocol document

2020-03-13 Thread GitBox
mrproliu opened a new pull request #4509: Provide the data transmission protocol document URL: https://github.com/apache/skywalking/pull/4509 Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided

[GitHub] [skywalking] wu-sheng commented on issue #4508: can skywalking agent support in weblogic or websphere?

2020-03-13 Thread GitBox
wu-sheng commented on issue #4508: can skywalking agent support in weblogic or websphere? URL: https://github.com/apache/skywalking/issues/4508#issuecomment-599007526 There is nothing different between weblogic and tomcat. Read weblogic and Websphere document about jvm arguments.

[GitHub] [skywalking] wu-sheng closed issue #4508: can skywalking agent support in weblogic or websphere?

2020-03-13 Thread GitBox
wu-sheng closed issue #4508: can skywalking agent support in weblogic or websphere? URL: https://github.com/apache/skywalking/issues/4508 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] soulsoul opened a new issue #4508: can skywalking agent support in weblogic or websphere?

2020-03-13 Thread GitBox
soulsoul opened a new issue #4508: can skywalking agent support in weblogic or websphere? URL: https://github.com/apache/skywalking/issues/4508 Please answer these questions before submitting your issue. - Why do you submit this issue? - * Question or discussion - [ ] Bug

[GitHub] [skywalking] wu-sheng closed issue #4498: CICD improvement

2020-03-13 Thread GitBox
wu-sheng closed issue #4498: CICD improvement URL: https://github.com/apache/skywalking/issues/4498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [skywalking] wu-sheng commented on issue #4498: CICD improvement

2020-03-13 Thread GitBox
wu-sheng commented on issue #4498: CICD improvement URL: https://github.com/apache/skywalking/issues/4498#issuecomment-598814107 After offline discussion, this topic doesn't make sense to the community. I am closing it. This

[skywalking] branch oap-ssl updated (1e04dfc -> e44a7e9)

2020-03-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1e04dfc Merge branch 'master' into oap-ssl add d5efc97 RestTemplate async plugin ClassCastException

[skywalking] branch master updated: RestTemplate async plugin ClassCastException (#4507)

2020-03-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new d5efc97 RestTemplate async plugin

[GitHub] [skywalking] wu-sheng commented on issue #4507: RestTemplate async plugin ClassCastException

2020-03-13 Thread GitBox
wu-sheng commented on issue #4507: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4507#issuecomment-598771998 Merged, welcome. This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng merged pull request #4507: RestTemplate async plugin ClassCastException

2020-03-13 Thread GitBox
wu-sheng merged pull request #4507: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4507 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking] branch oap-ssl updated (4dad852 -> 1e04dfc)

2020-03-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 4dad852 Polish codes add 80911d0 fix the error of Struts2 plugin: java.lang.NoSuchMethodError:

[GitHub] [skywalking] JaredTan95 commented on issue #4477: Support ES username/password change dynamically

2020-03-13 Thread GitBox
JaredTan95 commented on issue #4477: Support ES username/password change dynamically URL: https://github.com/apache/skywalking/issues/4477#issuecomment-598704367 provided. This is an automated message from the Apache Git

[GitHub] [skywalking] JaredTan95 merged pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
JaredTan95 merged pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] JaredTan95 closed issue #4477: Support ES username/password change dynamically

2020-03-13 Thread GitBox
JaredTan95 closed issue #4477: Support ES username/password change dynamically URL: https://github.com/apache/skywalking/issues/4477 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking] branch master updated (80911d0 -> e69391a)

2020-03-13 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 80911d0 fix the error of Struts2 plugin: java.lang.NoSuchMethodError:

[GitHub] [skywalking] wu-sheng closed issue #4506: sharding-sphere-4.x-plugin dependencies error

2020-03-13 Thread GitBox
wu-sheng closed issue #4506: sharding-sphere-4.x-plugin dependencies error URL: https://github.com/apache/skywalking/issues/4506 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] wu-sheng commented on issue #4506: sharding-sphere-4.x-plugin dependencies error

2020-03-13 Thread GitBox
wu-sheng commented on issue #4506: sharding-sphere-4.x-plugin dependencies error URL: https://github.com/apache/skywalking/issues/4506#issuecomment-598703194 It is not supported, please submit issue to shardingsphere community.

[GitHub] [skywalking] codecov-io edited a comment on issue #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#issuecomment-596432355 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4470?src=pr=h1) Report > Merging

[GitHub] [skywalking] JaredTan95 edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
JaredTan95 edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#issuecomment-598688452 tested `user/password` changed scenario, and LGTM: ```bash ## pasword changed: ··

[GitHub] [skywalking] JaredTan95 removed a comment on issue #4477: Support ES username/password change dynamically

2020-03-13 Thread GitBox
JaredTan95 removed a comment on issue #4477: Support ES username/password change dynamically URL: https://github.com/apache/skywalking/issues/4477#issuecomment-598688146 tested `user/password` changed scenario, and LGTM: ```bash ·· Caused by:

[skywalking] branch vault-support updated (5cac4e5 -> f7b500a)

2020-03-13 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch vault-support in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 5cac4e5 Fix doc issue. add 80911d0 fix the error of Struts2 plugin: java.lang.NoSuchMethodError:

[GitHub] [skywalking] JaredTan95 commented on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
JaredTan95 commented on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#issuecomment-598688452 tested `user/password` changed scenario, and LGTM: ```bash ·· Caused by:

[GitHub] [skywalking] JaredTan95 commented on issue #4477: Support ES username/password change dynamically

2020-03-13 Thread GitBox
JaredTan95 commented on issue #4477: Support ES username/password change dynamically URL: https://github.com/apache/skywalking/issues/4477#issuecomment-598688146 tested `user/password` changed scenario, and LGTM: ```bash ·· Caused by:

[skywalking] branch oap-ssl updated (049fc81 -> 4dad852)

2020-03-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard 049fc81 Merge branch 'master' into oap-ssl discard 65cb79d Polish codes omit 80911d0 fix the error

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392178836 ## File path: test/e2e/e2e-ssl/src/docker/certs/server-key.pem ## @@ -0,0 +1,28 @@ +-BEGIN PRIVATE

[GitHub] [skywalking] wu-sheng commented on issue #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on issue #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#issuecomment-598681488 You need to fix CI This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] cngdkxw opened a new pull request #4507: RestTemplate async plugin ClassCastException

2020-03-13 Thread GitBox
cngdkxw opened a new pull request #4507: RestTemplate async plugin ClassCastException URL: https://github.com/apache/skywalking/pull/4507 org.apache.skywalking.apm.plugin.spring.resttemplate.async.FutureGetInterceptor throw ClassCastException before fix bug picture

[skywalking] branch oap-ssl updated (65cb79d -> 049fc81)

2020-03-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 65cb79d Polish codes add 80911d0 fix the error of Struts2 plugin: java.lang.NoSuchMethodError:

[GitHub] [skywalking] hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392163501 ## File path: test/e2e/e2e-ssl/src/docker/certs/server-key.pem ## @@ -0,0 +1,28 @@ +-BEGIN PRIVATE

[skywalking] branch oap-ssl updated (b522ec6 -> 65cb79d)

2020-03-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. discard b522ec6 Polish codes add 65cb79d Polish codes This update added new revisions after undoing existing

[GitHub] [skywalking] hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392163280 ## File path: test/e2e/e2e-ssl/e2e-ssl.iml ## @@ -0,0 +1,120 @@ + Review comment: deleted it.

[GitHub] [skywalking] hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392162764 ## File path:

[GitHub] [skywalking] hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
hanahmily commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392162664 ## File path:

[skywalking] branch oap-ssl updated (2625484 -> b522ec6)

2020-03-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch oap-ssl in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2625484 Ignore TSL relevant files add b522ec6 Polish codes No new revisions were added by this

[GitHub] [skywalking] codecov-io edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#issuecomment-597552700 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4493?src=pr=h1) Report > Merging

[GitHub] [skywalking] muyun12 opened a new issue #4506: sharding-sphere-4.x-plugin dependencies error

2020-03-13 Thread GitBox
muyun12 opened a new issue #4506: sharding-sphere-4.x-plugin dependencies error URL: https://github.com/apache/skywalking/issues/4506 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ]

[GitHub] [skywalking] codecov-io edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
codecov-io edited a comment on issue #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#issuecomment-597552700 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4493?src=pr=h1) Report > Merging

[skywalking] branch master updated: fix the error of Struts2 plugin: java.lang.NoSuchMethodError: javax.servlet.http.HttpServletResponse.getStatus() (#4503)

2020-03-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 80911d0 fix the error of Struts2 plugin:

[GitHub] [skywalking] wu-sheng merged pull request #4503: Support servlet 2.5 for Struts2

2020-03-13 Thread GitBox
wu-sheng merged pull request #4503: Support servlet 2.5 for Struts2 URL: https://github.com/apache/skywalking/pull/4503 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[skywalking] branch vault-support updated (1e5b173 -> 5cac4e5)

2020-03-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch vault-support in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 1e5b173 Merge branch 'master' into vault-support add 5cac4e5 Fix doc issue. No new revisions

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#discussion_r392101147 ## File path: docs/en/setup/backend/backend-storage.md ## @@ -124,6 +126,20 @@

[skywalking] branch vault-support updated (b08bf83 -> 1e5b173)

2020-03-13 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch vault-support in repository https://gitbox.apache.org/repos/asf/skywalking.git. from b08bf83 Merge branch 'master' into vault-support add 37e93a6 add KubeSphere in powered-by list

[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage

2020-03-13 Thread GitBox
JaredTan95 commented on a change in pull request #4493: Support Secrets Management File in the ElasticSearch 6/7 storage URL: https://github.com/apache/skywalking/pull/4493#discussion_r392087102 ## File path: docs/en/setup/backend/backend-storage.md ## @@ -124,6 +126,20

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392053297 ## File path: test/e2e/e2e-ssl/src/docker/certs/server-key.pem ## @@ -0,0 +1,28 @@ +-BEGIN PRIVATE

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392052385 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392052837 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392053104 ## File path: test/e2e/e2e-ssl/e2e-ssl.iml ## @@ -0,0 +1,120 @@ + Review comment: I think this should

[GitHub] [skywalking] wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation

2020-03-13 Thread GitBox
wu-sheng commented on a change in pull request #4470: Enable OAP gRPC SSL transportation URL: https://github.com/apache/skywalking/pull/4470#discussion_r392052234 ## File path:

[GitHub] [skywalking] jol5 edited a comment on issue #4502: SkyWalking not work after two date

2020-03-13 Thread GitBox
jol5 edited a comment on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598564618 > I don't know why. Usually deleting index and creating indexes at middle night cause more payload, especially for some some ES cluster.

[GitHub] [skywalking] jol5 commented on issue #4502: SkyWalking not work after two date

2020-03-13 Thread GitBox
jol5 commented on issue #4502: SkyWalking not work after two date URL: https://github.com/apache/skywalking/issues/4502#issuecomment-598564618 > I don't know why. Usually deleting index and creating indexes at middle night cause more payload, especially for some some ES cluster. The next